[dpdk-dev] [PATCH] cryptodev: renaming 2 elements for clarity

2016-04-06 Thread Thomas Monjalon
2016-04-04 18:14, Fiona Trahe:
> renamed rte_cryptodev_sym_session.type -> dev_type
> (as it's not a session type, but a device type)
> 
> renamed rte_crypto_sym_op.type -> sess_type
> (as it's not an op type, but a session type)
> 
> Signed-off-by: Fiona Trahe 

Applied, thanks


[dpdk-dev] [PATCH] cryptodev: renaming 2 elements for clarity

2016-04-04 Thread Fiona Trahe
renamed rte_cryptodev_sym_session.type -> dev_type
(as it's not a session type, but a device type)

renamed rte_crypto_sym_op.type -> sess_type
(as it's not an op type, but a session type)

Signed-off-by: Fiona Trahe 
---
 drivers/crypto/aesni_gcm/aesni_gcm_pmd.c   | 7 ---
 drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 6 +++---
 drivers/crypto/null/null_crypto_pmd.c  | 4 ++--
 drivers/crypto/qat/qat_crypto.c| 4 ++--
 drivers/crypto/snow3g/rte_snow3g_pmd.c | 6 +++---
 lib/librte_cryptodev/rte_crypto_sym.h  | 6 +++---
 lib/librte_cryptodev/rte_cryptodev.c   | 4 ++--
 lib/librte_cryptodev/rte_cryptodev.h   | 2 +-
 8 files changed, 20 insertions(+), 19 deletions(-)

diff --git a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c 
b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c
index 35577bc..2987ef6 100644
--- a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c
+++ b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c
@@ -180,8 +180,9 @@ aesni_gcm_get_session(struct aesni_gcm_qp *qp, struct 
rte_crypto_sym_op *op)
 {
struct aesni_gcm_session *sess = NULL;

-   if (op->type == RTE_CRYPTO_SYM_OP_WITH_SESSION) {
-   if (unlikely(op->session->type != RTE_CRYPTODEV_AESNI_GCM_PMD))
+   if (op->sess_type == RTE_CRYPTO_SYM_OP_WITH_SESSION) {
+   if (unlikely(op->session->dev_type
+   != RTE_CRYPTODEV_AESNI_GCM_PMD))
return sess;

sess = (struct aesni_gcm_session *)op->session->_private;
@@ -339,7 +340,7 @@ handle_completed_gcm_crypto_op(struct aesni_gcm_qp *qp,
post_process_gcm_crypto_op(op);

/* Free session if a session-less crypto op */
-   if (op->sym->type == RTE_CRYPTO_SYM_OP_SESSIONLESS) {
+   if (op->sym->sess_type == RTE_CRYPTO_SYM_OP_SESSIONLESS) {
rte_mempool_put(qp->sess_mp, op->sym->session);
op->sym->session = NULL;
}
diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c 
b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c
index a4b8807..3415ac1 100644
--- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c
+++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c
@@ -299,8 +299,8 @@ get_session(struct aesni_mb_qp *qp, struct rte_crypto_op 
*op)
 {
struct aesni_mb_session *sess = NULL;

-   if (op->sym->type == RTE_CRYPTO_SYM_OP_WITH_SESSION) {
-   if (unlikely(op->sym->session->type !=
+   if (op->sym->sess_type == RTE_CRYPTO_SYM_OP_WITH_SESSION) {
+   if (unlikely(op->sym->session->dev_type !=
RTE_CRYPTODEV_AESNI_MB_PMD))
return NULL;

@@ -475,7 +475,7 @@ post_process_mb_job(struct aesni_mb_qp *qp, JOB_AES_HMAC 
*job)
}

/* Free session if a session-less crypto op */
-   if (op->sym->type == RTE_CRYPTO_SYM_OP_SESSIONLESS) {
+   if (op->sym->sess_type == RTE_CRYPTO_SYM_OP_SESSIONLESS) {
rte_mempool_put(qp->sess_mp, op->sym->session);
op->sym->session = NULL;
}
diff --git a/drivers/crypto/null/null_crypto_pmd.c 
b/drivers/crypto/null/null_crypto_pmd.c
index 82b990c..bdaf13c 100644
--- a/drivers/crypto/null/null_crypto_pmd.c
+++ b/drivers/crypto/null/null_crypto_pmd.c
@@ -114,9 +114,9 @@ get_session(struct null_crypto_qp *qp, struct 
rte_crypto_sym_op *op)
 {
struct null_crypto_session *sess;

-   if (op->type == RTE_CRYPTO_SYM_OP_WITH_SESSION) {
+   if (op->sess_type == RTE_CRYPTO_SYM_OP_WITH_SESSION) {
if (unlikely(op->session == NULL ||
-   op->session->type != RTE_CRYPTODEV_NULL_PMD))
+op->session->dev_type != RTE_CRYPTODEV_NULL_PMD))
return NULL;

sess = (struct null_crypto_session *)op->session->_private;
diff --git a/drivers/crypto/qat/qat_crypto.c b/drivers/crypto/qat/qat_crypto.c
index 45bb8b3..495ea1c 100644
--- a/drivers/crypto/qat/qat_crypto.c
+++ b/drivers/crypto/qat/qat_crypto.c
@@ -676,13 +676,13 @@ qat_write_hw_desc_entry(struct rte_crypto_op *op, uint8_t 
*out_msg)
return -EINVAL;
}
 #endif
-   if (unlikely(op->sym->type == RTE_CRYPTO_SYM_OP_SESSIONLESS)) {
+   if (unlikely(op->sym->sess_type == RTE_CRYPTO_SYM_OP_SESSIONLESS)) {
PMD_DRV_LOG(ERR, "QAT PMD only supports session oriented"
" requests, op (%p) is sessionless.", op);
return -EINVAL;
}

-   if (unlikely(op->sym->session->type != RTE_CRYPTODEV_QAT_SYM_PMD)) {
+   if (unlikely(op->sym->session->dev_type != RTE_CRYPTODEV_QAT_SYM_PMD)) {
PMD_DRV_LOG(ERR, "Session was not created for this device");
return -EINVAL;
}
diff --git a/drivers/crypto/snow3g/rte_snow3g_pmd.c 
b/drivers/crypto/snow3g/rte_snow3g_pmd.c
index 97c7fb5..f3e0e66 100644
--- a/drivers/crypto/snow3g/rte_snow3g_pmd.c
+++ b/drivers/crypto/snow3g/rte_snow3g_pmd.c
@@ -162,8 +162,8 @@