[dpdk-dev] [PATCH] examples/ipsec-secgw: fix buffer not null terminated

[Thomas Monjalon]

2016-11-04 14:18, Ferruh Yigit:
> On 11/3/2016 12:12 PM, Fan Zhang wrote:
> > Fixes: 0d547ed03717 ("examples/ipsec-secgw: support configuration file")
> > Coverity issue: 137854
> > 
> > Signed-off-by: Fan Zhang 
> 
> Acked-by: Ferruh Yigit 
> 
> 
> Minor nit, for all coverity fixes, defined commit log format is:
> 
> Coverity issue: x
> Fixes: .
> 
> Basically two lines should be swapped, but I guess this can be fixed
> while applying instead of sending a new version for this.

Applied, thanks

[dpdk-dev] [PATCH] examples/ipsec-secgw: fix buffer not null terminated

[Ferruh Yigit]

On 11/3/2016 12:12 PM, Fan Zhang wrote:
> Fixes: 0d547ed03717 ("examples/ipsec-secgw: support configuration file")
> Coverity issue: 137854
> 
> Signed-off-by: Fan Zhang 

Acked-by: Ferruh Yigit 


Minor nit, for all coverity fixes, defined commit log format is:

Coverity issue: x
Fixes: .

Basically two lines should be swapped, but I guess this can be fixed
while applying instead of sending a new version for this.

[dpdk-dev] [PATCH] examples/ipsec-secgw: fix buffer not null terminated

[Fan Zhang]

Fixes: 0d547ed03717 ("examples/ipsec-secgw: support configuration file")
Coverity issue: 137854

Signed-off-by: Fan Zhang 
---
 examples/ipsec-secgw/parser.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/ipsec-secgw/parser.c b/examples/ipsec-secgw/parser.c
index 99bdfc5..e09a7c0 100644
--- a/examples/ipsec-secgw/parser.c
+++ b/examples/ipsec-secgw/parser.c
@@ -248,7 +248,7 @@ parse_ipv4_addr(const char *token, struct in_addr *ipv4, 
uint32_t *mask)
if (mask)
*mask = atoi(pch);
} else {
-   strncpy(ip_str, token, sizeof(ip_str));
+   strncpy(ip_str, token, sizeof(ip_str) - 1);
if (mask)
*mask = 0;
}
-- 
2.5.5