[dpdk-dev] [PATCH] ixgbe: fix the issue second 5tuple filter overwrites the first one

2015-03-27 Thread Thomas Monjalon 
> > This patch corrects the index to fix the issue that is second 5tuple
> > filter
> > overwrites the first one.
> > 
> > Signed-off-by: Jingjing Wu 
> 
> Acked-by: Marvin Liu 

Fixes: 4c54a7e7bd42 ("ixgbe: migrate ntuple filter to new API")

Applied, thanks

[dpdk-dev] [PATCH] ixgbe: fix the issue second 5tuple filter overwrites the first one

2015-03-25 Thread Jingjing Wu 
This patch corrects the index to fix the issue that is second 5tuple filter
overwrites the first one.

Signed-off-by: Jingjing Wu 
---
 lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c 
b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
index 92d75db..5caee22 100644
--- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
+++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
@@ -3882,10 +3882,10 @@ ixgbe_add_5tuple_filter(struct rte_eth_dev *dev,
ftqf |= IXGBE_FTQF_POOL_MASK_EN;
ftqf |= IXGBE_FTQF_QUEUE_ENABLE;

-   IXGBE_WRITE_REG(hw, IXGBE_DAQF(idx), filter->filter_info.dst_ip);
-   IXGBE_WRITE_REG(hw, IXGBE_SAQF(idx), filter->filter_info.src_ip);
-   IXGBE_WRITE_REG(hw, IXGBE_SDPQF(idx), sdpqf);
-   IXGBE_WRITE_REG(hw, IXGBE_FTQF(idx), ftqf);
+   IXGBE_WRITE_REG(hw, IXGBE_DAQF(i), filter->filter_info.dst_ip);
+   IXGBE_WRITE_REG(hw, IXGBE_SAQF(i), filter->filter_info.src_ip);
+   IXGBE_WRITE_REG(hw, IXGBE_SDPQF(i), sdpqf);
+   IXGBE_WRITE_REG(hw, IXGBE_FTQF(i), ftqf);

l34timir |= IXGBE_L34T_IMIR_RESERVE;
l34timir |= (uint32_t)(filter->queue <<
-- 
1.9.3

[dpdk-dev] [PATCH] ixgbe: fix the issue second 5tuple filter overwrites the first one

2015-03-25 Thread Liu, Yong 
> -Original Message-
> From: Wu, Jingjing
> Sent: Wednesday, March 25, 2015 12:47 PM
> To: dev at dpdk.org
> Cc: Wu, Jingjing; Liu, Yong
> Subject: [PATCH] ixgbe: fix the issue second 5tuple filter overwrites the
> first one
> 
> This patch corrects the index to fix the issue that is second 5tuple
> filter
> overwrites the first one.
> 
> Signed-off-by: Jingjing Wu 

Acked-by: Marvin Liu 
> ---
>  lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
> b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
> index 92d75db..5caee22 100644
> --- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
> +++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
> @@ -3882,10 +3882,10 @@ ixgbe_add_5tuple_filter(struct rte_eth_dev *dev,
>   ftqf |= IXGBE_FTQF_POOL_MASK_EN;
>   ftqf |= IXGBE_FTQF_QUEUE_ENABLE;
> 
> - IXGBE_WRITE_REG(hw, IXGBE_DAQF(idx), filter->filter_info.dst_ip);
> - IXGBE_WRITE_REG(hw, IXGBE_SAQF(idx), filter->filter_info.src_ip);
> - IXGBE_WRITE_REG(hw, IXGBE_SDPQF(idx), sdpqf);
> - IXGBE_WRITE_REG(hw, IXGBE_FTQF(idx), ftqf);
> + IXGBE_WRITE_REG(hw, IXGBE_DAQF(i), filter->filter_info.dst_ip);
> + IXGBE_WRITE_REG(hw, IXGBE_SAQF(i), filter->filter_info.src_ip);
> + IXGBE_WRITE_REG(hw, IXGBE_SDPQF(i), sdpqf);
> + IXGBE_WRITE_REG(hw, IXGBE_FTQF(i), ftqf);
> 
>   l34timir |= IXGBE_L34T_IMIR_RESERVE;
>   l34timir |= (uint32_t)(filter->queue <<
> --
> 1.9.3

Acked-by: Marvin Liu