[dpdk-dev] [PATCH] lib/librte_vhost: remove vhost device from data plane when receive VHOST_SET_MEM_TABLE message

[Thomas Monjalon]

> > This patch fixes the segfault issue in the case vhost receives new
> > VHOST_SET_MEM_TABLE message without VHOST_VRING_GET_VRING_BASE(which
> > we uses as the stop message).
> > 
> > Signed-off-by: Huawei Xie 
> 
> Acked-by: Tommy Long  

Applied, thanks

[dpdk-dev] [PATCH] lib/librte_vhost: remove vhost device from data plane when receive VHOST_SET_MEM_TABLE message

[Long, Thomas]

Acked-by: Tommy Long  


-Original Message-
From: Xie, Huawei 
Sent: Tuesday, March 3, 2015 2:26 AM
To: dev at dpdk.org
Cc: haifeng.lin at huawei.com; mukawa at igel.co.jp; Long, Thomas; Xie, Huawei
Subject: [PATCH] lib/librte_vhost: remove vhost device from data plane when 
receive VHOST_SET_MEM_TABLE message

This patch fixes the segfault issue in the case vhost receives new 
VHOST_SET_MEM_TABLE message without VHOST_VRING_GET_VRING_BASE(which we uses as 
the stop message).

Signed-off-by: Huawei Xie 
---
 lib/librte_vhost/vhost_user/virtio-net-user.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/lib/librte_vhost/vhost_user/virtio-net-user.c 
b/lib/librte_vhost/vhost_user/virtio-net-user.c
index 97c5177..aa08706 100644
--- a/lib/librte_vhost/vhost_user/virtio-net-user.c
+++ b/lib/librte_vhost/vhost_user/virtio-net-user.c
@@ -109,6 +109,10 @@ user_set_mem_table(struct vhost_device_ctx ctx, struct 
VhostUserMsg *pmsg)
if (dev == NULL)
return -1;

+   /* Remove from the data plane. */
+   if (dev->flags & VIRTIO_DEV_RUNNING)
+   notify_ops->destroy_device(dev);
+
if (dev->mem) {
free_mem_region(dev);
free(dev->mem);
-- 
1.8.1.4

[dpdk-dev] [PATCH] lib/librte_vhost: remove vhost device from data plane when receive VHOST_SET_MEM_TABLE message

[Huawei Xie]

This patch fixes the segfault issue in the case vhost receives new 
VHOST_SET_MEM_TABLE message without VHOST_VRING_GET_VRING_BASE(which we uses as 
the stop message).

Signed-off-by: Huawei Xie 
---
 lib/librte_vhost/vhost_user/virtio-net-user.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/lib/librte_vhost/vhost_user/virtio-net-user.c 
b/lib/librte_vhost/vhost_user/virtio-net-user.c
index 97c5177..aa08706 100644
--- a/lib/librte_vhost/vhost_user/virtio-net-user.c
+++ b/lib/librte_vhost/vhost_user/virtio-net-user.c
@@ -109,6 +109,10 @@ user_set_mem_table(struct vhost_device_ctx ctx, struct 
VhostUserMsg *pmsg)
if (dev == NULL)
return -1;

+   /* Remove from the data plane. */
+   if (dev->flags & VIRTIO_DEV_RUNNING)
+   notify_ops->destroy_device(dev);
+
if (dev->mem) {
free_mem_region(dev);
free(dev->mem);
-- 
1.8.1.4