On 5/2/2016 5:10 PM, Thomas Monjalon wrote:
> 2016-04-29 17:34, Ferruh Yigit:
>> Add default library output folder to the library search folder.
>>
>> This is useful for development environment, in production environment
>> DPDK libraries already should be in know locations.
>
> Yes it is useful in dev environment, but can be risky or strange when
> packaged for production environment.
> Shouldn't we have a switch to avoid a development garbage in production?
> I suggest to use RTE_DEVEL_BUILD.
>
Right, I will use RTE_DEVEL_BUILD
>> Patch removes requirement to set LD_LIBRARY_PATH variable when DPDK
>> compiled as shared library.
>
> Yes, this patch could remove
> export LD_LIBRARY_PATH=$build/lib:$LD_LIBRARY_PATH
> in scripts/test-null.sh.
>
Sure, I can update it.
> [...]
>> +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)
>> +LDFLAGS += --rpath=$(RTE_SDK_BIN)/lib
>> +endif
>
> Isn't it -rpath, with a single dash?
>
It seems both are working, I will convert to single dash.
> As it is a variable setting, it should be added before the rules,
> just after LDLIBS settings.
>
OK.
I will send an updated version.
Thanks for the review,
ferruh
