[dpdk-dev] [PATCH] pdump: close client socket

[Reshma Pattan]

Close the client socket before returning on error.

Coverity issue: 127555

Fixes: f3c1829130ac ("pdump: check missing home environment variable")

Signed-off-by: Reshma Pattan 
---
 lib/librte_pdump/rte_pdump.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/librte_pdump/rte_pdump.c b/lib/librte_pdump/rte_pdump.c
index ee566cb..22ed476 100644
--- a/lib/librte_pdump/rte_pdump.c
+++ b/lib/librte_pdump/rte_pdump.c
@@ -677,7 +677,7 @@ pdump_create_client_socket(struct pdump_request *p)
RTE_LOG(ERR, PDUMP,
"Failed to get client socket path: %s:%d\n",
__func__, __LINE__);
-   return -1;
+   goto exit;
}
addr.sun_family = AF_UNIX;
addr_len = sizeof(struct sockaddr_un);
@@ -728,6 +728,7 @@ pdump_create_client_socket(struct pdump_request *p)
ret = server_resp.err_value;
} while (0);

+exit:
close(socket_fd);
unlink(addr.sun_path);
return ret;
-- 
2.5.0

[dpdk-dev] [PATCH] pdump: close client socket

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Reshma Pattan
> Sent: Monday, July 4, 2016 5:17 PM
> To: dev at dpdk.org
> Cc: Pattan, Reshma 
> Subject: [dpdk-dev] [PATCH] pdump: close client socket
> 
> Close the client socket before returning on error.
> 
> Coverity issue: 127555
> 
> Fixes: f3c1829130ac ("pdump: check missing home environment variable")
> 
> Signed-off-by: Reshma Pattan 

Acked-by: John McNamara 

[dpdk-dev] [PATCH] pdump: close client socket

[Thomas Monjalon]

> > Close the client socket before returning on error.
> > 
> > Coverity issue: 127555
> > 
> > Fixes: f3c1829130ac ("pdump: check missing home environment variable")
> > 
> > Signed-off-by: Reshma Pattan 
> 
> Acked-by: John McNamara 


Applied, thanks