[dpdk-dev] [PATCH] scripts: fix newline character in sed expression
> > Use of \n in sed expression is not portable and triggered an invalid > > configuration on BSD (at least). > > Replace with an explicit newline. > > > > Reported-by: Bruce Richardson > > Signed-off-by: David Marchand > > Acked-by: Bruce Richardson Applied Thanks -- Thomas
[dpdk-dev] [PATCH] scripts: fix newline character in sed expression
Use of \n in sed expression is not portable and triggered an invalid configuration on BSD (at least). Replace with an explicit newline. Reported-by: Bruce Richardson Signed-off-by: David Marchand --- scripts/gen-config-h.sh |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/scripts/gen-config-h.sh b/scripts/gen-config-h.sh index 2fac08c..d36efd6 100755 --- a/scripts/gen-config-h.sh +++ b/scripts/gen-config-h.sh @@ -35,9 +35,11 @@ echo "#ifndef __RTE_CONFIG_H" echo "#define __RTE_CONFIG_H" grep CONFIG_ $1 | grep -v '^[ \t]*#' | -sed 's,CONFIG_\(.*\)=y.*$,#undef \1\n#define \1 1,' | +sed 's,CONFIG_\(.*\)=y.*$,#undef \1\ +#define \1 1,' | sed 's,CONFIG_\(.*\)=n.*$,#undef \1,' | -sed 's,CONFIG_\(.*\)=\(.*\)$,#undef \1\n#define \1 \2,' | +sed 's,CONFIG_\(.*\)=\(.*\)$,#undef \1\ +#define \1 \2,' | sed 's,\# CONFIG_\(.*\) is not set$,#undef \1,' echo "#endif /* __RTE_CONFIG_H */" -- 1.7.10.4
[dpdk-dev] [PATCH] scripts: fix newline character in sed expression
On Fri, Nov 28, 2014 at 04:42:44PM +0100, David Marchand wrote: > Use of \n in sed expression is not portable and triggered an invalid > configuration on BSD (at least). > Replace with an explicit newline. > > Reported-by: Bruce Richardson > Signed-off-by: David Marchand Acked-by: Bruce Richardson > --- > scripts/gen-config-h.sh |6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/scripts/gen-config-h.sh b/scripts/gen-config-h.sh > index 2fac08c..d36efd6 100755 > --- a/scripts/gen-config-h.sh > +++ b/scripts/gen-config-h.sh > @@ -35,9 +35,11 @@ echo "#ifndef __RTE_CONFIG_H" > echo "#define __RTE_CONFIG_H" > grep CONFIG_ $1 | > grep -v '^[ \t]*#' | > -sed 's,CONFIG_\(.*\)=y.*$,#undef \1\n#define \1 1,' | > +sed 's,CONFIG_\(.*\)=y.*$,#undef \1\ > +#define \1 1,' | > sed 's,CONFIG_\(.*\)=n.*$,#undef \1,' | > -sed 's,CONFIG_\(.*\)=\(.*\)$,#undef \1\n#define \1 \2,' | > +sed 's,CONFIG_\(.*\)=\(.*\)$,#undef \1\ > +#define \1 \2,' | > sed 's,\# CONFIG_\(.*\) is not set$,#undef \1,' > echo "#endif /* __RTE_CONFIG_H */" > > -- > 1.7.10.4 >
