[dpdk-dev] [PATCH] vmxnet3: remove asserts that confuse coverity

[Thomas Monjalon]

> >These asserts are only for debugging and never fired during
> >any testing, but they confuse coverity's null tracking.
> >
> >Signed-off-by: Stephen Hemminger 
> 
> Acked-by: Yong Wang 

Applied, thanks

[dpdk-dev] [PATCH] vmxnet3: remove asserts that confuse coverity

[Yong Wang]

On 3/30/16, 2:38 PM, "Stephen Hemminger"  wrote:



>These asserts are only for debugging and never fired during
>any testing, but they confuse coverity's null tracking.
>
>Signed-off-by: Stephen Hemminger 
>---

Acked-by: Yong Wang 


> drivers/net/vmxnet3/vmxnet3_rxtx.c | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c 
>b/drivers/net/vmxnet3/vmxnet3_rxtx.c
>index 66b0eed..f72156a 100644
>--- a/drivers/net/vmxnet3/vmxnet3_rxtx.c
>+++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c
>@@ -710,7 +710,6 @@ vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf 
>**rx_pkts, uint16_t nb_pkts)
>* the last mbuf of the current packet.
>*/
>   if (rcd->sop) {
>-  VMXNET3_ASSERT(rxq->start_seg != NULL);
>   VMXNET3_ASSERT(rxd->btype == VMXNET3_RXD_BTYPE_HEAD);
> 
>   if (unlikely(rcd->len == 0)) {
>@@ -729,7 +728,6 @@ vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf 
>**rx_pkts, uint16_t nb_pkts)
>   struct rte_mbuf *start = rxq->start_seg;
> 
>   VMXNET3_ASSERT(rxd->btype == VMXNET3_RXD_BTYPE_BODY);
>-  VMXNET3_ASSERT(start != NULL);
> 
>   start->pkt_len += rxm->data_len;
>   start->nb_segs++;
>-- 
>2.1.4
>

[dpdk-dev] [PATCH] vmxnet3: remove asserts that confuse coverity

[Stephen Hemminger]

These asserts are only for debugging and never fired during
any testing, but they confuse coverity's null tracking.

Signed-off-by: Stephen Hemminger 
---
 drivers/net/vmxnet3/vmxnet3_rxtx.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c 
b/drivers/net/vmxnet3/vmxnet3_rxtx.c
index 66b0eed..f72156a 100644
--- a/drivers/net/vmxnet3/vmxnet3_rxtx.c
+++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c
@@ -710,7 +710,6 @@ vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf 
**rx_pkts, uint16_t nb_pkts)
 * the last mbuf of the current packet.
 */
if (rcd->sop) {
-   VMXNET3_ASSERT(rxq->start_seg != NULL);
VMXNET3_ASSERT(rxd->btype == VMXNET3_RXD_BTYPE_HEAD);

if (unlikely(rcd->len == 0)) {
@@ -729,7 +728,6 @@ vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf 
**rx_pkts, uint16_t nb_pkts)
struct rte_mbuf *start = rxq->start_seg;

VMXNET3_ASSERT(rxd->btype == VMXNET3_RXD_BTYPE_BODY);
-   VMXNET3_ASSERT(start != NULL);

start->pkt_len += rxm->data_len;
start->nb_segs++;
-- 
2.1.4