[dpdk-dev] [PATCH 0/4] port: fix and test bugs in tx_bulk ops

2016-03-30 Thread Thomas Monjalon
2016-03-28 16:51, Robert Sanford:
> This patch series does the following:
> 
> * enhances port ring writer test, to send two large, but not full
>   bursts; exposes ring writer buffer overflow
> * fixes ring writer buffer overflow
> * fixes full burst checks in ethdev, ring, and sched f_tx_bulk ops
> * fixes ethdev writer, to send bursts no larger than specified max

Cristian, a fast review would be helpful to integrate these fixes
in 16.04.


[dpdk-dev] [PATCH 0/4] port: fix and test bugs in tx_bulk ops

2016-03-30 Thread Dumitrescu, Cristian


> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Wednesday, March 30, 2016 12:00 PM
> To: Dumitrescu, Cristian 
> Cc: dev at dpdk.org; Robert Sanford 
> Subject: Re: [dpdk-dev] [PATCH 0/4] port: fix and test bugs in tx_bulk ops
> 
> 2016-03-28 16:51, Robert Sanford:
> > This patch series does the following:
> >
> > * enhances port ring writer test, to send two large, but not full
> >   bursts; exposes ring writer buffer overflow
> > * fixes ring writer buffer overflow
> > * fixes full burst checks in ethdev, ring, and sched f_tx_bulk ops
> > * fixes ethdev writer, to send bursts no larger than specified max
> 
> Cristian, a fast review would be helpful to integrate these fixes
> in 16.04.

Please note Robert's patches are not trivial and the potential impact is quite 
high. We'll keep you update We are working on reviewing them and will send 
update on our progress.

These potential changes come up very late into the 16.04 cycle. Given their 
nature, once they get merged, one RC cycle is required by the validation team 
to fully test them, so I want to make sure I flag this to you as early as 
possible.



[dpdk-dev] [PATCH 0/4] port: fix and test bugs in tx_bulk ops

2016-03-28 Thread Robert Sanford
This patch series does the following:

* enhances port ring writer test, to send two large, but not full
  bursts; exposes ring writer buffer overflow
* fixes ring writer buffer overflow
* fixes full burst checks in ethdev, ring, and sched f_tx_bulk ops
* fixes ethdev writer, to send bursts no larger than specified max



Robert Sanford (4):
  app/test: enhance test_port_ring_writer
  port: fix ring writer buffer overflow
  port: fix full burst checks in f_tx_bulk ops
  port: fix ethdev writer burst too big

 app/test/test_table_ports.c   |   27 +--
 lib/librte_port/rte_port_ethdev.c |   35 ++-
 lib/librte_port/rte_port_ring.c   |   20 ++--
 lib/librte_port/rte_port_sched.c  |7 ++-
 4 files changed, 47 insertions(+), 42 deletions(-)