[dpdk-dev] [PATCH 1/2] app/testpmd: use correct hardware address in ARP replies

2015-05-29 Thread Thomas Monjalon
2015-05-22 13:07, Adrien Mazarguil:
> In the icmpecho forwarding mode, ARP replies from testpmd contain
> invalid zero-filled MAC addresses. This is broken since the commit below.
> 
> Fixes: 31db4d38de72 ("net: change arp header struct declaration")
> 
> Signed-off-by: Adrien Mazarguil 
> Acked-by: Ivan Boule 

Applied, thanks


[dpdk-dev] [PATCH 1/2] app/testpmd: use correct hardware address in ARP replies

2015-05-22 Thread Adrien Mazarguil
In the icmpecho forwarding mode, ARP replies from testpmd contain
invalid zero-filled MAC addresses. This is broken since the commit below.

Fixes: 31db4d38de72 ("net: change arp header struct declaration")

Signed-off-by: Adrien Mazarguil 
Acked-by: Ivan Boule 
---
 app/test-pmd/icmpecho.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test-pmd/icmpecho.c b/app/test-pmd/icmpecho.c
index 010c5a9..c5933f4 100644
--- a/app/test-pmd/icmpecho.c
+++ b/app/test-pmd/icmpecho.c
@@ -400,7 +400,7 @@ reply_to_icmp_echo_rqsts(struct fwd_stream *fs)
arp_h->arp_op = rte_cpu_to_be_16(ARP_OP_REPLY);
ether_addr_copy(&arp_h->arp_data.arp_tha, ð_addr);
ether_addr_copy(&arp_h->arp_data.arp_sha, 
&arp_h->arp_data.arp_tha);
-   ether_addr_copy(ð_addr, &arp_h->arp_data.arp_sha);
+   ether_addr_copy(ð_h->s_addr, 
&arp_h->arp_data.arp_sha);

/* Swap IP addresses in ARP payload */
ip_addr = arp_h->arp_data.arp_sip;
-- 
2.1.0