[dpdk-dev] [PATCH 1/5] eal: make enum rte_kernel_driver non-PCI specific

2016-09-12 Thread Shreyansh Jain 
Hi,

On Sunday 11 September 2016 05:45 PM, Yuanhan Liu wrote:
> On Thu, Sep 01, 2016 at 10:11:51AM +0530, Shreyansh Jain wrote:
>> From: Jan Viktorin 
>>
>> From: Jan Viktorin 
>>
>> Signed-off-by: Jan Viktorin 
>> Signed-off-by: Shreyansh Jain 
>
> Hi,
>
> FYI, my testrobot caught some errors when this patch is applied.
>
> --yliu
>
> ---
> i686-native-linuxapp-gcc: config-all-yes
> 
> In file included from lib/librte_eal/linuxapp/eal/eal_pci.c:38:0:
> i686-native-linuxapp-gcc/include/rte_pci.h:157:25: error: field 'kdrv' has 
> incomplete type
>   enum rte_kernel_driver kdrv;/**< Kernel driver passthrough */
>  ^
> In file included from lib/librte_eal/linuxapp/eal/eal_vfio_mp_sync.c:52:0:
> i686-native-linuxapp-gcc/include/rte_pci.h:157:25: error: field 'kdrv' has 
> incomplete type
>   enum rte_kernel_driver kdrv;/**< Kernel driver passthrough */
>  ^
> In file included from lib/librte_eal/common/eal_private.h:38:0,
>  from lib/librte_eal/linuxapp/eal/eal_thread.c:55:
> i686-native-linuxapp-gcc/include/rte_pci.h:157:25: error: field 'kdrv' has 
> incomplete type
>   enum rte_kernel_driver kdrv;/**< Kernel driver passthrough */
>  ^
> make[7]: *** [eal_thread.o] Error 1
> make[7]: *** Waiting for unfinished jobs
> In file included from lib/librte_eal/linuxapp/eal/eal.c:72:0:
> i686-native-linuxapp-gcc/include/rte_pci.h:157:25: error: field 'kdrv' has 
> incomplete type
>   enum rte_kernel_driver kdrv;/**< Kernel driver passthrough */
>  ^
> In file included from lib/librte_eal/common/eal_private.h:38:0,
>  from lib/librte_eal/linuxapp/eal/eal_memory.c:97:
> i686-native-linuxapp-gcc/include/rte_pci.h:157:25: error: field 'kdrv' has 
> incomplete type
>   enum rte_kernel_driver kdrv;/**< Kernel driver passthrough */
>  ^
> In file included from lib/librte_eal/common/eal_private.h:38:0,
>  from lib/librte_eal/linuxapp/eal/eal_log.c:50:
> i686-native-linuxapp-gcc/include/rte_pci.h:157:25: error: field 'kdrv' has 
> incomplete type
>   enum rte_kernel_driver kdrv;/**< Kernel driver passthrough */
>  ^
> make[7]: *** [eal_log.o] Error 1
> make[7]: *** [eal_vfio_mp_sync.o] Error 1
> In file included from lib/librte_eal/common/eal_private.h:38:0,
>  from lib/librte_eal/linuxapp/eal/eal_vfio.c:45:
> i686-native-linuxapp-gcc/include/rte_pci.h:157:25: error: field 'kdrv' has 
> incomplete type
>   enum rte_kernel_driver kdrv;/**< Kernel driver passthrough */
>  ^
> make[7]: *** [eal.o] Error 1
> make[7]: *** [eal_memory.o] Error 1
> make[7]: *** [eal_vfio.o] Error 1
> lib/librte_eal/linuxapp/eal/eal_pci.c: In function 'rte_eal_pci_map_device':
> lib/librte_eal/linuxapp/eal/eal_pci.c:133:7: error: 'RTE_KDRV_VFIO' 
> undeclared (first use in this function)
>   case RTE_KDRV_VFIO:
>^
> lib/librte_eal/linuxapp/eal/eal_pci.c:133:7: note: each undeclared identifier 
> is reported only once for each function it appears in
> lib/librte_eal/linuxapp/eal/eal_pci.c:139:7: error: 'RTE_KDRV_IGB_UIO' 
> undeclared (first use in this function)
>   case RTE_KDRV_IGB_UIO:
>^
> lib/librte_eal/linuxapp/eal/eal_pci.c:140:7: error: 'RTE_KDRV_UIO_GENERIC' 
> undeclared (first use in this function)
>   case RTE_KDRV_UIO_GENERIC:
>^
> lib/librte_eal/linuxapp/eal/eal_pci.c: In function 'rte_eal_pci_unmap_device':
> lib/librte_eal/linuxapp/eal/eal_pci.c:160:7: error: 'RTE_KDRV_VFIO' 
> undeclared (first use in this function)
>   case RTE_KDRV_VFIO:
>^
> lib/librte_eal/linuxapp/eal/eal_pci.c:163:7: error: 'RTE_KDRV_IGB_UIO' 
> undeclared (first use in this function)
>   case RTE_KDRV_IGB_UIO:
>^
> lib/librte_eal/linuxapp/eal/eal_pci.c:164:7: error: 'RTE_KDRV_UIO_GENERIC' 
> undeclared (first use in this function)
>   case RTE_KDRV_UIO_GENERIC:
>^
> lib/librte_eal/linuxapp/eal/eal_pci.c: In function 'pci_scan_one':
> lib/librte_eal/linuxapp/eal/eal_pci.c:381:16: error: 'RTE_KDRV_VFIO' 
> undeclared (first use in this function)
> dev->kdrv = RTE_KDRV_VFIO;
> ^
> lib/librte_eal/linuxapp/eal/eal_pci.c:383:16: error: 'RTE_KDRV_IGB_UIO' 
> undeclared (first use in this function)
> dev->kdrv = RTE_KDRV_IGB_UIO;
> ^
> lib/librte_eal/linuxapp/eal/eal_pci.c:385:16: error: 'RTE_KDRV_UIO_GENERIC' 
> undeclared (first use in this function)
> dev->kdrv = RTE_KDRV_UIO_GENERIC;
> ^
> lib/librte_eal/linuxapp/eal/eal_pci.c:387:16: error: 'RTE_KDRV_UNKNOWN' 
> undeclared (first use in this function)
> dev->kdrv = RTE_KDRV_UNKNOWN;
> ^
> lib/librte_eal/linuxapp/eal/eal_pci.c:389:15: error: 'RTE_KDRV_NONE' 
> undeclared (first use in this function)
>dev->kdrv =

[dpdk-dev] [PATCH 1/5] eal: make enum rte_kernel_driver non-PCI specific

2016-09-11 Thread Yuanhan Liu 
On Thu, Sep 01, 2016 at 10:11:51AM +0530, Shreyansh Jain wrote:
> From: Jan Viktorin 
> 
> From: Jan Viktorin 
> 
> Signed-off-by: Jan Viktorin 
> Signed-off-by: Shreyansh Jain 

Hi,

FYI, my testrobot caught some errors when this patch is applied.

--yliu

---
i686-native-linuxapp-gcc: config-all-yes

In file included from lib/librte_eal/linuxapp/eal/eal_pci.c:38:0:
i686-native-linuxapp-gcc/include/rte_pci.h:157:25: error: field 'kdrv' has 
incomplete type
  enum rte_kernel_driver kdrv;/**< Kernel driver passthrough */
 ^
In file included from lib/librte_eal/linuxapp/eal/eal_vfio_mp_sync.c:52:0:
i686-native-linuxapp-gcc/include/rte_pci.h:157:25: error: field 'kdrv' has 
incomplete type
  enum rte_kernel_driver kdrv;/**< Kernel driver passthrough */
 ^
In file included from lib/librte_eal/common/eal_private.h:38:0,
 from lib/librte_eal/linuxapp/eal/eal_thread.c:55:
i686-native-linuxapp-gcc/include/rte_pci.h:157:25: error: field 'kdrv' has 
incomplete type
  enum rte_kernel_driver kdrv;/**< Kernel driver passthrough */
 ^
make[7]: *** [eal_thread.o] Error 1
make[7]: *** Waiting for unfinished jobs
In file included from lib/librte_eal/linuxapp/eal/eal.c:72:0:
i686-native-linuxapp-gcc/include/rte_pci.h:157:25: error: field 'kdrv' has 
incomplete type
  enum rte_kernel_driver kdrv;/**< Kernel driver passthrough */
 ^
In file included from lib/librte_eal/common/eal_private.h:38:0,
 from lib/librte_eal/linuxapp/eal/eal_memory.c:97:
i686-native-linuxapp-gcc/include/rte_pci.h:157:25: error: field 'kdrv' has 
incomplete type
  enum rte_kernel_driver kdrv;/**< Kernel driver passthrough */
 ^
In file included from lib/librte_eal/common/eal_private.h:38:0,
 from lib/librte_eal/linuxapp/eal/eal_log.c:50:
i686-native-linuxapp-gcc/include/rte_pci.h:157:25: error: field 'kdrv' has 
incomplete type
  enum rte_kernel_driver kdrv;/**< Kernel driver passthrough */
 ^
make[7]: *** [eal_log.o] Error 1
make[7]: *** [eal_vfio_mp_sync.o] Error 1
In file included from lib/librte_eal/common/eal_private.h:38:0,
 from lib/librte_eal/linuxapp/eal/eal_vfio.c:45:
i686-native-linuxapp-gcc/include/rte_pci.h:157:25: error: field 'kdrv' has 
incomplete type
  enum rte_kernel_driver kdrv;/**< Kernel driver passthrough */
 ^
make[7]: *** [eal.o] Error 1
make[7]: *** [eal_memory.o] Error 1
make[7]: *** [eal_vfio.o] Error 1
lib/librte_eal/linuxapp/eal/eal_pci.c: In function 'rte_eal_pci_map_device':
lib/librte_eal/linuxapp/eal/eal_pci.c:133:7: error: 'RTE_KDRV_VFIO' undeclared 
(first use in this function)
  case RTE_KDRV_VFIO:
   ^
lib/librte_eal/linuxapp/eal/eal_pci.c:133:7: note: each undeclared identifier 
is reported only once for each function it appears in
lib/librte_eal/linuxapp/eal/eal_pci.c:139:7: error: 'RTE_KDRV_IGB_UIO' 
undeclared (first use in this function)
  case RTE_KDRV_IGB_UIO:
   ^
lib/librte_eal/linuxapp/eal/eal_pci.c:140:7: error: 'RTE_KDRV_UIO_GENERIC' 
undeclared (first use in this function)
  case RTE_KDRV_UIO_GENERIC:
   ^
lib/librte_eal/linuxapp/eal/eal_pci.c: In function 'rte_eal_pci_unmap_device':
lib/librte_eal/linuxapp/eal/eal_pci.c:160:7: error: 'RTE_KDRV_VFIO' undeclared 
(first use in this function)
  case RTE_KDRV_VFIO:
   ^
lib/librte_eal/linuxapp/eal/eal_pci.c:163:7: error: 'RTE_KDRV_IGB_UIO' 
undeclared (first use in this function)
  case RTE_KDRV_IGB_UIO:
   ^
lib/librte_eal/linuxapp/eal/eal_pci.c:164:7: error: 'RTE_KDRV_UIO_GENERIC' 
undeclared (first use in this function)
  case RTE_KDRV_UIO_GENERIC:
   ^
lib/librte_eal/linuxapp/eal/eal_pci.c: In function 'pci_scan_one':
lib/librte_eal/linuxapp/eal/eal_pci.c:381:16: error: 'RTE_KDRV_VFIO' undeclared 
(first use in this function)
dev->kdrv = RTE_KDRV_VFIO;
^
lib/librte_eal/linuxapp/eal/eal_pci.c:383:16: error: 'RTE_KDRV_IGB_UIO' 
undeclared (first use in this function)
dev->kdrv = RTE_KDRV_IGB_UIO;
^
lib/librte_eal/linuxapp/eal/eal_pci.c:385:16: error: 'RTE_KDRV_UIO_GENERIC' 
undeclared (first use in this function)
dev->kdrv = RTE_KDRV_UIO_GENERIC;
^
lib/librte_eal/linuxapp/eal/eal_pci.c:387:16: error: 'RTE_KDRV_UNKNOWN' 
undeclared (first use in this function)
dev->kdrv = RTE_KDRV_UNKNOWN;
^
lib/librte_eal/linuxapp/eal/eal_pci.c:389:15: error: 'RTE_KDRV_NONE' undeclared 
(first use in this function)
   dev->kdrv = RTE_KDRV_NONE;
   ^
lib/librte_eal/linuxapp/eal/eal_pci.c: In function 'rte_eal_pci_ioport_map':
lib/librte_eal/linuxapp/eal/eal_pci.c:626:7: error: 'RTE_KDRV_VFIO' undeclared 
(first use in this function)
  case RTE_KDRV_VFIO:
   ^

[dpdk-dev] [PATCH 1/5] eal: make enum rte_kernel_driver non-PCI specific

2016-09-01 Thread Shreyansh Jain 
From: Jan Viktorin 

From: Jan Viktorin 

Signed-off-by: Jan Viktorin 
Signed-off-by: Shreyansh Jain 
---
 lib/librte_eal/common/include/rte_dev.h | 12 
 lib/librte_eal/common/include/rte_pci.h |  9 -
 2 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/lib/librte_eal/common/include/rte_dev.h 
b/lib/librte_eal/common/include/rte_dev.h
index 95789f9..60bc91d 100644
--- a/lib/librte_eal/common/include/rte_dev.h
+++ b/lib/librte_eal/common/include/rte_dev.h
@@ -101,6 +101,18 @@ rte_pmd_debug_trace(const char *func_name, const char 
*fmt, ...)
 } while (0)


+/**
+ * Kernel driver passthrough type
+ */
+enum rte_kernel_driver {
+   RTE_KDRV_UNKNOWN = 0,
+   RTE_KDRV_IGB_UIO,
+   RTE_KDRV_VFIO,
+   RTE_KDRV_UIO_GENERIC,
+   RTE_KDRV_NIC_UIO,
+   RTE_KDRV_NONE,
+};
+
 /** Double linked list of device drivers. */
 TAILQ_HEAD(rte_driver_list, rte_driver);

diff --git a/lib/librte_eal/common/include/rte_pci.h 
b/lib/librte_eal/common/include/rte_pci.h
index fa74962..a4c8156 100644
--- a/lib/librte_eal/common/include/rte_pci.h
+++ b/lib/librte_eal/common/include/rte_pci.h
@@ -141,15 +141,6 @@ struct rte_pci_addr {

 struct rte_devargs;

-enum rte_kernel_driver {
-   RTE_KDRV_UNKNOWN = 0,
-   RTE_KDRV_IGB_UIO,
-   RTE_KDRV_VFIO,
-   RTE_KDRV_UIO_GENERIC,
-   RTE_KDRV_NIC_UIO,
-   RTE_KDRV_NONE,
-};
-
 /**
  * A structure describing a PCI device.
  */
-- 
2.7.4