[dpdk-dev] [PATCH 4/4] app: replace dump_cfg with proc_info

2015-06-08 Thread Thomas Monjalon
2015-06-08 13:45, Tahhan, Maryam:
> > > Extend dump_cfg to also display statistcs information for given DPDK
> > > ports and rename the application to proc_info as it's now a utility
> > > doing a little more than just dumping the memory information for DPDK.
> > >
> > > Signed-off-by: Maryam Tahhan 
> > > ---
> > >  app/Makefile   |   2 +-
> > >  app/dump_cfg/Makefile  |  45 -
> > >  app/dump_cfg/main.c|  92 -
> > >  app/proc_info/Makefile |  45 +
> > >  app/proc_info/main.c   | 525
> > +
> > >  mk/rte.sdktest.mk  |   4 +-
> > 
> > It looks promising, thanks.
> > Would you consider adding yourself as a maintainer of this app?
> 
> Yep, I can do that. Should I add myself to the maintainers file in a separate 
> patch, or as a reworked version of this patch?

In case there is no other comment, a separate patch is OK.
Thanks



[dpdk-dev] [PATCH 4/4] app: replace dump_cfg with proc_info

2015-06-08 Thread Tahhan, Maryam
> > Extend dump_cfg to also display statistcs information for given DPDK
> > ports and rename the application to proc_info as it's now a utility
> > doing a little more than just dumping the memory information for DPDK.
> >
> > Signed-off-by: Maryam Tahhan 
> > ---
> >  app/Makefile   |   2 +-
> >  app/dump_cfg/Makefile  |  45 -
> >  app/dump_cfg/main.c|  92 -
> >  app/proc_info/Makefile |  45 +
> >  app/proc_info/main.c   | 525
> +
> >  mk/rte.sdktest.mk  |   4 +-
> 
> It looks promising, thanks.
> Would you consider adding yourself as a maintainer of this app?

Yep, I can do that. Should I add myself to the maintainers file in a separate 
patch, or as a reworked version of this patch?

BR
Maryam


[dpdk-dev] [PATCH 4/4] app: replace dump_cfg with proc_info

2015-06-06 Thread Thomas Monjalon
2015-06-05 18:35, Maryam Tahhan:
> Extend dump_cfg to also display statistcs information for given DPDK
> ports and rename the application to proc_info as it's now a utility
> doing a little more than just dumping the memory information for DPDK.
> 
> Signed-off-by: Maryam Tahhan 
> ---
>  app/Makefile   |   2 +-
>  app/dump_cfg/Makefile  |  45 -
>  app/dump_cfg/main.c|  92 -
>  app/proc_info/Makefile |  45 +
>  app/proc_info/main.c   | 525 
> +
>  mk/rte.sdktest.mk  |   4 +-

It looks promising, thanks.
Would you consider adding yourself as a maintainer of this app?



[dpdk-dev] [PATCH 4/4] app: replace dump_cfg with proc_info

2015-06-05 Thread Maryam Tahhan
Extend dump_cfg to also display statistcs information for given DPDK
ports and rename the application to proc_info as it's now a utility
doing a little more than just dumping the memory information for DPDK.

Signed-off-by: Maryam Tahhan 
---
 app/Makefile   |   2 +-
 app/dump_cfg/Makefile  |  45 -
 app/dump_cfg/main.c|  92 -
 app/proc_info/Makefile |  45 +
 app/proc_info/main.c   | 525 +
 mk/rte.sdktest.mk  |   4 +-
 6 files changed, 573 insertions(+), 140 deletions(-)
 delete mode 100644 app/dump_cfg/Makefile
 delete mode 100644 app/dump_cfg/main.c
 create mode 100644 app/proc_info/Makefile
 create mode 100644 app/proc_info/main.c

diff --git a/app/Makefile b/app/Makefile
index 50c670b..88c0bad 100644
--- a/app/Makefile
+++ b/app/Makefile
@@ -36,6 +36,6 @@ DIRS-$(CONFIG_RTE_LIBRTE_ACL) += test-acl
 DIRS-$(CONFIG_RTE_LIBRTE_PIPELINE) += test-pipeline
 DIRS-$(CONFIG_RTE_TEST_PMD) += test-pmd
 DIRS-$(CONFIG_RTE_LIBRTE_CMDLINE) += cmdline_test
-DIRS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += dump_cfg
+DIRS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += proc_info

 include $(RTE_SDK)/mk/rte.subdir.mk
diff --git a/app/dump_cfg/Makefile b/app/dump_cfg/Makefile
deleted file mode 100644
index 3257127..000
--- a/app/dump_cfg/Makefile
+++ /dev/null
@@ -1,45 +0,0 @@
-#   BSD LICENSE
-#
-#   Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
-#   All rights reserved.
-#
-#   Redistribution and use in source and binary forms, with or without
-#   modification, are permitted provided that the following conditions
-#   are met:
-#
-# * Redistributions of source code must retain the above copyright
-#   notice, this list of conditions and the following disclaimer.
-# * Redistributions in binary form must reproduce the above copyright
-#   notice, this list of conditions and the following disclaimer in
-#   the documentation and/or other materials provided with the
-#   distribution.
-# * Neither the name of Intel Corporation nor the names of its
-#   contributors may be used to endorse or promote products derived
-#   from this software without specific prior written permission.
-#
-#   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-#   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-#   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-#   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-#   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-#   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
-#   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
-#   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
-#   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-#   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-#   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-
-include $(RTE_SDK)/mk/rte.vars.mk
-
-APP = dump_cfg
-
-CFLAGS += $(WERROR_FLAGS)
-
-# all source are stored in SRCS-y
-
-SRCS-y := main.c
-
-# this application needs libraries first
-DEPDIRS-y += lib
-
-include $(RTE_SDK)/mk/rte.app.mk
diff --git a/app/dump_cfg/main.c b/app/dump_cfg/main.c
deleted file mode 100644
index 127dbb1..000
--- a/app/dump_cfg/main.c
+++ /dev/null
@@ -1,92 +0,0 @@
-/*-
- *   BSD LICENSE
- *
- *   Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
- *   All rights reserved.
- *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- * * Redistributions of source code must retain the above copyright
- *   notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above copyright
- *   notice, this list of conditions and the following disclaimer in
- *   the documentation and/or other materials provided with the
- *   distribution.
- * * Neither the name of Intel Corporation nor the names of its
- *   contributors may be used to endorse or promote products derived
- *   from this software without specific prior written permission.
- *
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT