[dpdk-dev] [PATCH 5/6] qede: add driver
>> >> >> >>On Tue, 23 Feb 2016 02:28:25 + >>Harish Patil wrote: >> >>> All of the checkpatch warnings had been fixed (except one which cannot >>>be >>> fixed) using the checkpatch script available under DPDK scripts/ >>> directory. The linux checkpatch version is 0.32. >>> >>> [root at dut4019 dpdk]# ./scripts/checkpatches.sh patches-send/*.patch >>> >>> ### patches-send/0004-qede-add-driver-common-module.patch >>> >>> WARNING:CAMELCASE: Avoid CamelCase: >>> #251: FILE: drivers/net/qede/ecore/bcm_osal.c:120: >>> + inflateEnd(p_hwfn->stream); >>> >>> total: 0 errors, 1 warnings, 54467 lines checked >>> >>> Wouldn?t that suffice? >> >>Maybe your version of checkpatch from kernel is older than more recent >>version I am using (from Linux 4.4). >> >I had used checkpatch version 0.32 as mentioned above. >The latest checkpatch version in net-next also shows 0.32. >my $V = '0.32?; > >I see similar checkpatch related conversations going on in other threads >in the distribution. >Please advise. >+Thomas > >Thanks, >Harish > > > +Thomas
[dpdk-dev] [PATCH 5/6] qede: add driver
> >On Tue, 23 Feb 2016 02:28:25 + >Harish Patil wrote: > >> All of the checkpatch warnings had been fixed (except one which cannot >>be >> fixed) using the checkpatch script available under DPDK scripts/ >> directory. The linux checkpatch version is 0.32. >> >> [root at dut4019 dpdk]# ./scripts/checkpatches.sh patches-send/*.patch >> >> ### patches-send/0004-qede-add-driver-common-module.patch >> >> WARNING:CAMELCASE: Avoid CamelCase: >> #251: FILE: drivers/net/qede/ecore/bcm_osal.c:120: >> + inflateEnd(p_hwfn->stream); >> >> total: 0 errors, 1 warnings, 54467 lines checked >> >> Wouldn?t that suffice? > >Maybe your version of checkpatch from kernel is older than more recent >version I am using (from Linux 4.4). > I had used checkpatch version 0.32 as mentioned above. The latest checkpatch version in net-next also shows 0.32. my $V = '0.32?; I see similar checkpatch related conversations going on in other threads in the distribution. Please advise. +Thomas Thanks, Harish
[dpdk-dev] [PATCH 5/6] qede: add driver
On Tue, 23 Feb 2016 02:28:25 + Harish Patil wrote: > All of the checkpatch warnings had been fixed (except one which cannot be > fixed) using the checkpatch script available under DPDK scripts/ > directory. The linux checkpatch version is 0.32. > > [root at dut4019 dpdk]# ./scripts/checkpatches.sh patches-send/*.patch > > ### patches-send/0004-qede-add-driver-common-module.patch > > WARNING:CAMELCASE: Avoid CamelCase: > #251: FILE: drivers/net/qede/ecore/bcm_osal.c:120: > + inflateEnd(p_hwfn->stream); > > total: 0 errors, 1 warnings, 54467 lines checked > > Wouldn?t that suffice? Maybe your version of checkpatch from kernel is older than more recent version I am using (from Linux 4.4).
[dpdk-dev] [PATCH 5/6] qede: add driver
On Tue, 23 Feb 2016 02:28:25 + Harish Patil wrote: > All of the checkpatch warnings had been fixed (except one which cannot be > fixed) using the checkpatch script available under DPDK scripts/ > directory. The linux checkpatch version is 0.32. > > [root at dut4019 dpdk]# ./scripts/checkpatches.sh patches-send/*.patch > > ### patches-send/0004-qede-add-driver-common-module.patch > > WARNING:CAMELCASE: Avoid CamelCase: > #251: FILE: drivers/net/qede/ecore/bcm_osal.c:120: > + inflateEnd(p_hwfn->stream); > > total: 0 errors, 1 warnings, 54467 lines checked > > Wouldn?t that suffice? The problem is that the DPDK version is shutting off warnings about stuff that is really incorrect and should be fixed. Look at the warnings about spaces in strings, I don't know why the DPDK wrapper disables that.
[dpdk-dev] [PATCH 5/6] qede: add driver
On Sat, 20 Feb 2016 07:40:30 -0800
Harish Patil wrote:
> Signed-off-by: Harish Patil
> Signed-off-by: Rasesh Mody
> Signed-off-by: Sony Chacko
> ---
> drivers/net/qede/LICENSE.qede_pmd | 28 +
> drivers/net/qede/Makefile | 95 ++
> drivers/net/qede/qede_eth_if.c| 461 ++
> drivers/net/qede/qede_eth_if.h| 180
> drivers/net/qede/qede_ethdev.c| 815 +
> drivers/net/qede/qede_ethdev.h| 138 +++
> drivers/net/qede/qede_if.h| 167
> drivers/net/qede/qede_logs.h | 93 ++
> drivers/net/qede/qede_main.c | 587 +
> drivers/net/qede/qede_rxtx.c | 1346
> +
> drivers/net/qede/qede_rxtx.h | 183
> drivers/net/qede/rte_pmd_qede_version.map |4 +
> 12 files changed, 4097 insertions(+)
> create mode 100644 drivers/net/qede/LICENSE.qede_pmd
> create mode 100644 drivers/net/qede/Makefile
> create mode 100644 drivers/net/qede/qede_eth_if.c
> create mode 100644 drivers/net/qede/qede_eth_if.h
> create mode 100644 drivers/net/qede/qede_ethdev.c
> create mode 100644 drivers/net/qede/qede_ethdev.h
> create mode 100644 drivers/net/qede/qede_if.h
> create mode 100644 drivers/net/qede/qede_logs.h
> create mode 100644 drivers/net/qede/qede_main.c
> create mode 100644 drivers/net/qede/qede_rxtx.c
> create mode 100644 drivers/net/qede/qede_rxtx.h
> create mode 100644 drivers/net/qede/rte_pmd_qede_version.map
DPDK doesn't follow all the kernel style rules, but lots of them.
The biggest catch was the ; in the LOG macros.
Minor stuff about spacing around casts etc.
Running checkpatch with --ignore
PREFER_KERNEL_TYPES,LINE_SPACING,PARENTHESIS_ALIGNMENT,BIT_MACRO,NETWORKING_BLOCK_COMMENT_STYLE,SPLIT_STRING,COMPARISON_TO_NULL,CONCATENATED_STRING
Produces:
CHECK:SPACING: spaces preferred around that '*' (ctx:VxO)
#410: FILE: drivers/net/qede/qede_eth_if.c:175:
+ uint16_t cqe_pbl_size, void OSAL_IOMEM**pp_prod)
^
CHECK:SPACING: spaces preferred around that '*' (ctx:VxO)
#467: FILE: drivers/net/qede/qede_eth_if.c:232:
+ uint16_t pbl_size, void OSAL_IOMEM**pp_doorbell)
^
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#519: FILE: drivers/net/qede/qede_eth_if.c:284:
+{
+
WARNING:SPACING: Unnecessary space before function pointer arguments
#823: FILE: drivers/net/qede/qede_eth_if.h:121:
+ int (*fill_dev_info) (struct ecore_dev *edev,
WARNING:SPACING: Unnecessary space before function pointer arguments
#826: FILE: drivers/net/qede/qede_eth_if.h:124:
+ int (*vport_start) (struct ecore_dev *edev,
WARNING:SPACING: Unnecessary space before function pointer arguments
#829: FILE: drivers/net/qede/qede_eth_if.h:127:
+ int (*vport_stop) (struct ecore_dev *edev, uint8_t vport_id);
WARNING:SPACING: Unnecessary space before function pointer arguments
#831: FILE: drivers/net/qede/qede_eth_if.h:129:
+ int (*vport_update) (struct ecore_dev *edev,
WARNING:SPACING: Unnecessary space before function pointer arguments
#834: FILE: drivers/net/qede/qede_eth_if.h:132:
+ int (*q_rx_start) (struct ecore_dev *cdev,
CHECK:SPACING: spaces preferred around that '*' (ctx:VxO)
#840: FILE: drivers/net/qede/qede_eth_if.h:138:
+ uint16_t cqe_pbl_size, void OSAL_IOMEM**pp_prod);
^
WARNING:SPACING: Unnecessary space before function pointer arguments
#842: FILE: drivers/net/qede/qede_eth_if.h:140:
+ int (*q_rx_stop) (struct ecore_dev *edev,
WARNING:SPACING: Unnecessary space before function pointer arguments
#845: FILE: drivers/net/qede/qede_eth_if.h:143:
+ int (*q_tx_start) (struct ecore_dev *edev,
CHECK:SPACING: spaces preferred around that '*' (ctx:VxO)
#850: FILE: drivers/net/qede/qede_eth_if.h:148:
+ uint16_t pbl_size, void OSAL_IOMEM**pp_doorbell);
^
WARNING:SPACING: Unnecessary space before function pointer arguments
#852: FILE: drivers/net/qede/qede_eth_if.h:150:
+ int (*q_tx_stop) (struct ecore_dev *edev,
WARNING:SPACING: Unnecessary space before function pointer arguments
#855: FILE: drivers/net/qede/qede_eth_if.h:153:
+ int (*eth_cqe_completion) (struct ecore_dev *edev,
WARNING:SPACING: Unnecessary space before function pointer arguments
#859: FILE: drivers/net/qede/qede_eth_if.h:157:
+ int (*fastpath_stop) (struct ecore_dev *edev);
WARNING:SPACING: Unnecessary space before function pointer arguments
#861: FILE: drivers/net/qede/qede_eth_if.h:159:
+ void (*get_vport_stats) (struct ecore_dev *edev,
WARNING:SPACING: Unnecessary space before function pointer arguments
#864: FILE: drivers/net/qede/qede_eth_if.h:162:
+
[dpdk-dev] [PATCH 5/6] qede: add driver
Signed-off-by: Harish Patil Signed-off-by: Rasesh Mody Signed-off-by: Sony Chacko --- drivers/net/qede/LICENSE.qede_pmd | 28 + drivers/net/qede/Makefile | 95 ++ drivers/net/qede/qede_eth_if.c| 461 ++ drivers/net/qede/qede_eth_if.h| 180 drivers/net/qede/qede_ethdev.c| 815 + drivers/net/qede/qede_ethdev.h| 138 +++ drivers/net/qede/qede_if.h| 167 drivers/net/qede/qede_logs.h | 93 ++ drivers/net/qede/qede_main.c | 587 + drivers/net/qede/qede_rxtx.c | 1346 + drivers/net/qede/qede_rxtx.h | 183 drivers/net/qede/rte_pmd_qede_version.map |4 + 12 files changed, 4097 insertions(+) create mode 100644 drivers/net/qede/LICENSE.qede_pmd create mode 100644 drivers/net/qede/Makefile create mode 100644 drivers/net/qede/qede_eth_if.c create mode 100644 drivers/net/qede/qede_eth_if.h create mode 100644 drivers/net/qede/qede_ethdev.c create mode 100644 drivers/net/qede/qede_ethdev.h create mode 100644 drivers/net/qede/qede_if.h create mode 100644 drivers/net/qede/qede_logs.h create mode 100644 drivers/net/qede/qede_main.c create mode 100644 drivers/net/qede/qede_rxtx.c create mode 100644 drivers/net/qede/qede_rxtx.h create mode 100644 drivers/net/qede/rte_pmd_qede_version.map diff --git a/drivers/net/qede/LICENSE.qede_pmd b/drivers/net/qede/LICENSE.qede_pmd new file mode 100644 index 000..c7cbdcc --- /dev/null +++ b/drivers/net/qede/LICENSE.qede_pmd @@ -0,0 +1,28 @@ +/* + * BSD LICENSE + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in the + *documentation and/or other materials provided with the distribution. + * 3. Neither the name of QLogic Corporation nor the name of its contributors + *may be used to endorse or promote products derived from this software + *without specific prior written consent. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS' + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS + * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF + * THE POSSIBILITY OF SUCH DAMAGE. + */ diff --git a/drivers/net/qede/Makefile b/drivers/net/qede/Makefile new file mode 100644 index 000..a62d80e --- /dev/null +++ b/drivers/net/qede/Makefile @@ -0,0 +1,95 @@ +#Copyright (c) 2016 QLogic Corporation. +#All rights reserved. +#www.qlogic.com +# +#See LICENSE.qede_pmd for copyright and licensing details. + +include $(RTE_SDK)/mk/rte.vars.mk + +# +# library name +# +LIB = librte_pmd_qede.a + +CFLAGS += -O3 +CFLAGS += $(WERROR_FLAGS) + +EXPORT_MAP := rte_pmd_qede_version.map + +LIBABIVER := 1 + +# +#OS +# +OS_TYPE := $(shell uname -s) + +# +# CFLAGS +# +CFLAGS_ECORE_DRIVER = -Wno-unused-parameter +CFLAGS_ECORE_DRIVER += -Wno-unused-value +CFLAGS_ECORE_DRIVER += -Wno-sign-compare +CFLAGS_ECORE_DRIVER += -Wno-missing-prototypes +CFLAGS_ECORE_DRIVER += -Wno-cast-qual +CFLAGS_ECORE_DRIVER += -Wno-unused-function +CFLAGS_ECORE_DRIVER += -Wno-unused-variable +CFLAGS_ECORE_DRIVER += -Wno-strict-aliasing +CFLAGS_ECORE_DRIVER += -Wno-missing-prototypes +CFLAGS_ECORE_DRIVER += -Wno-format-nonliteral +ifeq ($(OS_TYPE),Linux) +CFLAGS_ECORE_DRIVER += -Wno-shift-negative-value +endif + +ifneq (,$(filter gcc gcc48,$(CC))) +CFLAGS_ECORE_DRIVER += -Wno-unused-but-set-variable +CFLAGS_ECORE_DRIVER += -Wno-missing-declarations +CFLAGS_ECORE_DRIVER += -Wno-maybe-uninitialized +CFLAGS_ECORE_DRIVER += -Wno-strict-prototypes +else ifeq ($(CC), clang) +CFLAGS_ECORE_DRIVER += -Wno-format-extra-args +CFLAGS_ECORE_DRIVER += -Wno-visibility +CFLAGS_ECORE_DRIVER += -Wno-empty-body +CFLAGS_ECORE_DRIVER += -Wno-invalid-source-encoding +CFLAGS_ECORE_DRIVER += -Wno-sometimes-uninitialized +CFLAGS_ECORE_DRIVER += -Wno-pointer-bool-conversion +else +#icc flags +endif + +# +# Add extra flags for base ecore driver files +# to disable warnings in them +# +#
