[dpdk-dev] [PATCH v1 0/3] Add missing ethdev driver support
On 16/02/2016 18:54, Stephen Hemminger wrote: > On Thu, 28 Jan 2016 08:48:12 + > Remy Horton wrote: > >> Several rte_eth_dev_* functions are currently only supported >> by the ixgbe NIC driver. This patchset adds driver support >> for some of these functions to the i40e, virtio, and vmxnet3 >> drivers. > > It is good to make drivers more complete and compatible, but unless > the virtual driver has some useful data I can't see the point of providing > these functions in this case. The base infrastructure (rte_ethdev) should > deal with by returning not supported error (or all zeros); rather than > creating more code in other drivers for no real gain. Come to the same conclusion regarding the Rx/Tx queue info functions, as working out how to derive the figures I could return was also baking in some implicit assumptions. Plan to exclude those ones from the v2. ..Remy
[dpdk-dev] [PATCH v1 0/3] Add missing ethdev driver support
On Thu, 28 Jan 2016 08:48:12 + Remy Horton wrote: > Several rte_eth_dev_* functions are currently only supported > by the ixgbe NIC driver. This patchset adds driver support > for some of these functions to the i40e, virtio, and vmxnet3 > drivers. It is good to make drivers more complete and compatible, but unless the virtual driver has some useful data I can't see the point of providing these functions in this case. The base infrastructure (rte_ethdev) should deal with by returning not supported error (or all zeros); rather than creating more code in other drivers for no real gain.
[dpdk-dev] [PATCH v1 0/3] Add missing ethdev driver support
Several rte_eth_dev_* functions are currently only supported by the ixgbe NIC driver. This patchset adds driver support for some of these functions to the i40e, virtio, and vmxnet3 drivers. Remy Horton (3): drivers/net/i40e: Add ethdev functions drivers/net/virtio: Add ethdev functions drivers/net/vmxnet3: Add ethdev functions doc/guides/rel_notes/release_2_3.rst | 14 + drivers/net/i40e/i40e_ethdev.c | 130 +- drivers/net/i40e/i40e_regs.h | 814 +++ drivers/net/virtio/virtio_ethdev.c | 47 ++ drivers/net/vmxnet3/vmxnet3_ethdev.c | 60 +++ 5 files changed, 1063 insertions(+), 2 deletions(-) create mode 100644 drivers/net/i40e/i40e_regs.h -- 2.5.0
