[dpdk-dev] [PATCH v1 19/28] eal/soc: add drv_flags

[Jan Viktorin]

On Mon, 13 Jun 2016 14:21:40 +
Shreyansh Jain  wrote:

> > -Original Message-
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jan Viktorin
> > Sent: Friday, May 06, 2016 7:18 PM
> > To: dev at dpdk.org
> > Cc: Jan Viktorin ; David Marchand
> > ; Thomas Monjalon  > 6wind.com>;
> > Bruce Richardson ; Declan Doherty
> > ; jianbo.liu at linaro.org;
> > jerin.jacob at caviumnetworks.com; Keith Wiles ; 
> > Stephen
> > Hemminger 
> > Subject: [dpdk-dev] [PATCH v1 19/28] eal/soc: add drv_flags
> > 
> > The flags are copied from the PCI ones. They should be refactorized into a
> > general set of flags in the future.
> > 
> > Signed-off-by: Jan Viktorin 
> > ---
> >  lib/librte_eal/common/include/rte_soc.h | 10 ++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/lib/librte_eal/common/include/rte_soc.h
> > b/lib/librte_eal/common/include/rte_soc.h
> > index 49cfeb7..50a3b35 100644
> > --- a/lib/librte_eal/common/include/rte_soc.h
> > +++ b/lib/librte_eal/common/include/rte_soc.h
> > @@ -125,8 +125,18 @@ struct rte_soc_driver {
> > soc_devinit_t *devinit;/**< Device initialization */
> > soc_devuninit_t *devuninit;/**< Device uninitialization */
> > const struct rte_soc_id *id_table; /**< ID table, NULL terminated */
> > +   uint32_t drv_flags;/**< Control handling of device */
> >  };
> > 
> > +/** Device needs to map its resources by EAL */
> > +#define RTE_SOC_DRV_NEED_MAPPING 0x0001
> > +/** Device needs to be unbound event if no module is provieded */  
> 
> Comment should read "Device needs to be unbound even if no module is provided"

OK, thanks.

> 
> > +#define RTE_SOC_DRV_FORCE_UNBIND 0x0004
> > +/** Device driver supports link state interrupt */
> > +#define RTE_SOC_DRV_INTR_LSC0x0008
> > +/** Device driver supports detaching capability */
> > +#define RTE_SOC_DRV_DETACHABLE  0x0010
> > +
> >  /**
> >   * A structure describing a SoC mapping.
> >   */
> > --
> > 2.8.0  
> 

[dpdk-dev] [PATCH v1 19/28] eal/soc: add drv_flags

[Shreyansh Jain]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jan Viktorin
> Sent: Friday, May 06, 2016 7:18 PM
> To: dev at dpdk.org
> Cc: Jan Viktorin ; David Marchand
> ; Thomas Monjalon ;
> Bruce Richardson ; Declan Doherty
> ; jianbo.liu at linaro.org;
> jerin.jacob at caviumnetworks.com; Keith Wiles ; 
> Stephen
> Hemminger 
> Subject: [dpdk-dev] [PATCH v1 19/28] eal/soc: add drv_flags
> 
> The flags are copied from the PCI ones. They should be refactorized into a
> general set of flags in the future.
> 
> Signed-off-by: Jan Viktorin 
> ---
>  lib/librte_eal/common/include/rte_soc.h | 10 ++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/lib/librte_eal/common/include/rte_soc.h
> b/lib/librte_eal/common/include/rte_soc.h
> index 49cfeb7..50a3b35 100644
> --- a/lib/librte_eal/common/include/rte_soc.h
> +++ b/lib/librte_eal/common/include/rte_soc.h
> @@ -125,8 +125,18 @@ struct rte_soc_driver {
>   soc_devinit_t *devinit;/**< Device initialization */
>   soc_devuninit_t *devuninit;/**< Device uninitialization */
>   const struct rte_soc_id *id_table; /**< ID table, NULL terminated */
> + uint32_t drv_flags;/**< Control handling of device */
>  };
> 
> +/** Device needs to map its resources by EAL */
> +#define RTE_SOC_DRV_NEED_MAPPING 0x0001
> +/** Device needs to be unbound event if no module is provieded */

Comment should read "Device needs to be unbound even if no module is provided"

> +#define RTE_SOC_DRV_FORCE_UNBIND 0x0004
> +/** Device driver supports link state interrupt */
> +#define RTE_SOC_DRV_INTR_LSC  0x0008
> +/** Device driver supports detaching capability */
> +#define RTE_SOC_DRV_DETACHABLE0x0010
> +
>  /**
>   * A structure describing a SoC mapping.
>   */
> --
> 2.8.0

[dpdk-dev] [PATCH v1 19/28] eal/soc: add drv_flags

[Jan Viktorin]

The flags are copied from the PCI ones. They should be refactorized into a
general set of flags in the future.

Signed-off-by: Jan Viktorin 
---
 lib/librte_eal/common/include/rte_soc.h | 10 ++
 1 file changed, 10 insertions(+)

diff --git a/lib/librte_eal/common/include/rte_soc.h 
b/lib/librte_eal/common/include/rte_soc.h
index 49cfeb7..50a3b35 100644
--- a/lib/librte_eal/common/include/rte_soc.h
+++ b/lib/librte_eal/common/include/rte_soc.h
@@ -125,8 +125,18 @@ struct rte_soc_driver {
soc_devinit_t *devinit;/**< Device initialization */
soc_devuninit_t *devuninit;/**< Device uninitialization */
const struct rte_soc_id *id_table; /**< ID table, NULL terminated */
+   uint32_t drv_flags;/**< Control handling of device */
 };

+/** Device needs to map its resources by EAL */
+#define RTE_SOC_DRV_NEED_MAPPING 0x0001
+/** Device needs to be unbound event if no module is provieded */
+#define RTE_SOC_DRV_FORCE_UNBIND 0x0004
+/** Device driver supports link state interrupt */
+#define RTE_SOC_DRV_INTR_LSC0x0008
+/** Device driver supports detaching capability */
+#define RTE_SOC_DRV_DETACHABLE  0x0010
+
 /**
  * A structure describing a SoC mapping.
  */
-- 
2.8.0