[dpdk-dev] [PATCH v2] doc: add pep8 as the python code style guidelines

2016-06-07 Thread Thomas Monjalon
2016-06-03 11:51, Bruce Richardson:
> On Fri, May 27, 2016 at 03:57:15PM +0100, John McNamara wrote:
> > Added PEP8 to the DPDK Coding Style guidelines to cover Python
> > contributions to DPDK.
> > 
> > Signed-off-by: John McNamara 
> Acked-by: Bruce Richardson 

Applied, thanks


[dpdk-dev] [PATCH v2] doc: add pep8 as the python code style guidelines

2016-06-03 Thread Bruce Richardson
On Fri, May 27, 2016 at 03:57:15PM +0100, John McNamara wrote:
> Added PEP8 to the DPDK Coding Style guidelines to cover Python
> contributions to DPDK.
> 
> Signed-off-by: John McNamara 
> ---
> v2: fixed section level.
> 
> 
>  doc/guides/contributing/coding_style.rst | 8 
>  1 file changed, 8 insertions(+)
> 
> diff --git a/doc/guides/contributing/coding_style.rst 
> b/doc/guides/contributing/coding_style.rst
> index ad1392d..1eb67f3 100644
> --- a/doc/guides/contributing/coding_style.rst
> +++ b/doc/guides/contributing/coding_style.rst
> @@ -685,3 +685,11 @@ Control Statements
>   usage();
>   /* NOTREACHED */
>   }
> +
> +
> +Python Code
> +---
> +
> +All python code should be compliant with `PEP8 (Style Guide for Python Code) 
> `_.
> +
> +The ``pep8`` tool can be used for testing compliance with the guidelines.
> -- 
Yep, I think this would be good to have, especially since there is a nice
public tool to help ensure people are compliant with this. Even though all
existing code is not (yet) compliant no reason new code shouldn't be.

Acked-by: Bruce Richardson 



[dpdk-dev] [PATCH v2] doc: add pep8 as the python code style guidelines

2016-05-27 Thread John McNamara
Added PEP8 to the DPDK Coding Style guidelines to cover Python
contributions to DPDK.

Signed-off-by: John McNamara 
---
v2: fixed section level.


 doc/guides/contributing/coding_style.rst | 8 
 1 file changed, 8 insertions(+)

diff --git a/doc/guides/contributing/coding_style.rst 
b/doc/guides/contributing/coding_style.rst
index ad1392d..1eb67f3 100644
--- a/doc/guides/contributing/coding_style.rst
+++ b/doc/guides/contributing/coding_style.rst
@@ -685,3 +685,11 @@ Control Statements
  usage();
  /* NOTREACHED */
  }
+
+
+Python Code
+---
+
+All python code should be compliant with `PEP8 (Style Guide for Python Code) 
`_.
+
+The ``pep8`` tool can be used for testing compliance with the guidelines.
-- 
2.5.0