[dpdk-dev] [PATCH v2] doc: update nic overview

[Thomas Monjalon]

Hi Mark,

I'm waiting for these small comments.
Please could you rebase your patch and fix it if needed?

2016-04-06 10:33, Thomas Monjalon:
> 2016-04-01 16:55, Chen Jing D:
> > -   stats per queue  X  
> >X
> > +   stats per queue  X  
> >X
> 
> I think you should fill "stats per queue"
> 
> > BSD nic_uio  X   X X X X
> 
> What is the issue with BSD?

[dpdk-dev] [PATCH v2] doc: update nic overview

[Chen, Jing D]

Hi, Thomas,


> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Thursday, April 07, 2016 3:54 PM
> To: Chen, Jing D
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] doc: update nic overview
> 
> Hi Mark,
> 
> I'm waiting for these small comments.
> Please could you rebase your patch and fix it if needed?
> 

Sorry, will do today.

> 2016-04-06 10:33, Thomas Monjalon:
> > 2016-04-01 16:55, Chen Jing D:
> > > -   stats per queue  X
> > >  X
> > > +   stats per queue  X
> > >  X
> >
> > I think you should fill "stats per queue"
> >
> > > BSD nic_uio  X   X X X X
> >
> > What is the issue with BSD?
> 

[dpdk-dev] [PATCH v2] doc: update nic overview

[Thomas Monjalon]

2016-04-01 16:55, Chen Jing D:
> -   stats per queue  X
>  X
> +   stats per queue  X
>  X

I think you should fill "stats per queue"

> BSD nic_uio  X   X X X X

What is the issue with BSD?

[dpdk-dev] [PATCH v2] doc: update nic overview

[Chen, Jing D]

Thomas,


> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Saturday, April 02, 2016 5:40 AM
> To: Chen, Jing D
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] doc: update nic overview
> 
> 2016-04-01 16:55, Chen Jing D:
> > Add feature support list for fm10k, fm10k-vec, fm10kvf and
> > fm10kvf-vec.
> 
> Please help me to understand what is fm10kvf.
> I see only one fm10k driver:
> % git grep 'struct eth_driver' drivers/net/fm10k/
> drivers/net/fm10k/fm10k_ethdev.c:static struct eth_driver rte_pmd_fm10k
> = {

You can refer to below definition:

static const struct rte_pci_id pci_id_fm10k_map[] = {
#define RTE_PCI_DEV_ID_DECL_FM10K(vend, dev) { RTE_PCI_DEVICE(vend, dev) },
#define RTE_PCI_DEV_ID_DECL_FM10KVF(vend, dev) { RTE_PCI_DEVICE(vend, dev) },
#include "rte_pci_dev_ids.h"
{ .vendor_id = 0, /* sentinel */ },
};

As you can see that fm10k driver will manage 2 different types of devices, PF 
and VF. 
We can say that there are 2 drivers under fm10k directory. The aspects that not 
applicable
to PF/VF will use condition check to control execution path. This makes driver 
can work with
PF and VF devices and reduce redundant code. 

[dpdk-dev] [PATCH v2] doc: update nic overview

[Thomas Monjalon]

2016-04-01 16:55, Chen Jing D:
> Add feature support list for fm10k, fm10k-vec, fm10kvf and
> fm10kvf-vec.

Please help me to understand what is fm10kvf.
I see only one fm10k driver:
% git grep 'struct eth_driver' drivers/net/fm10k/
drivers/net/fm10k/fm10k_ethdev.c:static struct eth_driver rte_pmd_fm10k = {

[dpdk-dev] [PATCH v2] doc: update nic overview

[Chen Jing D(Mark)]

From: "Chen Jing D(Mark)" 

Add feature support list for fm10k, fm10k-vec, fm10kvf and
fm10kvf-vec.

Signed-off-by: Chen Jing D(Mark) 
---
v2:
 - fix a typo

 doc/guides/nics/overview.rst |   86 +-
 1 files changed, 43 insertions(+), 43 deletions(-)

diff --git a/doc/guides/nics/overview.rst b/doc/guides/nics/overview.rst
index 542479a..b5d1c2c 100644
--- a/doc/guides/nics/overview.rst
+++ b/doc/guides/nics/overview.rst
@@ -74,39 +74,39 @@ Most of these differences are summarized below.

 .. table:: Features availability in networking drivers

-    = = = = = = = = = = = = = = = = = = = = = = = = = = = 
= = = = = =
-   Feature  a b b b c e e e i i i i i i i i i i f f m m m n n p r 
s v v v v x
-f n n o x 1 n n 4 4 4 4 g g x x x x m m l l p f u c i 
z h i i m e
-p x x n g 0 a i 0 0 0 0 b b g g g g 1 1 x x i p l a n 
e o r r x n
-a 2 2 d b 0   c e e e e   v b b b b 0 0 4 5 p   l p g 
d s t t n v
-c x x i e 0   . v v   f e e e e k k e 
a t i i e i
-k   v n   . f f   . v v   .   
t   o o t r
-e   f g   .   .   . f f   .   
a . 3 t
-t v   v   v   v   v   
2 v
-  e   e   e   e   e
 e
-  c   c   c   c   c
 c
-    = = = = = = = = = = = = = = = = = = = = = = = = = = = 
= = = = = =
-   link status  X   X X   
X X
-   link status eventX X
 X
-   queue status event  
 X
-   Rx interrupt X X X X
-   queue start/stop X   X   X X X X   X
+    = = = = = = = = = = = = = = = = = = = = = = = = = = = 
= = = = = = = =
+   Feature  a b b b c e e e i i i i i i i i i i f f f f m m m n n 
p r s v v v v x
+f n n o x 1 n n 4 4 4 4 g g x x x x m m m m l l p f u 
c i z h i i m e
+p x x n g 0 a i 0 0 0 0 b b g g g g 1 1 1 1 x x i p l 
a n e o r r x n
+a 2 2 d b 0   c e e e e   v b b b b 0 0 0 0 4 5 p   l 
p g d s t t n v
+c x x i e 0   . v v   f e e e e k k k k e  
   a t i i e i
+k   v n   . f f   . v v   . v v
   t   o o t r
+e   f g   .   .   . f f   . f f
   a . 3 t
+t v   v   v   v   v   v
   2 v
+  e   e   e   e   e   e
 e
+  c   c   c   c   c   c
 c
+    = = = = = = = = = = = = = = = = = = = = = = = = = = = 
= = = = = = = =
+   link status  X   X X
   X X
+   link status eventX X
 X
+   queue status event  
 X
+   Rx interrupt X X X X X X X X
+   queue start/stop X   X   X X X X X X X X
   X
MTU update   X   X
-   jumbo frame  X   X   X X X X
-   scattered Rx X   X   X X X X   X
+   jumbo frame  X   X   X X X X X X X X
+   scattered Rx X   X   X X X X X X X X
   X
LRO
-   TSO  X   X   X X X X
-   promiscuous mode X   X X X X   X
-   allmulticast modeX   X X X X   X
-   unicast MAC filter   X X X X
-   multicast MAC filter X X X X
-   RSS hash X   X   X X X X
-   RSS key update   X   X X X X
-   RSS reta update  X   X X X X
-   VMDq X X
+   TSO  X   X   X X X X X X X X
+   promiscuous mode X   X X X X X X
   X
+   allmulticast modeX   X X X X X X
   X
+   unicast MAC filter   X X X X X X
+   multicast MAC filter X X X X X X
+   RSS hash X   X   X X X X X X X X
+   RSS key update   X   X X X X X X X X
+   RSS