[dpdk-dev] [PATCH v2] net/virtio-user: fix build error in SUSE 11

2016-07-01 Thread Yuanhan Liu
On Wed, Jun 29, 2016 at 03:23:03AM +, Jianfeng Tan wrote:
> On some older systems, such as SUSE 11, the compiling error shows
> as:
>.../dpdk/drivers/net/virtio/virtio_user/virtio_user_dev.c:67:22:
>  error: ?O_CLOEXEC? undeclared (first use in this function)
> 
> The fix is to use EFD_CLOEXEC, which is defined in sys/eventfd.h,
> instead of O_CLOEXEC which needs _GNU_SOURCE defined on some old
> systems.
> 
> Fixes: 37a7eb2ae816 ("net/virtio-user: add device emulation layer")
> 
> Signed-off-by: Jianfeng Tan 

Applied to dpdk-next-virtio.

Thanks.

--yliu


[dpdk-dev] [PATCH v2] net/virtio-user: fix build error in SUSE 11

2016-06-29 Thread Jianfeng Tan
On some older systems, such as SUSE 11, the compiling error shows
as:
   .../dpdk/drivers/net/virtio/virtio_user/virtio_user_dev.c:67:22:
 error: ?O_CLOEXEC? undeclared (first use in this function)

The fix is to use EFD_CLOEXEC, which is defined in sys/eventfd.h,
instead of O_CLOEXEC which needs _GNU_SOURCE defined on some old
systems.

Fixes: 37a7eb2ae816 ("net/virtio-user: add device emulation layer")

Signed-off-by: Jianfeng Tan 
---
v2:
 - Change the way to fix this issue.
 drivers/net/virtio/virtio_user/virtio_user_dev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c 
b/drivers/net/virtio/virtio_user/virtio_user_dev.c
index 3d12a32..1b1e5bf 100644
--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c
+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c
@@ -63,12 +63,12 @@ virtio_user_kick_queue(struct virtio_user_dev *dev, 
uint32_t queue_sel)
/* May use invalid flag, but some backend leverages kickfd and callfd as
 * criteria to judge if dev is alive. so finally we use real event_fd.
 */
-   callfd = eventfd(0, O_CLOEXEC | O_NONBLOCK);
+   callfd = eventfd(0, EFD_CLOEXEC | EFD_NONBLOCK);
if (callfd < 0) {
PMD_DRV_LOG(ERR, "callfd error, %s\n", strerror(errno));
return -1;
}
-   kickfd = eventfd(0, O_CLOEXEC | O_NONBLOCK);
+   kickfd = eventfd(0, EFD_CLOEXEC | EFD_NONBLOCK);
if (kickfd < 0) {
close(callfd);
PMD_DRV_LOG(ERR, "kickfd error, %s\n", strerror(errno));
-- 
2.1.4