[dpdk-dev] [PATCH v3 0/4] remove hard-coding of crypto num qps and cleanup
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Thursday, October 06, 2016 5:30 PM > To: Trahe, Fiona; dev at dpdk.org > Cc: Trahe, Fiona; akhil.goyal at nxp.com > Subject: Re: [dpdk-dev] [PATCH v3 0/4] remove hard-coding of crypto num > qps and cleanup > > > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Fiona Trahe > > Sent: Thursday, October 06, 2016 10:34 AM > > To: dev at dpdk.org > > Cc: De Lara Guarch, Pablo; Trahe, Fiona; akhil.goyal at nxp.com > > Subject: [dpdk-dev] [PATCH v3 0/4] remove hard-coding of crypto num qps > > and cleanup > > > > > > ts_params->conf.nb_queue_pairs should not be hard coded with device > > specific number. It should be retrieved from the device info. > > Any test which changes it should restore it to orig value. > > > > Also related cleanup of test code setting number and size of > > queue-pairs on a device, e.g. > > * Removed irrelevant ?for? loop ? was hardcoded to only loop once. > > * Removed obsolete comment re inability to free and re-allocate queu > > memory > > and obsolete workaround for it which used to create maximum size > queues. > > > > And added freeing of ring memory on queue-pair release in aesni_mb PMD, > > else releasing and setting up queue-pair of a different size fails. > > > > v3: > > separate out into 4 patches > > > > v2: > > Fix for broken QAT PMD unit tests exposed by v1 > > i.e. In test_device_configure_invalid_queue_pair_ids() after running tests > > for invalid values restore original nb_queue_pairs. > > Also cleanup of test code setting number and size of queue-pairs on a > device > > Also fix for aesni_mb PMD not freeing ring memory on qp release > > > > > > Fiona Trahe (4): > > crypto/aesni_mb: free ring memory on qp release in PMD > > app/test: remove pointless for loop > > app/test: cleanup unnecessary ring size setup > > app/test: remove hard-coding of crypto num qps > > Akhil Goyal (1): > > app/test: remove hard-coding of crypto num qps > > > > app/test/test_cryptodev.c | 53 > > ++ > > app/test/test_cryptodev_perf.c | 19 + > > drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 10 - > > 3 files changed, 31 insertions(+), 51 deletions(-) > > > > -- > > 2.5.0 > > Series-acked-by: Pablo de Lara Applied to dpdk-next-crypto. Thanks, Pablo
[dpdk-dev] [PATCH v3 0/4] remove hard-coding of crypto num qps and cleanup
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Fiona Trahe > Sent: Thursday, October 06, 2016 10:34 AM > To: dev at dpdk.org > Cc: De Lara Guarch, Pablo; Trahe, Fiona; akhil.goyal at nxp.com > Subject: [dpdk-dev] [PATCH v3 0/4] remove hard-coding of crypto num qps > and cleanup > > > ts_params->conf.nb_queue_pairs should not be hard coded with device > specific number. It should be retrieved from the device info. > Any test which changes it should restore it to orig value. > > Also related cleanup of test code setting number and size of > queue-pairs on a device, e.g. > * Removed irrelevant ?for? loop ? was hardcoded to only loop once. > * Removed obsolete comment re inability to free and re-allocate queu > memory > and obsolete workaround for it which used to create maximum size queues. > > And added freeing of ring memory on queue-pair release in aesni_mb PMD, > else releasing and setting up queue-pair of a different size fails. > > v3: > separate out into 4 patches > > v2: > Fix for broken QAT PMD unit tests exposed by v1 > i.e. In test_device_configure_invalid_queue_pair_ids() after running tests > for invalid values restore original nb_queue_pairs. > Also cleanup of test code setting number and size of queue-pairs on a device > Also fix for aesni_mb PMD not freeing ring memory on qp release > > > Fiona Trahe (4): > crypto/aesni_mb: free ring memory on qp release in PMD > app/test: remove pointless for loop > app/test: cleanup unnecessary ring size setup > app/test: remove hard-coding of crypto num qps > Akhil Goyal (1): > app/test: remove hard-coding of crypto num qps > > app/test/test_cryptodev.c | 53 > ++ > app/test/test_cryptodev_perf.c | 19 + > drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 10 - > 3 files changed, 31 insertions(+), 51 deletions(-) > > -- > 2.5.0 Series-acked-by: Pablo de Lara
[dpdk-dev] [PATCH v3 0/4] remove hard-coding of crypto num qps and cleanup
ts_params->conf.nb_queue_pairs should not be hard coded with device specific number. It should be retrieved from the device info. Any test which changes it should restore it to orig value. Also related cleanup of test code setting number and size of queue-pairs on a device, e.g. * Removed irrelevant ???for??? loop ??? was hardcoded to only loop once. * Removed obsolete comment re inability to free and re-allocate queu memory and obsolete workaround for it which used to create maximum size queues. And added freeing of ring memory on queue-pair release in aesni_mb PMD, else releasing and setting up queue-pair of a different size fails. v3: separate out into 4 patches v2: Fix for broken QAT PMD unit tests exposed by v1 i.e. In test_device_configure_invalid_queue_pair_ids() after running tests for invalid values restore original nb_queue_pairs. Also cleanup of test code setting number and size of queue-pairs on a device Also fix for aesni_mb PMD not freeing ring memory on qp release Fiona Trahe (4): crypto/aesni_mb: free ring memory on qp release in PMD app/test: remove pointless for loop app/test: cleanup unnecessary ring size setup app/test: remove hard-coding of crypto num qps Akhil Goyal (1): app/test: remove hard-coding of crypto num qps app/test/test_cryptodev.c | 53 ++ app/test/test_cryptodev_perf.c | 19 + drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 10 - 3 files changed, 31 insertions(+), 51 deletions(-) -- 2.5.0
