[dpdk-dev] [PATCH v3 0/6] Move EAL common functions

2014-12-30 Thread Neil Horman
On Tue, Dec 30, 2014 at 11:36:24AM -0500, Ravi Kerur wrote:
> Changes in v3
> Make subject line explicit on file names.
> Commit log includes function names moved to common directory.
> 
> Changes in v2
> Fix patch review comments from Neil.
> 
> Changes in v1
> Common functions in linuxapp and bsdapp are moved into
> librte_eal/common directory.
> New files added follow _common_ naming conventions.
> 
> Following checkpatch warnings are treated as false-positive.
> WARNING: quoted string split across lines
> 
> Tested against ubuntu and FreeBSD.
> 
> Ravi Kerur (6):
>   Move common functions in eal_debug.c
>   Move common functions in eal_thread.c
>   Move common functions in eal.c
>   Move common functions in eal_lcore.c
>   Move common functions in eal_timer.c
>   Move common functions in eal_memory.c
> 
>  app/test/test_debug.c |   1 -
>  lib/librte_eal/bsdapp/eal/Makefile|  11 +-
>  lib/librte_eal/bsdapp/eal/eal.c   | 233 +
>  lib/librte_eal/bsdapp/eal/eal_debug.c | 113 ---
>  lib/librte_eal/bsdapp/eal/eal_lcore.c |  62 ++
>  lib/librte_eal/bsdapp/eal/eal_memory.c|  40 +---
>  lib/librte_eal/bsdapp/eal/eal_thread.c| 233 -
>  lib/librte_eal/bsdapp/eal/eal_timer.c |  50 +
>  lib/librte_eal/common/eal_common.c| 326 
> ++
>  lib/librte_eal/common/eal_common_debug.c  | 106 ++
>  lib/librte_eal/common/eal_common_lcore.c  | 106 ++
>  lib/librte_eal/common/eal_common_memory.c |  38 +++-
>  lib/librte_eal/common/eal_common_thread.c | 248 +++
>  lib/librte_eal/common/eal_common_timer.c  |  95 +
>  lib/librte_eal/common/eal_externs.h   |  45 +
>  lib/librte_eal/common/eal_hugepages.h |   1 +
>  lib/librte_eal/common/eal_private.h   | 112 ++
>  lib/librte_eal/common/include/rte_debug.h |   7 -
>  lib/librte_eal/linuxapp/eal/Makefile  |  11 +-
>  lib/librte_eal/linuxapp/eal/eal.c | 246 +-
>  lib/librte_eal/linuxapp/eal/eal_debug.c   | 113 ---
>  lib/librte_eal/linuxapp/eal/eal_lcore.c   |  55 +
>  lib/librte_eal/linuxapp/eal/eal_memory.c  |  36 +---
>  lib/librte_eal/linuxapp/eal/eal_thread.c  | 233 -
>  lib/librte_eal/linuxapp/eal/eal_timer.c   |  54 +
>  25 files changed, 1134 insertions(+), 1441 deletions(-)
>  delete mode 100644 lib/librte_eal/bsdapp/eal/eal_debug.c
>  delete mode 100644 lib/librte_eal/bsdapp/eal/eal_thread.c
>  create mode 100644 lib/librte_eal/common/eal_common.c
>  create mode 100644 lib/librte_eal/common/eal_common_debug.c
>  create mode 100644 lib/librte_eal/common/eal_common_lcore.c
>  create mode 100644 lib/librte_eal/common/eal_common_thread.c
>  create mode 100644 lib/librte_eal/common/eal_common_timer.c
>  create mode 100644 lib/librte_eal/common/eal_externs.h
>  delete mode 100644 lib/librte_eal/linuxapp/eal/eal_debug.c
>  delete mode 100644 lib/librte_eal/linuxapp/eal/eal_thread.c
> 
> -- 
> 1.9.1
> 
> 
Thanks
For the series
Acked-by: Neil Horman 



[dpdk-dev] [PATCH v3 0/6] Move EAL common functions

2014-12-30 Thread Ravi Kerur
Changes in v3
Make subject line explicit on file names.
Commit log includes function names moved to common directory.

Changes in v2
Fix patch review comments from Neil.

Changes in v1
Common functions in linuxapp and bsdapp are moved into
librte_eal/common directory.
New files added follow _common_ naming conventions.

Following checkpatch warnings are treated as false-positive.
WARNING: quoted string split across lines

Tested against ubuntu and FreeBSD.

Ravi Kerur (6):
  Move common functions in eal_debug.c
  Move common functions in eal_thread.c
  Move common functions in eal.c
  Move common functions in eal_lcore.c
  Move common functions in eal_timer.c
  Move common functions in eal_memory.c

 app/test/test_debug.c |   1 -
 lib/librte_eal/bsdapp/eal/Makefile|  11 +-
 lib/librte_eal/bsdapp/eal/eal.c   | 233 +
 lib/librte_eal/bsdapp/eal/eal_debug.c | 113 ---
 lib/librte_eal/bsdapp/eal/eal_lcore.c |  62 ++
 lib/librte_eal/bsdapp/eal/eal_memory.c|  40 +---
 lib/librte_eal/bsdapp/eal/eal_thread.c| 233 -
 lib/librte_eal/bsdapp/eal/eal_timer.c |  50 +
 lib/librte_eal/common/eal_common.c| 326 ++
 lib/librte_eal/common/eal_common_debug.c  | 106 ++
 lib/librte_eal/common/eal_common_lcore.c  | 106 ++
 lib/librte_eal/common/eal_common_memory.c |  38 +++-
 lib/librte_eal/common/eal_common_thread.c | 248 +++
 lib/librte_eal/common/eal_common_timer.c  |  95 +
 lib/librte_eal/common/eal_externs.h   |  45 +
 lib/librte_eal/common/eal_hugepages.h |   1 +
 lib/librte_eal/common/eal_private.h   | 112 ++
 lib/librte_eal/common/include/rte_debug.h |   7 -
 lib/librte_eal/linuxapp/eal/Makefile  |  11 +-
 lib/librte_eal/linuxapp/eal/eal.c | 246 +-
 lib/librte_eal/linuxapp/eal/eal_debug.c   | 113 ---
 lib/librte_eal/linuxapp/eal/eal_lcore.c   |  55 +
 lib/librte_eal/linuxapp/eal/eal_memory.c  |  36 +---
 lib/librte_eal/linuxapp/eal/eal_thread.c  | 233 -
 lib/librte_eal/linuxapp/eal/eal_timer.c   |  54 +
 25 files changed, 1134 insertions(+), 1441 deletions(-)
 delete mode 100644 lib/librte_eal/bsdapp/eal/eal_debug.c
 delete mode 100644 lib/librte_eal/bsdapp/eal/eal_thread.c
 create mode 100644 lib/librte_eal/common/eal_common.c
 create mode 100644 lib/librte_eal/common/eal_common_debug.c
 create mode 100644 lib/librte_eal/common/eal_common_lcore.c
 create mode 100644 lib/librte_eal/common/eal_common_thread.c
 create mode 100644 lib/librte_eal/common/eal_common_timer.c
 create mode 100644 lib/librte_eal/common/eal_externs.h
 delete mode 100644 lib/librte_eal/linuxapp/eal/eal_debug.c
 delete mode 100644 lib/librte_eal/linuxapp/eal/eal_thread.c

-- 
1.9.1