[dpdk-dev] [PATCH v3 06/11] bnx2x: FreeBSD enablement

2015-11-24 Thread Thomas Monjalon
2015-11-23 23:44, Rasesh Mody:
> --- a/drivers/net/bnx2x/bnx2x.h
> +++ b/drivers/net/bnx2x/bnx2x.h
> @@ -16,6 +16,12 @@
>  #ifndef __BNX2X_H__
>  #define __BNX2X_H__
>  
> +#ifdef __FreeBSD__
> +#define __LITTLE_ENDIAN _LITTLE_ENDIAN
> +#define __BIG_ENDIAN_BIG_ENDIAN
> +#define __BYTE_ORDER_BYTE_ORDER
> +#endif
> +
>  #include "bnx2x_ethdev.h"
>  
>  #if __BYTE_ORDER == __LITTLE_ENDIAN
[...]
> --- a/drivers/net/bnx2x/ecore_sp.h
> +++ b/drivers/net/bnx2x/ecore_sp.h
> @@ -16,6 +16,12 @@
>  #ifndef ECORE_SP_H
>  #define ECORE_SP_H
>  
> +#ifdef __FreeBSD__
> +#define __LITTLE_ENDIAN _LITTLE_ENDIAN
> +#define __BIG_ENDIAN_BIG_ENDIAN
> +#define __BYTE_ORDER_BYTE_ORDER
> +#endif
> +
>  #if __BYTE_ORDER == __LITTLE_ENDIAN
>  #ifndef LITTLE_ENDIAN
>  #define LITTLE_ENDIAN

Why not use RTE_BYTE_ORDER which manages already these tricks?
Maybe you have not noticed it:
lib/librte_eal/common/include/generic/rte_byteorder.h


[dpdk-dev] [PATCH v3 06/11] bnx2x: FreeBSD enablement

2015-11-23 Thread Rasesh Mody
Compile tested.

Signed-off-by: Rasesh Mody 
---
 doc/guides/nics/bnx2x.rst|8 
 drivers/net/bnx2x/bnx2x.c|9 +
 drivers/net/bnx2x/bnx2x.h|   23 +++
 drivers/net/bnx2x/ecore_sp.h |6 ++
 4 files changed, 46 insertions(+)

diff --git a/doc/guides/nics/bnx2x.rst b/doc/guides/nics/bnx2x.rst
index 7a94080..5647a90 100644
--- a/doc/guides/nics/bnx2x.rst
+++ b/doc/guides/nics/bnx2x.rst
@@ -155,6 +155,14 @@ command::
cd 
gmake config T=x86_64-native-bsdapp-gcc install 
-Wl,-rpath=/usr/local/lib/gcc48 CC=gcc48

+To compile BNX2X PMD for FreeBSD x86_64 gcc target, run the following "gmake"
+command:
+
+.. code-block:: console
+
+   cd 
+   gmake config T=x86_64-native-bsdapp-gcc install 
-Wl,-rpath=/usr/local/lib/gcc48 CC=gcc48
+
 Linux
 -

diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c
index c149ac5..f125c79 100644
--- a/drivers/net/bnx2x/bnx2x.c
+++ b/drivers/net/bnx2x/bnx2x.c
@@ -9505,13 +9505,22 @@ static int bnx2x_pci_get_caps(struct bnx2x_softc *sc)
return -ENOMEM;
}

+#ifndef __FreeBSD__
pci_read(sc, PCI_STATUS, , 2);
if (!(status & PCI_STATUS_CAP_LIST)) {
+#else
+   pci_read(sc, PCIR_STATUS, , 2);
+   if (!(status & PCIM_STATUS_CAPPRESENT)) {
+#endif
PMD_DRV_LOG(NOTICE, "PCIe capability reading failed");
return -1;
}

+#ifndef __FreeBSD__
pci_read(sc, PCI_CAPABILITY_LIST, _cap.next, 1);
+#else
+   pci_read(sc, PCIR_CAP_PTR, _cap.next, 1);
+#endif
while (pci_cap.next) {
cap->addr = pci_cap.next & ~3;
pci_read(sc, pci_cap.next & ~3, _cap, 2);
diff --git a/drivers/net/bnx2x/bnx2x.h b/drivers/net/bnx2x/bnx2x.h
index b049bd1..0362e4b 100644
--- a/drivers/net/bnx2x/bnx2x.h
+++ b/drivers/net/bnx2x/bnx2x.h
@@ -16,6 +16,12 @@
 #ifndef __BNX2X_H__
 #define __BNX2X_H__

+#ifdef __FreeBSD__
+#define __LITTLE_ENDIAN _LITTLE_ENDIAN
+#define __BIG_ENDIAN_BIG_ENDIAN
+#define __BYTE_ORDER_BYTE_ORDER
+#endif
+
 #include "bnx2x_ethdev.h"

 #if __BYTE_ORDER == __LITTLE_ENDIAN
@@ -47,6 +53,7 @@

 #include "elink.h"

+#ifndef __FreeBSD__
 #include 

 #define PCIY_PMG   PCI_CAP_ID_PM
@@ -68,11 +75,15 @@
 #define PCIM_PSTAT_PMEENABLE   PCI_PM_CTRL_PME_ENABLE
 #define PCIR_MSIX_CTRL PCI_MSIX_FLAGS
 #define PCIM_MSIXCTRL_TABLE_SIZE   PCI_MSIX_FLAGS_QSIZE
+#else
+#include 
+#endif

 #define IFM_10G_CX420 /* 10GBase CX4 copper */
 #define IFM_10G_TWINAX 22 /* 10GBase Twinax copper */
 #define IFM_10G_T  26 /* 10GBase-T - RJ45 */

+#ifndef __FreeBSD__
 #define PCIR_EXPRESS_DEVICE_STAPCI_EXP_TYPE_RC_EC
 #define PCIM_EXP_STA_TRANSACTION_PND   PCI_EXP_DEVSTA_TRPND
 #define PCIR_EXPRESS_LINK_STA  PCI_EXP_LNKSTA
@@ -81,6 +92,16 @@
 #define PCIR_EXPRESS_DEVICE_CTLPCI_EXP_DEVCTL
 #define PCIM_EXP_CTL_MAX_PAYLOAD   PCI_EXP_DEVCTL_PAYLOAD
 #define PCIM_EXP_CTL_MAX_READ_REQUEST  PCI_EXP_DEVCTL_READRQ
+#else
+#define PCIR_EXPRESS_DEVICE_STAPCIER_DEVICE_STA
+#define PCIM_EXP_STA_TRANSACTION_PND   PCIEM_STA_TRANSACTION_PND
+#define PCIR_EXPRESS_LINK_STA  PCIER_LINK_STA
+#define PCIM_LINK_STA_WIDTHPCIEM_LINK_STA_WIDTH
+#define PCIM_LINK_STA_SPEEDPCIEM_LINK_STA_SPEED
+#define PCIR_EXPRESS_DEVICE_CTLPCIER_DEVICE_CTL
+#define PCIM_EXP_CTL_MAX_PAYLOAD   PCIEM_CTL_MAX_PAYLOAD
+#define PCIM_EXP_CTL_MAX_READ_REQUEST  PCIEM_CTL_MAX_READ_REQUEST
+#endif

 #ifndef ARRAY_SIZE
 #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]))
@@ -148,6 +169,7 @@ struct bnx2x_device_type {
 #endif
 #define MCLBYTES  (1 << MCLSHIFT)

+#if !defined(MJUMPAGESIZE)
 #if BNX2X_PAGE_SIZE < 2048
 #define MJUMPAGESIZEMCLBYTES
 #elif BNX2X_PAGE_SIZE <= 8192
@@ -155,6 +177,7 @@ struct bnx2x_device_type {
 #else
 #define MJUMPAGESIZE(8 * 1024)
 #endif
+#endif
 #define MJUM9BYTES  (9 * 1024)
 #define MJUM16BYTES (16 * 1024)

diff --git a/drivers/net/bnx2x/ecore_sp.h b/drivers/net/bnx2x/ecore_sp.h
index 8e65584..a0b7b75 100644
--- a/drivers/net/bnx2x/ecore_sp.h
+++ b/drivers/net/bnx2x/ecore_sp.h
@@ -16,6 +16,12 @@
 #ifndef ECORE_SP_H
 #define ECORE_SP_H

+#ifdef __FreeBSD__
+#define __LITTLE_ENDIAN _LITTLE_ENDIAN
+#define __BIG_ENDIAN_BIG_ENDIAN
+#define __BYTE_ORDER_BYTE_ORDER
+#endif
+
 #if __BYTE_ORDER == __LITTLE_ENDIAN
 #ifndef LITTLE_ENDIAN
 #define LITTLE_ENDIAN
-- 
1.7.10.3