[dpdk-dev] [PATCH v3 1/4] bnx2x: Update documentation
Hi Bruce, > From: Bruce Richardson [mailto:bruce.richardson at intel.com] > Sent: Wednesday, April 06, 2016 7:33 AM > > On Tue, Apr 05, 2016 at 05:37:05PM -0700, Rasesh Mody wrote: > > Signed-off-by: Harish Patil > > Signed-off-by: Rasesh Mody > > --- > > doc/guides/nics/bnx2x.rst|1 + > > doc/guides/nics/overview.rst | 22 +++--- > > 2 files changed, 12 insertions(+), 11 deletions(-) > > > Thanks for the patchset. Looking at it though, some of the changes are bug or > documentation fixes which would be good to get into 16.04 e.g. patch 1, and > the fix for the regular stats in patch 2, while other parts of the set, e.g. > the TX > optimisations, or the new xstats functionality, are larger changes. Given we > are within days of a final release, the latter changes not really suitable for > merging at this point. > As per Thomas' guidance, the only code changes are meant to be bug fixes, > in case a change introduces a last minute issue. > > Any chance you could split this patchset in two, with the doc and bug fixes > alone in one set, and the feature changes in a separate set for 16.07? > > Thanks, > /Bruce Could you please apply only the patch 1 that takes care of the documentation for 16.04? Remaining patches we'll re-submit for 16.07. Thanks! Rasesh
[dpdk-dev] [PATCH v3 1/4] bnx2x: Update documentation
On Tue, Apr 05, 2016 at 05:37:05PM -0700, Rasesh Mody wrote: > Signed-off-by: Harish Patil > Signed-off-by: Rasesh Mody > --- > doc/guides/nics/bnx2x.rst|1 + > doc/guides/nics/overview.rst | 22 +++--- > 2 files changed, 12 insertions(+), 11 deletions(-) > Thanks for the patchset. Looking at it though, some of the changes are bug or documentation fixes which would be good to get into 16.04 e.g. patch 1, and the fix for the regular stats in patch 2, while other parts of the set, e.g. the TX optimisations, or the new xstats functionality, are larger changes. Given we are within days of a final release, the latter changes not really suitable for merging at this point. As per Thomas' guidance, the only code changes are meant to be bug fixes, in case a change introduces a last minute issue. Any chance you could split this patchset in two, with the doc and bug fixes alone in one set, and the feature changes in a separate set for 16.07? Thanks, /Bruce
[dpdk-dev] [PATCH v3 1/4] bnx2x: Update documentation
Signed-off-by: Harish Patil Signed-off-by: Rasesh Mody --- doc/guides/nics/bnx2x.rst|1 + doc/guides/nics/overview.rst | 22 +++--- 2 files changed, 12 insertions(+), 11 deletions(-) diff --git a/doc/guides/nics/bnx2x.rst b/doc/guides/nics/bnx2x.rst index ed0e5e5..df8fb47 100644 --- a/doc/guides/nics/bnx2x.rst +++ b/doc/guides/nics/bnx2x.rst @@ -60,6 +60,7 @@ The features not yet supported include: - LRO/TSO offload - Checksum offload - SR-IOV PF +- Rx TX scatter gather Co-existence considerations --- diff --git a/doc/guides/nics/overview.rst b/doc/guides/nics/overview.rst index ec1af46..482a59c 100644 --- a/doc/guides/nics/overview.rst +++ b/doc/guides/nics/overview.rst @@ -87,8 +87,8 @@ Most of these differences are summarized below. c c c c c c = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = speed capabilities - link status X X X X X X X - link status eventX X X X X + link statusX X X X X X X X X + link status event X X X X X X X queue status event X Rx interrupt X X X X queue start/stop X X X X X X X X X @@ -97,15 +97,15 @@ Most of these differences are summarized below. scattered Rx X X X X X X X X X LRO TSO X X X X X X - promiscuous mode X X X X X X X X + promiscuous mode X X X X X X X X X X allmulticast modeX X X X X X X X - unicast MAC filter X X X X - multicast MAC filter X X X X + unicast MAC filter X X X X X X + multicast MAC filter X X X X X X RSS hash X X X X X X X X RSS key update X X X X X X RSS reta update X X X X X X VMDq X X - SR-IOV X X X X X + SR-IOV X X X X X X DCB X X VLAN filter X X X X X X ethertype filter X X @@ -127,14 +127,14 @@ Most of these differences are summarized below. inner L4 checksumX X X X packet type parsing X X X X X timesync X X - basic stats X X X X X X X X X X - extended stats X X X X X + basic statsX X X X X X X X X X X X + extended stats X X X X X X X stats per queue X X X X EEPROM dump registers dump multiprocess aware X X X X X X BSD nic_uio X X X X X - Linux UIOX X X X X X + Linux UIO X X X X X X X X Linux VFIO X X X X X other kdrv X ARMv7 @@ -142,8 +142,8 @@ Most of these differences are summarized below. Power8 X X TILE-Gx x86-32 X X X X X X X X X - x86-64 X X X X X X X X X X - usage docX X X X + x86-64 X X X X X X X X X X X X + usage doc X X X X X X design doc perf doc = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = -- 1.7.10.3
