[dpdk-dev] [PATCH v4 07/13] eal: add intr api to report multi-vector capability

2015-11-04 Thread Cunming Liang
VFIO allows multiple MSI-X vector, others doesn't, but maybe will allow it in 
the future.
Device drivers need to be aware of the capability.
It's better to avoid condition check on interrupt type(VFIO) everywhere, instead
a capability api is more flexible for the condition change.

v3 change:
  - add new api dummy in bsdapp

Signed-off-by: Cunming Liang 
---
 lib/librte_eal/bsdapp/eal/eal_interrupts.c|  7 +++
 lib/librte_eal/bsdapp/eal/include/exec-env/rte_interrupts.h   | 10 ++
 lib/librte_eal/bsdapp/eal/rte_eal_version.map |  7 +++
 lib/librte_eal/linuxapp/eal/eal_interrupts.c  |  9 +
 lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts.h | 10 ++
 lib/librte_eal/linuxapp/eal/rte_eal_version.map   |  7 +++
 6 files changed, 50 insertions(+)

diff --git a/lib/librte_eal/bsdapp/eal/eal_interrupts.c 
b/lib/librte_eal/bsdapp/eal/eal_interrupts.c
index 51a13fa..836e483 100644
--- a/lib/librte_eal/bsdapp/eal/eal_interrupts.c
+++ b/lib/librte_eal/bsdapp/eal/eal_interrupts.c
@@ -110,3 +110,10 @@ rte_intr_allow_others(struct rte_intr_handle *intr_handle)
RTE_SET_USED(intr_handle);
return 1;
 }
+
+int
+rte_intr_cap_multiple(struct rte_intr_handle *intr_handle)
+{
+   RTE_SET_USED(intr_handle);
+   return 0;
+}
diff --git a/lib/librte_eal/bsdapp/eal/include/exec-env/rte_interrupts.h 
b/lib/librte_eal/bsdapp/eal/include/exec-env/rte_interrupts.h
index 3d138bf..70a7087 100644
--- a/lib/librte_eal/bsdapp/eal/include/exec-env/rte_interrupts.h
+++ b/lib/librte_eal/bsdapp/eal/include/exec-env/rte_interrupts.h
@@ -122,4 +122,14 @@ int rte_intr_dp_is_en(struct rte_intr_handle *intr_handle);
  */
 int rte_intr_allow_others(struct rte_intr_handle *intr_handle);

+/**
+ * The multiple interrupt vector capability of interrupt handle instance.
+ * It returns zero if no multiple interrupt vector support.
+ *
+ * @param intr_handle
+ *   Pointer to the interrupt handle.
+ */
+int
+rte_intr_cap_multiple(struct rte_intr_handle *intr_handle);
+
 #endif /* _RTE_BSDAPP_INTERRUPTS_H_ */
diff --git a/lib/librte_eal/bsdapp/eal/rte_eal_version.map 
b/lib/librte_eal/bsdapp/eal/rte_eal_version.map
index 64fdfb1..8b00761 100644
--- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map
+++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map
@@ -125,3 +125,10 @@ DPDK_2.1 {
rte_memzone_free;

 } DPDK_2.0;
+
+DPDK_2.2 {
+   global:
+
+   rte_intr_cap_multiple;
+
+} DPDK_2.1;
\ No newline at end of file
diff --git a/lib/librte_eal/linuxapp/eal/eal_interrupts.c 
b/lib/librte_eal/linuxapp/eal/eal_interrupts.c
index 8938067..95beb4c 100644
--- a/lib/librte_eal/linuxapp/eal/eal_interrupts.c
+++ b/lib/librte_eal/linuxapp/eal/eal_interrupts.c
@@ -1212,3 +1212,12 @@ rte_intr_allow_others(struct rte_intr_handle 
*intr_handle)
else
return !!(intr_handle->max_intr - intr_handle->nb_efd);
 }
+
+int
+rte_intr_cap_multiple(struct rte_intr_handle *intr_handle)
+{
+   if (intr_handle->type == RTE_INTR_HANDLE_VFIO_MSIX)
+   return 1;
+
+   return 0;
+}
diff --git a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts.h 
b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts.h
index b44e69c..3dacbff 100644
--- a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts.h
+++ b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts.h
@@ -215,4 +215,14 @@ rte_intr_dp_is_en(struct rte_intr_handle *intr_handle);
 int
 rte_intr_allow_others(struct rte_intr_handle *intr_handle);

+/**
+ * The multiple interrupt vector capability of interrupt handle instance.
+ * It returns zero if no multiple interrupt vector support.
+ *
+ * @param intr_handle
+ *   Pointer to the interrupt handle.
+ */
+int
+rte_intr_cap_multiple(struct rte_intr_handle *intr_handle);
+
 #endif /* _RTE_LINUXAPP_INTERRUPTS_H_ */
diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map 
b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
index dbb8fa1..cb9f4d6 100644
--- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map
+++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
@@ -128,3 +128,10 @@ DPDK_2.1 {
rte_memzone_free;

 } DPDK_2.0;
+
+DPDK_2.2 {
+   global:
+
+   rte_intr_cap_multiple;
+
+} DPDK_2.1;
\ No newline at end of file
-- 
2.4.3



[dpdk-dev] [PATCH v4 07/13] eal: add intr api to report multi-vector capability

2015-11-04 Thread David Marchand
On Wed, Nov 4, 2015 at 9:45 AM, Cunming Liang 
wrote:

> VFIO allows multiple MSI-X vector, others doesn't, but maybe will allow it
> in the future.
> Device drivers need to be aware of the capability.
> It's better to avoid condition check on interrupt type(VFIO) everywhere,
> instead
> a capability api is more flexible for the condition change.
>
> v3 change:
>   - add new api dummy in bsdapp
>
> Signed-off-by: Cunming Liang 
>

Acked-by: David Marchand 

-- 
David Marchand