[dpdk-dev] [PATCH v5 0/2] cryptodev API changes
Tested-by: Min Cao - Tested Commit: e45ef10c34540c3f543689d833db8bb7296d9e85 - OS: Fedora20 3.11.10-301.fc20.x86_64 - GCC: gcc (GCC) 4.8.3 - CPU: Intel(R) Xeon(R) CPU E5-2658 v3 @ 2.20GHz - NIC: Niantic - Default x86_64-native-linuxapp-gcc configuration - Prerequisites: - Total 23 cases, 23 passed, 0 failed - test case 1: QAT Unit test Total 13 cases, 13 passed, 0 failed - test case 2: AES_NI Unit test Total 10 cases, 10 passed, 0 failed -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Fiona Trahe Sent: Saturday, March 05, 2016 1:18 AM To: dev at dpdk.org Subject: [dpdk-dev] [PATCH v5 0/2] cryptodev API changes This patch set separates the symmetric crypto operations from generic operations and then modifies the cryptodev burst API to accept bursts of rte_crypto_op rather than rte_mbufs. V5: - updates .map file - removes EXPERIMENTAL label from rte_cryptodev.h V4: - Fixes for issues introduced in __rte_crypto_op_raw_bulk_alloc in V3 patcheset. - Typo fix in cached attribute on rte_crypto_op structure. V3: - Addresses V2 comments - Rebased for head Declan Doherty (1): cryptodev: change burst API to be crypto op oriented Fiona Trahe (1): cryptodev: API tidy and changes to support future extensions MAINTAINERS| 6 +- app/test/test_cryptodev.c | 894 +++-- app/test/test_cryptodev.h | 9 +- app/test/test_cryptodev_perf.c | 270 --- config/common_bsdapp | 8 - config/common_linuxapp | 8 - doc/api/doxy-api-index.md | 1 - drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 199 ++--- drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 18 +- drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h | 6 +- drivers/crypto/qat/qat_crypto.c| 150 ++-- drivers/crypto/qat/qat_crypto.h| 14 +- drivers/crypto/qat/rte_qat_cryptodev.c | 8 +- examples/l2fwd-crypto/main.c | 300 --- lib/Makefile | 1 - lib/librte_cryptodev/Makefile | 1 + lib/librte_cryptodev/rte_crypto.h | 819 +++ lib/librte_cryptodev/rte_crypto_sym.h | 642 +++ lib/librte_cryptodev/rte_cryptodev.c | 115 ++- lib/librte_cryptodev/rte_cryptodev.h | 189 ++--- lib/librte_cryptodev/rte_cryptodev_pmd.h | 32 +- lib/librte_cryptodev/rte_cryptodev_version.map | 7 +- lib/librte_mbuf/rte_mbuf.h | 6 - lib/librte_mbuf_offload/Makefile | 52 -- lib/librte_mbuf_offload/rte_mbuf_offload.c | 100 --- lib/librte_mbuf_offload/rte_mbuf_offload.h | 310 --- .../rte_mbuf_offload_version.map | 7 - 27 files changed, 2145 insertions(+), 2027 deletions(-) create mode 100644 lib/librte_cryptodev/rte_crypto_sym.h delete mode 100644 lib/librte_mbuf_offload/Makefile delete mode 100644 lib/librte_mbuf_offload/rte_mbuf_offload.c delete mode 100644 lib/librte_mbuf_offload/rte_mbuf_offload.h delete mode 100644 lib/librte_mbuf_offload/rte_mbuf_offload_version.map -- 2.1.0
[dpdk-dev] [PATCH v5 0/2] cryptodev API changes
2016-03-04 17:43, Trahe, Fiona: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > 2016-03-04 17:17, Fiona Trahe: > > > This patch set separates the symmetric crypto operations from generic > > operations and then modifies the cryptodev burst API to accept bursts of > > rte_crypto_op rather than rte_mbufs. > > > > > > V5: > > > - updates .map file > > > - removes EXPERIMENTAL label from rte_cryptodev.h > > > > Why do you want to remove the experimental label? > > Declan had already removed from the MAINTAINERS file and other places in > previous patches. > This one was just forgotten as far as we know, though as Declan is out we > can't confirm with him. > Do you think we should keep the label ? I cannot really decide because it's hard to understand the improvements in a such big patch. It would be easier if the changes were split in several steps. Maybe the last step (last patch) would be to remove the flag. Having it in a separate patch would give the opportunity to detail the reason of the removal in the commit message.
[dpdk-dev] [PATCH v5 0/2] cryptodev API changes
2016-03-04 17:17, Fiona Trahe: > This patch set separates the symmetric crypto operations from generic > operations and then modifies the cryptodev burst API to accept bursts of > rte_crypto_op rather than rte_mbufs. > > V5: > - updates .map file > - removes EXPERIMENTAL label from rte_cryptodev.h Why do you want to remove the experimental label?
[dpdk-dev] [PATCH v5 0/2] cryptodev API changes
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, March 04, 2016 5:46 PM > To: Trahe, Fiona > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 0/2] cryptodev API changes > > 2016-03-04 17:43, Trahe, Fiona: > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > > 2016-03-04 17:17, Fiona Trahe: > > > > This patch set separates the symmetric crypto operations from > > > > generic > > > operations and then modifies the cryptodev burst API to accept > > > bursts of rte_crypto_op rather than rte_mbufs. > > > > > > > > V5: > > > > - updates .map file > > > > - removes EXPERIMENTAL label from rte_cryptodev.h > > > > > > Why do you want to remove the experimental label? > > > > Declan had already removed from the MAINTAINERS file and other places in > previous patches. > > This one was just forgotten as far as we know, though as Declan is out we > can't confirm with him. > > Do you think we should keep the label ? > > I cannot really decide because it's hard to understand the improvements in a > such big patch. It would be easier if the changes were split in several steps. > Maybe the last step (last patch) would be to remove the flag. Having it in a > separate patch would give the opportunity to detail the reason of the removal > in > the commit message. Fair enough. I'll put the label back in. And we'll handle later with a separate explicit commit to give people a chance to comment.
[dpdk-dev] [PATCH v5 0/2] cryptodev API changes
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, March 04, 2016 5:39 PM > To: Trahe, Fiona > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 0/2] cryptodev API changes > > 2016-03-04 17:17, Fiona Trahe: > > This patch set separates the symmetric crypto operations from generic > operations and then modifies the cryptodev burst API to accept bursts of > rte_crypto_op rather than rte_mbufs. > > > > V5: > > - updates .map file > > - removes EXPERIMENTAL label from rte_cryptodev.h > > Why do you want to remove the experimental label? Declan had already removed from the MAINTAINERS file and other places in previous patches. This one was just forgotten as far as we know, though as Declan is out we can't confirm with him. Do you think we should keep the label ?
[dpdk-dev] [PATCH v5 0/2] cryptodev API changes
> -Original Message- > From: Trahe, Fiona > Sent: Friday, March 04, 2016 5:18 PM > To: dev at dpdk.org > Cc: Doherty, Declan; Trahe, Fiona > Subject: [PATCH v5 0/2] cryptodev API changes > > This patch set separates the symmetric crypto operations from generic > operations and then modifies the cryptodev burst API to accept bursts of > rte_crypto_op rather than rte_mbufs. > > V5: > - updates .map file > - removes EXPERIMENTAL label from rte_cryptodev.h > > V4: > - Fixes for issues introduced in __rte_crypto_op_raw_bulk_alloc in V3 > patcheset. > - Typo fix in cached attribute on rte_crypto_op structure. > > V3: > - Addresses V2 comments > - Rebased for head > > > Declan Doherty (1): > cryptodev: change burst API to be crypto op oriented > > Fiona Trahe (1): > cryptodev: API tidy and changes to support future extensions > > > MAINTAINERS| 6 +- > app/test/test_cryptodev.c | 894 > +++-- > app/test/test_cryptodev.h | 9 +- > app/test/test_cryptodev_perf.c | 270 --- > config/common_bsdapp | 8 - > config/common_linuxapp | 8 - > doc/api/doxy-api-index.md | 1 - > drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 199 ++--- > drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 18 +- > drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h | 6 +- > drivers/crypto/qat/qat_crypto.c| 150 ++-- > drivers/crypto/qat/qat_crypto.h| 14 +- > drivers/crypto/qat/rte_qat_cryptodev.c | 8 +- > examples/l2fwd-crypto/main.c | 300 --- > lib/Makefile | 1 - > lib/librte_cryptodev/Makefile | 1 + > lib/librte_cryptodev/rte_crypto.h | 819 +++ > lib/librte_cryptodev/rte_crypto_sym.h | 642 +++ > lib/librte_cryptodev/rte_cryptodev.c | 115 ++- > lib/librte_cryptodev/rte_cryptodev.h | 189 ++--- > lib/librte_cryptodev/rte_cryptodev_pmd.h | 32 +- > lib/librte_cryptodev/rte_cryptodev_version.map | 7 +- > lib/librte_mbuf/rte_mbuf.h | 6 - > lib/librte_mbuf_offload/Makefile | 52 -- > lib/librte_mbuf_offload/rte_mbuf_offload.c | 100 --- > lib/librte_mbuf_offload/rte_mbuf_offload.h | 310 --- > .../rte_mbuf_offload_version.map | 7 - > 27 files changed, 2145 insertions(+), 2027 deletions(-) create mode 100644 > lib/librte_cryptodev/rte_crypto_sym.h > delete mode 100644 lib/librte_mbuf_offload/Makefile delete mode 100644 > lib/librte_mbuf_offload/rte_mbuf_offload.c > delete mode 100644 lib/librte_mbuf_offload/rte_mbuf_offload.h > delete mode 100644 lib/librte_mbuf_offload/rte_mbuf_offload_version.map > > -- > 2.1.0 NACK - email subject of patches got screwed up. I'll resend.
[dpdk-dev] [PATCH v5 0/2] cryptodev API changes
This patch set separates the symmetric crypto operations from generic operations and then modifies the cryptodev burst API to accept bursts of rte_crypto_op rather than rte_mbufs. V5: - updates .map file - removes EXPERIMENTAL label from rte_cryptodev.h V4: - Fixes for issues introduced in __rte_crypto_op_raw_bulk_alloc in V3 patcheset. - Typo fix in cached attribute on rte_crypto_op structure. V3: - Addresses V2 comments - Rebased for head Declan Doherty (1): cryptodev: change burst API to be crypto op oriented Fiona Trahe (1): cryptodev: API tidy and changes to support future extensions MAINTAINERS| 6 +- app/test/test_cryptodev.c | 894 +++-- app/test/test_cryptodev.h | 9 +- app/test/test_cryptodev_perf.c | 270 --- config/common_bsdapp | 8 - config/common_linuxapp | 8 - doc/api/doxy-api-index.md | 1 - drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 199 ++--- drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 18 +- drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h | 6 +- drivers/crypto/qat/qat_crypto.c| 150 ++-- drivers/crypto/qat/qat_crypto.h| 14 +- drivers/crypto/qat/rte_qat_cryptodev.c | 8 +- examples/l2fwd-crypto/main.c | 300 --- lib/Makefile | 1 - lib/librte_cryptodev/Makefile | 1 + lib/librte_cryptodev/rte_crypto.h | 819 +++ lib/librte_cryptodev/rte_crypto_sym.h | 642 +++ lib/librte_cryptodev/rte_cryptodev.c | 115 ++- lib/librte_cryptodev/rte_cryptodev.h | 189 ++--- lib/librte_cryptodev/rte_cryptodev_pmd.h | 32 +- lib/librte_cryptodev/rte_cryptodev_version.map | 7 +- lib/librte_mbuf/rte_mbuf.h | 6 - lib/librte_mbuf_offload/Makefile | 52 -- lib/librte_mbuf_offload/rte_mbuf_offload.c | 100 --- lib/librte_mbuf_offload/rte_mbuf_offload.h | 310 --- .../rte_mbuf_offload_version.map | 7 - 27 files changed, 2145 insertions(+), 2027 deletions(-) create mode 100644 lib/librte_cryptodev/rte_crypto_sym.h delete mode 100644 lib/librte_mbuf_offload/Makefile delete mode 100644 lib/librte_mbuf_offload/rte_mbuf_offload.c delete mode 100644 lib/librte_mbuf_offload/rte_mbuf_offload.h delete mode 100644 lib/librte_mbuf_offload/rte_mbuf_offload_version.map -- 2.1.0
