[dpdk-dev] [PATCH v7 02/10] eal/linux: add rte_epoll_wait/ctl support

2015-05-11 Thread Liang, Cunming


On 5/8/2015 10:57 AM, Stephen Hemminger wrote:
> On Tue,  5 May 2015 13:39:38 +0800
> Cunming Liang  wrote:
>
>> +else if (rc < 0) {
>> +/* epoll_wait fail */
>> +RTE_LOG(ERR, EAL, "epoll_wait returns with fail %s\n",
>> +strerror(errno));
> In real application there maybe other random signals.
> Therefore the code should ignore and return for case of EWOULDBLOCK and EINTR
[LCM] Thanks, you're right, when EINTR happens, shall continue 
epoll_wait instead of return.
Per EWOULDBLOCK, seems epoll_wait won't return it, so I assume your 
mention is about epoll event read.


[dpdk-dev] [PATCH v7 02/10] eal/linux: add rte_epoll_wait/ctl support

2015-05-07 Thread Stephen Hemminger
On Tue,  5 May 2015 13:39:38 +0800
Cunming Liang  wrote:

> + else if (rc < 0) {
> + /* epoll_wait fail */
> + RTE_LOG(ERR, EAL, "epoll_wait returns with fail %s\n",
> + strerror(errno));

In real application there maybe other random signals.
Therefore the code should ignore and return for case of EWOULDBLOCK and EINTR


[dpdk-dev] [PATCH v7 02/10] eal/linux: add rte_epoll_wait/ctl support

2015-05-05 Thread Cunming Liang
The patch adds 'rte_epoll_wait' and 'rte_epoll_ctl' for async event wakeup.
It defines 'struct rte_epoll_event' as the event param.
The 'op' uses the same enum as epoll_wait/ctl does.
The epoll event support to carry a raw user data and to register a callback 
which is exectuted during wakeup.

Signed-off-by: Cunming Liang 
---
v7 changes
 - split v6[4/8] into two patches, one for epoll event(this one)
   another for rx intr(next patch)
 - introduce rte_epoll_event definition
 - rte_epoll_wait/ctl for more generic RTE epoll API

v6 changes
 - split rte_intr_wait_rx_pkt into two function, wait and set.
 - rewrite rte_intr_rx_wait/rte_intr_rx_set to remove queue visibility on eal.
 - rte_intr_rx_wait to support multiplexing.
 - allow epfd as input to support flexible event fd combination.

 lib/librte_eal/linuxapp/eal/eal_interrupts.c   | 97 ++
 .../linuxapp/eal/include/exec-env/rte_interrupts.h | 66 ++-
 lib/librte_eal/linuxapp/eal/rte_eal_version.map|  3 +
 3 files changed, 165 insertions(+), 1 deletion(-)

diff --git a/lib/librte_eal/linuxapp/eal/eal_interrupts.c 
b/lib/librte_eal/linuxapp/eal/eal_interrupts.c
index 66deda2..b641745 100644
--- a/lib/librte_eal/linuxapp/eal/eal_interrupts.c
+++ b/lib/librte_eal/linuxapp/eal/eal_interrupts.c
@@ -69,6 +69,8 @@

 #define EAL_INTR_EPOLL_WAIT_FOREVER (-1)

+static RTE_DEFINE_PER_LCORE(int, _epfd) = -1; /**< epoll fd per thread */
+
 /**
  * union for pipe fds.
  */
@@ -859,3 +861,98 @@ rte_eal_intr_init(void)
return -ret;
 }

+static void
+eal_epoll_process_event(struct epoll_event *evs, int n,
+   struct rte_epoll_event *events)
+{
+   int i;
+   struct rte_epoll_event *rev;
+   for (i = 0; i < n; i++) {
+   rev = (struct rte_epoll_event *)evs[i].data.ptr;
+   if (rev) {
+   events[i].fd= rev->fd;
+   events[i].event = rev->event;
+   events[i].data  = rev->data;
+   if (rev->cb_fun)
+   rev->cb_fun(rev->fd, rev->cb_arg);
+   }
+   }
+}
+
+static inline int
+eal_init_tls_epfd(void)
+{
+   int pfd = epoll_create(255);
+   if (pfd < 0) {
+   RTE_LOG(ERR, EAL,
+   "Cannot create epoll instance\n");
+   return -1;
+   }
+   return pfd;
+}
+
+int
+rte_intr_tls_epfd(void)
+{
+   if (RTE_PER_LCORE(_epfd) == -1)
+   RTE_PER_LCORE(_epfd) = eal_init_tls_epfd();
+
+   return RTE_PER_LCORE(_epfd);
+}
+
+int
+rte_epoll_wait(int epfd, struct rte_epoll_event *events,
+  int maxevents, int timeout)
+{
+   struct epoll_event evs[maxevents];
+   int rc;
+
+   if (!events) {
+   RTE_LOG(ERR, EAL, "rte_epoll_event can't be NULL\n");
+   return -1;
+   }
+
+   /* using per thread epoll fd */
+   if (epfd == RTE_EPOLL_PER_THREAD)
+   epfd = rte_intr_tls_epfd();
+
+   rc = epoll_wait(epfd, evs, maxevents, timeout);
+   if (likely(rc > 0))
+   /* epoll_wait has at least one fd ready to read */
+   eal_epoll_process_event(evs, rc, events);
+   else if (rc < 0) {
+   /* epoll_wait fail */
+   RTE_LOG(ERR, EAL, "epoll_wait returns with fail %s\n",
+   strerror(errno));
+   rc = -1;
+   }
+
+   return rc;
+}
+
+int
+rte_epoll_ctl(int epfd, int op, int fd,
+ struct rte_epoll_event *event)
+{
+   struct epoll_event ev;
+
+   if (!event) {
+   RTE_LOG(ERR, EAL, "rte_epoll_event can't be NULL\n");
+   return -1;
+   }
+
+   /* using per thread epoll fd */
+   if (epfd == RTE_EPOLL_PER_THREAD)
+   epfd = rte_intr_tls_epfd();
+
+   event->fd   = fd;  /* ignore fd in rev */
+   ev.data.ptr = (void *)event;
+   ev.events   = event->event;
+   if (epoll_ctl(epfd, op, fd, ) < 0) {
+   RTE_LOG(ERR, EAL, "Error op %d fd %d epoll_ctl, %s\n",
+   op, fd, strerror(errno));
+   return -1;
+   }
+
+   return 0;
+}
diff --git a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts.h 
b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts.h
index e1f4a7a..af405cf 100644
--- a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts.h
+++ b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts.h
@@ -50,7 +50,19 @@ enum rte_intr_handle_type {
RTE_INTR_HANDLE_MAX
 };

-struct rte_epoll_event;
+#define RTE_INTR_EVENT_ADD1UL
+#defineRTE_INTR_EVENT_DEL2UL
+
+typedef void (*rte_intr_event_cb_t)(int fd, void *arg);
+
+/** interrupt epoll event obj, taken by epoll_event.ptr */
+struct rte_epoll_event {
+   int fd;   /**< OUT: event fd */
+   uint32_t event;   /**< event type */
+   void *data;