[dpdk-dev] [PATCH v7 03/28] librte_ether: add function rte_eth_copy_dev_info

[Iremonger, Bernard]

Hi Thomas,

> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Sunday, November 1, 2015 9:31 PM
> To: Iremonger, Bernard 
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v7 03/28] librte_ether: add function
> rte_eth_copy_dev_info
> 
> 2015-10-30 15:08, Bernard Iremonger:
> > +/**
> > + * Copy pci device info to the Ethernet device data.
> [...]
> > +extern void rte_eth_copy_dev_info(struct rte_eth_dev *eth_dev, struct
> rte_pci_device *pci_dev);
> 
> This function should have the word "pci" in its name.

I will rename to  rte_eth_copy_pci_info().

Regards,

Bernard.

[dpdk-dev] [PATCH v7 03/28] librte_ether: add function rte_eth_copy_dev_info

[Thomas Monjalon]

2015-10-30 15:08, Bernard Iremonger:
> +/**
> + * Copy pci device info to the Ethernet device data.
[...]
> +extern void rte_eth_copy_dev_info(struct rte_eth_dev *eth_dev, struct 
> rte_pci_device *pci_dev);

This function should have the word "pci" in its name.

[dpdk-dev] [PATCH v7 03/28] librte_ether: add function rte_eth_copy_dev_info

[Bernard Iremonger]

Signed-off-by: Bernard Iremonger 
Acked-by: Bruce Richardson 
---
 lib/librte_ether/rte_ethdev.c  | 14 ++
 lib/librte_ether/rte_ethdev.h  | 14 ++
 lib/librte_ether/rte_ether_version.map |  7 +++
 3 files changed, 35 insertions(+)

diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index f593f6e..ce1d000 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -3342,3 +3342,17 @@ rte_eth_dev_set_eeprom(uint8_t port_id, struct 
rte_dev_eeprom_info *info)
FUNC_PTR_OR_ERR_RET(*dev->dev_ops->set_eeprom, -ENOTSUP);
return (*dev->dev_ops->set_eeprom)(dev, info);
 }
+
+void
+rte_eth_copy_dev_info(struct rte_eth_dev *eth_dev, struct rte_pci_device 
*pci_dev)
+{
+   if ((eth_dev == NULL) || (pci_dev == NULL)) {
+   PMD_DEBUG_TRACE("NULL pointer eth_dev=%p pci_dev=%p\n",
+   eth_dev, pci_dev);
+   }
+
+   eth_dev->data->dev_flags = pci_dev->driver->drv_flags;
+   eth_dev->data->kdrv = pci_dev->kdrv;
+   eth_dev->data->numa_node = pci_dev->numa_node;
+   eth_dev->data->drv_name = pci_dev->driver->name;
+}
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index 1517fe2..37bba9f 100644
--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rte_ethdev.h
@@ -3613,6 +3613,20 @@ extern int rte_eth_timesync_read_rx_timestamp(uint8_t 
port_id,
 extern int rte_eth_timesync_read_tx_timestamp(uint8_t port_id,
  struct timespec *timestamp);

+/**
+ * Copy pci device info to the Ethernet device data.
+ *
+ * @param eth_dev
+ * The *eth_dev* pointer is the address of the *rte_eth_dev* structure.
+ * @param pci_dev
+ * The *pci_dev* pointer is the address of the *rte_pci_device* structure.
+ *
+ * @return
+ *   - 0 on success, negative on error
+ */
+extern void rte_eth_copy_dev_info(struct rte_eth_dev *eth_dev, struct 
rte_pci_device *pci_dev);
+
+
 #ifdef __cplusplus
 }
 #endif
diff --git a/lib/librte_ether/rte_ether_version.map 
b/lib/librte_ether/rte_ether_version.map
index 8345a6c..e6a43be 100644
--- a/lib/librte_ether/rte_ether_version.map
+++ b/lib/librte_ether/rte_ether_version.map
@@ -127,3 +127,10 @@ DPDK_2.1 {
rte_eth_timesync_read_tx_timestamp;

 } DPDK_2.0;
+
+DPDK_2.2 {
+   global:
+
+   rte_eth_copy_dev_info;
+
+} DPDK_2.1;
-- 
1.9.1