[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c
On Thu, Apr 30, 2015 at 9:00 AM, Neil Horman wrote: > On Wed, Apr 29, 2015 at 10:47:04AM -0700, Ravi Kerur wrote: > > > > I tried to run validate-abi.sh on BSD but ran into errors. If there > is a > > > > way to check against BSD please let me know. > > > > > > > The ABI checker should work on BSD as far as I know, since it only > relies > > > on > > > dwarf information in the output binary. What errors are you seeing? > > > > > > > dpdk-bsd:/home/rkerur/dpdk-validate-abi-1/dpdk # sh > > ./scripts/validate-abi.sh v2.0.0-rc3 v2.0.0-abi > x86_64-native-bsdapp-clang > > mktemp: illegal option -- p > Ah, bsd mktemp doesn't support the -p option. I'll see if I can fix that. > I think there are couple of other issues I found freeBSD sed is different from Linux (GNU sed) and I get following errors with the script "sed 1 command c expects \ followed by text". I have to use gsed (GNU sed) in freeBSD to get rid of that error and similarly freeBSD uses gmake instead of make. I have made those minor changes and sending them with this email as an attachment. > > usage: mktemp [-d] [-q] [-t prefix] [-u] template ... > >mktemp [-d] [-q] [-u] -t prefix > > Cant find abi-compliance-checker utility > > > > abi-compliance-checker is installed as shown below. > > > > dpdk-bsd:/home/rkerur/dpdk-validate-abi-1/dpdk # pkg install > > devel/abi-compliance-checker > > Updating FreeBSD repository catalogue... > > FreeBSD repository is up-to-date. > > All repositories are up-to-date. > > Checking integrity... done (0 conflicting) > > The most recent version of packages are already installed > > > > Whats the path for abi-compliance checker there? It would seem that the > binary > isn't in your path, as which isn't locating it. > I am using regular freeBSD port install which doesn't install in any /usr/bin or /usr/local/bin. I finally decided to install both abi-dumper and abi-compliance-checker from source, compile and install it in correct directory. Above error is fixed after that, however, abi utilities use "eu-readelf" and I can't find that utility to install in freeBSD. I get following errors ERROR: can't find "eu-readelf" command freeBSD has only readelf. Please let me know if there is a way to get rid of this error. Thanks, Ravi > > > > > > > Neil > > > > > > >
[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c
On Wed, Apr 29, 2015 at 10:47:04AM -0700, Ravi Kerur wrote: > > > I tried to run validate-abi.sh on BSD but ran into errors. If there is a > > > way to check against BSD please let me know. > > > > > The ABI checker should work on BSD as far as I know, since it only relies > > on > > dwarf information in the output binary. What errors are you seeing? > > > > dpdk-bsd:/home/rkerur/dpdk-validate-abi-1/dpdk # sh > ./scripts/validate-abi.sh v2.0.0-rc3 v2.0.0-abi x86_64-native-bsdapp-clang > mktemp: illegal option -- p Ah, bsd mktemp doesn't support the -p option. I'll see if I can fix that. > usage: mktemp [-d] [-q] [-t prefix] [-u] template ... >mktemp [-d] [-q] [-u] -t prefix > Cant find abi-compliance-checker utility > > abi-compliance-checker is installed as shown below. > > dpdk-bsd:/home/rkerur/dpdk-validate-abi-1/dpdk # pkg install > devel/abi-compliance-checker > Updating FreeBSD repository catalogue... > FreeBSD repository is up-to-date. > All repositories are up-to-date. > Checking integrity... done (0 conflicting) > The most recent version of packages are already installed > Whats the path for abi-compliance checker there? It would seem that the binary isn't in your path, as which isn't locating it. Neil > > > > > Neil > > > >
[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c
> > I tried to run validate-abi.sh on BSD but ran into errors. If there is a > > way to check against BSD please let me know. > > > The ABI checker should work on BSD as far as I know, since it only relies > on > dwarf information in the output binary. What errors are you seeing? > dpdk-bsd:/home/rkerur/dpdk-validate-abi-1/dpdk # sh ./scripts/validate-abi.sh v2.0.0-rc3 v2.0.0-abi x86_64-native-bsdapp-clang mktemp: illegal option -- p usage: mktemp [-d] [-q] [-t prefix] [-u] template ... mktemp [-d] [-q] [-u] -t prefix Cant find abi-compliance-checker utility abi-compliance-checker is installed as shown below. dpdk-bsd:/home/rkerur/dpdk-validate-abi-1/dpdk # pkg install devel/abi-compliance-checker Updating FreeBSD repository catalogue... FreeBSD repository is up-to-date. All repositories are up-to-date. Checking integrity... done (0 conflicting) The most recent version of packages are already installed > > Neil > >
[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c
On Tue, Apr 28, 2015 at 04:52:37PM -0700, Ravi Kerur wrote: > On Tue, Apr 28, 2015 at 12:35 PM, Neil Horman > wrote: > > > On Mon, Apr 27, 2015 at 03:39:41PM -0700, Ravi Kerur wrote: > > > On Mon, Apr 27, 2015 at 6:44 AM, Neil Horman > > wrote: > > > > > > > On Sat, Apr 25, 2015 at 05:09:01PM -0700, Ravi Kerur wrote: > > > > > On Sat, Apr 25, 2015 at 6:02 AM, Neil Horman > > > > tuxdriver.com> > > > > wrote: > > > > > > > > > > > On Sat, Apr 25, 2015 at 08:32:42AM -0400, Neil Horman wrote: > > > > > > > On Fri, Apr 24, 2015 at 06:45:06PM -0700, Ravi Kerur wrote: > > > > > > > > On Fri, Apr 24, 2015 at 2:24 PM, Ravi Kerur > > > > > > > gmail.com> > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Fri, Apr 24, 2015 at 12:51 PM, Neil Horman < > > > > nhorman at tuxdriver.com > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > >> On Fri, Apr 24, 2015 at 12:21:23PM -0700, Ravi Kerur wrote: > > > > > > > > >> > On Fri, Apr 24, 2015 at 11:53 AM, Neil Horman < > > > > > > nhorman at tuxdriver.com> > > > > > > > > >> wrote: > > > > > > > > >> > > > > > > > > > >> > > On Fri, Apr 24, 2015 at 09:45:24AM -0700, Ravi Kerur > > wrote: > > > > > > > > >> > > > On Fri, Apr 24, 2015 at 8:22 AM, Neil Horman < > > > > > > nhorman at tuxdriver.com > > > > > > > > >> > > > > > > > > > >> > > wrote: > > > > > > > > >> > > > > > > > > > > > >> > > > > On Fri, Apr 24, 2015 at 08:14:04AM -0700, Ravi Kerur > > > > wrote: > > > > > > > > >> > > > > > On Fri, Apr 24, 2015 at 6:51 AM, Neil Horman < > > > > > > > > >> nhorman at tuxdriver.com> > > > > > > > > >> > > > > wrote: > > > > > > > > >> > > > > > > > > > > > > > >> > > > > > > On Thu, Apr 23, 2015 at 02:35:31PM -0700, Ravi > > Kerur > > > > > > wrote: > > > > > > > > >> > > > > > > > Changes in v7 > > > > > > > > >> > > > > > > > Remove _setname_ pthread calls. > > > > > > > > >> > > > > > > > Use rte_gettid() API in RTE_LOG to print > > > > thread_id. > > > > > > > > >> > > > > > > > > > > > > > > > >> > > > > > > > Changes in v6 > > > > > > > > >> > > > > > > > Remove RTE_EXEC_ENV_BSDAPP from > > > > eal_common_thread.c > > > > > > file. > > > > > > > > >> > > > > > > > Add pthread_setname_np/pthread_set_name_np for > > > > > > Linux/FreeBSD > > > > > > > > >> > > > > > > > respectively. Plan to use _getname_ in RTE_LOG > > > > when > > > > > > > > >> available. > > > > > > > > >> > > > > > > > Use existing rte_get_systid() in RTE_LOG to > > print > > > > > > thread_id. > > > > > > > > >> > > > > > > > > > > > > > > > >> > > > > > > > Changes in v5 > > > > > > > > >> > > > > > > > Rebase to latest code. > > > > > > > > >> > > > > > > > > > > > > > > > >> > > > > > > > Changes in v4 > > > > > > > > >> > > > > > > > None > > > > > > > > >> > > > > > > > > > > > > > > > >> > > > > > > > Changes in v3 > > > > > > > > >> > > > > > > > Changed subject to be more explicit on file > > name > > > > > > inclusion. > > > > > > > > >> > > > > > > > > > > > > > > > >> > > > > > > > Changes in v2 > > > > > > > > >> > > > > > > > None > > > > > > > > >> > > > > > > > > > > > > > > > >> > > > > > > > Changes in v1 > > > > > > > > >> > > > > > > > eal_thread.c has minor differences between > > Linux > > > > and > > > > > > BSD, > > > > > > > > >> move > > > > > > > > >> > > > > > > > entire file into common directory. > > > > > > > > >> > > > > > > > Use RTE_EXEC_ENV_BSDAPP to differentiate on > > minor > > > > > > > > >> differences. > > > > > > > > >> > > > > > > > Rename eal_thread.c to eal_common_thread.c > > > > > > > > >> > > > > > > > Makefile changes to reflect file move and name > > > > change. > > > > > > > > >> > > > > > > > Fix checkpatch warnings. > > > > > > > > >> > > > > > > > > > > > > > > > >> > > > > > > > Signed-off-by: Ravi Kerur > > > > > > > > >> > > > > > > > --- > > > > > > > > >> > > > > > > > lib/librte_eal/bsdapp/eal/Makefile| > > 2 > > > > +- > > > > > > > > >> > > > > > > > lib/librte_eal/bsdapp/eal/eal_thread.c| > > 152 > > > > > > > > >> > > > > > > -- > > > > > > > > >> > > > > > > > lib/librte_eal/common/eal_common_thread.c | > > 147 > > > > > > > > >> > > > > > > - > > > > > > > > >> > > > > > > > lib/librte_eal/linuxapp/eal/eal_thread.c | > > 152 > > > > > > > > >> > > > > > > +- > > > > > > > > >> > > > > > > > 4 files changed, 148 insertions(+), 305 > > > > deletions(-) > > > > > > > > >> > > > > > > > > > > > > > > > >> > > > > > > > diff --git > > a/lib/librte_eal/bsdapp/eal/Makefile > > > > > > > > >> > > > > > > b/lib/librte_eal/bsdapp/eal/Makefile > > > > > > > > >> > > > > > > > index 2357cfa..55971b9 100644 > > > > > > > > >> > > > > > > > --- a/lib/librte_eal/bsdapp/eal/Makefile > > > > > > > > >> > > > > > > > +++ b/lib/librte_eal/bsdapp/eal/Makefile > > > > > > > > >> > > > > > > > @@ -87,7 +87,7 @@ CFLAGS_eal_common_log.o := > > > > > > -D_GNU_SOURCE > > > > > > > > >> > > > >
[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c
On Tue, Apr 28, 2015 at 12:35 PM, Neil Horman wrote: > On Mon, Apr 27, 2015 at 03:39:41PM -0700, Ravi Kerur wrote: > > On Mon, Apr 27, 2015 at 6:44 AM, Neil Horman > wrote: > > > > > On Sat, Apr 25, 2015 at 05:09:01PM -0700, Ravi Kerur wrote: > > > > On Sat, Apr 25, 2015 at 6:02 AM, Neil Horman > > > wrote: > > > > > > > > > On Sat, Apr 25, 2015 at 08:32:42AM -0400, Neil Horman wrote: > > > > > > On Fri, Apr 24, 2015 at 06:45:06PM -0700, Ravi Kerur wrote: > > > > > > > On Fri, Apr 24, 2015 at 2:24 PM, Ravi Kerur > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Fri, Apr 24, 2015 at 12:51 PM, Neil Horman < > > > nhorman at tuxdriver.com > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > >> On Fri, Apr 24, 2015 at 12:21:23PM -0700, Ravi Kerur wrote: > > > > > > > >> > On Fri, Apr 24, 2015 at 11:53 AM, Neil Horman < > > > > > nhorman at tuxdriver.com> > > > > > > > >> wrote: > > > > > > > >> > > > > > > > > >> > > On Fri, Apr 24, 2015 at 09:45:24AM -0700, Ravi Kerur > wrote: > > > > > > > >> > > > On Fri, Apr 24, 2015 at 8:22 AM, Neil Horman < > > > > > nhorman at tuxdriver.com > > > > > > > >> > > > > > > > > >> > > wrote: > > > > > > > >> > > > > > > > > > > >> > > > > On Fri, Apr 24, 2015 at 08:14:04AM -0700, Ravi Kerur > > > wrote: > > > > > > > >> > > > > > On Fri, Apr 24, 2015 at 6:51 AM, Neil Horman < > > > > > > > >> nhorman at tuxdriver.com> > > > > > > > >> > > > > wrote: > > > > > > > >> > > > > > > > > > > > > >> > > > > > > On Thu, Apr 23, 2015 at 02:35:31PM -0700, Ravi > Kerur > > > > > wrote: > > > > > > > >> > > > > > > > Changes in v7 > > > > > > > >> > > > > > > > Remove _setname_ pthread calls. > > > > > > > >> > > > > > > > Use rte_gettid() API in RTE_LOG to print > > > thread_id. > > > > > > > >> > > > > > > > > > > > > > > >> > > > > > > > Changes in v6 > > > > > > > >> > > > > > > > Remove RTE_EXEC_ENV_BSDAPP from > > > eal_common_thread.c > > > > > file. > > > > > > > >> > > > > > > > Add pthread_setname_np/pthread_set_name_np for > > > > > Linux/FreeBSD > > > > > > > >> > > > > > > > respectively. Plan to use _getname_ in RTE_LOG > > > when > > > > > > > >> available. > > > > > > > >> > > > > > > > Use existing rte_get_systid() in RTE_LOG to > print > > > > > thread_id. > > > > > > > >> > > > > > > > > > > > > > > >> > > > > > > > Changes in v5 > > > > > > > >> > > > > > > > Rebase to latest code. > > > > > > > >> > > > > > > > > > > > > > > >> > > > > > > > Changes in v4 > > > > > > > >> > > > > > > > None > > > > > > > >> > > > > > > > > > > > > > > >> > > > > > > > Changes in v3 > > > > > > > >> > > > > > > > Changed subject to be more explicit on file > name > > > > > inclusion. > > > > > > > >> > > > > > > > > > > > > > > >> > > > > > > > Changes in v2 > > > > > > > >> > > > > > > > None > > > > > > > >> > > > > > > > > > > > > > > >> > > > > > > > Changes in v1 > > > > > > > >> > > > > > > > eal_thread.c has minor differences between > Linux > > > and > > > > > BSD, > > > > > > > >> move > > > > > > > >> > > > > > > > entire file into common directory. > > > > > > > >> > > > > > > > Use RTE_EXEC_ENV_BSDAPP to differentiate on > minor > > > > > > > >> differences. > > > > > > > >> > > > > > > > Rename eal_thread.c to eal_common_thread.c > > > > > > > >> > > > > > > > Makefile changes to reflect file move and name > > > change. > > > > > > > >> > > > > > > > Fix checkpatch warnings. > > > > > > > >> > > > > > > > > > > > > > > >> > > > > > > > Signed-off-by: Ravi Kerur > > > > > > > >> > > > > > > > --- > > > > > > > >> > > > > > > > lib/librte_eal/bsdapp/eal/Makefile| > 2 > > > +- > > > > > > > >> > > > > > > > lib/librte_eal/bsdapp/eal/eal_thread.c| > 152 > > > > > > > >> > > > > > > -- > > > > > > > >> > > > > > > > lib/librte_eal/common/eal_common_thread.c | > 147 > > > > > > > >> > > > > > > - > > > > > > > >> > > > > > > > lib/librte_eal/linuxapp/eal/eal_thread.c | > 152 > > > > > > > >> > > > > > > +- > > > > > > > >> > > > > > > > 4 files changed, 148 insertions(+), 305 > > > deletions(-) > > > > > > > >> > > > > > > > > > > > > > > >> > > > > > > > diff --git > a/lib/librte_eal/bsdapp/eal/Makefile > > > > > > > >> > > > > > > b/lib/librte_eal/bsdapp/eal/Makefile > > > > > > > >> > > > > > > > index 2357cfa..55971b9 100644 > > > > > > > >> > > > > > > > --- a/lib/librte_eal/bsdapp/eal/Makefile > > > > > > > >> > > > > > > > +++ b/lib/librte_eal/bsdapp/eal/Makefile > > > > > > > >> > > > > > > > @@ -87,7 +87,7 @@ CFLAGS_eal_common_log.o := > > > > > -D_GNU_SOURCE > > > > > > > >> > > > > > > > # workaround for a gcc bug with noreturn > > > attribute > > > > > > > >> > > > > > > > # > > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12603 > > > > > > > >> > > > > > > > ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) > > > > > > > >> > > > > > > > -CFLAGS_eal_thread.o += -Wno-return-type > > > > > > > >> > > > > > > >
[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c
On Mon, Apr 27, 2015 at 03:39:41PM -0700, Ravi Kerur wrote: > On Mon, Apr 27, 2015 at 6:44 AM, Neil Horman wrote: > > > On Sat, Apr 25, 2015 at 05:09:01PM -0700, Ravi Kerur wrote: > > > On Sat, Apr 25, 2015 at 6:02 AM, Neil Horman > > wrote: > > > > > > > On Sat, Apr 25, 2015 at 08:32:42AM -0400, Neil Horman wrote: > > > > > On Fri, Apr 24, 2015 at 06:45:06PM -0700, Ravi Kerur wrote: > > > > > > On Fri, Apr 24, 2015 at 2:24 PM, Ravi Kerur > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > On Fri, Apr 24, 2015 at 12:51 PM, Neil Horman < > > nhorman at tuxdriver.com > > > > > > > > > > > > wrote: > > > > > > > > > > > > > >> On Fri, Apr 24, 2015 at 12:21:23PM -0700, Ravi Kerur wrote: > > > > > > >> > On Fri, Apr 24, 2015 at 11:53 AM, Neil Horman < > > > > nhorman at tuxdriver.com> > > > > > > >> wrote: > > > > > > >> > > > > > > > >> > > On Fri, Apr 24, 2015 at 09:45:24AM -0700, Ravi Kerur wrote: > > > > > > >> > > > On Fri, Apr 24, 2015 at 8:22 AM, Neil Horman < > > > > nhorman at tuxdriver.com > > > > > > >> > > > > > > > >> > > wrote: > > > > > > >> > > > > > > > > > >> > > > > On Fri, Apr 24, 2015 at 08:14:04AM -0700, Ravi Kerur > > wrote: > > > > > > >> > > > > > On Fri, Apr 24, 2015 at 6:51 AM, Neil Horman < > > > > > > >> nhorman at tuxdriver.com> > > > > > > >> > > > > wrote: > > > > > > >> > > > > > > > > > > > >> > > > > > > On Thu, Apr 23, 2015 at 02:35:31PM -0700, Ravi Kerur > > > > wrote: > > > > > > >> > > > > > > > Changes in v7 > > > > > > >> > > > > > > > Remove _setname_ pthread calls. > > > > > > >> > > > > > > > Use rte_gettid() API in RTE_LOG to print > > thread_id. > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > Changes in v6 > > > > > > >> > > > > > > > Remove RTE_EXEC_ENV_BSDAPP from > > eal_common_thread.c > > > > file. > > > > > > >> > > > > > > > Add pthread_setname_np/pthread_set_name_np for > > > > Linux/FreeBSD > > > > > > >> > > > > > > > respectively. Plan to use _getname_ in RTE_LOG > > when > > > > > > >> available. > > > > > > >> > > > > > > > Use existing rte_get_systid() in RTE_LOG to print > > > > thread_id. > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > Changes in v5 > > > > > > >> > > > > > > > Rebase to latest code. > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > Changes in v4 > > > > > > >> > > > > > > > None > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > Changes in v3 > > > > > > >> > > > > > > > Changed subject to be more explicit on file name > > > > inclusion. > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > Changes in v2 > > > > > > >> > > > > > > > None > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > Changes in v1 > > > > > > >> > > > > > > > eal_thread.c has minor differences between Linux > > and > > > > BSD, > > > > > > >> move > > > > > > >> > > > > > > > entire file into common directory. > > > > > > >> > > > > > > > Use RTE_EXEC_ENV_BSDAPP to differentiate on minor > > > > > > >> differences. > > > > > > >> > > > > > > > Rename eal_thread.c to eal_common_thread.c > > > > > > >> > > > > > > > Makefile changes to reflect file move and name > > change. > > > > > > >> > > > > > > > Fix checkpatch warnings. > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > Signed-off-by: Ravi Kerur > > > > > > >> > > > > > > > --- > > > > > > >> > > > > > > > lib/librte_eal/bsdapp/eal/Makefile| 2 > > +- > > > > > > >> > > > > > > > lib/librte_eal/bsdapp/eal/eal_thread.c| 152 > > > > > > >> > > > > > > -- > > > > > > >> > > > > > > > lib/librte_eal/common/eal_common_thread.c | 147 > > > > > > >> > > > > > > - > > > > > > >> > > > > > > > lib/librte_eal/linuxapp/eal/eal_thread.c | 152 > > > > > > >> > > > > > > +- > > > > > > >> > > > > > > > 4 files changed, 148 insertions(+), 305 > > deletions(-) > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > diff --git a/lib/librte_eal/bsdapp/eal/Makefile > > > > > > >> > > > > > > b/lib/librte_eal/bsdapp/eal/Makefile > > > > > > >> > > > > > > > index 2357cfa..55971b9 100644 > > > > > > >> > > > > > > > --- a/lib/librte_eal/bsdapp/eal/Makefile > > > > > > >> > > > > > > > +++ b/lib/librte_eal/bsdapp/eal/Makefile > > > > > > >> > > > > > > > @@ -87,7 +87,7 @@ CFLAGS_eal_common_log.o := > > > > -D_GNU_SOURCE > > > > > > >> > > > > > > > # workaround for a gcc bug with noreturn > > attribute > > > > > > >> > > > > > > > # > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12603 > > > > > > >> > > > > > > > ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) > > > > > > >> > > > > > > > -CFLAGS_eal_thread.o += -Wno-return-type > > > > > > >> > > > > > > > +CFLAGS_eal_common_thread.o += -Wno-return-type > > > > > > >> > > > > > > > CFLAGS_eal_hpet.o += -Wno-return-type > > > > > > >> > > > > > > > endif > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > diff --git > > a/lib/librte_eal/bsdapp/eal/eal_thread.c > > > > > > >> > > > > > >
[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c
On Mon, Apr 27, 2015 at 6:44 AM, Neil Horman wrote: > On Sat, Apr 25, 2015 at 05:09:01PM -0700, Ravi Kerur wrote: > > On Sat, Apr 25, 2015 at 6:02 AM, Neil Horman > wrote: > > > > > On Sat, Apr 25, 2015 at 08:32:42AM -0400, Neil Horman wrote: > > > > On Fri, Apr 24, 2015 at 06:45:06PM -0700, Ravi Kerur wrote: > > > > > On Fri, Apr 24, 2015 at 2:24 PM, Ravi Kerur > wrote: > > > > > > > > > > > > > > > > > > > > > > > On Fri, Apr 24, 2015 at 12:51 PM, Neil Horman < > nhorman at tuxdriver.com > > > > > > > > > > wrote: > > > > > > > > > > > >> On Fri, Apr 24, 2015 at 12:21:23PM -0700, Ravi Kerur wrote: > > > > > >> > On Fri, Apr 24, 2015 at 11:53 AM, Neil Horman < > > > nhorman at tuxdriver.com> > > > > > >> wrote: > > > > > >> > > > > > > >> > > On Fri, Apr 24, 2015 at 09:45:24AM -0700, Ravi Kerur wrote: > > > > > >> > > > On Fri, Apr 24, 2015 at 8:22 AM, Neil Horman < > > > nhorman at tuxdriver.com > > > > > >> > > > > > > >> > > wrote: > > > > > >> > > > > > > > > >> > > > > On Fri, Apr 24, 2015 at 08:14:04AM -0700, Ravi Kerur > wrote: > > > > > >> > > > > > On Fri, Apr 24, 2015 at 6:51 AM, Neil Horman < > > > > > >> nhorman at tuxdriver.com> > > > > > >> > > > > wrote: > > > > > >> > > > > > > > > > > >> > > > > > > On Thu, Apr 23, 2015 at 02:35:31PM -0700, Ravi Kerur > > > wrote: > > > > > >> > > > > > > > Changes in v7 > > > > > >> > > > > > > > Remove _setname_ pthread calls. > > > > > >> > > > > > > > Use rte_gettid() API in RTE_LOG to print > thread_id. > > > > > >> > > > > > > > > > > > > >> > > > > > > > Changes in v6 > > > > > >> > > > > > > > Remove RTE_EXEC_ENV_BSDAPP from > eal_common_thread.c > > > file. > > > > > >> > > > > > > > Add pthread_setname_np/pthread_set_name_np for > > > Linux/FreeBSD > > > > > >> > > > > > > > respectively. Plan to use _getname_ in RTE_LOG > when > > > > > >> available. > > > > > >> > > > > > > > Use existing rte_get_systid() in RTE_LOG to print > > > thread_id. > > > > > >> > > > > > > > > > > > > >> > > > > > > > Changes in v5 > > > > > >> > > > > > > > Rebase to latest code. > > > > > >> > > > > > > > > > > > > >> > > > > > > > Changes in v4 > > > > > >> > > > > > > > None > > > > > >> > > > > > > > > > > > > >> > > > > > > > Changes in v3 > > > > > >> > > > > > > > Changed subject to be more explicit on file name > > > inclusion. > > > > > >> > > > > > > > > > > > > >> > > > > > > > Changes in v2 > > > > > >> > > > > > > > None > > > > > >> > > > > > > > > > > > > >> > > > > > > > Changes in v1 > > > > > >> > > > > > > > eal_thread.c has minor differences between Linux > and > > > BSD, > > > > > >> move > > > > > >> > > > > > > > entire file into common directory. > > > > > >> > > > > > > > Use RTE_EXEC_ENV_BSDAPP to differentiate on minor > > > > > >> differences. > > > > > >> > > > > > > > Rename eal_thread.c to eal_common_thread.c > > > > > >> > > > > > > > Makefile changes to reflect file move and name > change. > > > > > >> > > > > > > > Fix checkpatch warnings. > > > > > >> > > > > > > > > > > > > >> > > > > > > > Signed-off-by: Ravi Kerur > > > > > >> > > > > > > > --- > > > > > >> > > > > > > > lib/librte_eal/bsdapp/eal/Makefile| 2 > +- > > > > > >> > > > > > > > lib/librte_eal/bsdapp/eal/eal_thread.c| 152 > > > > > >> > > > > > > -- > > > > > >> > > > > > > > lib/librte_eal/common/eal_common_thread.c | 147 > > > > > >> > > > > > > - > > > > > >> > > > > > > > lib/librte_eal/linuxapp/eal/eal_thread.c | 152 > > > > > >> > > > > > > +- > > > > > >> > > > > > > > 4 files changed, 148 insertions(+), 305 > deletions(-) > > > > > >> > > > > > > > > > > > > >> > > > > > > > diff --git a/lib/librte_eal/bsdapp/eal/Makefile > > > > > >> > > > > > > b/lib/librte_eal/bsdapp/eal/Makefile > > > > > >> > > > > > > > index 2357cfa..55971b9 100644 > > > > > >> > > > > > > > --- a/lib/librte_eal/bsdapp/eal/Makefile > > > > > >> > > > > > > > +++ b/lib/librte_eal/bsdapp/eal/Makefile > > > > > >> > > > > > > > @@ -87,7 +87,7 @@ CFLAGS_eal_common_log.o := > > > -D_GNU_SOURCE > > > > > >> > > > > > > > # workaround for a gcc bug with noreturn > attribute > > > > > >> > > > > > > > # > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12603 > > > > > >> > > > > > > > ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) > > > > > >> > > > > > > > -CFLAGS_eal_thread.o += -Wno-return-type > > > > > >> > > > > > > > +CFLAGS_eal_common_thread.o += -Wno-return-type > > > > > >> > > > > > > > CFLAGS_eal_hpet.o += -Wno-return-type > > > > > >> > > > > > > > endif > > > > > >> > > > > > > > > > > > > >> > > > > > > > diff --git > a/lib/librte_eal/bsdapp/eal/eal_thread.c > > > > > >> > > > > > > b/lib/librte_eal/bsdapp/eal/eal_thread.c > > > > > >> > > > > > > > index 9a03437..5714b8f 100644 > > > > > >> > > > > > > > --- a/lib/librte_eal/bsdapp/eal/eal_thread.c > > > > > >> > > > > > > > +++ b/lib/librte_eal/bsdapp/eal/eal_thread.c > > > > > >> > > > > > > > @@ -35,163 +35,11 @@ > > > > > >>
[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c
On Sat, Apr 25, 2015 at 05:09:01PM -0700, Ravi Kerur wrote: > On Sat, Apr 25, 2015 at 6:02 AM, Neil Horman wrote: > > > On Sat, Apr 25, 2015 at 08:32:42AM -0400, Neil Horman wrote: > > > On Fri, Apr 24, 2015 at 06:45:06PM -0700, Ravi Kerur wrote: > > > > On Fri, Apr 24, 2015 at 2:24 PM, Ravi Kerur wrote: > > > > > > > > > > > > > > > > > > > On Fri, Apr 24, 2015 at 12:51 PM, Neil Horman > > > > tuxdriver.com > > > > > > > > wrote: > > > > > > > > > >> On Fri, Apr 24, 2015 at 12:21:23PM -0700, Ravi Kerur wrote: > > > > >> > On Fri, Apr 24, 2015 at 11:53 AM, Neil Horman < > > nhorman at tuxdriver.com> > > > > >> wrote: > > > > >> > > > > > >> > > On Fri, Apr 24, 2015 at 09:45:24AM -0700, Ravi Kerur wrote: > > > > >> > > > On Fri, Apr 24, 2015 at 8:22 AM, Neil Horman < > > nhorman at tuxdriver.com > > > > >> > > > > > >> > > wrote: > > > > >> > > > > > > > >> > > > > On Fri, Apr 24, 2015 at 08:14:04AM -0700, Ravi Kerur wrote: > > > > >> > > > > > On Fri, Apr 24, 2015 at 6:51 AM, Neil Horman < > > > > >> nhorman at tuxdriver.com> > > > > >> > > > > wrote: > > > > >> > > > > > > > > > >> > > > > > > On Thu, Apr 23, 2015 at 02:35:31PM -0700, Ravi Kerur > > wrote: > > > > >> > > > > > > > Changes in v7 > > > > >> > > > > > > > Remove _setname_ pthread calls. > > > > >> > > > > > > > Use rte_gettid() API in RTE_LOG to print thread_id. > > > > >> > > > > > > > > > > > >> > > > > > > > Changes in v6 > > > > >> > > > > > > > Remove RTE_EXEC_ENV_BSDAPP from eal_common_thread.c > > file. > > > > >> > > > > > > > Add pthread_setname_np/pthread_set_name_np for > > Linux/FreeBSD > > > > >> > > > > > > > respectively. Plan to use _getname_ in RTE_LOG when > > > > >> available. > > > > >> > > > > > > > Use existing rte_get_systid() in RTE_LOG to print > > thread_id. > > > > >> > > > > > > > > > > > >> > > > > > > > Changes in v5 > > > > >> > > > > > > > Rebase to latest code. > > > > >> > > > > > > > > > > > >> > > > > > > > Changes in v4 > > > > >> > > > > > > > None > > > > >> > > > > > > > > > > > >> > > > > > > > Changes in v3 > > > > >> > > > > > > > Changed subject to be more explicit on file name > > inclusion. > > > > >> > > > > > > > > > > > >> > > > > > > > Changes in v2 > > > > >> > > > > > > > None > > > > >> > > > > > > > > > > > >> > > > > > > > Changes in v1 > > > > >> > > > > > > > eal_thread.c has minor differences between Linux and > > BSD, > > > > >> move > > > > >> > > > > > > > entire file into common directory. > > > > >> > > > > > > > Use RTE_EXEC_ENV_BSDAPP to differentiate on minor > > > > >> differences. > > > > >> > > > > > > > Rename eal_thread.c to eal_common_thread.c > > > > >> > > > > > > > Makefile changes to reflect file move and name change. > > > > >> > > > > > > > Fix checkpatch warnings. > > > > >> > > > > > > > > > > > >> > > > > > > > Signed-off-by: Ravi Kerur > > > > >> > > > > > > > --- > > > > >> > > > > > > > lib/librte_eal/bsdapp/eal/Makefile| 2 +- > > > > >> > > > > > > > lib/librte_eal/bsdapp/eal/eal_thread.c| 152 > > > > >> > > > > > > -- > > > > >> > > > > > > > lib/librte_eal/common/eal_common_thread.c | 147 > > > > >> > > > > > > - > > > > >> > > > > > > > lib/librte_eal/linuxapp/eal/eal_thread.c | 152 > > > > >> > > > > > > +- > > > > >> > > > > > > > 4 files changed, 148 insertions(+), 305 deletions(-) > > > > >> > > > > > > > > > > > >> > > > > > > > diff --git a/lib/librte_eal/bsdapp/eal/Makefile > > > > >> > > > > > > b/lib/librte_eal/bsdapp/eal/Makefile > > > > >> > > > > > > > index 2357cfa..55971b9 100644 > > > > >> > > > > > > > --- a/lib/librte_eal/bsdapp/eal/Makefile > > > > >> > > > > > > > +++ b/lib/librte_eal/bsdapp/eal/Makefile > > > > >> > > > > > > > @@ -87,7 +87,7 @@ CFLAGS_eal_common_log.o := > > -D_GNU_SOURCE > > > > >> > > > > > > > # workaround for a gcc bug with noreturn attribute > > > > >> > > > > > > > # http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12603 > > > > >> > > > > > > > ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) > > > > >> > > > > > > > -CFLAGS_eal_thread.o += -Wno-return-type > > > > >> > > > > > > > +CFLAGS_eal_common_thread.o += -Wno-return-type > > > > >> > > > > > > > CFLAGS_eal_hpet.o += -Wno-return-type > > > > >> > > > > > > > endif > > > > >> > > > > > > > > > > > >> > > > > > > > diff --git a/lib/librte_eal/bsdapp/eal/eal_thread.c > > > > >> > > > > > > b/lib/librte_eal/bsdapp/eal/eal_thread.c > > > > >> > > > > > > > index 9a03437..5714b8f 100644 > > > > >> > > > > > > > --- a/lib/librte_eal/bsdapp/eal/eal_thread.c > > > > >> > > > > > > > +++ b/lib/librte_eal/bsdapp/eal/eal_thread.c > > > > >> > > > > > > > @@ -35,163 +35,11 @@ > > > > >> > > > > > > > #include > > > > >> > > > > > > > #include > > > > >> > > > > > > > #include > > > > >> > > > > > > > -#include > > > > >> > > > > > > > -#include > > > > >> > > > > > > > -#include > > > > >> > > > > > > > -#include > > > > >> > > > > > > > #include > > > > >> >
[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c
On Sat, Apr 25, 2015 at 6:02 AM, Neil Horman wrote: > On Sat, Apr 25, 2015 at 08:32:42AM -0400, Neil Horman wrote: > > On Fri, Apr 24, 2015 at 06:45:06PM -0700, Ravi Kerur wrote: > > > On Fri, Apr 24, 2015 at 2:24 PM, Ravi Kerur wrote: > > > > > > > > > > > > > > > On Fri, Apr 24, 2015 at 12:51 PM, Neil Horman > > > > > wrote: > > > > > > > >> On Fri, Apr 24, 2015 at 12:21:23PM -0700, Ravi Kerur wrote: > > > >> > On Fri, Apr 24, 2015 at 11:53 AM, Neil Horman < > nhorman at tuxdriver.com> > > > >> wrote: > > > >> > > > > >> > > On Fri, Apr 24, 2015 at 09:45:24AM -0700, Ravi Kerur wrote: > > > >> > > > On Fri, Apr 24, 2015 at 8:22 AM, Neil Horman < > nhorman at tuxdriver.com > > > >> > > > > >> > > wrote: > > > >> > > > > > > >> > > > > On Fri, Apr 24, 2015 at 08:14:04AM -0700, Ravi Kerur wrote: > > > >> > > > > > On Fri, Apr 24, 2015 at 6:51 AM, Neil Horman < > > > >> nhorman at tuxdriver.com> > > > >> > > > > wrote: > > > >> > > > > > > > > >> > > > > > > On Thu, Apr 23, 2015 at 02:35:31PM -0700, Ravi Kerur > wrote: > > > >> > > > > > > > Changes in v7 > > > >> > > > > > > > Remove _setname_ pthread calls. > > > >> > > > > > > > Use rte_gettid() API in RTE_LOG to print thread_id. > > > >> > > > > > > > > > > >> > > > > > > > Changes in v6 > > > >> > > > > > > > Remove RTE_EXEC_ENV_BSDAPP from eal_common_thread.c > file. > > > >> > > > > > > > Add pthread_setname_np/pthread_set_name_np for > Linux/FreeBSD > > > >> > > > > > > > respectively. Plan to use _getname_ in RTE_LOG when > > > >> available. > > > >> > > > > > > > Use existing rte_get_systid() in RTE_LOG to print > thread_id. > > > >> > > > > > > > > > > >> > > > > > > > Changes in v5 > > > >> > > > > > > > Rebase to latest code. > > > >> > > > > > > > > > > >> > > > > > > > Changes in v4 > > > >> > > > > > > > None > > > >> > > > > > > > > > > >> > > > > > > > Changes in v3 > > > >> > > > > > > > Changed subject to be more explicit on file name > inclusion. > > > >> > > > > > > > > > > >> > > > > > > > Changes in v2 > > > >> > > > > > > > None > > > >> > > > > > > > > > > >> > > > > > > > Changes in v1 > > > >> > > > > > > > eal_thread.c has minor differences between Linux and > BSD, > > > >> move > > > >> > > > > > > > entire file into common directory. > > > >> > > > > > > > Use RTE_EXEC_ENV_BSDAPP to differentiate on minor > > > >> differences. > > > >> > > > > > > > Rename eal_thread.c to eal_common_thread.c > > > >> > > > > > > > Makefile changes to reflect file move and name change. > > > >> > > > > > > > Fix checkpatch warnings. > > > >> > > > > > > > > > > >> > > > > > > > Signed-off-by: Ravi Kerur > > > >> > > > > > > > --- > > > >> > > > > > > > lib/librte_eal/bsdapp/eal/Makefile| 2 +- > > > >> > > > > > > > lib/librte_eal/bsdapp/eal/eal_thread.c| 152 > > > >> > > > > > > -- > > > >> > > > > > > > lib/librte_eal/common/eal_common_thread.c | 147 > > > >> > > > > > > - > > > >> > > > > > > > lib/librte_eal/linuxapp/eal/eal_thread.c | 152 > > > >> > > > > > > +- > > > >> > > > > > > > 4 files changed, 148 insertions(+), 305 deletions(-) > > > >> > > > > > > > > > > >> > > > > > > > diff --git a/lib/librte_eal/bsdapp/eal/Makefile > > > >> > > > > > > b/lib/librte_eal/bsdapp/eal/Makefile > > > >> > > > > > > > index 2357cfa..55971b9 100644 > > > >> > > > > > > > --- a/lib/librte_eal/bsdapp/eal/Makefile > > > >> > > > > > > > +++ b/lib/librte_eal/bsdapp/eal/Makefile > > > >> > > > > > > > @@ -87,7 +87,7 @@ CFLAGS_eal_common_log.o := > -D_GNU_SOURCE > > > >> > > > > > > > # workaround for a gcc bug with noreturn attribute > > > >> > > > > > > > # http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12603 > > > >> > > > > > > > ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) > > > >> > > > > > > > -CFLAGS_eal_thread.o += -Wno-return-type > > > >> > > > > > > > +CFLAGS_eal_common_thread.o += -Wno-return-type > > > >> > > > > > > > CFLAGS_eal_hpet.o += -Wno-return-type > > > >> > > > > > > > endif > > > >> > > > > > > > > > > >> > > > > > > > diff --git a/lib/librte_eal/bsdapp/eal/eal_thread.c > > > >> > > > > > > b/lib/librte_eal/bsdapp/eal/eal_thread.c > > > >> > > > > > > > index 9a03437..5714b8f 100644 > > > >> > > > > > > > --- a/lib/librte_eal/bsdapp/eal/eal_thread.c > > > >> > > > > > > > +++ b/lib/librte_eal/bsdapp/eal/eal_thread.c > > > >> > > > > > > > @@ -35,163 +35,11 @@ > > > >> > > > > > > > #include > > > >> > > > > > > > #include > > > >> > > > > > > > #include > > > >> > > > > > > > -#include > > > >> > > > > > > > -#include > > > >> > > > > > > > -#include > > > >> > > > > > > > -#include > > > >> > > > > > > > #include > > > >> > > > > > > > > > > >> > > > > > > > -#include > > > >> > > > > > > > -#include > > > >> > > > > > > > -#include > > > >> > > > > > > > -#include > > > >> > > > > > > > -#include > > > >> > > > > > > > -#include > > > >> > > > > > > > -#include > > > >> > > > > > > > -#include > > > >> > > > >
[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c
On Sat, Apr 25, 2015 at 08:32:42AM -0400, Neil Horman wrote: > On Fri, Apr 24, 2015 at 06:45:06PM -0700, Ravi Kerur wrote: > > On Fri, Apr 24, 2015 at 2:24 PM, Ravi Kerur wrote: > > > > > > > > > > > On Fri, Apr 24, 2015 at 12:51 PM, Neil Horman > > > wrote: > > > > > >> On Fri, Apr 24, 2015 at 12:21:23PM -0700, Ravi Kerur wrote: > > >> > On Fri, Apr 24, 2015 at 11:53 AM, Neil Horman > >> > tuxdriver.com> > > >> wrote: > > >> > > > >> > > On Fri, Apr 24, 2015 at 09:45:24AM -0700, Ravi Kerur wrote: > > >> > > > On Fri, Apr 24, 2015 at 8:22 AM, Neil Horman > >> > > > tuxdriver.com > > >> > > > >> > > wrote: > > >> > > > > > >> > > > > On Fri, Apr 24, 2015 at 08:14:04AM -0700, Ravi Kerur wrote: > > >> > > > > > On Fri, Apr 24, 2015 at 6:51 AM, Neil Horman < > > >> nhorman at tuxdriver.com> > > >> > > > > wrote: > > >> > > > > > > > >> > > > > > > On Thu, Apr 23, 2015 at 02:35:31PM -0700, Ravi Kerur wrote: > > >> > > > > > > > Changes in v7 > > >> > > > > > > > Remove _setname_ pthread calls. > > >> > > > > > > > Use rte_gettid() API in RTE_LOG to print thread_id. > > >> > > > > > > > > > >> > > > > > > > Changes in v6 > > >> > > > > > > > Remove RTE_EXEC_ENV_BSDAPP from eal_common_thread.c file. > > >> > > > > > > > Add pthread_setname_np/pthread_set_name_np for > > >> > > > > > > > Linux/FreeBSD > > >> > > > > > > > respectively. Plan to use _getname_ in RTE_LOG when > > >> available. > > >> > > > > > > > Use existing rte_get_systid() in RTE_LOG to print > > >> > > > > > > > thread_id. > > >> > > > > > > > > > >> > > > > > > > Changes in v5 > > >> > > > > > > > Rebase to latest code. > > >> > > > > > > > > > >> > > > > > > > Changes in v4 > > >> > > > > > > > None > > >> > > > > > > > > > >> > > > > > > > Changes in v3 > > >> > > > > > > > Changed subject to be more explicit on file name inclusion. > > >> > > > > > > > > > >> > > > > > > > Changes in v2 > > >> > > > > > > > None > > >> > > > > > > > > > >> > > > > > > > Changes in v1 > > >> > > > > > > > eal_thread.c has minor differences between Linux and BSD, > > >> move > > >> > > > > > > > entire file into common directory. > > >> > > > > > > > Use RTE_EXEC_ENV_BSDAPP to differentiate on minor > > >> differences. > > >> > > > > > > > Rename eal_thread.c to eal_common_thread.c > > >> > > > > > > > Makefile changes to reflect file move and name change. > > >> > > > > > > > Fix checkpatch warnings. > > >> > > > > > > > > > >> > > > > > > > Signed-off-by: Ravi Kerur > > >> > > > > > > > --- > > >> > > > > > > > lib/librte_eal/bsdapp/eal/Makefile| 2 +- > > >> > > > > > > > lib/librte_eal/bsdapp/eal/eal_thread.c| 152 > > >> > > > > > > -- > > >> > > > > > > > lib/librte_eal/common/eal_common_thread.c | 147 > > >> > > > > > > - > > >> > > > > > > > lib/librte_eal/linuxapp/eal/eal_thread.c | 152 > > >> > > > > > > +- > > >> > > > > > > > 4 files changed, 148 insertions(+), 305 deletions(-) > > >> > > > > > > > > > >> > > > > > > > diff --git a/lib/librte_eal/bsdapp/eal/Makefile > > >> > > > > > > b/lib/librte_eal/bsdapp/eal/Makefile > > >> > > > > > > > index 2357cfa..55971b9 100644 > > >> > > > > > > > --- a/lib/librte_eal/bsdapp/eal/Makefile > > >> > > > > > > > +++ b/lib/librte_eal/bsdapp/eal/Makefile > > >> > > > > > > > @@ -87,7 +87,7 @@ CFLAGS_eal_common_log.o := -D_GNU_SOURCE > > >> > > > > > > > # workaround for a gcc bug with noreturn attribute > > >> > > > > > > > # http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12603 > > >> > > > > > > > ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) > > >> > > > > > > > -CFLAGS_eal_thread.o += -Wno-return-type > > >> > > > > > > > +CFLAGS_eal_common_thread.o += -Wno-return-type > > >> > > > > > > > CFLAGS_eal_hpet.o += -Wno-return-type > > >> > > > > > > > endif > > >> > > > > > > > > > >> > > > > > > > diff --git a/lib/librte_eal/bsdapp/eal/eal_thread.c > > >> > > > > > > b/lib/librte_eal/bsdapp/eal/eal_thread.c > > >> > > > > > > > index 9a03437..5714b8f 100644 > > >> > > > > > > > --- a/lib/librte_eal/bsdapp/eal/eal_thread.c > > >> > > > > > > > +++ b/lib/librte_eal/bsdapp/eal/eal_thread.c > > >> > > > > > > > @@ -35,163 +35,11 @@ > > >> > > > > > > > #include > > >> > > > > > > > #include > > >> > > > > > > > #include > > >> > > > > > > > -#include > > >> > > > > > > > -#include > > >> > > > > > > > -#include > > >> > > > > > > > -#include > > >> > > > > > > > #include > > >> > > > > > > > > > >> > > > > > > > -#include > > >> > > > > > > > -#include > > >> > > > > > > > -#include > > >> > > > > > > > -#include > > >> > > > > > > > -#include > > >> > > > > > > > -#include > > >> > > > > > > > -#include > > >> > > > > > > > -#include > > >> > > > > > > > -#include > > >> > > > > > > > -#include > > >> > > > > > > > - > > >> > > > > > > > #include "eal_private.h" > > >> > > > > > > > #include "eal_thread.h" > > >> > > > > > > > > > >> > > > > > > > -RTE_DEFINE_PER_LCORE(unsigned,
[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c
On Fri, Apr 24, 2015 at 06:45:06PM -0700, Ravi Kerur wrote: > On Fri, Apr 24, 2015 at 2:24 PM, Ravi Kerur wrote: > > > > > > > On Fri, Apr 24, 2015 at 12:51 PM, Neil Horman > > wrote: > > > >> On Fri, Apr 24, 2015 at 12:21:23PM -0700, Ravi Kerur wrote: > >> > On Fri, Apr 24, 2015 at 11:53 AM, Neil Horman > >> wrote: > >> > > >> > > On Fri, Apr 24, 2015 at 09:45:24AM -0700, Ravi Kerur wrote: > >> > > > On Fri, Apr 24, 2015 at 8:22 AM, Neil Horman >> > > > tuxdriver.com > >> > > >> > > wrote: > >> > > > > >> > > > > On Fri, Apr 24, 2015 at 08:14:04AM -0700, Ravi Kerur wrote: > >> > > > > > On Fri, Apr 24, 2015 at 6:51 AM, Neil Horman < > >> nhorman at tuxdriver.com> > >> > > > > wrote: > >> > > > > > > >> > > > > > > On Thu, Apr 23, 2015 at 02:35:31PM -0700, Ravi Kerur wrote: > >> > > > > > > > Changes in v7 > >> > > > > > > > Remove _setname_ pthread calls. > >> > > > > > > > Use rte_gettid() API in RTE_LOG to print thread_id. > >> > > > > > > > > >> > > > > > > > Changes in v6 > >> > > > > > > > Remove RTE_EXEC_ENV_BSDAPP from eal_common_thread.c file. > >> > > > > > > > Add pthread_setname_np/pthread_set_name_np for Linux/FreeBSD > >> > > > > > > > respectively. Plan to use _getname_ in RTE_LOG when > >> available. > >> > > > > > > > Use existing rte_get_systid() in RTE_LOG to print thread_id. > >> > > > > > > > > >> > > > > > > > Changes in v5 > >> > > > > > > > Rebase to latest code. > >> > > > > > > > > >> > > > > > > > Changes in v4 > >> > > > > > > > None > >> > > > > > > > > >> > > > > > > > Changes in v3 > >> > > > > > > > Changed subject to be more explicit on file name inclusion. > >> > > > > > > > > >> > > > > > > > Changes in v2 > >> > > > > > > > None > >> > > > > > > > > >> > > > > > > > Changes in v1 > >> > > > > > > > eal_thread.c has minor differences between Linux and BSD, > >> move > >> > > > > > > > entire file into common directory. > >> > > > > > > > Use RTE_EXEC_ENV_BSDAPP to differentiate on minor > >> differences. > >> > > > > > > > Rename eal_thread.c to eal_common_thread.c > >> > > > > > > > Makefile changes to reflect file move and name change. > >> > > > > > > > Fix checkpatch warnings. > >> > > > > > > > > >> > > > > > > > Signed-off-by: Ravi Kerur > >> > > > > > > > --- > >> > > > > > > > lib/librte_eal/bsdapp/eal/Makefile| 2 +- > >> > > > > > > > lib/librte_eal/bsdapp/eal/eal_thread.c| 152 > >> > > > > > > -- > >> > > > > > > > lib/librte_eal/common/eal_common_thread.c | 147 > >> > > > > > > - > >> > > > > > > > lib/librte_eal/linuxapp/eal/eal_thread.c | 152 > >> > > > > > > +- > >> > > > > > > > 4 files changed, 148 insertions(+), 305 deletions(-) > >> > > > > > > > > >> > > > > > > > diff --git a/lib/librte_eal/bsdapp/eal/Makefile > >> > > > > > > b/lib/librte_eal/bsdapp/eal/Makefile > >> > > > > > > > index 2357cfa..55971b9 100644 > >> > > > > > > > --- a/lib/librte_eal/bsdapp/eal/Makefile > >> > > > > > > > +++ b/lib/librte_eal/bsdapp/eal/Makefile > >> > > > > > > > @@ -87,7 +87,7 @@ CFLAGS_eal_common_log.o := -D_GNU_SOURCE > >> > > > > > > > # workaround for a gcc bug with noreturn attribute > >> > > > > > > > # http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12603 > >> > > > > > > > ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) > >> > > > > > > > -CFLAGS_eal_thread.o += -Wno-return-type > >> > > > > > > > +CFLAGS_eal_common_thread.o += -Wno-return-type > >> > > > > > > > CFLAGS_eal_hpet.o += -Wno-return-type > >> > > > > > > > endif > >> > > > > > > > > >> > > > > > > > diff --git a/lib/librte_eal/bsdapp/eal/eal_thread.c > >> > > > > > > b/lib/librte_eal/bsdapp/eal/eal_thread.c > >> > > > > > > > index 9a03437..5714b8f 100644 > >> > > > > > > > --- a/lib/librte_eal/bsdapp/eal/eal_thread.c > >> > > > > > > > +++ b/lib/librte_eal/bsdapp/eal/eal_thread.c > >> > > > > > > > @@ -35,163 +35,11 @@ > >> > > > > > > > #include > >> > > > > > > > #include > >> > > > > > > > #include > >> > > > > > > > -#include > >> > > > > > > > -#include > >> > > > > > > > -#include > >> > > > > > > > -#include > >> > > > > > > > #include > >> > > > > > > > > >> > > > > > > > -#include > >> > > > > > > > -#include > >> > > > > > > > -#include > >> > > > > > > > -#include > >> > > > > > > > -#include > >> > > > > > > > -#include > >> > > > > > > > -#include > >> > > > > > > > -#include > >> > > > > > > > -#include > >> > > > > > > > -#include > >> > > > > > > > - > >> > > > > > > > #include "eal_private.h" > >> > > > > > > > #include "eal_thread.h" > >> > > > > > > > > >> > > > > > > > -RTE_DEFINE_PER_LCORE(unsigned, _lcore_id) = LCORE_ID_ANY; > >> > > > > > > NAK, these are exported symbols, you can't remove them without > >> > > going > >> > > > > > > through the > >> > > > > > > deprecation process. > >> > > > > > > > >> > > > > > > > >> > > > > > They are not removed/deleted, they are moved from eal_thread.c > >> to > >> > > > > > eal_common_thread.c file since it
[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c
On Fri, Apr 24, 2015 at 2:24 PM, Ravi Kerur wrote: > > > On Fri, Apr 24, 2015 at 12:51 PM, Neil Horman > wrote: > >> On Fri, Apr 24, 2015 at 12:21:23PM -0700, Ravi Kerur wrote: >> > On Fri, Apr 24, 2015 at 11:53 AM, Neil Horman >> wrote: >> > >> > > On Fri, Apr 24, 2015 at 09:45:24AM -0700, Ravi Kerur wrote: >> > > > On Fri, Apr 24, 2015 at 8:22 AM, Neil Horman > > >> > > wrote: >> > > > >> > > > > On Fri, Apr 24, 2015 at 08:14:04AM -0700, Ravi Kerur wrote: >> > > > > > On Fri, Apr 24, 2015 at 6:51 AM, Neil Horman < >> nhorman at tuxdriver.com> >> > > > > wrote: >> > > > > > >> > > > > > > On Thu, Apr 23, 2015 at 02:35:31PM -0700, Ravi Kerur wrote: >> > > > > > > > Changes in v7 >> > > > > > > > Remove _setname_ pthread calls. >> > > > > > > > Use rte_gettid() API in RTE_LOG to print thread_id. >> > > > > > > > >> > > > > > > > Changes in v6 >> > > > > > > > Remove RTE_EXEC_ENV_BSDAPP from eal_common_thread.c file. >> > > > > > > > Add pthread_setname_np/pthread_set_name_np for Linux/FreeBSD >> > > > > > > > respectively. Plan to use _getname_ in RTE_LOG when >> available. >> > > > > > > > Use existing rte_get_systid() in RTE_LOG to print thread_id. >> > > > > > > > >> > > > > > > > Changes in v5 >> > > > > > > > Rebase to latest code. >> > > > > > > > >> > > > > > > > Changes in v4 >> > > > > > > > None >> > > > > > > > >> > > > > > > > Changes in v3 >> > > > > > > > Changed subject to be more explicit on file name inclusion. >> > > > > > > > >> > > > > > > > Changes in v2 >> > > > > > > > None >> > > > > > > > >> > > > > > > > Changes in v1 >> > > > > > > > eal_thread.c has minor differences between Linux and BSD, >> move >> > > > > > > > entire file into common directory. >> > > > > > > > Use RTE_EXEC_ENV_BSDAPP to differentiate on minor >> differences. >> > > > > > > > Rename eal_thread.c to eal_common_thread.c >> > > > > > > > Makefile changes to reflect file move and name change. >> > > > > > > > Fix checkpatch warnings. >> > > > > > > > >> > > > > > > > Signed-off-by: Ravi Kerur >> > > > > > > > --- >> > > > > > > > lib/librte_eal/bsdapp/eal/Makefile| 2 +- >> > > > > > > > lib/librte_eal/bsdapp/eal/eal_thread.c| 152 >> > > > > > > -- >> > > > > > > > lib/librte_eal/common/eal_common_thread.c | 147 >> > > > > > > - >> > > > > > > > lib/librte_eal/linuxapp/eal/eal_thread.c | 152 >> > > > > > > +- >> > > > > > > > 4 files changed, 148 insertions(+), 305 deletions(-) >> > > > > > > > >> > > > > > > > diff --git a/lib/librte_eal/bsdapp/eal/Makefile >> > > > > > > b/lib/librte_eal/bsdapp/eal/Makefile >> > > > > > > > index 2357cfa..55971b9 100644 >> > > > > > > > --- a/lib/librte_eal/bsdapp/eal/Makefile >> > > > > > > > +++ b/lib/librte_eal/bsdapp/eal/Makefile >> > > > > > > > @@ -87,7 +87,7 @@ CFLAGS_eal_common_log.o := -D_GNU_SOURCE >> > > > > > > > # workaround for a gcc bug with noreturn attribute >> > > > > > > > # http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12603 >> > > > > > > > ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) >> > > > > > > > -CFLAGS_eal_thread.o += -Wno-return-type >> > > > > > > > +CFLAGS_eal_common_thread.o += -Wno-return-type >> > > > > > > > CFLAGS_eal_hpet.o += -Wno-return-type >> > > > > > > > endif >> > > > > > > > >> > > > > > > > diff --git a/lib/librte_eal/bsdapp/eal/eal_thread.c >> > > > > > > b/lib/librte_eal/bsdapp/eal/eal_thread.c >> > > > > > > > index 9a03437..5714b8f 100644 >> > > > > > > > --- a/lib/librte_eal/bsdapp/eal/eal_thread.c >> > > > > > > > +++ b/lib/librte_eal/bsdapp/eal/eal_thread.c >> > > > > > > > @@ -35,163 +35,11 @@ >> > > > > > > > #include >> > > > > > > > #include >> > > > > > > > #include >> > > > > > > > -#include >> > > > > > > > -#include >> > > > > > > > -#include >> > > > > > > > -#include >> > > > > > > > #include >> > > > > > > > >> > > > > > > > -#include >> > > > > > > > -#include >> > > > > > > > -#include >> > > > > > > > -#include >> > > > > > > > -#include >> > > > > > > > -#include >> > > > > > > > -#include >> > > > > > > > -#include >> > > > > > > > -#include >> > > > > > > > -#include >> > > > > > > > - >> > > > > > > > #include "eal_private.h" >> > > > > > > > #include "eal_thread.h" >> > > > > > > > >> > > > > > > > -RTE_DEFINE_PER_LCORE(unsigned, _lcore_id) = LCORE_ID_ANY; >> > > > > > > NAK, these are exported symbols, you can't remove them without >> > > going >> > > > > > > through the >> > > > > > > deprecation process. >> > > > > > > >> > > > > > > >> > > > > > They are not removed/deleted, they are moved from eal_thread.c >> to >> > > > > > eal_common_thread.c file since it is common to both Linux and >> BSD. >> > > > > > >> > > > > Then perhaps you forgot to export the symbol? Its showing up as >> > > removed >> > > > > on the >> > > > > ABI checker utility. >> > > > > >> > > > > Neil >> > > > > >> > > > >> > > > Can you please show me in the current code where it is being >> exported? I >>
[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c
On Fri, Apr 24, 2015 at 12:21:23PM -0700, Ravi Kerur wrote: > On Fri, Apr 24, 2015 at 11:53 AM, Neil Horman > wrote: > > > On Fri, Apr 24, 2015 at 09:45:24AM -0700, Ravi Kerur wrote: > > > On Fri, Apr 24, 2015 at 8:22 AM, Neil Horman > > wrote: > > > > > > > On Fri, Apr 24, 2015 at 08:14:04AM -0700, Ravi Kerur wrote: > > > > > On Fri, Apr 24, 2015 at 6:51 AM, Neil Horman > > > > tuxdriver.com> > > > > wrote: > > > > > > > > > > > On Thu, Apr 23, 2015 at 02:35:31PM -0700, Ravi Kerur wrote: > > > > > > > Changes in v7 > > > > > > > Remove _setname_ pthread calls. > > > > > > > Use rte_gettid() API in RTE_LOG to print thread_id. > > > > > > > > > > > > > > Changes in v6 > > > > > > > Remove RTE_EXEC_ENV_BSDAPP from eal_common_thread.c file. > > > > > > > Add pthread_setname_np/pthread_set_name_np for Linux/FreeBSD > > > > > > > respectively. Plan to use _getname_ in RTE_LOG when available. > > > > > > > Use existing rte_get_systid() in RTE_LOG to print thread_id. > > > > > > > > > > > > > > Changes in v5 > > > > > > > Rebase to latest code. > > > > > > > > > > > > > > Changes in v4 > > > > > > > None > > > > > > > > > > > > > > Changes in v3 > > > > > > > Changed subject to be more explicit on file name inclusion. > > > > > > > > > > > > > > Changes in v2 > > > > > > > None > > > > > > > > > > > > > > Changes in v1 > > > > > > > eal_thread.c has minor differences between Linux and BSD, move > > > > > > > entire file into common directory. > > > > > > > Use RTE_EXEC_ENV_BSDAPP to differentiate on minor differences. > > > > > > > Rename eal_thread.c to eal_common_thread.c > > > > > > > Makefile changes to reflect file move and name change. > > > > > > > Fix checkpatch warnings. > > > > > > > > > > > > > > Signed-off-by: Ravi Kerur > > > > > > > --- > > > > > > > lib/librte_eal/bsdapp/eal/Makefile| 2 +- > > > > > > > lib/librte_eal/bsdapp/eal/eal_thread.c| 152 > > > > > > -- > > > > > > > lib/librte_eal/common/eal_common_thread.c | 147 > > > > > > - > > > > > > > lib/librte_eal/linuxapp/eal/eal_thread.c | 152 > > > > > > +- > > > > > > > 4 files changed, 148 insertions(+), 305 deletions(-) > > > > > > > > > > > > > > diff --git a/lib/librte_eal/bsdapp/eal/Makefile > > > > > > b/lib/librte_eal/bsdapp/eal/Makefile > > > > > > > index 2357cfa..55971b9 100644 > > > > > > > --- a/lib/librte_eal/bsdapp/eal/Makefile > > > > > > > +++ b/lib/librte_eal/bsdapp/eal/Makefile > > > > > > > @@ -87,7 +87,7 @@ CFLAGS_eal_common_log.o := -D_GNU_SOURCE > > > > > > > # workaround for a gcc bug with noreturn attribute > > > > > > > # http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12603 > > > > > > > ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) > > > > > > > -CFLAGS_eal_thread.o += -Wno-return-type > > > > > > > +CFLAGS_eal_common_thread.o += -Wno-return-type > > > > > > > CFLAGS_eal_hpet.o += -Wno-return-type > > > > > > > endif > > > > > > > > > > > > > > diff --git a/lib/librte_eal/bsdapp/eal/eal_thread.c > > > > > > b/lib/librte_eal/bsdapp/eal/eal_thread.c > > > > > > > index 9a03437..5714b8f 100644 > > > > > > > --- a/lib/librte_eal/bsdapp/eal/eal_thread.c > > > > > > > +++ b/lib/librte_eal/bsdapp/eal/eal_thread.c > > > > > > > @@ -35,163 +35,11 @@ > > > > > > > #include > > > > > > > #include > > > > > > > #include > > > > > > > -#include > > > > > > > -#include > > > > > > > -#include > > > > > > > -#include > > > > > > > #include > > > > > > > > > > > > > > -#include > > > > > > > -#include > > > > > > > -#include > > > > > > > -#include > > > > > > > -#include > > > > > > > -#include > > > > > > > -#include > > > > > > > -#include > > > > > > > -#include > > > > > > > -#include > > > > > > > - > > > > > > > #include "eal_private.h" > > > > > > > #include "eal_thread.h" > > > > > > > > > > > > > > -RTE_DEFINE_PER_LCORE(unsigned, _lcore_id) = LCORE_ID_ANY; > > > > > > NAK, these are exported symbols, you can't remove them without > > going > > > > > > through the > > > > > > deprecation process. > > > > > > > > > > > > > > > > > They are not removed/deleted, they are moved from eal_thread.c to > > > > > eal_common_thread.c file since it is common to both Linux and BSD. > > > > > > > > > Then perhaps you forgot to export the symbol? Its showing up as > > removed > > > > on the > > > > ABI checker utility. > > > > > > > > Neil > > > > > > > > > > Can you please show me in the current code where it is being exported? I > > > have only moved definitions to _common_ files, not sure why it should be > > > exported now. I searched in the current code for RTE_DEFINE_PER_LCORE > > > > > > #home/rkerur/dpdk-tmp/dpdk# grep -ir RTE_DEFINE_PER_LCORE * > > > app/test/test_per_lcore.c:static RTE_DEFINE_PER_LCORE(unsigned, test) = > > > 0x12345678; > > > lib/librte_eal/linuxapp/eal/eal_thread.c:RTE_DEFINE_PER_LCORE(unsigned, > > > _lcore_id) = LCORE_ID_ANY; > > >
[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c
On Fri, Apr 24, 2015 at 09:45:24AM -0700, Ravi Kerur wrote: > On Fri, Apr 24, 2015 at 8:22 AM, Neil Horman wrote: > > > On Fri, Apr 24, 2015 at 08:14:04AM -0700, Ravi Kerur wrote: > > > On Fri, Apr 24, 2015 at 6:51 AM, Neil Horman > > wrote: > > > > > > > On Thu, Apr 23, 2015 at 02:35:31PM -0700, Ravi Kerur wrote: > > > > > Changes in v7 > > > > > Remove _setname_ pthread calls. > > > > > Use rte_gettid() API in RTE_LOG to print thread_id. > > > > > > > > > > Changes in v6 > > > > > Remove RTE_EXEC_ENV_BSDAPP from eal_common_thread.c file. > > > > > Add pthread_setname_np/pthread_set_name_np for Linux/FreeBSD > > > > > respectively. Plan to use _getname_ in RTE_LOG when available. > > > > > Use existing rte_get_systid() in RTE_LOG to print thread_id. > > > > > > > > > > Changes in v5 > > > > > Rebase to latest code. > > > > > > > > > > Changes in v4 > > > > > None > > > > > > > > > > Changes in v3 > > > > > Changed subject to be more explicit on file name inclusion. > > > > > > > > > > Changes in v2 > > > > > None > > > > > > > > > > Changes in v1 > > > > > eal_thread.c has minor differences between Linux and BSD, move > > > > > entire file into common directory. > > > > > Use RTE_EXEC_ENV_BSDAPP to differentiate on minor differences. > > > > > Rename eal_thread.c to eal_common_thread.c > > > > > Makefile changes to reflect file move and name change. > > > > > Fix checkpatch warnings. > > > > > > > > > > Signed-off-by: Ravi Kerur > > > > > --- > > > > > lib/librte_eal/bsdapp/eal/Makefile| 2 +- > > > > > lib/librte_eal/bsdapp/eal/eal_thread.c| 152 > > > > -- > > > > > lib/librte_eal/common/eal_common_thread.c | 147 > > > > - > > > > > lib/librte_eal/linuxapp/eal/eal_thread.c | 152 > > > > +- > > > > > 4 files changed, 148 insertions(+), 305 deletions(-) > > > > > > > > > > diff --git a/lib/librte_eal/bsdapp/eal/Makefile > > > > b/lib/librte_eal/bsdapp/eal/Makefile > > > > > index 2357cfa..55971b9 100644 > > > > > --- a/lib/librte_eal/bsdapp/eal/Makefile > > > > > +++ b/lib/librte_eal/bsdapp/eal/Makefile > > > > > @@ -87,7 +87,7 @@ CFLAGS_eal_common_log.o := -D_GNU_SOURCE > > > > > # workaround for a gcc bug with noreturn attribute > > > > > # http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12603 > > > > > ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) > > > > > -CFLAGS_eal_thread.o += -Wno-return-type > > > > > +CFLAGS_eal_common_thread.o += -Wno-return-type > > > > > CFLAGS_eal_hpet.o += -Wno-return-type > > > > > endif > > > > > > > > > > diff --git a/lib/librte_eal/bsdapp/eal/eal_thread.c > > > > b/lib/librte_eal/bsdapp/eal/eal_thread.c > > > > > index 9a03437..5714b8f 100644 > > > > > --- a/lib/librte_eal/bsdapp/eal/eal_thread.c > > > > > +++ b/lib/librte_eal/bsdapp/eal/eal_thread.c > > > > > @@ -35,163 +35,11 @@ > > > > > #include > > > > > #include > > > > > #include > > > > > -#include > > > > > -#include > > > > > -#include > > > > > -#include > > > > > #include > > > > > > > > > > -#include > > > > > -#include > > > > > -#include > > > > > -#include > > > > > -#include > > > > > -#include > > > > > -#include > > > > > -#include > > > > > -#include > > > > > -#include > > > > > - > > > > > #include "eal_private.h" > > > > > #include "eal_thread.h" > > > > > > > > > > -RTE_DEFINE_PER_LCORE(unsigned, _lcore_id) = LCORE_ID_ANY; > > > > NAK, these are exported symbols, you can't remove them without going > > > > through the > > > > deprecation process. > > > > > > > > > > > They are not removed/deleted, they are moved from eal_thread.c to > > > eal_common_thread.c file since it is common to both Linux and BSD. > > > > > Then perhaps you forgot to export the symbol? Its showing up as removed > > on the > > ABI checker utility. > > > > Neil > > > > Can you please show me in the current code where it is being exported? I > have only moved definitions to _common_ files, not sure why it should be > exported now. I searched in the current code for RTE_DEFINE_PER_LCORE > > #home/rkerur/dpdk-tmp/dpdk# grep -ir RTE_DEFINE_PER_LCORE * > app/test/test_per_lcore.c:static RTE_DEFINE_PER_LCORE(unsigned, test) = > 0x12345678; > lib/librte_eal/linuxapp/eal/eal_thread.c:RTE_DEFINE_PER_LCORE(unsigned, > _lcore_id) = LCORE_ID_ANY; > lib/librte_eal/linuxapp/eal/eal_thread.c:RTE_DEFINE_PER_LCORE(unsigned, > _socket_id) = (unsigned)SOCKET_ID_ANY; > lib/librte_eal/linuxapp/eal/eal_thread.c:RTE_DEFINE_PER_LCORE(rte_cpuset_t, > _cpuset); > lib/librte_eal/bsdapp/eal/eal_thread.c:RTE_DEFINE_PER_LCORE(unsigned, > _lcore_id) = LCORE_ID_ANY; > lib/librte_eal/bsdapp/eal/eal_thread.c:RTE_DEFINE_PER_LCORE(unsigned, > _socket_id) = (unsigned)SOCKET_ID_ANY; > lib/librte_eal/bsdapp/eal/eal_thread.c:RTE_DEFINE_PER_LCORE(rte_cpuset_t, > _cpuset); > lib/librte_eal/common/include/rte_per_lcore.h:#define > RTE_DEFINE_PER_LCORE(type, name)\ > lib/librte_eal/common/include/rte_eal.h:static >
[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c
On Fri, Apr 24, 2015 at 11:53 AM, Neil Horman wrote: > On Fri, Apr 24, 2015 at 09:45:24AM -0700, Ravi Kerur wrote: > > On Fri, Apr 24, 2015 at 8:22 AM, Neil Horman > wrote: > > > > > On Fri, Apr 24, 2015 at 08:14:04AM -0700, Ravi Kerur wrote: > > > > On Fri, Apr 24, 2015 at 6:51 AM, Neil Horman > > > wrote: > > > > > > > > > On Thu, Apr 23, 2015 at 02:35:31PM -0700, Ravi Kerur wrote: > > > > > > Changes in v7 > > > > > > Remove _setname_ pthread calls. > > > > > > Use rte_gettid() API in RTE_LOG to print thread_id. > > > > > > > > > > > > Changes in v6 > > > > > > Remove RTE_EXEC_ENV_BSDAPP from eal_common_thread.c file. > > > > > > Add pthread_setname_np/pthread_set_name_np for Linux/FreeBSD > > > > > > respectively. Plan to use _getname_ in RTE_LOG when available. > > > > > > Use existing rte_get_systid() in RTE_LOG to print thread_id. > > > > > > > > > > > > Changes in v5 > > > > > > Rebase to latest code. > > > > > > > > > > > > Changes in v4 > > > > > > None > > > > > > > > > > > > Changes in v3 > > > > > > Changed subject to be more explicit on file name inclusion. > > > > > > > > > > > > Changes in v2 > > > > > > None > > > > > > > > > > > > Changes in v1 > > > > > > eal_thread.c has minor differences between Linux and BSD, move > > > > > > entire file into common directory. > > > > > > Use RTE_EXEC_ENV_BSDAPP to differentiate on minor differences. > > > > > > Rename eal_thread.c to eal_common_thread.c > > > > > > Makefile changes to reflect file move and name change. > > > > > > Fix checkpatch warnings. > > > > > > > > > > > > Signed-off-by: Ravi Kerur > > > > > > --- > > > > > > lib/librte_eal/bsdapp/eal/Makefile| 2 +- > > > > > > lib/librte_eal/bsdapp/eal/eal_thread.c| 152 > > > > > -- > > > > > > lib/librte_eal/common/eal_common_thread.c | 147 > > > > > - > > > > > > lib/librte_eal/linuxapp/eal/eal_thread.c | 152 > > > > > +- > > > > > > 4 files changed, 148 insertions(+), 305 deletions(-) > > > > > > > > > > > > diff --git a/lib/librte_eal/bsdapp/eal/Makefile > > > > > b/lib/librte_eal/bsdapp/eal/Makefile > > > > > > index 2357cfa..55971b9 100644 > > > > > > --- a/lib/librte_eal/bsdapp/eal/Makefile > > > > > > +++ b/lib/librte_eal/bsdapp/eal/Makefile > > > > > > @@ -87,7 +87,7 @@ CFLAGS_eal_common_log.o := -D_GNU_SOURCE > > > > > > # workaround for a gcc bug with noreturn attribute > > > > > > # http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12603 > > > > > > ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) > > > > > > -CFLAGS_eal_thread.o += -Wno-return-type > > > > > > +CFLAGS_eal_common_thread.o += -Wno-return-type > > > > > > CFLAGS_eal_hpet.o += -Wno-return-type > > > > > > endif > > > > > > > > > > > > diff --git a/lib/librte_eal/bsdapp/eal/eal_thread.c > > > > > b/lib/librte_eal/bsdapp/eal/eal_thread.c > > > > > > index 9a03437..5714b8f 100644 > > > > > > --- a/lib/librte_eal/bsdapp/eal/eal_thread.c > > > > > > +++ b/lib/librte_eal/bsdapp/eal/eal_thread.c > > > > > > @@ -35,163 +35,11 @@ > > > > > > #include > > > > > > #include > > > > > > #include > > > > > > -#include > > > > > > -#include > > > > > > -#include > > > > > > -#include > > > > > > #include > > > > > > > > > > > > -#include > > > > > > -#include > > > > > > -#include > > > > > > -#include > > > > > > -#include > > > > > > -#include > > > > > > -#include > > > > > > -#include > > > > > > -#include > > > > > > -#include > > > > > > - > > > > > > #include "eal_private.h" > > > > > > #include "eal_thread.h" > > > > > > > > > > > > -RTE_DEFINE_PER_LCORE(unsigned, _lcore_id) = LCORE_ID_ANY; > > > > > NAK, these are exported symbols, you can't remove them without > going > > > > > through the > > > > > deprecation process. > > > > > > > > > > > > > > They are not removed/deleted, they are moved from eal_thread.c to > > > > eal_common_thread.c file since it is common to both Linux and BSD. > > > > > > > Then perhaps you forgot to export the symbol? Its showing up as > removed > > > on the > > > ABI checker utility. > > > > > > Neil > > > > > > > Can you please show me in the current code where it is being exported? I > > have only moved definitions to _common_ files, not sure why it should be > > exported now. I searched in the current code for RTE_DEFINE_PER_LCORE > > > > #home/rkerur/dpdk-tmp/dpdk# grep -ir RTE_DEFINE_PER_LCORE * > > app/test/test_per_lcore.c:static RTE_DEFINE_PER_LCORE(unsigned, test) = > > 0x12345678; > > lib/librte_eal/linuxapp/eal/eal_thread.c:RTE_DEFINE_PER_LCORE(unsigned, > > _lcore_id) = LCORE_ID_ANY; > > lib/librte_eal/linuxapp/eal/eal_thread.c:RTE_DEFINE_PER_LCORE(unsigned, > > _socket_id) = (unsigned)SOCKET_ID_ANY; > > > lib/librte_eal/linuxapp/eal/eal_thread.c:RTE_DEFINE_PER_LCORE(rte_cpuset_t, > > _cpuset); > > lib/librte_eal/bsdapp/eal/eal_thread.c:RTE_DEFINE_PER_LCORE(unsigned, > > _lcore_id) = LCORE_ID_ANY; > >
[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c
On Fri, Apr 24, 2015 at 08:14:04AM -0700, Ravi Kerur wrote: > On Fri, Apr 24, 2015 at 6:51 AM, Neil Horman wrote: > > > On Thu, Apr 23, 2015 at 02:35:31PM -0700, Ravi Kerur wrote: > > > Changes in v7 > > > Remove _setname_ pthread calls. > > > Use rte_gettid() API in RTE_LOG to print thread_id. > > > > > > Changes in v6 > > > Remove RTE_EXEC_ENV_BSDAPP from eal_common_thread.c file. > > > Add pthread_setname_np/pthread_set_name_np for Linux/FreeBSD > > > respectively. Plan to use _getname_ in RTE_LOG when available. > > > Use existing rte_get_systid() in RTE_LOG to print thread_id. > > > > > > Changes in v5 > > > Rebase to latest code. > > > > > > Changes in v4 > > > None > > > > > > Changes in v3 > > > Changed subject to be more explicit on file name inclusion. > > > > > > Changes in v2 > > > None > > > > > > Changes in v1 > > > eal_thread.c has minor differences between Linux and BSD, move > > > entire file into common directory. > > > Use RTE_EXEC_ENV_BSDAPP to differentiate on minor differences. > > > Rename eal_thread.c to eal_common_thread.c > > > Makefile changes to reflect file move and name change. > > > Fix checkpatch warnings. > > > > > > Signed-off-by: Ravi Kerur > > > --- > > > lib/librte_eal/bsdapp/eal/Makefile| 2 +- > > > lib/librte_eal/bsdapp/eal/eal_thread.c| 152 > > -- > > > lib/librte_eal/common/eal_common_thread.c | 147 > > - > > > lib/librte_eal/linuxapp/eal/eal_thread.c | 152 > > +- > > > 4 files changed, 148 insertions(+), 305 deletions(-) > > > > > > diff --git a/lib/librte_eal/bsdapp/eal/Makefile > > b/lib/librte_eal/bsdapp/eal/Makefile > > > index 2357cfa..55971b9 100644 > > > --- a/lib/librte_eal/bsdapp/eal/Makefile > > > +++ b/lib/librte_eal/bsdapp/eal/Makefile > > > @@ -87,7 +87,7 @@ CFLAGS_eal_common_log.o := -D_GNU_SOURCE > > > # workaround for a gcc bug with noreturn attribute > > > # http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12603 > > > ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) > > > -CFLAGS_eal_thread.o += -Wno-return-type > > > +CFLAGS_eal_common_thread.o += -Wno-return-type > > > CFLAGS_eal_hpet.o += -Wno-return-type > > > endif > > > > > > diff --git a/lib/librte_eal/bsdapp/eal/eal_thread.c > > b/lib/librte_eal/bsdapp/eal/eal_thread.c > > > index 9a03437..5714b8f 100644 > > > --- a/lib/librte_eal/bsdapp/eal/eal_thread.c > > > +++ b/lib/librte_eal/bsdapp/eal/eal_thread.c > > > @@ -35,163 +35,11 @@ > > > #include > > > #include > > > #include > > > -#include > > > -#include > > > -#include > > > -#include > > > #include > > > > > > -#include > > > -#include > > > -#include > > > -#include > > > -#include > > > -#include > > > -#include > > > -#include > > > -#include > > > -#include > > > - > > > #include "eal_private.h" > > > #include "eal_thread.h" > > > > > > -RTE_DEFINE_PER_LCORE(unsigned, _lcore_id) = LCORE_ID_ANY; > > NAK, these are exported symbols, you can't remove them without going > > through the > > deprecation process. > > > > > They are not removed/deleted, they are moved from eal_thread.c to > eal_common_thread.c file since it is common to both Linux and BSD. > Then perhaps you forgot to export the symbol? Its showing up as removed on the ABI checker utility. Neil > Thanks > Ravi > > Regards > > Neil > > > >
[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c
On Thu, Apr 23, 2015 at 02:35:31PM -0700, Ravi Kerur wrote: > Changes in v7 > Remove _setname_ pthread calls. > Use rte_gettid() API in RTE_LOG to print thread_id. > > Changes in v6 > Remove RTE_EXEC_ENV_BSDAPP from eal_common_thread.c file. > Add pthread_setname_np/pthread_set_name_np for Linux/FreeBSD > respectively. Plan to use _getname_ in RTE_LOG when available. > Use existing rte_get_systid() in RTE_LOG to print thread_id. > > Changes in v5 > Rebase to latest code. > > Changes in v4 > None > > Changes in v3 > Changed subject to be more explicit on file name inclusion. > > Changes in v2 > None > > Changes in v1 > eal_thread.c has minor differences between Linux and BSD, move > entire file into common directory. > Use RTE_EXEC_ENV_BSDAPP to differentiate on minor differences. > Rename eal_thread.c to eal_common_thread.c > Makefile changes to reflect file move and name change. > Fix checkpatch warnings. > > Signed-off-by: Ravi Kerur > --- > lib/librte_eal/bsdapp/eal/Makefile| 2 +- > lib/librte_eal/bsdapp/eal/eal_thread.c| 152 > -- > lib/librte_eal/common/eal_common_thread.c | 147 - > lib/librte_eal/linuxapp/eal/eal_thread.c | 152 > +- > 4 files changed, 148 insertions(+), 305 deletions(-) > > diff --git a/lib/librte_eal/bsdapp/eal/Makefile > b/lib/librte_eal/bsdapp/eal/Makefile > index 2357cfa..55971b9 100644 > --- a/lib/librte_eal/bsdapp/eal/Makefile > +++ b/lib/librte_eal/bsdapp/eal/Makefile > @@ -87,7 +87,7 @@ CFLAGS_eal_common_log.o := -D_GNU_SOURCE > # workaround for a gcc bug with noreturn attribute > # http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12603 > ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) > -CFLAGS_eal_thread.o += -Wno-return-type > +CFLAGS_eal_common_thread.o += -Wno-return-type > CFLAGS_eal_hpet.o += -Wno-return-type > endif > > diff --git a/lib/librte_eal/bsdapp/eal/eal_thread.c > b/lib/librte_eal/bsdapp/eal/eal_thread.c > index 9a03437..5714b8f 100644 > --- a/lib/librte_eal/bsdapp/eal/eal_thread.c > +++ b/lib/librte_eal/bsdapp/eal/eal_thread.c > @@ -35,163 +35,11 @@ > #include > #include > #include > -#include > -#include > -#include > -#include > #include > > -#include > -#include > -#include > -#include > -#include > -#include > -#include > -#include > -#include > -#include > - > #include "eal_private.h" > #include "eal_thread.h" > > -RTE_DEFINE_PER_LCORE(unsigned, _lcore_id) = LCORE_ID_ANY; NAK, these are exported symbols, you can't remove them without going through the deprecation process. Regards Neil
[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c
On Fri, Apr 24, 2015 at 8:22 AM, Neil Horman wrote: > On Fri, Apr 24, 2015 at 08:14:04AM -0700, Ravi Kerur wrote: > > On Fri, Apr 24, 2015 at 6:51 AM, Neil Horman > wrote: > > > > > On Thu, Apr 23, 2015 at 02:35:31PM -0700, Ravi Kerur wrote: > > > > Changes in v7 > > > > Remove _setname_ pthread calls. > > > > Use rte_gettid() API in RTE_LOG to print thread_id. > > > > > > > > Changes in v6 > > > > Remove RTE_EXEC_ENV_BSDAPP from eal_common_thread.c file. > > > > Add pthread_setname_np/pthread_set_name_np for Linux/FreeBSD > > > > respectively. Plan to use _getname_ in RTE_LOG when available. > > > > Use existing rte_get_systid() in RTE_LOG to print thread_id. > > > > > > > > Changes in v5 > > > > Rebase to latest code. > > > > > > > > Changes in v4 > > > > None > > > > > > > > Changes in v3 > > > > Changed subject to be more explicit on file name inclusion. > > > > > > > > Changes in v2 > > > > None > > > > > > > > Changes in v1 > > > > eal_thread.c has minor differences between Linux and BSD, move > > > > entire file into common directory. > > > > Use RTE_EXEC_ENV_BSDAPP to differentiate on minor differences. > > > > Rename eal_thread.c to eal_common_thread.c > > > > Makefile changes to reflect file move and name change. > > > > Fix checkpatch warnings. > > > > > > > > Signed-off-by: Ravi Kerur > > > > --- > > > > lib/librte_eal/bsdapp/eal/Makefile| 2 +- > > > > lib/librte_eal/bsdapp/eal/eal_thread.c| 152 > > > -- > > > > lib/librte_eal/common/eal_common_thread.c | 147 > > > - > > > > lib/librte_eal/linuxapp/eal/eal_thread.c | 152 > > > +- > > > > 4 files changed, 148 insertions(+), 305 deletions(-) > > > > > > > > diff --git a/lib/librte_eal/bsdapp/eal/Makefile > > > b/lib/librte_eal/bsdapp/eal/Makefile > > > > index 2357cfa..55971b9 100644 > > > > --- a/lib/librte_eal/bsdapp/eal/Makefile > > > > +++ b/lib/librte_eal/bsdapp/eal/Makefile > > > > @@ -87,7 +87,7 @@ CFLAGS_eal_common_log.o := -D_GNU_SOURCE > > > > # workaround for a gcc bug with noreturn attribute > > > > # http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12603 > > > > ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) > > > > -CFLAGS_eal_thread.o += -Wno-return-type > > > > +CFLAGS_eal_common_thread.o += -Wno-return-type > > > > CFLAGS_eal_hpet.o += -Wno-return-type > > > > endif > > > > > > > > diff --git a/lib/librte_eal/bsdapp/eal/eal_thread.c > > > b/lib/librte_eal/bsdapp/eal/eal_thread.c > > > > index 9a03437..5714b8f 100644 > > > > --- a/lib/librte_eal/bsdapp/eal/eal_thread.c > > > > +++ b/lib/librte_eal/bsdapp/eal/eal_thread.c > > > > @@ -35,163 +35,11 @@ > > > > #include > > > > #include > > > > #include > > > > -#include > > > > -#include > > > > -#include > > > > -#include > > > > #include > > > > > > > > -#include > > > > -#include > > > > -#include > > > > -#include > > > > -#include > > > > -#include > > > > -#include > > > > -#include > > > > -#include > > > > -#include > > > > - > > > > #include "eal_private.h" > > > > #include "eal_thread.h" > > > > > > > > -RTE_DEFINE_PER_LCORE(unsigned, _lcore_id) = LCORE_ID_ANY; > > > NAK, these are exported symbols, you can't remove them without going > > > through the > > > deprecation process. > > > > > > > > They are not removed/deleted, they are moved from eal_thread.c to > > eal_common_thread.c file since it is common to both Linux and BSD. > > > Then perhaps you forgot to export the symbol? Its showing up as removed > on the > ABI checker utility. > > Neil > Can you please show me in the current code where it is being exported? I have only moved definitions to _common_ files, not sure why it should be exported now. I searched in the current code for RTE_DEFINE_PER_LCORE #home/rkerur/dpdk-tmp/dpdk# grep -ir RTE_DEFINE_PER_LCORE * app/test/test_per_lcore.c:static RTE_DEFINE_PER_LCORE(unsigned, test) = 0x12345678; lib/librte_eal/linuxapp/eal/eal_thread.c:RTE_DEFINE_PER_LCORE(unsigned, _lcore_id) = LCORE_ID_ANY; lib/librte_eal/linuxapp/eal/eal_thread.c:RTE_DEFINE_PER_LCORE(unsigned, _socket_id) = (unsigned)SOCKET_ID_ANY; lib/librte_eal/linuxapp/eal/eal_thread.c:RTE_DEFINE_PER_LCORE(rte_cpuset_t, _cpuset); lib/librte_eal/bsdapp/eal/eal_thread.c:RTE_DEFINE_PER_LCORE(unsigned, _lcore_id) = LCORE_ID_ANY; lib/librte_eal/bsdapp/eal/eal_thread.c:RTE_DEFINE_PER_LCORE(unsigned, _socket_id) = (unsigned)SOCKET_ID_ANY; lib/librte_eal/bsdapp/eal/eal_thread.c:RTE_DEFINE_PER_LCORE(rte_cpuset_t, _cpuset); lib/librte_eal/common/include/rte_per_lcore.h:#define RTE_DEFINE_PER_LCORE(type, name)\ lib/librte_eal/common/include/rte_eal.h:static RTE_DEFINE_PER_LCORE(int, _thread_id) = -1; lib/librte_eal/common/eal_common_errno.c:RTE_DEFINE_PER_LCORE(int, _rte_errno); lib/librte_eal/common/eal_common_errno.c:static RTE_DEFINE_PER_LCORE(char[RETVAL_SZ], retval); > > Thanks > > Ravi > > > > Regards > > > Neil > > > > > > >
[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c
On Fri, Apr 24, 2015 at 6:51 AM, Neil Horman wrote: > On Thu, Apr 23, 2015 at 02:35:31PM -0700, Ravi Kerur wrote: > > Changes in v7 > > Remove _setname_ pthread calls. > > Use rte_gettid() API in RTE_LOG to print thread_id. > > > > Changes in v6 > > Remove RTE_EXEC_ENV_BSDAPP from eal_common_thread.c file. > > Add pthread_setname_np/pthread_set_name_np for Linux/FreeBSD > > respectively. Plan to use _getname_ in RTE_LOG when available. > > Use existing rte_get_systid() in RTE_LOG to print thread_id. > > > > Changes in v5 > > Rebase to latest code. > > > > Changes in v4 > > None > > > > Changes in v3 > > Changed subject to be more explicit on file name inclusion. > > > > Changes in v2 > > None > > > > Changes in v1 > > eal_thread.c has minor differences between Linux and BSD, move > > entire file into common directory. > > Use RTE_EXEC_ENV_BSDAPP to differentiate on minor differences. > > Rename eal_thread.c to eal_common_thread.c > > Makefile changes to reflect file move and name change. > > Fix checkpatch warnings. > > > > Signed-off-by: Ravi Kerur > > --- > > lib/librte_eal/bsdapp/eal/Makefile| 2 +- > > lib/librte_eal/bsdapp/eal/eal_thread.c| 152 > -- > > lib/librte_eal/common/eal_common_thread.c | 147 > - > > lib/librte_eal/linuxapp/eal/eal_thread.c | 152 > +- > > 4 files changed, 148 insertions(+), 305 deletions(-) > > > > diff --git a/lib/librte_eal/bsdapp/eal/Makefile > b/lib/librte_eal/bsdapp/eal/Makefile > > index 2357cfa..55971b9 100644 > > --- a/lib/librte_eal/bsdapp/eal/Makefile > > +++ b/lib/librte_eal/bsdapp/eal/Makefile > > @@ -87,7 +87,7 @@ CFLAGS_eal_common_log.o := -D_GNU_SOURCE > > # workaround for a gcc bug with noreturn attribute > > # http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12603 > > ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) > > -CFLAGS_eal_thread.o += -Wno-return-type > > +CFLAGS_eal_common_thread.o += -Wno-return-type > > CFLAGS_eal_hpet.o += -Wno-return-type > > endif > > > > diff --git a/lib/librte_eal/bsdapp/eal/eal_thread.c > b/lib/librte_eal/bsdapp/eal/eal_thread.c > > index 9a03437..5714b8f 100644 > > --- a/lib/librte_eal/bsdapp/eal/eal_thread.c > > +++ b/lib/librte_eal/bsdapp/eal/eal_thread.c > > @@ -35,163 +35,11 @@ > > #include > > #include > > #include > > -#include > > -#include > > -#include > > -#include > > #include > > > > -#include > > -#include > > -#include > > -#include > > -#include > > -#include > > -#include > > -#include > > -#include > > -#include > > - > > #include "eal_private.h" > > #include "eal_thread.h" > > > > -RTE_DEFINE_PER_LCORE(unsigned, _lcore_id) = LCORE_ID_ANY; > NAK, these are exported symbols, you can't remove them without going > through the > deprecation process. > > They are not removed/deleted, they are moved from eal_thread.c to eal_common_thread.c file since it is common to both Linux and BSD. Thanks Ravi Regards > Neil > >
[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c
Changes in v7
Remove _setname_ pthread calls.
Use rte_gettid() API in RTE_LOG to print thread_id.
Changes in v6
Remove RTE_EXEC_ENV_BSDAPP from eal_common_thread.c file.
Add pthread_setname_np/pthread_set_name_np for Linux/FreeBSD
respectively. Plan to use _getname_ in RTE_LOG when available.
Use existing rte_get_systid() in RTE_LOG to print thread_id.
Changes in v5
Rebase to latest code.
Changes in v4
None
Changes in v3
Changed subject to be more explicit on file name inclusion.
Changes in v2
None
Changes in v1
eal_thread.c has minor differences between Linux and BSD, move
entire file into common directory.
Use RTE_EXEC_ENV_BSDAPP to differentiate on minor differences.
Rename eal_thread.c to eal_common_thread.c
Makefile changes to reflect file move and name change.
Fix checkpatch warnings.
Signed-off-by: Ravi Kerur
---
lib/librte_eal/bsdapp/eal/Makefile| 2 +-
lib/librte_eal/bsdapp/eal/eal_thread.c| 152 --
lib/librte_eal/common/eal_common_thread.c | 147 -
lib/librte_eal/linuxapp/eal/eal_thread.c | 152 +-
4 files changed, 148 insertions(+), 305 deletions(-)
diff --git a/lib/librte_eal/bsdapp/eal/Makefile
b/lib/librte_eal/bsdapp/eal/Makefile
index 2357cfa..55971b9 100644
--- a/lib/librte_eal/bsdapp/eal/Makefile
+++ b/lib/librte_eal/bsdapp/eal/Makefile
@@ -87,7 +87,7 @@ CFLAGS_eal_common_log.o := -D_GNU_SOURCE
# workaround for a gcc bug with noreturn attribute
# http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12603
ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y)
-CFLAGS_eal_thread.o += -Wno-return-type
+CFLAGS_eal_common_thread.o += -Wno-return-type
CFLAGS_eal_hpet.o += -Wno-return-type
endif
diff --git a/lib/librte_eal/bsdapp/eal/eal_thread.c
b/lib/librte_eal/bsdapp/eal/eal_thread.c
index 9a03437..5714b8f 100644
--- a/lib/librte_eal/bsdapp/eal/eal_thread.c
+++ b/lib/librte_eal/bsdapp/eal/eal_thread.c
@@ -35,163 +35,11 @@
#include
#include
#include
-#include
-#include
-#include
-#include
#include
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-
#include "eal_private.h"
#include "eal_thread.h"
-RTE_DEFINE_PER_LCORE(unsigned, _lcore_id) = LCORE_ID_ANY;
-RTE_DEFINE_PER_LCORE(unsigned, _socket_id) = (unsigned)SOCKET_ID_ANY;
-RTE_DEFINE_PER_LCORE(rte_cpuset_t, _cpuset);
-
-/*
- * Send a message to a slave lcore identified by slave_id to call a
- * function f with argument arg. Once the execution is done, the
- * remote lcore switch in FINISHED state.
- */
-int
-rte_eal_remote_launch(int (*f)(void *), void *arg, unsigned slave_id)
-{
- int n;
- char c = 0;
- int m2s = lcore_config[slave_id].pipe_master2slave[1];
- int s2m = lcore_config[slave_id].pipe_slave2master[0];
-
- if (lcore_config[slave_id].state != WAIT)
- return -EBUSY;
-
- lcore_config[slave_id].f = f;
- lcore_config[slave_id].arg = arg;
-
- /* send message */
- n = 0;
- while (n == 0 || (n < 0 && errno == EINTR))
- n = write(m2s, , 1);
- if (n < 0)
- rte_panic("cannot write on configuration pipe\n");
-
- /* wait ack */
- do {
- n = read(s2m, , 1);
- } while (n < 0 && errno == EINTR);
-
- if (n <= 0)
- rte_panic("cannot read on configuration pipe\n");
-
- return 0;
-}
-
-/* set affinity for current thread */
-static int
-eal_thread_set_affinity(void)
-{
- unsigned lcore_id = rte_lcore_id();
-
- /* acquire system unique id */
- rte_gettid();
-
- /* update EAL thread core affinity */
- return rte_thread_set_affinity(_config[lcore_id].cpuset);
-}
-
-void eal_thread_init_master(unsigned lcore_id)
-{
- /* set the lcore ID in per-lcore memory area */
- RTE_PER_LCORE(_lcore_id) = lcore_id;
-
- /* set CPU affinity */
- if (eal_thread_set_affinity() < 0)
- rte_panic("cannot set affinity\n");
-}
-
-/* main loop of threads */
-__attribute__((noreturn)) void *
-eal_thread_loop(__attribute__((unused)) void *arg)
-{
- char c;
- int n, ret;
- unsigned lcore_id;
- pthread_t thread_id;
- int m2s, s2m;
- char cpuset[RTE_CPU_AFFINITY_STR_LEN];
-
- thread_id = pthread_self();
-
- /* retrieve our lcore_id from the configuration structure */
- RTE_LCORE_FOREACH_SLAVE(lcore_id) {
- if (thread_id == lcore_config[lcore_id].thread_id)
- break;
- }
- if (lcore_id == RTE_MAX_LCORE)
- rte_panic("cannot retrieve lcore id\n");
-
- m2s = lcore_config[lcore_id].pipe_master2slave[0];
- s2m = lcore_config[lcore_id].pipe_slave2master[1];
-
- /* set the lcore ID in per-lcore memory area */
- RTE_PER_LCORE(_lcore_id) = lcore_id;
-
- /* set CPU affinity */
- if (eal_thread_set_affinity() < 0)
- rte_panic("cannot set
