[dpdk-dev] [PATCH v8 01/11] ethdev: add API to query supported packet types

2016-03-15 Thread Tan, Jianfeng
Hi,

On 3/15/2016 1:14 AM, Ferruh Yigit wrote:
> On 3/14/2016 7:42 AM, Jianfeng Tan wrote:
>> Add a new API rte_eth_dev_get_supported_ptypes to query what packet types
>> can be filled by given already started device (or its pmd rx burst function
>> has already been decided).
>>
>> Signed-off-by: Jianfeng Tan 
>> Acked-by: Konstantin Ananyev 
>> Acked-by: Adrien Mazarguil 
>> ---
> <...>
>
>> +DPDK_16.04 {
>> +rte_eth_dev_get_supported_ptypes;
> Other script files tends to put a blank line before function names.

Thank you for reminding.

>
>> +
>> +local: *;
> This line is not required.

Yes, actually, this leads to compiling error when 
CONFIG_RTE_BUILD_SHARED_LIB=y.

Bruce, do you mind fix these two issues when applying the code (if 
there's no other issue)? Thanks.

Jianfeng

>
>> +} DPDK_2.2;
>>



[dpdk-dev] [PATCH v8 01/11] ethdev: add API to query supported packet types

2016-03-14 Thread Ferruh Yigit
On 3/14/2016 7:42 AM, Jianfeng Tan wrote:
> Add a new API rte_eth_dev_get_supported_ptypes to query what packet types
> can be filled by given already started device (or its pmd rx burst function
> has already been decided).
> 
> Signed-off-by: Jianfeng Tan 
> Acked-by: Konstantin Ananyev 
> Acked-by: Adrien Mazarguil 
> ---

<...>

> +DPDK_16.04 {
> + rte_eth_dev_get_supported_ptypes;
Other script files tends to put a blank line before function names.

> +
> + local: *;
This line is not required.

> +} DPDK_2.2;
> 



[dpdk-dev] [PATCH v8 01/11] ethdev: add API to query supported packet types

2016-03-14 Thread Jianfeng Tan
Add a new API rte_eth_dev_get_supported_ptypes to query what packet types
can be filled by given already started device (or its pmd rx burst function
has already been decided).

Signed-off-by: Jianfeng Tan 
Acked-by: Konstantin Ananyev 
Acked-by: Adrien Mazarguil 
---
 lib/librte_ether/rte_ethdev.c  | 27 +++
 lib/librte_ether/rte_ethdev.h  | 27 +++
 lib/librte_ether/rte_ether_version.map |  5 +
 3 files changed, 59 insertions(+)

diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index a6e83c1..52fb62c 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -1616,6 +1616,33 @@ rte_eth_dev_info_get(uint8_t port_id, struct 
rte_eth_dev_info *dev_info)
dev_info->driver_name = dev->data->drv_name;
 }

+int
+rte_eth_dev_get_supported_ptypes(uint8_t port_id, uint32_t ptype_mask,
+uint32_t *ptypes, int num)
+{
+   int i, j;
+   struct rte_eth_dev *dev;
+   const uint32_t *all_ptypes;
+
+   RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+   dev = _eth_devices[port_id];
+   RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_supported_ptypes_get,
+   -ENOTSUP);
+   all_ptypes = (*dev->dev_ops->dev_supported_ptypes_get)(dev);
+
+   if (!all_ptypes)
+   return 0;
+
+   for (i = 0, j = 0; all_ptypes[i] != RTE_PTYPE_UNKNOWN; ++i)
+   if (all_ptypes[i] & ptype_mask) {
+   if (j < num)
+   ptypes[j] = all_ptypes[i];
+   j++;
+   }
+
+   return j;
+}
+
 void
 rte_eth_macaddr_get(uint8_t port_id, struct ether_addr *mac_addr)
 {
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index e2893ba..7770f24 100644
--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rte_ethdev.h
@@ -1021,6 +1021,9 @@ typedef void (*eth_dev_infos_get_t)(struct rte_eth_dev 
*dev,
struct rte_eth_dev_info *dev_info);
 /**< @internal Get specific informations of an Ethernet device. */

+typedef const uint32_t *(*eth_dev_supported_ptypes_get_t)(struct rte_eth_dev 
*dev);
+/**< @internal Get supported ptypes of an Ethernet device. */
+
 typedef int (*eth_queue_start_t)(struct rte_eth_dev *dev,
uint16_t queue_id);
 /**< @internal Start rx and tx of a queue of an Ethernet device. */
@@ -1347,6 +1350,7 @@ struct eth_dev_ops {
eth_queue_stats_mapping_set_t queue_stats_mapping_set;
/**< Configure per queue stat counter mapping. */
eth_dev_infos_get_tdev_infos_get; /**< Get device info. */
+   eth_dev_supported_ptypes_get_t dev_supported_ptypes_get; /** Get 
supported ptypes */
mtu_set_t  mtu_set; /**< Set MTU. */
vlan_filter_set_t  vlan_filter_set;  /**< Filter VLAN Setup. */
vlan_tpid_set_tvlan_tpid_set;  /**< Outer VLAN TPID 
Setup. */
@@ -2270,6 +2274,29 @@ void rte_eth_macaddr_get(uint8_t port_id, struct 
ether_addr *mac_addr);
 void rte_eth_dev_info_get(uint8_t port_id, struct rte_eth_dev_info *dev_info);

 /**
+ * Retrieve the supported packet types of an Ethernet device.
+ *
+ * @note
+ *   Better to invoke this API after the device is already started or rx burst
+ *   function is decided, to obtain correct supported ptypes.
+ * @param port_id
+ *   The port identifier of the Ethernet device.
+ * @param ptype_mask
+ *   A hint of what kind of packet type which the caller is interested in.
+ * @param ptypes
+ *   An array pointer to store adequent packet types, allocated by caller.
+ * @param num
+ *  Size of the array pointed by param ptypes.
+ * @return
+ *   - (>0) Number of supported ptypes. If it exceeds param num, exceeding
+ *  packet types will not be filled in the given array.
+ *   - (0 or -ENOTSUP) if PMD does not fill the specified ptype.
+ *   - (-ENODEV) if *port_id* invalid.
+ */
+int rte_eth_dev_get_supported_ptypes(uint8_t port_id, uint32_t ptype_mask,
+uint32_t *ptypes, int num);
+
+/**
  * Retrieve the MTU of an Ethernet device.
  *
  * @param port_id
diff --git a/lib/librte_ether/rte_ether_version.map 
b/lib/librte_ether/rte_ether_version.map
index d8db24d..0f00dcb 100644
--- a/lib/librte_ether/rte_ether_version.map
+++ b/lib/librte_ether/rte_ether_version.map
@@ -117,3 +117,8 @@ DPDK_2.2 {

local: *;
 };
+DPDK_16.04 {
+   rte_eth_dev_get_supported_ptypes;
+
+   local: *;
+} DPDK_2.2;
-- 
2.1.4