[dpdk-dev] dpdk-1.7.0 bug report

2014-08-01 Thread Thomas Monjalon 
2014-07-23 14:24, David Binderman:
> dpdk-1.7.0/lib/librte_ether/rte_ether.h:208]: (style) Expression '(X & 0x2) 
> == 0x1' is always false.
> 
> Source code is
> 
> return ((ea->addr_bytes[0] & ETHER_LOCAL_ADMIN_ADDR) == 1);
> 
> but
> 
> #define ETHER_LOCAL_ADMIN_ADDR 0x02 /**< Locally assigned Eth. address. */

It's now fixed:
http://dpdk.org/browse/dpdk/commit/?id=030df0102ce762360

Thanks
-- 
Thomas

[dpdk-dev] dpdk-1.7.0 bug report

2014-07-23 Thread Thomas Monjalon 
Hi,

2014-07-23 14:24, David Binderman:
> dpdk-1.7.0/lib/librte_ether/rte_ether.h:208]: (style) Expression '(X & 0x2) 
> == 0x1' is always false.

Which tool are you using?

Thanks for the report
-- 
Thomas

[dpdk-dev] dpdk-1.7.0 bug report

2014-07-23 Thread David Binderman 
Hello there,


> 2014-07-23 14:24, David Binderman:
>> dpdk-1.7.0/lib/librte_ether/rte_ether.h:208]: (style) Expression '(X & 0x2) 
>> == 0x1' is always false.
>
> Which tool are you using?

cppcheck, available from sourceforge. Strongly recommended.

Regards

David Binderman

[dpdk-dev] dpdk-1.7.0 bug report

2014-07-23 Thread David Binderman 
Hello there,

dpdk-1.7.0/lib/librte_ether/rte_ether.h:208]: (style) Expression '(X & 0x2) == 
0x1' is always false.

Source code is

??? return ((ea->addr_bytes[0] & ETHER_LOCAL_ADMIN_ADDR) == 1);

but

#define ETHER_LOCAL_ADMIN_ADDR 0x02 /**< Locally assigned Eth. address. */

Regards

David Binderman