Re: [dpdk-dev] [dpdk-announce] release candidate 19.05-rc4

[dwilder]

You may share some release validation results
by replying to this message (at dev@dpdk.org).
If no objection, the version 19.05.0 will be out on May 13.



Hi Thomas-

I tested 19.05-rc4 on IBM Power9 hardware.  No issues were were seen.

Tests run:
 * Single port stability test using l3fwd (16 cpus) and TRex, tested 64 
and 1500 byte packets at a 0.0% drop rate for 4 hours each.


System tested:
 - IBM Power9 Model 8335-101 CPU: 2.3 (pvr 004e 1203)

Tested NICs:
 - ConnectX-5 (fw 16.23.1020).

OS Tested
 - Ubuntu 18.04.2 LTS (kernel 4.15.0-47-generic)

Latest dpdk tested version:
 - version(tag): v19.05-rc4

Regards,
Dave

Re: [dpdk-dev] [PATCH] net/mlx5: match on TCP flags via DV/DR engine

[Ori Kam]

> -Original Message-
> From: dev  On Behalf Of Jack Min
> Sent: Thursday, May 9, 2019 9:11 AM
> To: Shahaf Shuler ; Yongseok Koh
> 
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: match on TCP flags via DV/DR engine
> 
> Add support to match all TCP control bits (flags)
> except "NS (ECN-nonce)" via Direct Verbs (DV) or Direct Rule (DR)
> engine.
> 
> Signed-off-by: Xiaoyu Min 
> ---
>  drivers/net/mlx5/mlx5_flow_dv.c | 12 +++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_flow_dv.c
> b/drivers/net/mlx5/mlx5_flow_dv.c
> index cf255ca95c..44b4f40404 100644
> --- a/drivers/net/mlx5/mlx5_flow_dv.c
> +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> @@ -2066,6 +2066,12 @@ flow_dv_validate(struct rte_eth_dev *dev, const
> struct rte_flow_attr *attr,
>   uint64_t last_item = 0;
>   uint8_t next_protocol = 0xff;
>   int actions_n = 0;
> + struct rte_flow_item_tcp nic_tcp_mask = {
> + .hdr = { .tcp_flags = 0xFF,
> +  .src_port = RTE_BE16(UINT16_MAX),
> +  .dst_port = RTE_BE16(UINT16_MAX),
> + }
> + };
> 
>   if (items == NULL)
>   return -1;
> @@ -2146,7 +2152,7 @@ flow_dv_validate(struct rte_eth_dev *dev, const
> struct rte_flow_attr *attr,
>   ret = mlx5_flow_validate_item_tcp
>   (items, item_flags,
>next_protocol,
> -  &rte_flow_item_tcp_mask,
> +  &nic_tcp_mask,
>error);
>   if (ret < 0)
>   return ret;
> @@ -2862,6 +2868,10 @@ flow_dv_translate_item_tcp(void *matcher, void
> *key,
>rte_be_to_cpu_16(tcp_m->hdr.dst_port));
>   MLX5_SET(fte_match_set_lyr_2_4, headers_v, tcp_dport,
>rte_be_to_cpu_16(tcp_v->hdr.dst_port & tcp_m-
> >hdr.dst_port));
> + MLX5_SET(fte_match_set_lyr_2_4, headers_m, tcp_flags,
> +  tcp_m->hdr.tcp_flags);
> + MLX5_SET(fte_match_set_lyr_2_4, headers_v, tcp_flags,
> +  (tcp_v->hdr.tcp_flags & tcp_m->hdr.tcp_flags));
>  }
> 
>  /**
> --
> 2.20.1

Acked-by: Ori Kam 
Thanks,