RE: [PATCH 1/3] net/mlx5: support multi-packet RQ on Windows
V_LOG(DEBUG, "\tmax_single_wqe_log_num_of_strides:
> %u",
> + sh->dev_cap.mprq.log_max_stride_num);
> + DRV_LOG(DEBUG, "\tmin_stride_wqe_log_size: %u",
> + sh->dev_cap.mprq.log_min_stride_wqe_size);
> + DRV_LOG(DEBUG, "Device supports Multi-Packet RQ.");
> + }
> if (hca_attr->rss_ind_tbl_cap) {
> /*
>* DPDK doesn't support larger/variable indirection tables.
> --
> 2.16.1.windows.4
Tested-by: Pier Damouny
RE: [PATCH 2/3] net/mlx5: support CQE compression on Windows
> Subject: [PATCH 2/3] net/mlx5: support CQE compression on Windows
>
> CQE Compression reduces PCI overhead by coalescing and compressing
> multiple CQEs into a single merged CQE.
>
> Add supported for the CQE compression feature on Windows.
> feature is enabled by default unless not supported by the HW or if the
> rxq_cqe_comp_en PMD argument is explicitly disabled.
>
> Signed-off-by: Tal Shnaiderman
> ---
> drivers/common/mlx5/mlx5_devx_cmds.c | 2 ++
> drivers/common/mlx5/mlx5_devx_cmds.h | 1 +
> drivers/net/mlx5/windows/mlx5_os.c | 12
> 3 files changed, 15 insertions(+)
>
> diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c
> b/drivers/common/mlx5/mlx5_devx_cmds.c
> index 096bd1d520..a31e4995f5 100644
> --- a/drivers/common/mlx5/mlx5_devx_cmds.c
> +++ b/drivers/common/mlx5/mlx5_devx_cmds.c
> @@ -1062,6 +1062,8 @@ mlx5_devx_cmd_query_hca_attr(void *ctx,
> attr->cqe_compression = MLX5_GET(cmd_hca_cap, hcattr,
> cqe_compression);
> attr->mini_cqe_resp_flow_tag = MLX5_GET(cmd_hca_cap, hcattr,
> mini_cqe_resp_flow_tag);
> + attr->cqe_compression_128 = MLX5_GET(cmd_hca_cap, hcattr,
> + cqe_compression_128);
> attr->mini_cqe_resp_l3_l4_tag = MLX5_GET(cmd_hca_cap, hcattr,
>mini_cqe_resp_l3_l4_tag);
> attr->enhanced_cqe_compression = MLX5_GET(cmd_hca_cap,
> hcattr, diff --git a/drivers/common/mlx5/mlx5_devx_cmds.h
> b/drivers/common/mlx5/mlx5_devx_cmds.h
> index 9e7992b1c6..edcd867c4e 100644
> --- a/drivers/common/mlx5/mlx5_devx_cmds.h
> +++ b/drivers/common/mlx5/mlx5_devx_cmds.h
> @@ -284,6 +284,7 @@ struct mlx5_hca_attr {
> uint16_t max_wqe_sz_sq;
> uint32_t striding_rq:1;
> uint32_t ext_stride_num_range:1;
> + uint32_t cqe_compression_128:1;
> uint32_t set_reg_c:8;
> uint32_t nic_flow_table:1;
> uint32_t modify_outer_ip_ecn:1;
> diff --git a/drivers/net/mlx5/windows/mlx5_os.c
> b/drivers/net/mlx5/windows/mlx5_os.c
> index 0caa8931e4..6527269663 100644
> --- a/drivers/net/mlx5/windows/mlx5_os.c
> +++ b/drivers/net/mlx5/windows/mlx5_os.c
> @@ -237,6 +237,18 @@ mlx5_os_capabilities_prepare(struct
> mlx5_dev_ctx_shared *sh)
> } else {
> DRV_LOG(DEBUG, "Tunnel offloading is not supported.");
> }
> + sh->dev_cap.cqe_comp = 0;
> +#if (RTE_CACHE_LINE_SIZE == 128)
> + if (hca_attr->cqe_compression_128)
> + sh->dev_cap.cqe_comp = 1;
> + DRV_LOG(DEBUG, "Rx CQE 128B compression is %ssupported.",
> + sh->dev_cap.cqe_comp ? "" : "not ");
> +#else
> + if (hca_attr->cqe_compression)
> + sh->dev_cap.cqe_comp = 1;
> + DRV_LOG(DEBUG, "Rx CQE compression is %ssupported.",
> + sh->dev_cap.cqe_comp ? "" : "not ");
> +#endif
> snprintf(sh->dev_cap.fw_ver, 64, "%x.%x.%04x",
>MLX5_GET(initial_seg, pv_iseg, fw_rev_major),
>MLX5_GET(initial_seg, pv_iseg, fw_rev_minor),
> --
> 2.16.1.windows.4
Tested-by: Pier Damouny
RE: [PATCH 3/3] net/mlx5: support enhanced multi-packet write on Windows
c
> @@ -173,7 +173,6 @@ mlx5_os_capabilities_prepare(struct
> mlx5_dev_ctx_shared *sh)
> sh->dev_cap.max_qp = 1 << hca_attr->log_max_qp;
> sh->dev_cap.max_qp_wr = 1 << hca_attr->log_max_qp_sz;
> sh->dev_cap.dv_flow_en = 1;
> - sh->dev_cap.mps = MLX5_MPW_DISABLED;
> DRV_LOG(DEBUG, "MPW isn't supported.");
> DRV_LOG(DEBUG, "MPLS over GRE/UDP tunnel offloading is no
> supported.");
> sh->dev_cap.hw_csum = hca_attr->csum_cap; @@ -224,6 +223,13
> @@ mlx5_os_capabilities_prepare(struct mlx5_dev_ctx_shared *sh)
> DRV_LOG(DEBUG, "Maximum Rx indirection table size is %u",
> sh->dev_cap.ind_table_max_size);
> }
> + if (hca_attr->enhanced_multi_pkt_send_wqe)
> + sh->dev_cap.mps = MLX5_MPW_ENHANCED;
> + else if (hca_attr->multi_pkt_send_wqe &&
> + sh->dev_cap.mps != MLX5_ARG_UNSET)
> + sh->dev_cap.mps = MLX5_MPW;
> + else
> + sh->dev_cap.mps = MLX5_MPW_DISABLED;
> sh->dev_cap.swp =
> mlx5_get_supported_sw_parsing_offloads(hca_attr);
> sh->dev_cap.tunnel_en =
> mlx5_get_supported_tunneling_offloads(hca_attr);
> if (sh->dev_cap.tunnel_en) {
> --
> 2.16.1.windows.4
Tested-by: Pier Damouny
RE: [PATCH v4 0/2] Fix testpmd interrupt regression
> External email: Use caution opening links or attachments > > > Resolve issues from using control-C in testpmd. > Fixes regression from recent change to use cmdline_poll(). > > v4 - drop sig_atomic_t. Not required requires changes on > some platforms. > > Stephen Hemminger (2): > testpmd: go back to using cmdline_interact > testpmd: enable interrupt in interactive mode > > app/test-pmd/cmdline.c | 27 ++- > app/test-pmd/testpmd.c | 11 +++ > lib/cmdline/cmdline.h| 10 ++ > lib/cmdline/cmdline_os_unix.c| 8 +++- > lib/cmdline/cmdline_os_windows.c | 18 -- > lib/cmdline/cmdline_private.h| 2 +- > lib/cmdline/version.map | 3 +++ > 7 files changed, 62 insertions(+), 17 deletions(-) > > -- > 2.39.2 Confirming that this patch fixes Bug: 1180 over Windows. And CTRL-C works as expected. Tested-by: Pier Damouny
RE: [RFT v2] test-pmd: go back to using cmdline_interact
> Subject: [RFT v2] test-pmd: go back to using cmdline_interact > > External email: Use caution opening links or attachments > > > The cmdline library poll function is broken on Windows and was never > tested, don't use it. > > Instead, use sigaction() to cancel read character on Unix OS's and a new > helper to cancel I/O on Windows. > > Signed-off-by: Stephen Hemminger Confirmed that this patch fixes Bug: 1180 on Windows. Tested-by: Pier Damouny
