[dpdk-dev] net/virtio-user: Fix missing brackets in if condition
On Tue, 12 Jul 2016 11:30:25 +0200
Maxime Coquelin wrote:
> The error is reported using test build script:
I recommend to note that the error is reported only by GCC 6+.
>
> $ scripts/test-build.sh x86_64-native-linuxapp-gcc
> ...
> drivers/net/virtio/virtio_user_ethdev.c: In function
> ?virtio_user_pmd_devinit?:
> drivers/net/virtio/virtio_user_ethdev.c:345:2: error: this ?if? clause does
> not guard... [-Werror=misleading-indentation]
> if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_PATH) == 1)
> ^~
>
> Fixes: 404bd6bfe360 ("net/virtio-user: fix return value not checked")
>
> Cc: Jianfeng Tan
> Signed-off-by: Maxime Coquelin
> Acked-by: Yuanhan Liu
>
Reviewed-by: Jan Viktorin
[dpdk-dev] [PATCH v6 06/17] crypto: export init/uninit common wrappers for pci drivers
On Tue, 12 Jul 2016 11:31:11 +0530 Shreyansh Jain wrote: > Preparing for getting rid of rte_cryptodev_driver, here are two wrappers > that can be used by pci drivers that assume a 1 to 1 association between > pci resource and upper interface. > > Signed-off-by: David Marchand > Signed-off-by: Shreyansh Jain > --- Reviewed-by: Jan Viktorin
[dpdk-dev] [PATCH v6 07/17] ethdev: export init/uninit common wrappers for pci drivers
On Tue, 12 Jul 2016 11:31:12 +0530 Shreyansh Jain wrote: > Preparing for getting rid of eth_drv, here are two wrappers that can be > used by pci drivers that assume a 1 to 1 association between pci resource and > upper interface. > > Signed-off-by: David Marchand > Signed-off-by: Shreyansh Jain > --- Reviewed-by: Jan Viktorin
[dpdk-dev] [PATCH v6 11/17] eal/linux: move back interrupt thread init before setting affinity
On Tue, 12 Jul 2016 11:31:16 +0530 Shreyansh Jain wrote: > Now that virtio pci driver is initialized in a constructor, iopl() stuff > happens early enough so that interrupt thread can be created right after > plugin loading. > This way, chelsio driver should be happy again [1]. > > [1] http://dpdk.org/ml/archives/dev/2015-November/028289.html > > Signed-off-by: David Marchand > Tested-by: Rahul Lakkireddy > Signed-off-by: Shreyansh Jain > --- Reviewed-by: Jan Viktorin
[dpdk-dev] [PATCH v6 10/17] ethdev: get rid of eth driver register callback
On Tue, 12 Jul 2016 11:31:15 +0530 Shreyansh Jain wrote: > Now that all pdev are pci drivers, we don't need to register ethdev drivers > through a dedicated channel. > > Signed-off-by: David Marchand > Signed-off-by: Shreyansh Jain > --- Reviewed-by: Jan Viktorin
[dpdk-dev] [PATCH v6 09/17] crypto: get rid of crypto driver register callback
On Tue, 12 Jul 2016 11:31:14 +0530 Shreyansh Jain wrote: > Now that all pdev are pci drivers, we don't need to register crypto drivers > through a dedicated channel. > > Signed-off-by: David Marchand > Signed-off-by: Shreyansh Jain > --- Reviewed-by: Jan Viktorin
[dpdk-dev] [PATCH v6 01/17] pci: no need for dynamic tailq init
On Tue, 12 Jul 2016 11:31:06 +0530 Shreyansh Jain wrote: > These lists can be initialized once and for all at build time. > With this, those lists are only manipulated in a common place > (and we could even make them private). > > A nice side effect is that pci drivers can now register in constructors. > > Signed-off-by: David Marchand > Reviewed-by: Jan Viktorin > Signed-off-by: Shreyansh Jain > --- Tested-by: Jan Viktorin
[dpdk-dev] [PATCH v6 03/17] drivers: align pci driver definitions
On Tue, 12 Jul 2016 11:31:08 +0530 Shreyansh Jain wrote: > Pure coding style, but it might make it easier later if we want to move > fields in rte_cryptodev_driver and eth_driver structures. > > Signed-off-by: David Marchand > Signed-off-by: Shreyansh Jain > --- Reviewed-by: Jan Viktorin
[dpdk-dev] [PATCH v6 04/17] eal: remove duplicate function declaration
On Tue, 12 Jul 2016 11:31:09 +0530
Shreyansh Jain wrote:
> rte_eal_dev_init is declared in both eal_private.h and rte_dev.h since its
> introduction.
> This function has been exported in ABI, so remove it from eal_private.h
>
> Fixes: e57f20e05177 ("eal: make vdev init path generic for both virtual and
> pci devices")
> Signed-off-by: David Marchand
> Signed-off-by: Shreyansh Jain
> ---
Reviewed-by: Jan Viktorin
[dpdk-dev] [PATCH v6 02/17] crypto: no need for a crypto pmd type
On Tue, 12 Jul 2016 11:31:07 +0530 Shreyansh Jain wrote: > This information is not used and just adds noise. > > Signed-off-by: David Marchand > Signed-off-by: Shreyansh Jain > --- Reviewed-by: Jan Viktorin
[dpdk-dev] [dpdk-dev, 1/2] app/test: rework command registration
On Wed, 13 Jul 2016 23:24:09 +0200 Thomas Monjalon wrote: > The tests are registered with their command name by adding a structure > to a list. The structure of each test was declared in each test file > and passed to the register macro. > This rework generate the structure inside the register macro. There is just this little issue: WARNING:LONG_LINE: line over 80 characters #335: FILE: app/test/test_cryptodev_perf.c:2924: +REGISTER_TEST_COMMAND(cryptodev_sw_snow3g_perftest, perftest_sw_snow3g_cryptodev); WARNING:LONG_LINE: line over 80 characters #336: FILE: app/test/test_cryptodev_perf.c:2925: +REGISTER_TEST_COMMAND(cryptodev_qat_snow3g_perftest, perftest_qat_snow3g_cryptodev); total: 0 errors, 2 warnings, 758 lines checked Otherwise Reviewed-by: Jan Viktorin > > Signed-off-by: Thomas Monjalon > > --- > app/test/test.h | 17 +-- > app/test/test_acl.c | 6 +- > app/test/test_alarm.c| 6 +- > app/test/test_atomic.c | 6 +- > app/test/test_byteorder.c| 6 +- > app/test/test_cmdline.c | 6 +- > app/test/test_common.c | 6 +- > app/test/test_cpuflags.c | 6 +- > app/test/test_cryptodev.c| 41 > ++-- > app/test/test_cryptodev_perf.c | 28 > app/test/test_cycles.c | 6 +- > app/test/test_debug.c| 6 +- > app/test/test_devargs.c | 6 +- > app/test/test_distributor.c | 6 +- > app/test/test_distributor_perf.c | 6 +- > app/test/test_eal_flags.c| 6 +- > app/test/test_eal_fs.c | 6 +- > app/test/test_errno.c| 6 +- > app/test/test_func_reentrancy.c | 6 +- > app/test/test_hash.c | 6 +- > app/test/test_hash_functions.c | 6 +- > app/test/test_hash_multiwriter.c | 8 +-- > app/test/test_hash_perf.c| 6 +- > app/test/test_hash_scaling.c | 7 +- > app/test/test_interrupts.c | 6 +- > app/test/test_ivshmem.c | 6 +- > app/test/test_kni.c | 6 +- > app/test/test_kvargs.c | 6 +- > app/test/test_link_bonding.c | 6 +- > app/test/test_link_bonding_mode4.c | 7 +- > app/test/test_link_bonding_rssconf.c | 7 +- > app/test/test_logs.c | 6 +- > app/test/test_lpm.c | 6 +- > app/test/test_lpm6.c | 6 +- > app/test/test_lpm6_perf.c| 6 +- > app/test/test_lpm_perf.c | 6 +- > app/test/test_malloc.c | 6 +- > app/test/test_mbuf.c | 6 +- > app/test/test_memcpy.c | 6 +- > app/test/test_memcpy_perf.c | 6 +- > app/test/test_memory.c | 6 +- > app/test/test_mempool.c | 6 +- > app/test/test_mempool_perf.c | 6 +- > app/test/test_memzone.c | 6 +- > app/test/test_meter.c| 6 +- > app/test/test_mp_secondary.c | 6 +- > app/test/test_pci.c | 6 +- > app/test/test_per_lcore.c| 6 +- > app/test/test_pmd_perf.c | 6 +- > app/test/test_pmd_ring.c | 6 +- > app/test/test_pmd_ring_perf.c| 6 +- > app/test/test_power.c| 6 +- > app/test/test_power_acpi_cpufreq.c | 6 +- > app/test/test_power_kvm_vm.c | 6 +- > app/test/test_prefetch.c | 6 +- > app/test/test_red.c | 20 +++--- > app/test/test_reorder.c | 6 +- > app/test/test_resource.c | 6 +- > app/test/test_ring.c | 6 +- > app/test/test_ring_perf.c| 6 +- > app/test/test_rwlock.c | 6 +- > app/test/test_sched.c| 6 +- > app/test/test_spinlock.c | 6 +- > app/test/test_string_fns.c | 6 +- > app/test/test_table.c| 6 +- > app/test/test_tailq.c| 6 +- > app/test/test_thash.c| 6 +- > app/test/test_timer.c| 6 +- > app/test/test_timer_perf.c | 6 +- > app/test/test_timer_racecond.c | 6 +- > app/test/test_version.c | 6 +- > 71 files changed, 91 insertions(+), 422 deletions(-) > [...]
[dpdk-dev] [PATCH 1/9] pci: no need for dynamic tailq init
On Fri, 29 Jan 2016 15:08:28 +0100 David Marchand wrote: > These lists can be initialized once and for all at build time. > With this, those lists are only manipulated in a common place > (and we could even make them private). > > A nice side effect is that pci drivers can now register in constructors. > > Signed-off-by: David Marchand Reviewed-by: Jan Viktorin
[dpdk-dev] [PATCH 1/2] arch/arm: fix file descriptors leakage when getting CPU features
Hello Jianbo Liu, thank you, a good catch! Can you please git blame for the commit introducing the issue and add the "Fixes:" tag as described in [1]? Same for ppc. Regards Jan [1] http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-body On Fri, 4 Nov 2016 11:59:08 +0530 Jianbo Liu wrote: > Signed-off-by: Jianbo Liu Acked-by: Jan Viktorin
[dpdk-dev] [PATCH 2/2] arch/ppc: fix file descriptors leakage when getting CPU features
Please, add the Fixes tag. On Fri, 4 Nov 2016 11:59:09 +0530 Jianbo Liu wrote: > Signed-off-by: Jianbo Liu Acked-by: Jan Viktorin
