[GitHub] drill pull request: DRILL-1457: Push Limit past through UnionExcha...
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/169 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Zookeeper (semi-)automated cluster setup
Hey folks, I am exploring a setup for large cluster deployment for Drill. Is anyone aware of any ZooKeeper utility for simplified and (semi-)automated setup, and, ideally, configured for Drill? Thank you, Edmon
[GitHub] drill pull request: Drill 2908: Int96 support
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/162#discussion_r40498185
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetFixedWidthDictionaryReaders.java
---
@@ -59,6 +63,50 @@ protected void readField(long recordsToReadInThisPass) {
}
}
+ static class DictionaryFixedBinaryReader extends FixedByteAlignedReader {
+
+VarBinaryVector castedVector;
+
+DictionaryFixedBinaryReader(ParquetRecordReader parentReader, int
allocateSize, ColumnDescriptor descriptor,
+ColumnChunkMetaData columnChunkMetaData, boolean
fixedLength, VarBinaryVector v,
+SchemaElement schemaElement) throws
ExecutionSetupException {
+ super(parentReader, allocateSize, descriptor, columnChunkMetaData,
fixedLength, v, schemaElement);
+ castedVector = v;
+}
+
+// this method is called by its superclass during a read loop
+@Override
+protected void readField(long recordsToReadInThisPass) {
+
+ recordsReadInThisIteration = Math.min(pageReader.currentPageCount
+ - pageReader.valuesRead, recordsToReadInThisPass -
valuesReadInCurrentPass);
+
+ if (usingDictionary) {
+VarBinaryVector.Mutator mutator = castedVector.getMutator();
+Binary currDictValToWrite = null;
+for (int i = 0; i < recordsReadInThisIteration; i++){
+ currDictValToWrite =
pageReader.dictionaryValueReader.readBytes();
+ mutator.setSafe(valuesReadInCurrentPass + i,
currDictValToWrite.toByteBuffer(), 0,
+ currDictValToWrite.length());
+}
+// Set the write Index. The next page that gets read might be a
page that does not use dictionary encoding
+// and we will go into the else condition below. The readField
method of the parent class requires the
+// writer index to be set correctly.
+int writerIndex = castedVector.getBuffer().writerIndex();
+castedVector.getBuffer().setIndex(0, writerIndex +
(int)readLength);
--- End diff --
You're right. For DictionaryFixedBinaryReader, the readField code does not
call the super.readField method and the readLength is set in the parent class'
method. Updated the patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: Drill 3313
Github user parthchandra commented on the pull request: https://github.com/apache/drill/pull/134#issuecomment-143493034 Merged in 77e2b89 and 445790f --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] drill pull request: Drill 3313
Github user parthchandra closed the pull request at: https://github.com/apache/drill/pull/134 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] drill pull request: DRILL-1065: Support for ALTER ... RESET statem...
Github user adeneche commented on the pull request: https://github.com/apache/drill/pull/159#issuecomment-143511508 @sudheeshkatkam can you please rebase, and create a separate JIRA for removing *exec* from reserved words. +1, LGTM except `CompoundIdentifierConverter.java` I don't have enough knowledge to review this class. @jacques-n can you please review the change in this file ? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] drill pull request: Drill 2908: Int96 support
Github user adeneche commented on the pull request: https://github.com/apache/drill/pull/162#issuecomment-143516073 +1, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] drill pull request: DRILL-1065: Support for ALTER ... RESET statem...
Github user jacques-n commented on the pull request: https://github.com/apache/drill/pull/159#issuecomment-143477295 Okay, let's skip this for now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
