[GitHub] drill pull request: DRILL-4174: fix for DRILL-4081 mistakenly regr...
Github user adeneche closed the pull request at: https://github.com/apache/drill/pull/320 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Resolved] (DRILL-4174) fix for DRILL-4081 mistakenly regresses the fix for DRILL-3786
[ https://issues.apache.org/jira/browse/DRILL-4174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deneche A. Hakim resolved DRILL-4174. - Resolution: Fixed Fixed by 5cb8eb95ea98eacf1c262e50ab1ff2714d37fc2c > fix for DRILL-4081 mistakenly regresses the fix for DRILL-3786 > -- > > Key: DRILL-4174 > URL: https://issues.apache.org/jira/browse/DRILL-4174 > Project: Apache Drill > Issue Type: Bug > Components: Execution - Relational Operators >Affects Versions: 1.4.0 >Reporter: Deneche A. Hakim >Assignee: Deneche A. Hakim > Fix For: 1.5.0 > > > As part of fixing DRILL-3786, ExternalSortBatch counts how many batches are > held in memory in a local variable "totalBatches" to make sure sort spills to > disk before we have too many batches for the SelectionVector4. > The fix for DRILL-4081 removed the line that incremented totalBatches which > causes the previous fix to no longer work -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (DRILL-3786) Query with window function fails with IllegalFormatConversionException
[
https://issues.apache.org/jira/browse/DRILL-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deneche A. Hakim resolved DRILL-3786.
-
Resolution: Fixed
Fixed by DRILL-4174
> Query with window function fails with IllegalFormatConversionException
> --
>
> Key: DRILL-3786
> URL: https://issues.apache.org/jira/browse/DRILL-3786
> Project: Apache Drill
> Issue Type: Bug
> Components: Execution - Relational Operators
>Affects Versions: 1.2.0
> Environment: 10 Performance Nodes
> DRILL_MAX_DIRECT_MEMORY=100g
> DRILL_INIT_HEAP="8g"
> DRILL_MAX_HEAP="8g"
> planner.memory.query_max_memory_per_node bumped up to 20 GB
> TPC-DS SF 1000 dataset (Parquet)
>Reporter: Abhishek Girish
>Assignee: Deneche A. Hakim
>Priority: Critical
> Fix For: 1.4.0
>
> Attachments: drillbit.log.txt, query_profile.json
>
>
> Query fails with Runtime exception:
> {code:sql}
> SELECT sum(s.ss_quantity) OVER (PARTITION BY s.ss_store_sk, s.ss_customer_sk
> ORDER BY s.ss_store_sk) FROM store_sales s LIMIT 20;
> java.lang.RuntimeException: java.sql.SQLException: SYSTEM ERROR:
> IllegalFormatConversionException: d != java.lang.Character
> Fragment 1:0
> [Error Id: 12b51c0c-4992-4ceb-89c4-c99307529c7e on ucs-node8.perf.lab:31010]
> at sqlline.IncrementalRows.hasNext(IncrementalRows.java:73)
> at
> sqlline.TableOutputFormat$ResizingRowsProvider.next(TableOutputFormat.java:87)
> at sqlline.TableOutputFormat.print(TableOutputFormat.java:118)
> at sqlline.SqlLine.print(SqlLine.java:1583)
> at sqlline.Commands.execute(Commands.java:852)
> at sqlline.Commands.sql(Commands.java:751)
> at sqlline.SqlLine.dispatch(SqlLine.java:738)
> at sqlline.SqlLine.begin(SqlLine.java:612)
> at sqlline.SqlLine.start(SqlLine.java:366)
> at sqlline.SqlLine.main(SqlLine.java:259)
> {code}
> Query logs and profile attached.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (DRILL-4257) Ensure shutting down a Drillbit also shuts down all StoragePlugins
Jacques Nadeau created DRILL-4257: - Summary: Ensure shutting down a Drillbit also shuts down all StoragePlugins Key: DRILL-4257 URL: https://issues.apache.org/jira/browse/DRILL-4257 Project: Apache Drill Issue Type: Bug Components: Execution - Flow Reporter: Jacques Nadeau Assignee: Jacques Nadeau Fix For: 1.5.0 Right now, if a StoragePlugin implementation relies on the close method to clean up resources, those resources won't be cleaned up when the Drillbit class is shutdown. This is because Drillbit doesn't actually close the StoragePluginRegistry and associated resources. This causes problems in leaking resources in tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (DRILL-4258) Create New SYS tables: cpu, queries, fragments, threads, threadtraces
Jacques Nadeau created DRILL-4258: - Summary: Create New SYS tables: cpu, queries, fragments, threads, threadtraces Key: DRILL-4258 URL: https://issues.apache.org/jira/browse/DRILL-4258 Project: Apache Drill Issue Type: New Feature Components: Execution - Monitoring Reporter: Jacques Nadeau Assignee: Jacques Nadeau cpu: Drillbit, # Cores, CPU consumption (with different windows?) queries: Foreman, QueryId, User, SQL, Start Time, rows processed, query plan, # nodes involved, number of running fragments, memory consumed fragments: Drillbit, queryid, major fragmentid, minorfragmentid, coordinate, memory usage, rows processed, start time threads: name, priority, state, id, thread-level cpu stats threadtraces: threads, stack trace -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] drill pull request: DRILL-4257: Fix StoragePluginRegistry clean-up...
GitHub user jacques-n opened a pull request: https://github.com/apache/drill/pull/321 DRILL-4257: Fix StoragePluginRegistry clean-up behavior Fix StoragePluginRegistry clean-up behavior and misc clean up. - Create the storage plugin registry using a Drill configuration parameter to be able to replace the registry implementation. - Change StoragePluginRegistry into an interface and move the implementation to an impl class. - Write documentation for StoragePluginRegistry. - Make StoragePluginRegistry and StoragePluginMap AutoCloseable and ensure that Drillbit closes registry. - Misc Drillbit code reorganization so that fields are at top of class (and static methods at bottom). - Update DrillConfig to support reflection-based creation of storage plugin objects - Remove final from DrillConfig so that application developers can extend config object. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jacques-n/drill DRILL-4257 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/drill/pull/321.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #321 commit f172aed0380465c6eea480ddcd540038ebbe6a22 Author: Jacques Nadeau Date: 2016-01-10T01:48:26Z DRILL-4257: Fix StoragePluginRegistry clean-up behavior and misc clean up. - Create the storage plugin registry using a Drill configuration parameter to be able to replace the registry implementation. - Change StoragePluginRegistry into an interface and move the implementation to an impl class. - Write documentation for StoragePluginRegistry. - Make StoragePluginRegistry and StoragePluginMap AutoCloseable and ensure that Drillbit closes registry. - Misc Drillbit code reorganization so that fields are at top of class (and static methods at bottom). - Update DrillConfig to support reflection-based creation of storage plugin objects - Remove final from DrillConfig so that application developers can extend config object. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
