[GitHub] drill pull request #647: DRILL-4935 Allow Drill to advertise a specific host...

[xhochy]

Github user xhochy commented on a diff in the pull request:

https://github.com/apache/drill/pull/647#discussion_r86720949
  
--- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java 
---
@@ -142,7 +142,13 @@ private static BufferAllocator newAllocator(
 
   public DrillbitEndpoint start() throws DrillbitStartupException, 
UnknownHostException{
 int userPort = 
userServer.bind(config.getInt(ExecConstants.INITIAL_USER_PORT), 
allowPortHunting);
-String address = useIP ?  InetAddress.getLocalHost().getHostAddress() 
: InetAddress.getLocalHost().getCanonicalHostName();
+String configIP = config.getString(ExecConstants.BIT_ADVERTISED_HOST);
+String address = null;
+if (configIP == "") {
--- End diff --

You could use `config.hasPath` instead of relying on matching on an empty 
string.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #647: DRILL-4935 Allow Drill to advertise a specific host...

[harrisonmebane]

GitHub user harrisonmebane opened a pull request:

https://github.com/apache/drill/pull/647

DRILL-4935 Allow Drill to advertise a specific hostname to Zookeeper



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/harrisonmebane/drill DRILL-4935

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/647.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #647


commit 01dd583ff0f7dc0092371a85823b4737ca26b02d
Author: Harrison Mebane 
Date:   2016-10-07T20:10:36Z

allow configuration of advertised drillbit IP address




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---