Re: [VOTE] Release Apache Drill 1.9.0 RC2

[Khurram Faraaz]

+1 (non-binding)

built from source and deployed binaries on 4 node cluster
Ran the below functional test suites, all tests ran clean no failures were
seen.
# 1279 tests - window function tests
# 210 tests - joins
# 300 tests - aggregates
Did basic sqlline sanity tests, connected to Drillbits and ran simple SQL
queries.
Web UI tests - verified that profiles were displayed, also accessed
drillbit.log from Web UI & verified storage plugin content.

On Sat, Nov 19, 2016 at 3:26 AM, Sudheesh Katkam 
wrote:

> Hi all,
>
> I would like to propose the third release candidate (RC2) of Apache Drill,
> version 1.9.0. Thanks to everyone who contributed to this release!
>
> + Compared to RC0, this release candidate does not contain DRILL-4373, due
> to a regression (DRILL-5034).
> + Compared to RC1, this release candidate contains DRILL-5047.
>
> + The release candidate covers a total of 72 resolved JIRAs [1]. This is
> fewer than what was mentioned for RC1, which was actually incorrect.
> + The tarball artifacts are hosted at [2], and the maven artifacts are
> hosted at [3].
> + This release candidate is based on commit
> 4312d65bd5e0f68dc963ed722d0cdfd2628ea5f5 located at [4].
> + The artifacts are signed with the key at [5].
>
> The vote ends at 2:00 PM PT, November 23rd, 2016. Please vote early.
>
> Here's my vote: +1
>
> Thank you,
> Sudheesh
>
> [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12313820=12337861
> [2] http://people.apache.org/~sudheesh/drill/releases/1.9.0/rc2/
> [3] https://repository.apache.org/content/repositories/
> orgapachedrill-1039/
> [4] https://github.com/sudheeshkatkam/drill/commits/drill-1.9.0
> [5] https://people.apache.org/keys/committer/sudheesh.asc
>

[GitHub] drill pull request #653: DRILL-4831: Running refresh table metadata concurre...

[ppadma]

Github user ppadma commented on a diff in the pull request:

https://github.com/apache/drill/pull/653#discussion_r88770685
  
--- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java 
---
@@ -495,31 +499,75 @@ private ParquetFileMetadata_v3 
getParquetFileMetadata_v3(ParquetTableMetadata_v3
* @param p
* @throws IOException
*/
-  private void writeFile(ParquetTableMetadata_v3 parquetTableMetadata, 
Path p) throws IOException {
+  private void writeFile(ParquetTableMetadata_v3 parquetTableMetadata, 
String path) throws IOException {
 JsonFactory jsonFactory = new JsonFactory();
 jsonFactory.configure(Feature.AUTO_CLOSE_TARGET, false);
 jsonFactory.configure(JsonParser.Feature.AUTO_CLOSE_SOURCE, false);
 ObjectMapper mapper = new ObjectMapper(jsonFactory);
 SimpleModule module = new SimpleModule();
 module.addSerializer(ColumnMetadata_v3.class, new 
ColumnMetadata_v3.Serializer());
 mapper.registerModule(module);
-FSDataOutputStream os = fs.create(p);
+
+// If multiple clients are updating metadata cache file concurrently, 
the cache file
+// can get corrupted. To prevent this, write to a unique temporary 
file and then do
+// atomic rename.
+UUID randomUUID =  UUID.randomUUID();
--- End diff --

Yes, I wanted to use queryId as well. But, it is not easily accessible as 
you mentioned. I made the change to use same UUID for METADATA_FILENAME and 
METADATA_DIRECTORIES_FILENAME. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill issue #653: DRILL-4831: Running refresh table metadata concurrently ra...

[ppadma]

Github user ppadma commented on the issue:

https://github.com/apache/drill/pull/653
  
Updated diffs with all review comments taken care of.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #659: DRILL-5050: C++ client library has symbol resolutio...

[chunhui-shi]

Github user chunhui-shi commented on a diff in the pull request:

https://github.com/apache/drill/pull/659#discussion_r88765929
  
--- Diff: contrib/native/client/readme.macos ---
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+MacOS build (tested on OS X El Capitan)
+
+Install Prerequisites
+-
+
+0.1) Install XCode 
+  Download an istall from here: 
https://developer.apple.com/xcode/downloads/
--- End diff --

install


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #659: DRILL-5050: C++ client library has symbol resolutio...

[chunhui-shi]

Github user chunhui-shi commented on a diff in the pull request:

https://github.com/apache/drill/pull/659#discussion_r88765954
  
--- Diff: contrib/native/client/readme.macos ---
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+MacOS build (tested on OS X El Capitan)
+
+Install Prerequisites
+-
+
+0.1) Install XCode 
+  Download an istall from here: 
https://developer.apple.com/xcode/downloads/
+  In Terminal, install the command line tools 
+$> xcode-select --install
+
+0.2) Install brew following the instructions here: http://brew.sh/
+
+1) CMAKE 2.8 or above
+  Download and install Cmake : https://cmake.org/download/
+
+2.1) Install protobuf
+  $> brew install protobuf
+
+2.2) Install zookeeper
+  $> brew install zookeeper
+
+2.3) Install boost
+  $> brew install boost
+
+2.3.1) For production builds, see the readme.boost file  
+  
+  
+(Optional) Refresh protobuf source files
+
+When changes have been introduced to the protocol module, you might need 
to refresh the protobuf C++ source files too.
+  $> cd DRILL_DIR/contrib/native/client
+  $> mkdir build
+  $> cd build && cmake3 -G "XCode" -D CMAKE_BUILD_TYPE=Debug ..
+  $> xcodebuild -project drillclient.xcodeproj -configuration ${BUILDTYPE} 
-target fixProtobufs
+  $> xcodebuild -project drillclient.xcodeproj -configuration ${BUILDTYPE} 
-target cpProtobufs
+
+Open a pull request with the changes to 
DRILL_DIR/contrib/native/client/src/protobuf
+
+Build drill client
+---
+  $> cd DRILL_DIR/contrib/native/client
+  $> mkdir build
+  $> cd build && cmake3 -G "XCode" -D CMAKE_BUILD_TYPE=Debug ..
+  $> xcodebuild -project drillclient.xcodeproj -configuration ${BUILDTYPE} 
-target ALL_BUILD
+
+
+XCode IDE
+-
+  You can open the drillclient.xcodeproj file in the XCode ide and 
run/debug as with any other command line app
+
+Test
+
+Run query submitter from the command line
+  $> querySubmitter query='select * from 
dfs.`/Users/pchandra/work/data/tpc-h/customer.parquet`' type=sql 
connectStr=local=10.250.0.146:31010 api=async logLevel=trace user=yourUserName 
password=yourPassWord
+
+Valgrind
+
+  If you can get valgrind to build and run on macos, please update the 
instuctions here
--- End diff --

instruction


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #659: DRILL-5050: C++ client library has symbol resolutio...

[chunhui-shi]

Github user chunhui-shi commented on a diff in the pull request:

https://github.com/apache/drill/pull/659#discussion_r88766028
  
--- Diff: contrib/native/client/readme.boost ---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+Building Boost for Dill on MacOs
+
+
+These instreuctions are using Boost version 1.60.0 which is recommended
--- End diff --

instructions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #659: DRILL-5050: C++ client library has symbol resolutio...

[chunhui-shi]

Github user chunhui-shi commented on a diff in the pull request:

https://github.com/apache/drill/pull/659#discussion_r88765875
  
--- Diff: contrib/native/client/readme.boost ---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+Building Boost for Dill on MacOs
--- End diff --

Drill


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #659: DRILL-5050: C++ client library has symbol resolutio...

[laurentgo]

Github user laurentgo commented on a diff in the pull request:

https://github.com/apache/drill/pull/659#discussion_r88764054
  
--- Diff: contrib/native/client/CMakeLists.txt ---
@@ -88,19 +88,28 @@ if(MSVC)
 set(Boost_USE_STATIC_LIBS ON)
 set(Boost_USE_MULTITHREADED ON)
 set(Boost_USE_STATIC_RUNTIME OFF)
+elseif ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
+set(Boost_USE_STATIC_LIBS ON)
+set(Boost_USE_MULTITHREADED ON)
+#To build a production version, the macos build must use a shaded 
version
+#of boost. Arbirtarily, we choose the new namspace to be 
drill_boost.
+#See the instructions in the readme for the mac and rebuild boost. 
Then
+#uncomment the line below to build
+#set(Boost_NAMESPACE drill_boost)
--- End diff --

if the boost namespace is changed, I guess the code should be changed too? 
But it means that all boost symbols are changed too (included 
boost::shared_ptr<> which are part of the public API), correct?

In any case, can you also provide the changes to the source files?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #659: DRILL-5050: C++ client library has symbol resolutio...

[laurentgo]

Github user laurentgo commented on a diff in the pull request:

https://github.com/apache/drill/pull/659#discussion_r88763623
  
--- Diff: contrib/native/client/readme.macos ---
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+MacOS build (tested on OS X El Capitan)
+
+Install Prerequisites
+-
+
+0.1) Install XCode 
+  Download an istall from here: 
https://developer.apple.com/xcode/downloads/
--- End diff --

typo: install

Also XCode is available from the app store too...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #659: DRILL-5050: C++ client library has symbol resolutio...

[laurentgo]

Github user laurentgo commented on a diff in the pull request:

https://github.com/apache/drill/pull/659#discussion_r88763707
  
--- Diff: contrib/native/client/readme.macos ---
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+MacOS build (tested on OS X El Capitan)
+
+Install Prerequisites
+-
+
+0.1) Install XCode 
+  Download an istall from here: 
https://developer.apple.com/xcode/downloads/
+  In Terminal, install the command line tools 
+$> xcode-select --install
+
+0.2) Install brew following the instructions here: http://brew.sh/
+
+1) CMAKE 2.8 or above
--- End diff --

I think CMake3 and higher is required...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #659: DRILL-5050: C++ client library has symbol resolutio...

[laurentgo]

Github user laurentgo commented on a diff in the pull request:

https://github.com/apache/drill/pull/659#discussion_r88763696
  
--- Diff: contrib/native/client/readme.macos ---
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+MacOS build (tested on OS X El Capitan)
+
+Install Prerequisites
+-
+
+0.1) Install XCode 
+  Download an istall from here: 
https://developer.apple.com/xcode/downloads/
+  In Terminal, install the command line tools 
+$> xcode-select --install
+
+0.2) Install brew following the instructions here: http://brew.sh/
+
+1) CMAKE 2.8 or above
+  Download and install Cmake : https://cmake.org/download/
--- End diff --

not sure why not using brew here (it worked for me, binary is named cmake3)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #659: DRILL-5050: C++ client library has symbol resolutio...

[laurentgo]

Github user laurentgo commented on a diff in the pull request:

https://github.com/apache/drill/pull/659#discussion_r88763775
  
--- Diff: contrib/native/client/readme.macos ---
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+MacOS build (tested on OS X El Capitan)
+
+Install Prerequisites
+-
+
+0.1) Install XCode 
+  Download an istall from here: 
https://developer.apple.com/xcode/downloads/
+  In Terminal, install the command line tools 
+$> xcode-select --install
+
+0.2) Install brew following the instructions here: http://brew.sh/
+
+1) CMAKE 2.8 or above
+  Download and install Cmake : https://cmake.org/download/
+
+2.1) Install protobuf
+  $> brew install protobuf
--- End diff --

we might want to use protobuf-2.5.0 (same as the java version). I believe 
this is wire-compatible, but I don't know about the APIs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #659: DRILL-5050: C++ client library has symbol resolutio...

[laurentgo]

Github user laurentgo commented on a diff in the pull request:

https://github.com/apache/drill/pull/659#discussion_r88763555
  
--- Diff: contrib/native/client/readme.macos ---
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+MacOS build (tested on OS X El Capitan)
+
+Install Prerequisites
+-
+
+0.1) Install XCode 
+  Download an istall from here: 
https://developer.apple.com/xcode/downloads/
+  In Terminal, install the command line tools 
+$> xcode-select --install
+
+0.2) Install brew following the instructions here: http://brew.sh/
+
+1) CMAKE 2.8 or above
+  Download and install Cmake : https://cmake.org/download/
+
+2.1) Install protobuf
+  $> brew install protobuf
+
+2.2) Install zookeeper
+  $> brew install zookeeper
+
+2.3) Install boost
+  $> brew install boost
+
+2.3.1) For production builds, see the readme.boost file  
+  
+  
+(Optional) Refresh protobuf source files
+
+When changes have been introduced to the protocol module, you might need 
to refresh the protobuf C++ source files too.
+  $> cd DRILL_DIR/contrib/native/client
+  $> mkdir build
+  $> cd build && cmake3 -G "XCode" -D CMAKE_BUILD_TYPE=Debug ..
+  $> xcodebuild -project drillclient.xcodeproj -configuration ${BUILDTYPE} 
-target fixProtobufs
+  $> xcodebuild -project drillclient.xcodeproj -configuration ${BUILDTYPE} 
-target cpProtobufs
+
+Open a pull request with the changes to 
DRILL_DIR/contrib/native/client/src/protobuf
+
+Build drill client
+---
+  $> cd DRILL_DIR/contrib/native/client
+  $> mkdir build
+  $> cd build && cmake3 -G "XCode" -D CMAKE_BUILD_TYPE=Debug ..
+  $> xcodebuild -project drillclient.xcodeproj -configuration ${BUILDTYPE} 
-target ALL_BUILD
+
+
+XCode IDE
+-
+  You can open the drillclient.xcodeproj file in the XCode ide and 
run/debug as with any other command line app
+
+Test
+
+Run query submitter from the command line
+  $> querySubmitter query='select * from 
dfs.`/Users/pchandra/work/data/tpc-h/customer.parquet`' type=sql 
connectStr=local=10.250.0.146:31010 api=async logLevel=trace user=yourUserName 
password=yourPassWord
+
+Valgrind
+
+  If you can get valgrind to build and run on macos, please update the 
instuctions here
--- End diff --

you can use brew (I personally used it without issue)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [ANNOUNCE] - New Apache Drill Committer - Neeraja Rentachintala

[Rachel Silver]

Congrats!

On Fri, Nov 18, 2016 at 3:58 PM, yuliya Feldman  wrote:

> Congratulations Neeraja!!!
>
>   From: Parth Chandra 
>  To: dev 
>  Sent: Thursday, November 17, 2016 11:10 AM
>  Subject: [ANNOUNCE] - New Apache Drill Committer - Neeraja Rentachintala
>
> On behalf of the Apache Drill PMC, I am very pleased to announce that
> Neeraja Rentachintala has accepted the invitation to become a committer in
> the project.
>
>
> Welcome Neeraja !
>
>
>
>



-- 

Rachel Asher Silver

Product Manager - Hadoop Ecosystem

(412)253-2954



Now Available - Free Hadoop On-Demand Training

[GitHub] drill pull request #659: DRILL-5050: C++ client library has symbol resolutio...

[parthchandra]

GitHub user parthchandra opened a pull request:

https://github.com/apache/drill/pull/659

DRILL-5050: C++ client library has symbol resolution issues

when loaded by a process that already uses boost::asio

Build with Boost static libs and drill_boost namespace on mac. Added
readme with instructions

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/parthchandra/drill DRILL-5050

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/659.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #659


commit 49dc23f101bdcf4b97e10e355486f98c5d54a6c9
Author: Parth Chandra 
Date:   2016-11-14T22:01:29Z

DRILL-5050: C++ client library has symbol resolution issues
when loaded by a process that already uses boost::asio

Build with Boost static libs and drill_boost namespace on mac. Added
readme with instructions




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[VOTE] Release Apache Drill 1.9.0 RC2

[Sudheesh Katkam]

Hi all,

I would like to propose the third release candidate (RC2) of Apache Drill,
version 1.9.0. Thanks to everyone who contributed to this release!

+ Compared to RC0, this release candidate does not contain DRILL-4373, due
to a regression (DRILL-5034).
+ Compared to RC1, this release candidate contains DRILL-5047.

+ The release candidate covers a total of 72 resolved JIRAs [1]. This is
fewer than what was mentioned for RC1, which was actually incorrect.
+ The tarball artifacts are hosted at [2], and the maven artifacts are
hosted at [3].
+ This release candidate is based on commit
4312d65bd5e0f68dc963ed722d0cdfd2628ea5f5 located at [4].
+ The artifacts are signed with the key at [5].

The vote ends at 2:00 PM PT, November 23rd, 2016. Please vote early.

Here's my vote: +1

Thank you,
Sudheesh

[1] https://issues.apache.org/jira/secure/ReleaseNote.jspa?
projectId=12313820=12337861
[2] http://people.apache.org/~sudheesh/drill/releases/1.9.0/rc2/
[3] https://repository.apache.org/content/repositories/orgapachedrill-1039/
[4] https://github.com/sudheeshkatkam/drill/commits/drill-1.9.0
[5] https://people.apache.org/keys/committer/sudheesh.asc

Re: [ANNOUNCE] - New Apache Drill Committer - Neeraja Rentachintala

[yuliya Feldman]

Congratulations Neeraja!!!

  From: Parth Chandra 
 To: dev  
 Sent: Thursday, November 17, 2016 11:10 AM
 Subject: [ANNOUNCE] - New Apache Drill Committer - Neeraja Rentachintala
   
On behalf of the Apache Drill PMC, I am very pleased to announce that
Neeraja Rentachintala has accepted the invitation to become a committer in
the project.


Welcome Neeraja !


   

Build failed in Jenkins: drill-scm #796

[Apache Jenkins Server]

See 

Changes:

[sudheesh] DRILL-5047: When session option is string, query profile is displayed

--
[...truncated 5064 lines...]
[INFO] skip non existing resourceDirectory 

[INFO] 
[INFO] --- maven-resources-plugin:2.6:copy-resources (copy-gis-sample-data) @ 
drill-gis ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.5:process (default) @ drill-gis ---
[INFO] 
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ drill-gis 
---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ drill-gis ---
[INFO] Compiling 6 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ 
drill-gis ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
drill-gis ---
[INFO] Compiling 2 source files to 

[INFO] 
[INFO] --- maven-surefire-plugin:2.17:test (default-test) @ drill-gis ---
[INFO] Tests are skipped.
[INFO] 
[INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ drill-gis ---
[INFO] Building jar: 

[INFO] 
[INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-descriptor) @ 
drill-gis ---
[INFO] 
[INFO] --- maven-jar-plugin:2.4:test-jar (default) @ drill-gis ---
[INFO] Building jar: 

[INFO] 
[INFO] --- maven-checkstyle-plugin:2.12.1:check (checkstyle-validation) @ 
drill-gis ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- maven-enforcer-plugin:1.3.1:enforce (avoid_bad_dependencies) @ 
drill-gis ---
[INFO] 
[INFO] --- maven-install-plugin:2.5.1:install (default-install) @ drill-gis ---
[INFO] Installing 

 to 
/home/jenkins/.m2/repository/org/apache/drill/contrib/drill-gis/1.9.0-SNAPSHOT/drill-gis-1.9.0-SNAPSHOT.jar
[INFO] Installing 
 to 
/home/jenkins/.m2/repository/org/apache/drill/contrib/drill-gis/1.9.0-SNAPSHOT/drill-gis-1.9.0-SNAPSHOT.pom
[INFO] Installing 

 to 
/home/jenkins/.m2/repository/org/apache/drill/contrib/drill-gis/1.9.0-SNAPSHOT/drill-gis-1.9.0-SNAPSHOT-tests.jar
[INFO] 
[INFO] 
[INFO] Building Packaging and Distribution Assembly 1.9.0-SNAPSHOT
[INFO] 
Downloading: 
http://repository.mapr.com/maven/joda-time/joda-time/maven-metadata.xml
Downloading: 
http://repository.mapr.com/nexus/content/repositories/drill-optiq/joda-time/joda-time/maven-metadata.xml
Downloading: 
http://repo.dremio.com/release/joda-time/joda-time/maven-metadata.xml
Downloading: 
http://repository.mapr.com/nexus/content/repositories/drill/joda-time/joda-time/maven-metadata.xml
 
Downloading: 
https://oss.sonatype.org/content/repositories/snapshots/joda-time/joda-time/maven-metadata.xml
 
Downloading: 
http://repository.apache.org/snapshots/joda-time/joda-time/maven-metadata.xml
 
 
Downloading: 
https://repo.maven.apache.org/maven2/joda-time/joda-time/maven-metadata.xml
Downloading: 
https://repository.apache.org/content/repositories/snapshots/joda-time/joda-time/maven-metadata.xml
 
Downloading: 
http://repository.jboss.org/nexus/content/groups/public/joda-time/joda-time/maven-metadata.xml
 
 
228/228 B   

Downloaded: 
http://repository.jboss.org/nexus/content/groups/public/joda-time/joda-time/maven-metadata.xml
 (228 B at 0.7 KB/sec)

[WARNING] Could not transfer metadata joda-time:joda-time/maven-metadata.xml 
from/to central (https://repo.maven.apache.org/maven2): hostname in certificate 
didn't match:  !=  OR 
[WARNING] Failure to transfer org.slf4j:slf4j-api/maven-metadata.xml from 
https://repo.maven.apache.org/maven2 was cached in the local repository, 
resolution will not be reattempted until the update interval of central has 
elapsed or updates are 

[GitHub] drill issue #655: DRILL-5047: When session option is string, query profile i...

[gparai]

Github user gparai commented on the issue:

https://github.com/apache/drill/pull/655
  
Thanks for the explanation and the corresponding changes. LGTM.
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [ANNOUNCE] - New Apache Drill Committer - Neeraja Rentachintala

[Srabasti Banerjee]

Congratulations Neeraja! Well deserved :-)
ThanksSrabasti
 

On Friday, 18 November 2016 8:35 AM, Sudheesh Katkam  
wrote:
 

 Congratulations Neeraja!

> On Nov 18, 2016, at 2:55 AM, Tugdual Grall  wrote:
> 
> Congrats Neeraja!
> 
> t
> 
> On Thu, Nov 17, 2016 at 9:21 PM, Chunhui Shi  wrote:
> 
>> Congratulations!
>> 
>> 
>> On Thu, Nov 17, 2016 at 11:23 AM, Subbu Srinivasan <
>> ssriniva...@zscaler.com>
>> wrote:
>> 
>>> Congrats.
>>> Wish I had more time to contribute more(, perils of working in a
>>> startup)
>>> 
>>> 
>>> On Thu, Nov 17, 2016 at 11:18 AM, Jason Altekruse 
>>> wrote:
>>> 
 Congratulations! Thanks for all your contributions to Drill!
 
 Jason Altekruse
 Software Engineer at Dremio
 Apache Drill Committer
 
 On Thu, Nov 17, 2016 at 11:12 AM, Abhishek Girish 
 wrote:
 
> Congrats Neeraja!
> 
> On Thu, Nov 17, 2016 at 11:10 AM, Parth Chandra 
 wrote:
> 
>> On behalf of the Apache Drill PMC, I am very pleased to announce
>> that
>> Neeraja Rentachintala has accepted the invitation to become a
>>> committer
> in
>> the project.
>> 
>> 
>> Welcome Neeraja !
>> 
> 
 
>>> 
>> 



   

Re: [RESULT] [VOTE] Release Apache Drill 1.9.0 RC1

[Sudheesh Katkam]

I agree that the issue is not a regression. So I’ll go ahead with the getting 
the next release candidate out today.

- Sudheesh

> On Nov 18, 2016, at 9:39 AM, Jacques Nadeau  wrote:
> 
> It sounds like the issue is constrained only to JDBC then, despite my
> previous concerns. It also isn't a regression. As such, I guess it it
> shouldn't really be a blocker to the release. When I first saw the trace, I
> thought it was related to the new parallelization changes and was a
> regression.
> 
> --
> Jacques Nadeau
> CTO and Co-Founder, Dremio
> 
> On Fri, Nov 18, 2016 at 9:28 AM, Sudheesh Katkam  >
> wrote:
> 
>> Venki, could you please take a look, since you are most familiar with that
>> piece of code? Or anyone else wants to take a look?
>> 
>> The issue can be reproduced with a simple unit test. In
>> TestJdbcPluginWithDerbyIT, add this test. and then run “mvn install” in the
>> storage-jdbc sub-project.
>> 
>> @Test // DRILL-4984
>> public void limit0() throws Exception {
>>testNoResult("SELECT * FROM derby.DRILL_DERBY_TEST.PERSON LIMIT
>> 0");
>> }
>> 
>> In the ticket, Hogler suggested “adding a check for null in
>> FindHardDistributionScans.java @line 55 before calling getDrillTable()”.
>> But that check may not be sufficient (I could be wrong) because the check
>> does not imply if “contains” should be set to true/false. The call to
>> unwrap() returns a different type of table (not DrillTable or
>> DrillTranslatableTable), and that may need to be investigated.
>> 
>> Thank you,
>> Sudheesh
>> 
>>> On Nov 17, 2016, at 10:09 PM, Jacques Nadeau  wrote:
>>> 
>>> It might make sense for someone to look at this jira before rolling
>> another
>>> release: DRILL-4984
>>> 
>>> The stacktrace looks like it might be an issue with the new hard
>>> parallelization algorithm which could potentially influence all sources.
>> It
>>> might not have shown up in traditional regression tests if those always
>>> have source/drillbit affinity (just a random guess).
>>> 
>>> --
>>> Jacques Nadeau
>>> CTO and Co-Founder, Dremio
>>> 
>>> On Thu, Nov 17, 2016 at 10:50 AM, Sudheesh Katkam > >>
>>> wrote:
>>> 
 Hi all,
 
 I had not noticed that Gautam mentioned about a potential bug. That is a
 -1 from me on the proposed candidate; the bug is a regression in
>> behavior.
 I did not push the release artifacts until now, and the announcement is
>> not
 out.
 
 The issue is that the query profile is not displayed past the point of
 failure (trying to show a changed string option). So I will propose
>> another
 candidate once this issue is fixed [1, 2].
 
 In the mean time, please test the candidate for other regressions.
 
 Thank you,
 Sudheesh
 
 [1] https://issues.apache.org/jira/browse/DRILL-5047 <
 https://issues.apache.org/jira/browse/DRILL-5047 <
>> https://issues.apache.org/jira/browse/DRILL-5047 
>> >>
 [2] https://github.com/apache/drill/pull/655 
  <
>> https://github.com/apache/drill/pull/655 
>> > >  <
>> https://github.com/apache/ >
 drill/pull/655>
 
> On Nov 16, 2016, at 7:15 PM, Sudheesh Katkam 
 wrote:
> 
> The proposal passes!
> 
> Final tally:
> 
> 3 binding +1s
> + Sudheesh
> + Aman
> + Parth
> 
> 12 non-binding +1s
> + Khurram
> + Dechang
> + Rahul
> + Chunhui
> + Karthikeyan
> + Robert
> + Paul
> + Krystal
> + Sorabh
> + Abhishek
> + Kunal
> + Gautam
> 
> No 0s or -1s
> 
> I'll push the release artifacts, and send an announcement once
 propagated. Thanks to everyone involved!
> 
> Thank you,
> Sudheesh
> 
>> On Nov 16, 2016, at 6:23 PM, Gautam Parai 
>> wrote:
>> 
>> +1 (non-binding)
>> 
>> Built from source on Linux VM and Mac.
>> Ran unit tests.
>> Ran new tests derived from bugs (Drill-4986/Drill-4771/Drill-
>> 4792/Drill-4927)
>> Ran some random queries
>> 
>> Found a potential bug (NON-blocker) in Drill-4792.
>> 
>> LGTM
>> 
>> On Wed, Nov 16, 2016 at 5:52 PM, Kunal Khatua 
 wrote:
>> 
>>> +1 (non-binding)
>>> 
>>> Built from the GitHub repo and deployed on a 10-node setup.
>>> Ran a bunch of queries and verified the profiles as well.
>>> 
>>> LGTM.
>>> 
>>> 
>>> On Wed 16-Nov-2016 3:41:03 PM, Abhishek Girish 
 wrote:
>>> +1 (non-binding)
>>> 
>>> Built from source. Ran Functional and 

[GitHub] drill issue #655: DRILL-5047: When session option is string, query profile i...

[arina-ielchiieva]

Github user arina-ielchiieva commented on the issue:

https://github.com/apache/drill/pull/655
  
Replaced `HashMap` with `TreeMap` for sorted display.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #655: DRILL-5047: When session option is string, query pr...

[arina-ielchiieva]

Github user arina-ielchiieva commented on a diff in the pull request:

https://github.com/apache/drill/pull/655#discussion_r88702773
  
--- Diff: exec/java-exec/src/main/resources/rest/profile/profile.ftl ---
@@ -129,10 +130,10 @@
 
   
   
-<#list model.getOptionList() as option>
+<#list options?keys as name>
--- End diff --

Agree. I'll make fix shortly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [RESULT] [VOTE] Release Apache Drill 1.9.0 RC1

[Jacques Nadeau]

It sounds like the issue is constrained only to JDBC then, despite my
previous concerns. It also isn't a regression. As such, I guess it it
shouldn't really be a blocker to the release. When I first saw the trace, I
thought it was related to the new parallelization changes and was a
regression.

--
Jacques Nadeau
CTO and Co-Founder, Dremio

On Fri, Nov 18, 2016 at 9:28 AM, Sudheesh Katkam 
wrote:

> Venki, could you please take a look, since you are most familiar with that
> piece of code? Or anyone else wants to take a look?
>
> The issue can be reproduced with a simple unit test. In
> TestJdbcPluginWithDerbyIT, add this test. and then run “mvn install” in the
> storage-jdbc sub-project.
>
> @Test // DRILL-4984
> public void limit0() throws Exception {
> testNoResult("SELECT * FROM derby.DRILL_DERBY_TEST.PERSON LIMIT
> 0");
> }
>
> In the ticket, Hogler suggested “adding a check for null in
> FindHardDistributionScans.java @line 55 before calling getDrillTable()”.
> But that check may not be sufficient (I could be wrong) because the check
> does not imply if “contains” should be set to true/false. The call to
> unwrap() returns a different type of table (not DrillTable or
> DrillTranslatableTable), and that may need to be investigated.
>
> Thank you,
> Sudheesh
>
> > On Nov 17, 2016, at 10:09 PM, Jacques Nadeau  wrote:
> >
> > It might make sense for someone to look at this jira before rolling
> another
> > release: DRILL-4984
> >
> > The stacktrace looks like it might be an issue with the new hard
> > parallelization algorithm which could potentially influence all sources.
> It
> > might not have shown up in traditional regression tests if those always
> > have source/drillbit affinity (just a random guess).
> >
> > --
> > Jacques Nadeau
> > CTO and Co-Founder, Dremio
> >
> > On Thu, Nov 17, 2016 at 10:50 AM, Sudheesh Katkam  >
> > wrote:
> >
> >> Hi all,
> >>
> >> I had not noticed that Gautam mentioned about a potential bug. That is a
> >> -1 from me on the proposed candidate; the bug is a regression in
> behavior.
> >> I did not push the release artifacts until now, and the announcement is
> not
> >> out.
> >>
> >> The issue is that the query profile is not displayed past the point of
> >> failure (trying to show a changed string option). So I will propose
> another
> >> candidate once this issue is fixed [1, 2].
> >>
> >> In the mean time, please test the candidate for other regressions.
> >>
> >> Thank you,
> >> Sudheesh
> >>
> >> [1] https://issues.apache.org/jira/browse/DRILL-5047 <
> >> https://issues.apache.org/jira/browse/DRILL-5047 <
> https://issues.apache.org/jira/browse/DRILL-5047>>
> >> [2] https://github.com/apache/drill/pull/655 <
> https://github.com/apache/drill/pull/655>  https://github.com/apache/>
> >> drill/pull/655>
> >>
> >>> On Nov 16, 2016, at 7:15 PM, Sudheesh Katkam 
> >> wrote:
> >>>
> >>> The proposal passes!
> >>>
> >>> Final tally:
> >>>
> >>> 3 binding +1s
> >>> + Sudheesh
> >>> + Aman
> >>> + Parth
> >>>
> >>> 12 non-binding +1s
> >>> + Khurram
> >>> + Dechang
> >>> + Rahul
> >>> + Chunhui
> >>> + Karthikeyan
> >>> + Robert
> >>> + Paul
> >>> + Krystal
> >>> + Sorabh
> >>> + Abhishek
> >>> + Kunal
> >>> + Gautam
> >>>
> >>> No 0s or -1s
> >>>
> >>> I'll push the release artifacts, and send an announcement once
> >> propagated. Thanks to everyone involved!
> >>>
> >>> Thank you,
> >>> Sudheesh
> >>>
>  On Nov 16, 2016, at 6:23 PM, Gautam Parai 
> wrote:
> 
>  +1 (non-binding)
> 
>  Built from source on Linux VM and Mac.
>  Ran unit tests.
>  Ran new tests derived from bugs (Drill-4986/Drill-4771/Drill-
>  4792/Drill-4927)
>  Ran some random queries
> 
>  Found a potential bug (NON-blocker) in Drill-4792.
> 
>  LGTM
> 
>  On Wed, Nov 16, 2016 at 5:52 PM, Kunal Khatua 
> >> wrote:
> 
> > +1 (non-binding)
> >
> > Built from the GitHub repo and deployed on a 10-node setup.
> > Ran a bunch of queries and verified the profiles as well.
> >
> > LGTM.
> >
> >
> > On Wed 16-Nov-2016 3:41:03 PM, Abhishek Girish 
> >> wrote:
> > +1 (non-binding)
> >
> > Built from source. Ran Functional and Advanced tests from [1]. Sanity
> > tested Sqlline and Web UI. Looks good.
> >
> >
> > [1] https://github.com/mapr/drill-test-framework.git
> >
> >
> > On Wed, Nov 16, 2016 at 3:37 PM, Sorabh Hamirwasia
> >> wrote:
> >
> >> +1 (non-binding)
> >> Built from source and successfully ran unit tests.
> >> Ran both in embedded and distributed mode.
> >> Verified DRILL-4972 / DRILL-4964
> >> Ran some basic query on sys tables and sample data.
> >>
> >> Looks good.
> >>
> >>
> >> On Wed, Nov 16, 2016 at 

[GitHub] drill pull request #655: DRILL-5047: When session option is string, query pr...

[paul-rogers]

Github user paul-rogers commented on a diff in the pull request:

https://github.com/apache/drill/pull/655#discussion_r88701851
  
--- Diff: exec/java-exec/src/main/resources/rest/profile/profile.ftl ---
@@ -129,10 +130,10 @@
 
   
   
-<#list model.getOptionList() as option>
+<#list options?keys as name>
--- End diff --

Neither this nor the original design displays the keys as sorted. Sorted 
display is a fairly traditional to save the user from a random search for each 
value. Since we are changing the behavior, should we fix the sorting issue as 
well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [RESULT] [VOTE] Release Apache Drill 1.9.0 RC1

[Sudheesh Katkam]

Venki, could you please take a look, since you are most familiar with that 
piece of code? Or anyone else wants to take a look?

The issue can be reproduced with a simple unit test. In 
TestJdbcPluginWithDerbyIT, add this test. and then run “mvn install” in the 
storage-jdbc sub-project.

@Test // DRILL-4984
public void limit0() throws Exception {
testNoResult("SELECT * FROM derby.DRILL_DERBY_TEST.PERSON LIMIT 0");
}

In the ticket, Hogler suggested “adding a check for null in 
FindHardDistributionScans.java @line 55 before calling getDrillTable()”. But 
that check may not be sufficient (I could be wrong) because the check does not 
imply if “contains” should be set to true/false. The call to unwrap() returns a 
different type of table (not DrillTable or DrillTranslatableTable), and that 
may need to be investigated.

Thank you,
Sudheesh

> On Nov 17, 2016, at 10:09 PM, Jacques Nadeau  wrote:
> 
> It might make sense for someone to look at this jira before rolling another
> release: DRILL-4984
> 
> The stacktrace looks like it might be an issue with the new hard
> parallelization algorithm which could potentially influence all sources. It
> might not have shown up in traditional regression tests if those always
> have source/drillbit affinity (just a random guess).
> 
> --
> Jacques Nadeau
> CTO and Co-Founder, Dremio
> 
> On Thu, Nov 17, 2016 at 10:50 AM, Sudheesh Katkam  >
> wrote:
> 
>> Hi all,
>> 
>> I had not noticed that Gautam mentioned about a potential bug. That is a
>> -1 from me on the proposed candidate; the bug is a regression in behavior.
>> I did not push the release artifacts until now, and the announcement is not
>> out.
>> 
>> The issue is that the query profile is not displayed past the point of
>> failure (trying to show a changed string option). So I will propose another
>> candidate once this issue is fixed [1, 2].
>> 
>> In the mean time, please test the candidate for other regressions.
>> 
>> Thank you,
>> Sudheesh
>> 
>> [1] https://issues.apache.org/jira/browse/DRILL-5047 <
>> https://issues.apache.org/jira/browse/DRILL-5047 
>> >
>> [2] https://github.com/apache/drill/pull/655 
>>  > 
>> drill/pull/655>
>> 
>>> On Nov 16, 2016, at 7:15 PM, Sudheesh Katkam 
>> wrote:
>>> 
>>> The proposal passes!
>>> 
>>> Final tally:
>>> 
>>> 3 binding +1s
>>> + Sudheesh
>>> + Aman
>>> + Parth
>>> 
>>> 12 non-binding +1s
>>> + Khurram
>>> + Dechang
>>> + Rahul
>>> + Chunhui
>>> + Karthikeyan
>>> + Robert
>>> + Paul
>>> + Krystal
>>> + Sorabh
>>> + Abhishek
>>> + Kunal
>>> + Gautam
>>> 
>>> No 0s or -1s
>>> 
>>> I'll push the release artifacts, and send an announcement once
>> propagated. Thanks to everyone involved!
>>> 
>>> Thank you,
>>> Sudheesh
>>> 
 On Nov 16, 2016, at 6:23 PM, Gautam Parai  wrote:
 
 +1 (non-binding)
 
 Built from source on Linux VM and Mac.
 Ran unit tests.
 Ran new tests derived from bugs (Drill-4986/Drill-4771/Drill-
 4792/Drill-4927)
 Ran some random queries
 
 Found a potential bug (NON-blocker) in Drill-4792.
 
 LGTM
 
 On Wed, Nov 16, 2016 at 5:52 PM, Kunal Khatua 
>> wrote:
 
> +1 (non-binding)
> 
> Built from the GitHub repo and deployed on a 10-node setup.
> Ran a bunch of queries and verified the profiles as well.
> 
> LGTM.
> 
> 
> On Wed 16-Nov-2016 3:41:03 PM, Abhishek Girish 
>> wrote:
> +1 (non-binding)
> 
> Built from source. Ran Functional and Advanced tests from [1]. Sanity
> tested Sqlline and Web UI. Looks good.
> 
> 
> [1] https://github.com/mapr/drill-test-framework.git
> 
> 
> On Wed, Nov 16, 2016 at 3:37 PM, Sorabh Hamirwasia
>> wrote:
> 
>> +1 (non-binding)
>> Built from source and successfully ran unit tests.
>> Ran both in embedded and distributed mode.
>> Verified DRILL-4972 / DRILL-4964
>> Ran some basic query on sys tables and sample data.
>> 
>> Looks good.
>> 
>> 
>> On Wed, Nov 16, 2016 at 2:49 PM, Krystal Nguyen
>> wrote:
>> 
>>> +1 (non-binding)
>>> Built from source. Tested the WebUI including authentication. Tested
>>> sqlline.
>>> 
>>> On Wed, Nov 16, 2016 at 1:59 PM, Paul Rogers
>> wrote:
>>> 
 +1 (non-binding)
 Built from source
 Ran script unit tests to verify config settings, etc.
 
 Looks good.
 
 - Paul
 
> On Nov 16, 2016, at 1:46 PM, Robert Hou wrote:
> 
> +1 (non-binding)
> 
> Built from source.
> Tested parquet filter pushdown.
> 
> On Wed, Nov 16, 2016 at 1:22 PM, 

[GitHub] drill issue #655: DRILL-5047: When session option is string, query profile i...

[sudheeshkatkam]

Github user sudheeshkatkam commented on the issue:

https://github.com/apache/drill/pull/655
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [ANNOUNCE] - New Apache Drill Committer - Neeraja Rentachintala

[Sudheesh Katkam]

Congratulations Neeraja!

> On Nov 18, 2016, at 2:55 AM, Tugdual Grall  wrote:
> 
> Congrats Neeraja!
> 
> t
> 
> On Thu, Nov 17, 2016 at 9:21 PM, Chunhui Shi  wrote:
> 
>> Congratulations!
>> 
>> 
>> On Thu, Nov 17, 2016 at 11:23 AM, Subbu Srinivasan <
>> ssriniva...@zscaler.com>
>> wrote:
>> 
>>> Congrats.
>>> Wish I had more time to contribute more(, perils of working in a
>>> startup)
>>> 
>>> 
>>> On Thu, Nov 17, 2016 at 11:18 AM, Jason Altekruse 
>>> wrote:
>>> 
 Congratulations! Thanks for all your contributions to Drill!
 
 Jason Altekruse
 Software Engineer at Dremio
 Apache Drill Committer
 
 On Thu, Nov 17, 2016 at 11:12 AM, Abhishek Girish 
 wrote:
 
> Congrats Neeraja!
> 
> On Thu, Nov 17, 2016 at 11:10 AM, Parth Chandra 
 wrote:
> 
>> On behalf of the Apache Drill PMC, I am very pleased to announce
>> that
>> Neeraja Rentachintala has accepted the invitation to become a
>>> committer
> in
>> the project.
>> 
>> 
>> Welcome Neeraja !
>> 
> 
 
>>> 
>> 

[GitHub] drill pull request #658: DRILL-5051: Fix incorrect result returned in nest q...

[zbdzzg]

GitHub user zbdzzg opened a pull request:

https://github.com/apache/drill/pull/658

DRILL-5051: Fix incorrect result returned in nest query with offset 
specified

1. Fix this problem.
2. Merge two limit methods, most of code is the same.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zbdzzg/drill master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/658.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #658


commit 982b8c2bfa742feffb551ba5bfb66ba01b38d839
Author: hongze.zhz 
Date:   2016-11-18T12:11:38Z

DRILL-5051: Fix incorrect result returned in nest query with offset 
specified




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [ANNOUNCE] - New Apache Drill Committer - Neeraja Rentachintala

[Tugdual Grall]

Congrats Neeraja!

t

On Thu, Nov 17, 2016 at 9:21 PM, Chunhui Shi  wrote:

> Congratulations!
>
>
> On Thu, Nov 17, 2016 at 11:23 AM, Subbu Srinivasan <
> ssriniva...@zscaler.com>
> wrote:
>
> > Congrats.
> >  Wish I had more time to contribute more(, perils of working in a
> > startup)
> >
> >
> > On Thu, Nov 17, 2016 at 11:18 AM, Jason Altekruse 
> > wrote:
> >
> > > Congratulations! Thanks for all your contributions to Drill!
> > >
> > > Jason Altekruse
> > > Software Engineer at Dremio
> > > Apache Drill Committer
> > >
> > > On Thu, Nov 17, 2016 at 11:12 AM, Abhishek Girish 
> > > wrote:
> > >
> > > > Congrats Neeraja!
> > > >
> > > > On Thu, Nov 17, 2016 at 11:10 AM, Parth Chandra 
> > > wrote:
> > > >
> > > > > On behalf of the Apache Drill PMC, I am very pleased to announce
> that
> > > > > Neeraja Rentachintala has accepted the invitation to become a
> > committer
> > > > in
> > > > > the project.
> > > > >
> > > > >
> > > > > Welcome Neeraja !
> > > > >
> > > >
> > >
> >
>

[jira] [Created] (DRILL-5051) Returning incorrect number of rows while querying using both nested select and offset

[Hongze Zhang (JIRA)]

Hongze Zhang created DRILL-5051:
---

 Summary: Returning incorrect number of rows while querying using 
both nested select and offset
 Key: DRILL-5051
 URL: https://issues.apache.org/jira/browse/DRILL-5051
 Project: Apache Drill
  Issue Type: Bug
  Components: Query Planning & Optimization
Affects Versions: 1.8.0
 Environment: Fedora 24 / OpenJDK 8
Reporter: Hongze Zhang
 Fix For: Future


My SQl:

select count(1) from (select id from (select id from cp.`tpch/lineitem.parquet` 
LIMIT 2) limit 1 offset 1) 

This SQL returns nothing.

Something goes wrong in LimitRecordBatch.java, and the reason is different with 
[DRILL-4884|https://issues.apache.org/jira/browse/DRILL-4884?filter=-2]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] drill issue #655: DRILL-5047: When session option is string, query profile i...

[arina-ielchiieva]

Github user arina-ielchiieva commented on the issue:

https://github.com/apache/drill/pull/655
  
Answering to all comments in one:
1. `${option.getValue()}` is not sufficient since method returns Object and 
freemarker does not know how to cast it.
2. `?c` only works with boolean and numbers, since options can be string, 
it not sufficient
3. `?string` works with most of the types but it's true for boolean seems 
to be deprecated
4. to set null value to option is not possible (handled in 
SetOptionHandler.class) but option.getValue() may return null according to the 
code.

Paul's idea to prepare options to display on Java side seems to be the most 
reasonable.
So I have updated the pull request, added new method in 
ProfileWrapper.class with transforms `OptionValueList` into `Map`. If option value is null, it will be displayed as word 'null'.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #657: DRILL-5048: AssertionError when case statement is u...

[Serhii-Harnyk]

GitHub user Serhii-Harnyk opened a pull request:

https://github.com/apache/drill/pull/657

DRILL-5048: AssertionError when case statement is used with timestamp…

… and null

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Serhii-Harnyk/drill DRILL-5048

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/657.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #657


commit 66823553ec9074ee0adbb93f02cc86f41040d81b
Author: Serhii-Harnyk 
Date:   2016-11-17T14:23:58Z

DRILL-5048: AssertionError when case statement is used with timestamp and 
null




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---