date:20170308

[jira] [Resolved] (DRILL-5278) CTTAS store.format=csv, returns one extra record

2017-03-08 Thread Khurram Faraaz (JIRA)


 [ 
https://issues.apache.org/jira/browse/DRILL-5278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Khurram Faraaz resolved DRILL-5278.
---
Resolution: Not A Bug

> CTTAS store.format=csv, returns one extra record
> 
>
> Key: DRILL-5278
> URL: https://issues.apache.org/jira/browse/DRILL-5278
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Storage - Text & CSV
>Affects Versions: 1.10.0
>Reporter: Khurram Faraaz
>
> When store.format = csv, we see incorrect results returned, an extra record 
> is returned, as compared to when store.format = parquet. The difference is 
> seen when doing a count over a temporary table created in Drill.
> Drill 1.10.0 git commit ID : 300e9349
> Steps to reproduce the problem.
> {noformat}
> 0: jdbc:drill:schema=dfs.tmp> reset all;
> +---+---+
> |  ok   |summary|
> +---+---+
> | true  | ALL updated.  |
> +---+---+
> 1 row selected (0.279 seconds)
> 0: jdbc:drill:schema=dfs.tmp> ALTER SESSION SET `store.format`='csv';
> +---++
> |  ok   |summary |
> +---++
> | true  | store.format updated.  |
> +---++
> 1 row selected (0.21 seconds)
> 0: jdbc:drill:schema=dfs.tmp> CREATE TEMPORARY TABLE dfs.tmp.temp_tbl
> . . . . . . . . . . . . . . > AS
> . . . . . . . . . . . . . . > SELECT * FROM typeall_l;
> +---++
> | Fragment  | Number of records written  |
> +---++
> | 0_0   | 105|
> +---++
> 1 row selected (0.233 seconds)
> 0: jdbc:drill:schema=dfs.tmp> SELECT COUNT(*) FROM dfs.tmp.temp_tbl;
> +-+
> | EXPR$0  |
> +-+
> | 106 |
> +-+
> 1 row selected (0.189 seconds)
> 0: jdbc:drill:schema=dfs.tmp> drop table dfs.tmp.temp_tbl;
> +---+-+
> |  ok   |   summary   |
> +---+-+
> | true  | Temporary table [temp_tbl] dropped  |
> +---+-+
> 1 row selected (0.186 seconds)
> 0: jdbc:drill:schema=dfs.tmp> ALTER SESSION SET `store.format`='parquet';
> +---++
> |  ok   |summary |
> +---++
> | true  | store.format updated.  |
> +---++
> 1 row selected (0.196 seconds)
> 0: jdbc:drill:schema=dfs.tmp> CREATE TEMPORARY TABLE dfs.tmp.temp_tbl
> . . . . . . . . . . . . . . > AS
> . . . . . . . . . . . . . . > SELECT * FROM typeall_l;
> +---++
> | Fragment  | Number of records written  |
> +---++
> | 0_0   | 105|
> +---++
> 1 row selected (0.263 seconds)
> 0: jdbc:drill:schema=dfs.tmp> SELECT COUNT(*) FROM dfs.tmp.temp_tbl;
> +-+
> | EXPR$0  |
> +-+
> | 105 |
> +-+
> 1 row selected (0.169 seconds)
> 0: jdbc:drill:schema=dfs.tmp> drop table dfs.tmp.temp_tbl;
> +---+-+
> |  ok   |   summary   |
> +---+-+
> | true  | Temporary table [temp_tbl] dropped  |
> +---+-+
> 1 row selected (0.165 seconds)
> 0: jdbc:drill:schema=dfs.tmp>
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] drill pull request #776: DRILL-5165: limitRel to return correct rows for lim...

2017-03-08 Thread chunhui-shi

GitHub user chunhui-shi opened a pull request:

https://github.com/apache/drill/pull/776

DRILL-5165: limitRel to return correct rows for limit all case



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/chunhui-shi/drill DRILL-5165

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/776.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #776


commit cd10342fbcf4b3779b006515fb940137d9035157
Author: chunhui-shi 
Date:   2017-03-08T07:39:32Z

DRILL-5165: limitRel to return correct rows for limit all case




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Resolved] (DRILL-2293) CTAS does not clean up when it fails

2017-03-08 Thread Arina Ielchiieva (JIRA)


 [ 
https://issues.apache.org/jira/browse/DRILL-2293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arina Ielchiieva resolved DRILL-2293.
-
   Resolution: Fixed
Fix Version/s: (was: Future)
   1.10.0

> CTAS does not clean up when it fails
> 
>
> Key: DRILL-2293
> URL: https://issues.apache.org/jira/browse/DRILL-2293
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Storage - Parquet
>Reporter: Rahul Challapalli
> Fix For: 1.10.0
>
>
> git.commit.id.abbrev=6676f2d
> Data Set :
> {code}
> {
>   "id" : 1,
>   "map":{"rm": [
> {"mapid":"m1","mapvalue":{"col1":1,"col2":[0,1,2,3,4,5]},"rptd": [{ "a": 
> "foo"},{"b":"boo"}]},
> {"mapid":"m2","mapvalue":{"col1":0,"col2":[]},"rptd": [{ "a": 
> "bar"},{"c":1},{"d":4.5}]}
>   ]}
> }
> {code}
> The below query fails :
> {code}
> create table rep_map as select d.map from `temp.json` d;
> Query failed: Query stopped., index: -4, length: 4 (expected: range(0, 
> 16384)) [ d76e3f74-7e2c-406f-a7fd-5efc68227e75 on qa-node190.qa.lab:31010 ]
> {code}
> However drill created a folder 'rep_map' and the folder contained a broken 
> parquet file. 
> {code}
> create table rep_map as select d.map from `temp.json` d;
> +++
> | ok |  summary   |
> +++
> | false  | Table 'rep_map' already exists. |
> {code}
> Drill should clean up properly in case of a failure.
> I raised a different issue for the actual failure.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] drill pull request #776: DRILL-5165: limitRel to return correct rows for lim...

2017-03-08 Thread jinfengni

Github user jinfengni commented on a diff in the pull request:

https://github.com/apache/drill/pull/776#discussion_r104993761
  
--- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/limit/TestLimitWithExchanges.java
 ---
@@ -125,6 +125,15 @@ public void testLimitImpactExchange() throws Exception 
{
 }
   }
 
+  @Test
+  public void TestLimitAllOnParquet() throws Exception {
--- End diff --

Have you tried this new testcase without the change above? Will it 
successful or fail?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #775: DRILL-5326: Unit tests failures related to the SERV...

2017-03-08 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/775


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Time for 1.10 release

2017-03-08 Thread Jinfeng Ni

I merged the PR for DRILL-5326 to master branch, and will start
building RC0 shortly.



On Tue, Mar 7, 2017 at 2:13 PM, Jinfeng Ni  wrote:
> Yes, DRILL-5326 is blocking issue for RC0, if build with unit test fails.
>
>
> On Tue, Mar 7, 2017 at 12:55 PM, Zelaine Fong  wrote:
>> It looks like DRILL-5326 has just been logged.  I assume we need this for 
>> RC0?
>>
>> Vitalii – it looks like you have a fix.  Can you post a pull request as soon 
>> as you’re ready with the change.
>>
>> Thanks.
>>
>> -- Zelaine
>>
>> On 3/3/17, 2:13 PM, "Jinfeng Ni"  wrote:
>>
>> Pushed the patch for DRILL-5313, as well as two other patches which
>> were reviewed before 3/1.
>>
>> I will start build RC0 after QA sanity test is completed.
>>
>>
>> On Thu, Mar 2, 2017 at 11:00 PM, Jinfeng Ni  wrote:
>> > Looks like the C++ client is not able to built successfully [1], after
>> > the change of DRILL-5301 / DRILL-5167.
>> >
>> > This seems to be a blocking issue for 1.10.0, and I'll merge the patch
>> > once it's verified/reviewed.
>> >
>> > 1. https://issues.apache.org/jira/browse/DRILL-5313
>> >
>> > On Thu, Mar 2, 2017 at 5:37 PM, Jinfeng Ni  wrote:
>> >> I missed 5208, because it did not show up in Paul's list when he 
>> replied to
>> >> this thread.
>> >>
>> >> On Thu, Mar 2, 2017 at 2:58 PM Zelaine Fong  wrote:
>> >>>
>> >>> Jinfeng,
>> >>>
>> >>> I notice the following Jira has the ready-to-commit label but isn’t 
>> on
>> >>> your list:
>> >>>
>> >>> DRILL-5208
>> >>>
>> >>> Was this one overlooked?
>> >>>
>> >>> -- Zelaine
>> >>>
>> >>> On 3/2/17, 1:04 PM, "Jinfeng Ni"  wrote:
>> >>>
>> >>> The following PRs have been merged to Apache master.
>> >>>
>> >>> DRILL-4994
>> >>> DRILL-4730
>> >>> DRILL-5301
>> >>> DRILL-5167
>> >>> DRILL-5221
>> >>> DRILL-5258
>> >>> DRILL-5034
>> >>> DRILL-4963
>> >>> DRILL-5252
>> >>> DRILL-5266
>> >>> DRILL-5284
>> >>> DRILL-5304
>> >>> DRILL-5290
>> >>> DRILL-5287
>> >>>
>> >>> QA folks will run tests. If no issue found, I'll build a RC0 
>> candidate
>> >>> for 1.10 and start the vote.
>> >>>
>> >>> Thanks,
>> >>>
>> >>> Jinfeng
>> >>>
>> >>>
>> >>>
>> >>> On Thu, Mar 2, 2017 at 8:30 AM, Jinfeng Ni  
>> wrote:
>> >>> > I'm building a merge branch, and hopefully push to master 
>> branch
>> >>> today
>> >>> > if things go smoothly.
>> >>> >
>> >>> >
>> >>> > On Wed, Mar 1, 2017 at 7:13 PM, Padma Penumarthy
>> >>>  wrote:
>> >>> >> Hi Jinfeng,
>> >>> >>
>> >>> >> Please include DRILL-5287, DRILL-5290 and DRILL-5304.
>> >>> >>
>> >>> >> Thanks,
>> >>> >> Padma
>> >>> >>
>> >>> >>
>> >>> >>> On Feb 22, 2017, at 11:16 PM, Jinfeng Ni  
>> wrote:
>> >>> >>>
>> >>> >>> Hi Drillers,
>> >>> >>>
>> >>> >>> It has been almost 3 months since we release Drill 1.9. We 
>> have
>> >>> >>> resolved plenty of fixes and improvements (closed around 88 
>> JIRAs
>> >>> >>> [1]). I propose that we start the 1.10 release process, and 
>> set
>> >>> >>> Wednesday 3/1 as the cutoff day for code checkin. After 3/1, 
>> we
>> >>> should
>> >>> >>> start build a release candidate.
>> >>> >>>
>> >>> >>> Please reply in this email thread if you have something near
>> >>> complete
>> >>> >>> and you would like to include in 1.10 release.
>> >>> >>>
>> >>> >>> I volunteer as the release manager, unless someone else come
>> >>> forward.
>> >>> >>>
>> >>> >>> Thanks,
>> >>> >>>
>> >>> >>> Jinfeng
>> >>> >>>
>> >>> >>> [1]
>> >>> https://issues.apache.org/jira/browse/DRILL/fixforversion/12338769
>> >>> >>
>> >>>
>> >>>
>> >>
>>
>>

[GitHub] drill issue #776: DRILL-5165: limitRel to return correct rows for limit all ...

2017-03-08 Thread chunhui-shi

Github user chunhui-shi commented on the issue:

https://github.com/apache/drill/pull/776

It failed without the fix.

From: Jinfeng Ni 
Sent: Wednesday, March 8, 2017 10:56:06 AM
To: apache/drill
Cc: Chunhui Shi; Author
Subject: Re: [apache/drill] DRILL-5165: limitRel to return correct rows for 
limit all case (#776)

@jinfengni commented on this pull request.

In 
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/limit/TestLimitWithExchanges.java:

> @@ -125,6 +125,15 @@ public void testLimitImpactExchange() throws 
Exception {
 }
   }

+  @Test
+  public void TestLimitAllOnParquet() throws Exception {

Have you tried this new testcase without the change above? Will it 
successful or fail?

â
You are receiving this because you authored the thread.
Reply to this email directly, view it on 
GitHub, or 
mute the 
thread.

---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill issue #772: DRILL-5316: Check drillbits size before we attempt to acce...

2017-03-08 Thread superbstreak

Github user superbstreak commented on the issue:

https://github.com/apache/drill/pull/772
  
@sohami please review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #772: DRILL-5316: Check drillbits size before we attempt ...

2017-03-08 Thread laurentgo

Github user laurentgo commented on a diff in the pull request:

https://github.com/apache/drill/pull/772#discussion_r105034016
  
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
@@ -2143,6 +2146,9 @@ connectionStatus_t 
PooledDrillClientImpl::connect(const char* connStr, DrillUser
 Utils::shuffle(drillbits);
 // The original shuffled order is maintained if we shuffle 
first and then add any missing elements
 Utils::add(m_drillbits, drillbits);
+if (m_drillbits.empty()){
+return handleConnError(CONN_FAILURE, 
getMessage(ERR_CONN_ZKNODBIT));
--- End diff --

can be done before the shuffle (it should not change the number of elements)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (DRILL-5335) Client should remove offline nodes from m_drillbits in PooledDrillClientImpl::connect

2017-03-08 Thread Rob Wu (JIRA)

Rob Wu created DRILL-5335:
-

 Summary: Client should remove offline nodes from m_drillbits in 
PooledDrillClientImpl::connect
 Key: DRILL-5335
 URL: https://issues.apache.org/jira/browse/DRILL-5335
 Project: Apache Drill
  Issue Type: Bug
  Components: Client - C++
Reporter: Rob Wu
Priority: Minor


During pooled connect, it adds new drillbit into the m_drillbits vector.
https://github.com/apache/drill/blob/master/contrib/native/client/src/clientlib/drillClientImpl.cpp#L2145

In DRILL-5316, a check to prevent mod 0 from happening is implemented. However, 
the C++ client should also remove offline nodes to prevent invalid connection.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] drill pull request #772: DRILL-5316: Check drillbits size before we attempt ...

2017-03-08 Thread superbstreak

Github user superbstreak commented on a diff in the pull request:

https://github.com/apache/drill/pull/772#discussion_r105046142
  
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
@@ -2143,6 +2146,9 @@ connectionStatus_t 
PooledDrillClientImpl::connect(const char* connStr, DrillUser
 Utils::shuffle(drillbits);
 // The original shuffled order is maintained if we shuffle 
first and then add any missing elements
 Utils::add(m_drillbits, drillbits);
+if (m_drillbits.empty()){
+return handleConnError(CONN_FAILURE, 
getMessage(ERR_CONN_ZKNODBIT));
--- End diff --

Thanks, @laurentgo! A new ticket has been filed for the suggestion: 
[DRILL-5335](https://issues.apache.org/jira/browse/DRILL-5335)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[VOTE] Release Apache Drill 1.10.0 - rc0

2017-03-08 Thread Jinfeng Ni

Hello all,

I'd like to propose the first release candidate (rc0) of Apache Drill,
version 1.10.0.

The release candidate covers a total of 126 resolved JIRAs [1]. Thanks
to everyone who contributed to this release.

The tarball artifacts are hosted at [2] and the maven artifacts are
hosted at [3].

This release candidate is based on commit
38ef562b1ced59efe57b0dc606f2c36694569102 located at [4].

The vote will be open for the next ~96 hours (including an extra day
as the vote is happening over a weekend) ending at 8:00AM Pacific,
March 13th, 2017.

[ ] +1
[ ] +0
[ ] -1

Here's my vote: +1

Thanks,

Jinfeng

1. 
https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12338769&projectId=12313820
2. http://home.apache.org/~jni/drill/1.10.0/rc0/
3. https://repository.apache.org/content/repositories/orgapachedrill-1041/
4. https://github.com/jinfengni/incubator-drill/commits/drill-1.10.0

[GitHub] drill pull request #776: DRILL-5165: limitRel to return correct rows for lim...

2017-03-08 Thread chunhui-shi

Github user chunhui-shi commented on a diff in the pull request:

https://github.com/apache/drill/pull/776#discussion_r105102270
  
--- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/limit/TestLimitWithExchanges.java
 ---
@@ -125,6 +125,15 @@ public void testLimitImpactExchange() throws Exception 
{
 }
   }
 
+  @Test
+  public void TestLimitAllOnParquet() throws Exception {
--- End diff --

update the tested query. I did not notice the query in unit test is 
slightly different than the one I used in sqlline. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Resolved] (DRILL-5278) CTTAS store.format=csv, returns one extra record

[GitHub] drill pull request #776: DRILL-5165: limitRel to return correct rows for lim...

[jira] [Resolved] (DRILL-2293) CTAS does not clean up when it fails

[GitHub] drill pull request #776: DRILL-5165: limitRel to return correct rows for lim...

[GitHub] drill pull request #775: DRILL-5326: Unit tests failures related to the SERV...

Re: Time for 1.10 release

[GitHub] drill issue #776: DRILL-5165: limitRel to return correct rows for limit all ...

[GitHub] drill issue #772: DRILL-5316: Check drillbits size before we attempt to acce...

[GitHub] drill pull request #772: DRILL-5316: Check drillbits size before we attempt ...

[jira] [Created] (DRILL-5335) Client should remove offline nodes from m_drillbits in PooledDrillClientImpl::connect

[GitHub] drill pull request #772: DRILL-5316: Check drillbits size before we attempt ...

[VOTE] Release Apache Drill 1.10.0 - rc0

[GitHub] drill pull request #776: DRILL-5165: limitRel to return correct rows for lim...

13 matches

Site Navigation

Mail list logo

Footer information