[GitHub] arina-ielchiieva commented on a change in pull request #1430: DRILL-6680: Expose show files command into INFORMATION_SCHEMA

[GitBox]

arina-ielchiieva commented on a change in pull request #1430: DRILL-6680: 
Expose show files command into INFORMATION_SCHEMA
URL: https://github.com/apache/drill/pull/1430#discussion_r209499097
 
 

 ##
 File path: exec/java-exec/src/main/resources/drill-module.conf
 ##
 @@ -605,4 +605,5 @@ drill.exec.options: {
 store.kafka.poll.timeout: 200,
 web.logs.max_lines: 1,
 window.enable: true,
+storage.list_files_recursively: true
 
 Review comment:
   Sounds fair, made the changes. Thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] okalinin commented on a change in pull request #1428: DRILL-6670: align Parquet TIMESTAMP_MICROS logical type handling with earlier versions + minor fixes

[GitBox]

okalinin commented on a change in pull request #1428: DRILL-6670: align Parquet 
TIMESTAMP_MICROS logical type handling with earlier versions + minor fixes
URL: https://github.com/apache/drill/pull/1428#discussion_r209465875
 
 

 ##
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/AbstractParquetScanBatchCreator.java
 ##
 @@ -108,7 +108,7 @@ protected ScanBatch getBatch(ExecutorFragmentContext 
context, AbstractParquetRow
 
 if 
(!context.getOptions().getBoolean(ExecConstants.PARQUET_NEW_RECORD_READER)
 && !ParquetReaderUtility.containsComplexColumn(footer, 
rowGroupScan.getColumns())) {
-  logger.debug("Query {} qualifies for new Parquet reader",
+  logger.debug("Query {} qualifies for ParquetRecordReader",
 
 Review comment:
   @vrozov I realised that your proposed wording sounds better. 'not enforced' 
may cause confusion too. Reverted back to 'enabled/disabled'.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services