[GitHub] [drill] cgivre commented on a change in pull request #1892: Drill-7437: Storage Plugin for Generic HTTP REST API

2019-12-17 Thread GitBox 
cgivre commented on a change in pull request #1892: Drill-7437: Storage Plugin 
for Generic HTTP REST API
URL: https://github.com/apache/drill/pull/1892#discussion_r359145095
 
 

 ##
 File path: 
contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpScanSpec.java
 ##
 @@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.store.http;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import com.fasterxml.jackson.annotation.JsonCreator;
+import com.fasterxml.jackson.annotation.JsonIgnore;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.annotation.JsonTypeName;
+import org.apache.drill.shaded.guava.com.google.common.base.Joiner;
+import org.apache.drill.shaded.guava.com.google.common.base.MoreObjects;
+
+@JsonTypeName("http-scan-spec")
+public class HttpScanSpec {
+  private final String database;
+
+  private final Map args = new HashMap<>();
+
+  private final String tableName;
+
+  private final String schemaName;
+
+  private final HttpStoragePluginConfig config;
+
+  @JsonCreator
+  public HttpScanSpec(@JsonProperty("schemaName") String schemaName,
+  @JsonProperty("database") String database,
+  @JsonProperty("tableName") String tableName,
+  @JsonProperty("plugin") HttpStoragePlugin plugin) {
 
 Review comment:
   Fixed this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [drill] cgivre commented on a change in pull request #1892: Drill-7437: Storage Plugin for Generic HTTP REST API

2019-12-17 Thread GitBox 
cgivre commented on a change in pull request #1892: Drill-7437: Storage Plugin 
for Generic HTTP REST API
URL: https://github.com/apache/drill/pull/1892#discussion_r359145054
 
 

 ##
 File path: 
contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpSubScan.java
 ##
 @@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.store.http;
+
+import java.util.Arrays;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Objects;
+
+import com.fasterxml.jackson.annotation.JsonCreator;
+import com.fasterxml.jackson.annotation.JsonIgnore;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.annotation.JsonTypeName;
+import org.apache.drill.common.exceptions.ExecutionSetupException;
+import org.apache.drill.common.expression.SchemaPath;
+import org.apache.drill.exec.physical.base.AbstractBase;
+import org.apache.drill.exec.physical.base.PhysicalOperator;
+import org.apache.drill.exec.physical.base.PhysicalVisitor;
+import org.apache.drill.exec.physical.base.SubScan;
+import org.apache.drill.exec.proto.UserBitShared.CoreOperatorType;
+import org.apache.drill.shaded.guava.com.google.common.base.MoreObjects;
+import org.apache.drill.shaded.guava.com.google.common.collect.ImmutableSet;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@JsonTypeName("http-sub-scan")
+public class HttpSubScan extends AbstractBase implements SubScan {
+  private static final Logger logger = 
LoggerFactory.getLogger(HttpSubScan.class);
 
 Review comment:
   Removed unused loggers.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [drill] cgivre commented on a change in pull request #1892: Drill-7437: Storage Plugin for Generic HTTP REST API

2019-12-17 Thread GitBox 
cgivre commented on a change in pull request #1892: Drill-7437: Storage Plugin 
for Generic HTTP REST API
URL: https://github.com/apache/drill/pull/1892#discussion_r359144976
 
 

 ##
 File path: 
contrib/storage-http/src/test/java/org/apache/drill/exec/store/http/TestHttpPlugin.java
 ##
 @@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.drill.exec.store.http;
+
+import org.apache.drill.common.types.TypeProtos;
+import org.apache.drill.exec.physical.rowSet.RowSet;
+import org.apache.drill.exec.physical.rowSet.RowSetBuilder;
+import org.apache.drill.exec.record.metadata.SchemaBuilder;
+import org.apache.drill.exec.record.metadata.TupleMetadata;
+import org.apache.drill.exec.store.StoragePluginRegistry;
+import org.apache.drill.test.ClusterFixture;
+import org.apache.drill.test.ClusterTest;
+import org.apache.drill.test.QueryBuilder;
+import org.apache.drill.test.rowSet.RowSetComparison;
+import org.junit.BeforeClass;
+import org.junit.Ignore;
+import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import static org.junit.Assert.assertEquals;
+
+@Ignore("requires remote http server")
 
 Review comment:
   I completely redid the unit tests.  Since the code reuses the Drill 
JSONReader, the unit tests focus on the actual HTTP request.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [drill] cgivre commented on a change in pull request #1892: Drill-7437: Storage Plugin for Generic HTTP REST API

2019-12-17 Thread GitBox 
cgivre commented on a change in pull request #1892: Drill-7437: Storage Plugin 
for Generic HTTP REST API
URL: https://github.com/apache/drill/pull/1892#discussion_r359144824
 
 

 ##
 File path: 
contrib/storage-http/src/main/resources/bootstrap-storage-plugins.json
 ##
 @@ -0,0 +1,10 @@
+{
+  "storage":{
+"http" : {
+  "type":"http",
+  "connection": "https://api.sunrise-sunset.org/json";,
 
 Review comment:
   Removed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Created] (DRILL-7489) NPE for star query with alias

2019-12-17 Thread Arina Ielchiieva (Jira) 
Arina Ielchiieva created DRILL-7489:
---

 Summary: NPE for star query with alias 
 Key: DRILL-7489
 URL: https://issues.apache.org/jira/browse/DRILL-7489
 Project: Apache Drill
  Issue Type: Bug
Affects Versions: 1.16.0
Reporter: Arina Ielchiieva
Assignee: Igor Guzenko


Query where alias is used for star should throw exception.

Query on table with defined schema returns correct exception:
{noformat}
select * col_alias from sys.version;

org.apache.drill.common.exceptions.UserRemoteException: VALIDATION ERROR: At 
line 1, column 8: Unknown identifier '*'
{noformat}

Query on table with dynamic schema returns NPE:
{noformat}
select * col_alias from cp.`tpch/nation.parquet`

Caused by: java.lang.NullPointerException: 
at 
org.apache.calcite.sql2rel.SqlToRelConverter.convertIdentifier(SqlToRelConverter.java:3690)
at 
org.apache.calcite.sql2rel.SqlToRelConverter.access$2200(SqlToRelConverter.java:217)
at 
org.apache.calcite.sql2rel.SqlToRelConverter$Blackboard.visit(SqlToRelConverter.java:4765)
at 
org.apache.calcite.sql2rel.SqlToRelConverter$Blackboard.visit(SqlToRelConverter.java:4061)
at org.apache.calcite.sql.SqlIdentifier.accept(SqlIdentifier.java:317)
at 
org.apache.calcite.sql2rel.SqlToRelConverter$Blackboard.convertExpression(SqlToRelConverter.java:4625)
at 
org.apache.calcite.sql2rel.StandardConvertletTable.lambda$new$9(StandardConvertletTable.java:204)
at 
org.apache.calcite.sql2rel.SqlNodeToRexConverterImpl.convertCall(SqlNodeToRexConverterImpl.java:63)
at 
org.apache.calcite.sql2rel.SqlToRelConverter$Blackboard.visit(SqlToRelConverter.java:4756)
at 
org.apache.calcite.sql2rel.SqlToRelConverter$Blackboard.visit(SqlToRelConverter.java:4061)
at org.apache.calcite.sql.SqlCall.accept(SqlCall.java:139)
at 
org.apache.calcite.sql2rel.SqlToRelConverter$Blackboard.convertExpression(SqlToRelConverter.java:4625)
at 
org.apache.calcite.sql2rel.SqlToRelConverter.convertSelectList(SqlToRelConverter.java:3908)
at 
org.apache.calcite.sql2rel.SqlToRelConverter.convertSelectImpl(SqlToRelConverter.java:670)
at 
org.apache.calcite.sql2rel.SqlToRelConverter.convertSelect(SqlToRelConverter.java:627)
at 
org.apache.calcite.sql2rel.SqlToRelConverter.convertQueryRecursive(SqlToRelConverter.java:3150)
at 
org.apache.calcite.sql2rel.SqlToRelConverter.convertQuery(SqlToRelConverter.java:563)
at 
org.apache.drill.exec.planner.sql.SqlConverter.toRel(SqlConverter.java:381)
at 
org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.convertToRel(DefaultSqlHandler.java:685)
at 
org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.validateAndConvert(DefaultSqlHandler.java:202)
at 
org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.getPlan(DefaultSqlHandler.java:172)
at 
org.apache.drill.exec.planner.sql.DrillSqlWorker.getQueryPlan(DrillSqlWorker.java:282)
at 
org.apache.drill.exec.planner.sql.DrillSqlWorker.getPhysicalPlan(DrillSqlWorker.java:162)
at 
org.apache.drill.exec.planner.sql.DrillSqlWorker.convertPlan(DrillSqlWorker.java:139)
at 
org.apache.drill.exec.planner.sql.DrillSqlWorker.getPlan(DrillSqlWorker.java:92)
at org.apache.drill.exec.work.foreman.Foreman.runSQL(Foreman.java:590)
at org.apache.drill.exec.work.foreman.Foreman.run(Foreman.java:275)
{noformat}




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[VOTE] Release Apache Drill 1.17.0 - RC1

2019-12-17 Thread Volodymyr Vysotskyi 
Hi all,

I'd like to propose the second release candidate (RC1) of Apache Drill,
version 1.17.0.

Changes since the previous release candidate: fixed the following
show-stoppers: DRILL-7484 
, DRILL-7485 , DRILL-6332
, DRILL-7472
, DRILL-7474
, DRILL-7476
, DRILL-7481
, DRILL-7482
, DRILL-7473
, DRILL-7479
, DRILL-7483
, DRILL-7486
, and DRILL-7470
.

The release candidate covers a total of 203 resolved JIRAs [1]. Thanks to
everyone who contributed to this release.

The tarball artifacts are hosted at [2] and the maven artifacts are hosted
at [3].

This release candidate is based on commit
d65d2b4cc2aa5ea7a59cd40d0ad57a1e4639ae12 located at [4].

Please download and try out the release.

The vote ends at 5 PM UTC (9 AM PDT, 7 PM EET, 10:30 PM IST), December 20,
2019

[ ] +1
[ ] +0
[ ] -1

Here's my vote: +1

[1]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313820&version=12344870
[2] http://home.apache.org/~volodymyr/drill/releases/1.17.0/rc1/
[3] https://repository.apache.org/content/repositories/orgapachedrill-1076/
[4] https://github.com/vvysotskyi/drill/commits/drill-1.17.0

Kind regards,
Volodymyr Vysotskyi

[GitHub] [drill] asfgit closed pull request #1932: DRILL-7485: NPE on PCAP Batch Reader

2019-12-17 Thread GitBox 
asfgit closed pull request #1932: DRILL-7485: NPE on PCAP Batch Reader
URL: https://github.com/apache/drill/pull/1932
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [CANCEL] [VOTE] Release Apache Drill 1.17.0 - rc0

2019-12-17 Thread Volodymyr Vysotskyi 
Hi Drillers,

I have merged all pull requests for release-blocking issues and will start
preparing new RC soon.

Also, thank you all for so active and high-quality work, we have merged
12(!) pull requests since the last week.

Kind regards,
Volodymyr Vysotskyi


On Mon, Dec 16, 2019 at 5:11 PM Volodymyr Vysotskyi 
wrote:

> Hi all,
>
> Here is the current status of the release-blocking issues and issues which
> will be included in this release:
> - DRILL-7484  - ready
> to be merged;
> - DRILL-7485  - ready
> to be merged;
> - DRILL-6332  - ready
> to be merged;
> - DRILL-7472  - ready
> to be merged;
> - DRILL-7474  - ready
> to be merged;
> - DRILL-7476  - ready
> to be merged;
> - DRILL-7481  - ready
> to be merged;
> - DRILL-7482  - ready
> to be merged;
> - DRILL-7473  - PR is
> created and reviewed, CR comments should be addressed;
> - DRILL-7479  - PR is
> created and reviewed, CR comments should be addressed;
> - DRILL-7483  - PR is
> created and reviewed, CR comments should be addressed;
>
> Thanks to all for working on and reviewing fixes for these issues.
> Please let me know if there are any additional issues that should be
> included in this release, or if there are some troubles with the issues
> listed above.
>
> Kind regards,
> Volodymyr Vysotskyi
>
>
> On Fri, Dec 13, 2019 at 5:52 PM Vova Vysotskyi  wrote:
>
>> If the PR will be ready to be merged before other blocking Jiras are
>> resolved, we can include it.
>>
>> Kind regards,
>> Volodymyr Vysotskyi
>>
>>
>> On Fri, Dec 13, 2019 at 5:42 PM Charles Givre  wrote:
>>
>>> One more thing...
>>> Do you think we could include DRILL-6332 (
>>> https://github.com/apache/drill/pull/1931 <
>>> https://github.com/apache/drill/pull/1931>)?  This seems like a very
>>> minor change that could have a significant impact on potential users.
>>>
>>> I'll get DRILL-7484 and DRILL-7485 cleaned up and done over the weekend.
>>> --C
>>>
>>> > On Dec 13, 2019, at 10:40 AM, Volodymyr Vysotskyi <
>>> volody...@apache.org> wrote:
>>> >
>>> > Hi Charles,
>>> >
>>> > Yes, I think we can also include this one. Thanks for finding this
>>> issue
>>> > and submitting the fix!
>>> >
>>> > Kind regards,
>>> > Volodymyr Vysotskyi
>>> >
>>> >
>>> > On Fri, Dec 13, 2019 at 5:13 PM Charles Givre 
>>> wrote:
>>> >
>>> >> Hi Volodymyr,
>>> >> I'm going to get DRILL-7484 resolved over the weekend, but when I
>>> started
>>> >> working on it, I found another issue with the PCAP reader that causes
>>> >> NPEs.  The resolution was a minor change,(
>>> >> https://github.com/apache/drill/pull/1932 <
>>> >> https://github.com/apache/drill/pull/1932>).  Could we please include
>>> >> DRILL-7485 as well in the next RC?
>>> >> Thanks,
>>> >> -- C
>>> >>
>>> >>
>>> >>
>>> >>> On Dec 13, 2019, at 9:08 AM, Volodymyr Vysotskyi <
>>> volody...@apache.org>
>>> >> wrote:
>>> >>>
>>> >>> Hi all,
>>> >>>
>>> >>> The vote for Apache Drill 1.17.0 - rc0 was canceled.
>>> >>>
>>> >>> Thanks to all who voted.
>>> >>>
>>> >>> A new release will be tagged as 1.17.0-rc1 and will be available
>>> after
>>> >> the
>>> >>> following jiras are resolved:
>>> >>> - DRILL-7473  -
>>> >> Parquet
>>> >>> reader failed to get field of repeated map (Bohdan Kazydub is
>>> working on
>>> >>> the fix)
>>> >>> - DRILL-7484  -
>>> >> Malware
>>> >>> found with some antiviruses in the Drill test resources folder
>>> (Charles
>>> >>> Givre is working on the fix)
>>> >>>
>>> >>> Kind regards,
>>> >>> Volodymyr Vysotskyi
>>> >>
>>> >>
>>>
>>>

[GitHub] [drill] asfgit closed pull request #1922: DRILL-7476: Set lastSet on TransferPair copies

2019-12-17 Thread GitBox 
asfgit closed pull request #1922: DRILL-7476: Set lastSet on TransferPair copies
URL: https://github.com/apache/drill/pull/1922
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [drill] asfgit closed pull request #1927: DRILL-7482: Fix missing artifact and overlapping classes warnings in Drill build

2019-12-17 Thread GitBox 
asfgit closed pull request #1927: DRILL-7482: Fix missing artifact and 
overlapping classes warnings in Drill build
URL: https://github.com/apache/drill/pull/1927
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [drill] asfgit closed pull request #1924: DRILL-7481: Fix raw type warnings in Iceberg Metastore and related classes

2019-12-17 Thread GitBox 
asfgit closed pull request #1924: DRILL-7481: Fix raw type warnings in Iceberg 
Metastore and related classes
URL: https://github.com/apache/drill/pull/1924
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [drill] asfgit closed pull request #1935: DRILL-7483: Add support for 12 and 13 java versions

2019-12-17 Thread GitBox 
asfgit closed pull request #1935: DRILL-7483: Add support for 12 and 13 java 
versions
URL: https://github.com/apache/drill/pull/1935
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [drill] asfgit closed pull request #1923: DRILL-7479: Partial fixes for metadata parameterized type issues

2019-12-17 Thread GitBox 
asfgit closed pull request #1923: DRILL-7479: Partial fixes for metadata 
parameterized type issues
URL: https://github.com/apache/drill/pull/1923
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [drill] asfgit closed pull request #1928: DRILL-7486: Refactor row set reader builders

2019-12-17 Thread GitBox 
asfgit closed pull request #1928: DRILL-7486: Refactor row set reader builders
URL: https://github.com/apache/drill/pull/1928
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [drill] asfgit closed pull request #1920: DRILL-7470: Removed a conflicting dependency

2019-12-17 Thread GitBox 
asfgit closed pull request #1920: DRILL-7470: Removed a conflicting dependency
URL: https://github.com/apache/drill/pull/1920
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [drill] asfgit closed pull request #1926: DRILL-7474: Reduce size of Drill's tar.gz file

2019-12-17 Thread GitBox 
asfgit closed pull request #1926: DRILL-7474: Reduce size of Drill's tar.gz file
URL: https://github.com/apache/drill/pull/1926
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [drill] asfgit closed pull request #1925: DRILL-7472: Fix ser / de for sys and information_schema schemas queries

2019-12-17 Thread GitBox 
asfgit closed pull request #1925: DRILL-7472: Fix ser / de for sys and 
information_schema schemas queries
URL: https://github.com/apache/drill/pull/1925
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [drill] asfgit closed pull request #1933: DRILL-7473: Parquet reader failed to get field of repeated map

2019-12-17 Thread GitBox 
asfgit closed pull request #1933: DRILL-7473: Parquet reader failed to get 
field of repeated map
URL: https://github.com/apache/drill/pull/1933
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [drill] asfgit closed pull request #1931: DRILL-6332: Allow to provide two-component Kerberos principals

2019-12-17 Thread GitBox 
asfgit closed pull request #1931: DRILL-6332: Allow to provide two-component 
Kerberos principals
URL: https://github.com/apache/drill/pull/1931
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [drill] asfgit closed pull request #1934: DRILL-7484: Malware found in the Drill test folder

2019-12-17 Thread GitBox 
asfgit closed pull request #1934: DRILL-7484: Malware found in the Drill test 
folder
URL: https://github.com/apache/drill/pull/1934
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [drill] vvysotskyi commented on issue #1923: DRILL-7479: Partial fixes for metadata parameterized type issues

2019-12-17 Thread GitBox 
vvysotskyi commented on issue #1923: DRILL-7479: Partial fixes for metadata 
parameterized type issues
URL: https://github.com/apache/drill/pull/1923#issuecomment-566478827
 
 
   @paul-rogers, thanks for making changes, +1


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [drill] KazydubB commented on a change in pull request #1933: DRILL-7473: Parquet reader failed to get field of repeated map

2019-12-17 Thread GitBox 
KazydubB commented on a change in pull request #1933: DRILL-7473: Parquet 
reader failed to get field of repeated map
URL: https://github.com/apache/drill/pull/1933#discussion_r358686487
 
 

 ##
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/validate/BatchValidator.java
 ##
 @@ -293,14 +292,20 @@ private void validateVector(String name, ValueVector 
vector) {
   // structure to check.
 } else if (vector instanceof BaseRepeatedValueVector) {
   validateRepeatedVector(name, (BaseRepeatedValueVector) vector);
-} else if (vector instanceof RepeatedMapVector) {
-  validateRepeatedMapVector(name, (RepeatedMapVector) vector);
+} else if (vector instanceof AbstractRepeatedMapVector) {
 
 Review comment:
   I've updated the comment - hope it is clearer


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [drill] KazydubB commented on issue #1870: DRILL-7359: Add support for DICT type in RowSet Framework

2019-12-17 Thread GitBox 
KazydubB commented on issue #1870: DRILL-7359: Add support for DICT type in 
RowSet Framework
URL: https://github.com/apache/drill/pull/1870#issuecomment-566448821
 
 
   @paul-rogers, I'm sorry for taking so long. I'm planning to finish this in a 
few days.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [drill] arina-ielchiieva commented on issue #1928: DRILL-7486: Refactor row set reader builders

2019-12-17 Thread GitBox 
arina-ielchiieva commented on issue #1928: DRILL-7486: Refactor row set reader 
builders
URL: https://github.com/apache/drill/pull/1928#issuecomment-566432534
 
 
   +1, LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services