[jira] [Resolved] (DRILL-6580) Upgrade Curator libraries
[ https://issues.apache.org/jira/browse/DRILL-6580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vova Vysotskyi resolved DRILL-6580. --- Resolution: Fixed Fixed in DRILL-7702 > Upgrade Curator libraries > - > > Key: DRILL-6580 > URL: https://issues.apache.org/jira/browse/DRILL-6580 > Project: Apache Drill > Issue Type: Task >Reporter: Bohdan Kazydub >Assignee: Vova Vysotskyi >Priority: Major > > As of [DRILL-6534|https://issues.apache.org/jira/browse/DRILL-6534] Drill > uses explicit version ZooKeeper (ZK) and curator. ZK's version was upgraded > so it is better to upgrade Curator as it manages ZK. > Note: I've tried to upgrade Curator to 2.12.0, 3.3.0 and 4.0.1 (has hard > dependency on ZK 3.5.x) and everything seems to work except that size of > curator-client artifact is much larger than the current one's (~2+ MB and 70 > kB respectively) and as a result jdbc-all maxSize should be increased. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [drill] vvysotskyi commented on pull request #2069: DRILL-7723 - Add Excel Metadata as Implicit Fields
vvysotskyi commented on pull request #2069: URL: https://github.com/apache/drill/pull/2069#issuecomment-632861361 @cgivre, I'll take a look this weekend. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [drill] cgivre commented on pull request #2069: DRILL-7723 - Add Excel Metadata as Implicit Fields
cgivre commented on pull request #2069: URL: https://github.com/apache/drill/pull/2069#issuecomment-632839507 @vvysotskyi Any comments on this or is it good to go? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [drill] vvysotskyi commented on a change in pull request #2071: DRILL-7727 Fix protobuf warning message
vvysotskyi commented on a change in pull request #2071: URL: https://github.com/apache/drill/pull/2071#discussion_r429391914 ## File path: contrib/native/client/CMakeLists.txt ## @@ -25,6 +25,13 @@ cmake_policy(SET CMP0043 NEW) cmake_policy(SET CMP0048 NEW) enable_testing() +# +# required version for dependencies +# +set (BOOST_MINIMUM_VERSION 1.54.0) +set (PROTOBUF_MINIMUM_VERSION 3.6.1) Review comment: Yes, it can be merged, but after resolving conflicts. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [drill] cgivre commented on a change in pull request #2071: DRILL-7727 Fix protobuf warning message
cgivre commented on a change in pull request #2071: URL: https://github.com/apache/drill/pull/2071#discussion_r429390930 ## File path: contrib/native/client/CMakeLists.txt ## @@ -25,6 +25,13 @@ cmake_policy(SET CMP0043 NEW) cmake_policy(SET CMP0048 NEW) enable_testing() +# +# required version for dependencies +# +set (BOOST_MINIMUM_VERSION 1.54.0) +set (PROTOBUF_MINIMUM_VERSION 3.6.1) Review comment: @vvysotskyi @laurentgo Can we merge this PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (DRILL-7743) Prepared-statement dynamic parameters are not supported.
Ben qu created DRILL-7743: - Summary: Prepared-statement dynamic parameters are not supported. Key: DRILL-7743 URL: https://issues.apache.org/jira/browse/DRILL-7743 Project: Apache Drill Issue Type: Improvement Components: Client - JDBC Affects Versions: 1.17.0, 1.15.0 Reporter: Ben qu As described in title， jdbc driver PreparedStatement does not support dynamic parameters。 e.g: setString API of PreparedStatement would trigger the following exception. All threads started!All threads started!java.sql.SQLFeatureNotSupportedException: Prepared-statement dynamic parameters are not supported. at org.apache.drill.jdbc.impl.DrillPreparedStatementImpl.getParameter(DrillPreparedStatementImpl.java:88) at oadd.org.apache.calcite.avatica.AvaticaPreparedStatement.getSite(AvaticaPreparedStatement.java:434) at oadd.org.apache.calcite.avatica.AvaticaPreparedStatement.setString(AvaticaPreparedStatement.java:195) at InsertBatchesThread.execInsert(TsqlInsertClient.java:160) at InsertBatchesThread.run(TsqlInsertClient.java:192)java.sql.SQLFeatureNotSupportedException: Prepared-statement dynamic parameters are not supported. at org.apache.drill.jdbc.impl.DrillPreparedStatementImpl.getParameter(DrillPreparedStatementImpl.java:88) at oadd.org.apache.calcite.avatica.AvaticaPreparedStatement.getSite(AvaticaPreparedStatement.java:434) at oadd.org.apache.calcite.avatica.AvaticaPreparedStatement.setString(AvaticaPreparedStatement.java:195) at InsertBatchesThread.execInsert(TsqlInsertClient.java:160) at InsertBatchesThread.run(TsqlInsertClient.java:192) -- This message was sent by Atlassian Jira (v8.3.4#803005)
