[GitHub] [drill] vdiravka commented on a change in pull request #2432: DRILL-7994: Dependency version updates for severe vulnerabilities
vdiravka commented on a change in pull request #2432: URL: https://github.com/apache/drill/pull/2432#discussion_r797394342 ## File path: pom.xml ## @@ -92,20 +92,21 @@ 3.28.0-GA 0.6.6 0.9.10 -1.9.1 +1.11.0 4.0.2 -9.4.41.v20210516 +9.4.44.v20210927 2.34 2.0.1.Final 9.2 -1800 -3000 +2000 +2700 true true apache/drill 4.8-1 -3.6.3 +3.8.4 +3.6.3 Review comment: I am ok with either of variants. Just want to confirm this was not resolved accidentally -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [drill] jnturton merged pull request #2432: DRILL-7994: Dependency version updates for severe vulnerabilities
jnturton merged pull request #2432: URL: https://github.com/apache/drill/pull/2432 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [drill] luocooong merged pull request #2431: DRILL-8109: Hive storage plugin support reading parquet timestamp type with int64 logical type
luocooong merged pull request #2431: URL: https://github.com/apache/drill/pull/2431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [drill] jnturton opened a new pull request #2447: DRILL-7994: Dependency version updates for severe vulnerabilities
jnturton opened a new pull request #2447: URL: https://github.com/apache/drill/pull/2447 # [DRILL-7994](https://issues.apache.org/jira/browse/DRILL-7994): Dependency version updates for severe vulnerabilities ## Description Based on the OWASP dependency check report and dependabot. ## Documentation N/A ## Testing Existing tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [drill] vdiravka commented on a change in pull request #2447: DRILL-7994: Dependency version updates for severe vulnerabilities
vdiravka commented on a change in pull request #2447: URL: https://github.com/apache/drill/pull/2447#discussion_r797537220 ## File path: contrib/storage-phoenix/pom.xml ## @@ -33,7 +33,7 @@ 5.1.2 2.4.2 -9.4.31.v20200723 +9.4.44.v20210927 Review comment: I've checked and `SecuredPhoenixTestSuite` works fine with this jetty version (dependencies in `drill-storage-phoenix` are still needed for that). So please remove `jetty.test.version` property and it's usage -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (DRILL-8122) Change kafka metadata obtaining due to KAFKA-5697
Maksym Rymar created DRILL-8122: --- Summary: Change kafka metadata obtaining due to KAFKA-5697 Key: DRILL-8122 URL: https://issues.apache.org/jira/browse/DRILL-8122 Project: Apache Drill Issue Type: Bug Affects Versions: 1.19.0, 1.18.0, 1.17.0 Reporter: Maksym Rymar Assignee: Maksym Rymar Fix For: 1.20.0 Starting from kafka 2.0 was changed behavior of the [KafkaConsumer#poll|https://kafka.apache.org/11/javadoc/org/apache/kafka/clients/consumer/KafkaConsumer.html#poll-long-] . In Drill was used one hack, where poll() is used only to update consumer metadata. But after the next change: [https://github.com/apache/kafka/pull/4855] this hack is not working now as poll() is not blocked more until metadata update yet more. Unfortunately, Kafka doesn't have public method to only update assignment metadata in consumer and it's on the discussion now whether to add it or not: [KIP-505|https://cwiki.apache.org/confluence/display/KAFKA/KIP-505%3A+Add+new+public+method+to+only+update+assignment+metadata+in+consumer] . Once it will be introduced we can use it but until that it needs to implement a workaround. Code to change: https://github.com/apache/drill/blob/15b2f52260e4f0026f2dfafa23c5d32e0fb66502/contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaGroupScan.java#L185 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [drill] vvysotskyi commented on a change in pull request #2447: DRILL-7994: Dependency version updates for severe vulnerabilities
vvysotskyi commented on a change in pull request #2447: URL: https://github.com/apache/drill/pull/2447#discussion_r797570750 ## File path: .travis.yml ## @@ -50,41 +50,43 @@ before_install: - git fetch --unshallow # Install libraries required for protobuf generation - | -if [ $PHASE = "build_checkstyle_protobuf" ]; then \ - sudo apt-get install -y libboost-all-dev libzookeeper-mt-dev libsasl2-dev cmake libcppunit-dev checkinstall && \ - pushd .. && \ - if [ -f $HOME/protobuf/protobuf_3.16.1* ]; then \ -sudo dpkg -i $HOME/protobuf/protobuf_3.16.1*; \ - else \ -wget https://github.com/protocolbuffers/protobuf/releases/download/v3.16.1/protobuf-java-3.16.1.zip && \ -unzip protobuf-java-3.16.1.zip && pushd protobuf-3.16.1 && \ -./configure && sudo make && sudo checkinstall -y && \ -if [ ! -d $HOME/protobuf ]; then \ - mkdir -p $HOME/protobuf; \ -fi && \ -mv protobuf_3.16.1* $HOME/protobuf/ && popd; \ - fi && \ - sudo ldconfig && popd; \ +if [ $PHASE = "build_checkstyle_protobuf" ]; then + sudo apt-get install -y libboost-all-dev libzookeeper-mt-dev libsasl2-dev cmake libcppunit-dev checkinstall && + pushd .. && + if [ -f $HOME/protobuf/protobuf_3.16.1* ]; then +sudo dpkg -i $HOME/protobuf/protobuf_3.16.1*; + else +wget https://github.com/protocolbuffers/protobuf/releases/download/v3.16.1/protobuf-java-3.16.1.zip && +unzip protobuf-java-3.16.1.zip && pushd protobuf-3.16.1 && +./configure && sudo make && sudo checkinstall -y && +if [ ! -d $HOME/protobuf ]; then + mkdir -p $HOME/protobuf; +fi && +mv protobuf_3.16.1* $HOME/protobuf/ && popd; + fi && + sudo ldconfig && popd; fi install: # For tests phase runs unit tests # For protobuf phase: builds Drill project, performs license checkstyle goal and regenerates Java and C++ Protobuf files - | -if [ $PHASE = "tests" ]; then \ - mvn install --batch-mode --no-transfer-progress \ - -DexcludedGroups="org.apache.drill.categories.SlowTest,org.apache.drill.categories.UnlikelyTest,org.apache.drill.categories.SecurityTest"; \ -elif [ $PHASE = "build_checkstyle_protobuf" ]; then \ - MAVEN_OPTS="-Xms1G -Xmx1G" mvn install --no-transfer-progress -Drat.skip=false -Dlicense.skip=false --batch-mode -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn -DskipTests=true -Dmaven.javadoc.skip=true -Dmaven.source.skip=true && \ - pushd protocol && mvn process-sources -P proto-compile && popd && \ - mkdir contrib/native/client/build && pushd contrib/native/client/build && /usr/bin/cmake -G "Unix Makefiles" .. && make cpProtobufs && popd; \ +if [ $PHASE = "tests" ]; then + echo Selecting parallel GC to minimise peak mem usage. Review comment: Please avoid adding such comments in the ci output, they might confuse people that trying to figure out why their tests failing. ## File path: .travis.yml ## @@ -50,41 +50,43 @@ before_install: - git fetch --unshallow # Install libraries required for protobuf generation - | -if [ $PHASE = "build_checkstyle_protobuf" ]; then \ - sudo apt-get install -y libboost-all-dev libzookeeper-mt-dev libsasl2-dev cmake libcppunit-dev checkinstall && \ - pushd .. && \ - if [ -f $HOME/protobuf/protobuf_3.16.1* ]; then \ -sudo dpkg -i $HOME/protobuf/protobuf_3.16.1*; \ - else \ -wget https://github.com/protocolbuffers/protobuf/releases/download/v3.16.1/protobuf-java-3.16.1.zip && \ -unzip protobuf-java-3.16.1.zip && pushd protobuf-3.16.1 && \ -./configure && sudo make && sudo checkinstall -y && \ -if [ ! -d $HOME/protobuf ]; then \ - mkdir -p $HOME/protobuf; \ -fi && \ -mv protobuf_3.16.1* $HOME/protobuf/ && popd; \ - fi && \ - sudo ldconfig && popd; \ +if [ $PHASE = "build_checkstyle_protobuf" ]; then + sudo apt-get install -y libboost-all-dev libzookeeper-mt-dev libsasl2-dev cmake libcppunit-dev checkinstall && + pushd .. && + if [ -f $HOME/protobuf/protobuf_3.16.1* ]; then +sudo dpkg -i $HOME/protobuf/protobuf_3.16.1*; + else +wget https://github.com/protocolbuffers/protobuf/releases/download/v3.16.1/protobuf-java-3.16.1.zip && +unzip protobuf-java-3.16.1.zip && pushd protobuf-3.16.1 && +./configure && sudo make && sudo checkinstall -y && +if [ ! -d $HOME/protobuf ]; then + mkdir -p $HOME/protobuf; +fi && +mv protobuf_3.16.1* $HOME/protobuf/ && popd; + fi && + sudo ldconfig && popd; fi install: # For tests phase runs unit tests # For protobuf phase: builds Drill project, performs license checkstyle goal and regenerates Java and C++ Protobuf files - | -if [ $PHASE = "tests" ]; t
[GitHub] [drill] jnturton commented on a change in pull request #2447: DRILL-7994: Dependency version updates for severe vulnerabilities
jnturton commented on a change in pull request #2447: URL: https://github.com/apache/drill/pull/2447#discussion_r797589783 ## File path: .travis.yml ## @@ -50,41 +50,43 @@ before_install: - git fetch --unshallow # Install libraries required for protobuf generation - | -if [ $PHASE = "build_checkstyle_protobuf" ]; then \ - sudo apt-get install -y libboost-all-dev libzookeeper-mt-dev libsasl2-dev cmake libcppunit-dev checkinstall && \ - pushd .. && \ - if [ -f $HOME/protobuf/protobuf_3.16.1* ]; then \ -sudo dpkg -i $HOME/protobuf/protobuf_3.16.1*; \ - else \ -wget https://github.com/protocolbuffers/protobuf/releases/download/v3.16.1/protobuf-java-3.16.1.zip && \ -unzip protobuf-java-3.16.1.zip && pushd protobuf-3.16.1 && \ -./configure && sudo make && sudo checkinstall -y && \ -if [ ! -d $HOME/protobuf ]; then \ - mkdir -p $HOME/protobuf; \ -fi && \ -mv protobuf_3.16.1* $HOME/protobuf/ && popd; \ - fi && \ - sudo ldconfig && popd; \ +if [ $PHASE = "build_checkstyle_protobuf" ]; then + sudo apt-get install -y libboost-all-dev libzookeeper-mt-dev libsasl2-dev cmake libcppunit-dev checkinstall && + pushd .. && + if [ -f $HOME/protobuf/protobuf_3.16.1* ]; then +sudo dpkg -i $HOME/protobuf/protobuf_3.16.1*; + else +wget https://github.com/protocolbuffers/protobuf/releases/download/v3.16.1/protobuf-java-3.16.1.zip && +unzip protobuf-java-3.16.1.zip && pushd protobuf-3.16.1 && +./configure && sudo make && sudo checkinstall -y && +if [ ! -d $HOME/protobuf ]; then + mkdir -p $HOME/protobuf; +fi && +mv protobuf_3.16.1* $HOME/protobuf/ && popd; + fi && + sudo ldconfig && popd; fi install: # For tests phase runs unit tests # For protobuf phase: builds Drill project, performs license checkstyle goal and regenerates Java and C++ Protobuf files - | -if [ $PHASE = "tests" ]; then \ - mvn install --batch-mode --no-transfer-progress \ - -DexcludedGroups="org.apache.drill.categories.SlowTest,org.apache.drill.categories.UnlikelyTest,org.apache.drill.categories.SecurityTest"; \ -elif [ $PHASE = "build_checkstyle_protobuf" ]; then \ - MAVEN_OPTS="-Xms1G -Xmx1G" mvn install --no-transfer-progress -Drat.skip=false -Dlicense.skip=false --batch-mode -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn -DskipTests=true -Dmaven.javadoc.skip=true -Dmaven.source.skip=true && \ - pushd protocol && mvn process-sources -P proto-compile && popd && \ - mkdir contrib/native/client/build && pushd contrib/native/client/build && /usr/bin/cmake -G "Unix Makefiles" .. && make cpProtobufs && popd; \ +if [ $PHASE = "tests" ]; then + echo Selecting parallel GC to minimise peak mem usage. + MAVEN_OPTS="-XX:+UseParallelGC" Review comment: @vdiravka it was selected for an extremely memory constrained environment and regular Drill users with such memory constraints are well-advised to make the same selection. Will revert for now... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [drill] vdiravka commented on a change in pull request #2447: DRILL-7994: Dependency version updates for severe vulnerabilities
vdiravka commented on a change in pull request #2447: URL: https://github.com/apache/drill/pull/2447#discussion_r797605652 ## File path: .travis.yml ## @@ -50,41 +50,43 @@ before_install: - git fetch --unshallow # Install libraries required for protobuf generation - | -if [ $PHASE = "build_checkstyle_protobuf" ]; then \ - sudo apt-get install -y libboost-all-dev libzookeeper-mt-dev libsasl2-dev cmake libcppunit-dev checkinstall && \ - pushd .. && \ - if [ -f $HOME/protobuf/protobuf_3.16.1* ]; then \ -sudo dpkg -i $HOME/protobuf/protobuf_3.16.1*; \ - else \ -wget https://github.com/protocolbuffers/protobuf/releases/download/v3.16.1/protobuf-java-3.16.1.zip && \ -unzip protobuf-java-3.16.1.zip && pushd protobuf-3.16.1 && \ -./configure && sudo make && sudo checkinstall -y && \ -if [ ! -d $HOME/protobuf ]; then \ - mkdir -p $HOME/protobuf; \ -fi && \ -mv protobuf_3.16.1* $HOME/protobuf/ && popd; \ - fi && \ - sudo ldconfig && popd; \ +if [ $PHASE = "build_checkstyle_protobuf" ]; then + sudo apt-get install -y libboost-all-dev libzookeeper-mt-dev libsasl2-dev cmake libcppunit-dev checkinstall && + pushd .. && + if [ -f $HOME/protobuf/protobuf_3.16.1* ]; then +sudo dpkg -i $HOME/protobuf/protobuf_3.16.1*; + else +wget https://github.com/protocolbuffers/protobuf/releases/download/v3.16.1/protobuf-java-3.16.1.zip && +unzip protobuf-java-3.16.1.zip && pushd protobuf-3.16.1 && +./configure && sudo make && sudo checkinstall -y && +if [ ! -d $HOME/protobuf ]; then + mkdir -p $HOME/protobuf; +fi && +mv protobuf_3.16.1* $HOME/protobuf/ && popd; + fi && + sudo ldconfig && popd; fi install: # For tests phase runs unit tests # For protobuf phase: builds Drill project, performs license checkstyle goal and regenerates Java and C++ Protobuf files - | -if [ $PHASE = "tests" ]; then \ - mvn install --batch-mode --no-transfer-progress \ - -DexcludedGroups="org.apache.drill.categories.SlowTest,org.apache.drill.categories.UnlikelyTest,org.apache.drill.categories.SecurityTest"; \ -elif [ $PHASE = "build_checkstyle_protobuf" ]; then \ - MAVEN_OPTS="-Xms1G -Xmx1G" mvn install --no-transfer-progress -Drat.skip=false -Dlicense.skip=false --batch-mode -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn -DskipTests=true -Dmaven.javadoc.skip=true -Dmaven.source.skip=true && \ - pushd protocol && mvn process-sources -P proto-compile && popd && \ - mkdir contrib/native/client/build && pushd contrib/native/client/build && /usr/bin/cmake -G "Unix Makefiles" .. && make cpProtobufs && popd; \ +if [ $PHASE = "tests" ]; then + echo Selecting parallel GC to minimise peak mem usage. + MAVEN_OPTS="-XX:+UseParallelGC" Review comment: @jnturton Could you create a task to tune the application to use less memory and back to G1 as default for GitHub CI? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [drill] jnturton commented on pull request #2447: DRILL-7994: Dependency version updates for severe vulnerabilities
jnturton commented on pull request #2447: URL: https://github.com/apache/drill/pull/2447#issuecomment-1027942224 @vvysotskyi sorry, I wrote an @vdiravka but it was you who commented. The idea behind this GC is to reduce memory usage in low mem environments like our CI. The trade off is that it has some worse pause times than the newer GCs but some longer pauses are better than a crashed CI. My prediction is that reverting it will bring back "JVM process terminated unexpectedly" for the JDK 8 build specifically. But it can be set in another PR, I just needed a CI pass here for deps updates reasons. It was just a means to an end for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [drill] jnturton merged pull request #2447: DRILL-7994: Dependency version updates for severe vulnerabilities
jnturton merged pull request #2447: URL: https://github.com/apache/drill/pull/2447 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [drill] jnturton opened a new pull request #2448: DRILL-7994: Dependency version updates for severe vulnerabilities
jnturton opened a new pull request #2448: URL: https://github.com/apache/drill/pull/2448 # [DRILL-7994](https://issues.apache.org/jira/browse/DRILL-7994): Dependency version updates for severe vulnerabilities ## Description Postgresql: 42.3.1 -> 42.3.2 ## Documentation N/A ## Testing Existing unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [drill] jnturton closed pull request #2448: DRILL-7994: Dependency version updates for severe vulnerabilities
jnturton closed pull request #2448: URL: https://github.com/apache/drill/pull/2448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [drill] jnturton opened a new pull request #2449: DRILL-7994: Dependency version updates for severe vulnerabilities
jnturton opened a new pull request #2449: URL: https://github.com/apache/drill/pull/2449 # [DRILL-7994](https://issues.apache.org/jira/browse/DRILL-7994): Dependency version updates for severe vulnerabilities ## Description Postgresql: 42.3.1 -> 42.3.2 ## Documentation N/A ## Testing Existing unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Freeze for Drill 1.20
Please vote again on the assumption that the very minor Postgresql 42.3.1 -> 42.3.2 PR will be merged, clearing the last Dependabot alert. It passed local testing so it looks like a safe bet. On 2022/01/30 01:51, Charles Givre wrote: Hey James, Alas... I'm afraid I'd have to give a -1 on this. There are some dependabot alerts at the moment, which we really should resolve (or at least look at) before cutting a release. One of which has is linked to a severe CVE. Also, I just submitted a VERY minor bug fix which I'd love to squeak into this release, but that's not urgent. Best, --C On Jan 29, 2022, at 7:36 AM, James Turton wrote: Hello Dev community Not a moment too soon, we've finally dispatched the last issues holding back 1.20! Here's a big thank you from the release manager to everyone who helped to push us forward to this point. I'm sure I'm not the only one receiving the "When it's coming??" questions. As an interesting bit of trivia, there have been about 9 months separating recent releases and it has now been about 8 months since 1.19. Who knew we were so consistent ;-) ? Please vote for or against a feature freeze on the master branch. I assume only critical bug or vulnerability fixes get freeze immunity? Thank you James
Re: [VOTE] Freeze for Drill 1.20
Assuming we pass dependabot, big +1 from me!! Great work everyone! --C > On Feb 2, 2022, at 9:35 AM, James Turton wrote: > > Please vote again on the assumption that the very minor Postgresql 42.3.1 -> > 42.3.2 PR will be merged, clearing the last Dependabot alert. It passed > local testing so it looks like a safe bet. > > > On 2022/01/30 01:51, Charles Givre wrote: >> Hey James, >> Alas... I'm afraid I'd have to give a -1 on this. There are some dependabot >> alerts at the moment, which we really should resolve (or at least look at) >> before cutting a release. One of which has is linked to a severe CVE. Also, >> I just submitted a VERY minor bug fix which I'd love to squeak into this >> release, but that's not urgent. >> Best, >> --C >> >> >>> On Jan 29, 2022, at 7:36 AM, James Turton wrote: >>> >>> Hello Dev community >>> >>> Not a moment too soon, we've finally dispatched the last issues holding >>> back 1.20! Here's a big thank you from the release manager to everyone who >>> helped to push us forward to this point. I'm sure I'm not the only one >>> receiving the "When it's coming??" questions. As an interesting bit of >>> trivia, there have been about 9 months separating recent releases and it >>> has now been about 8 months since 1.19. Who knew we were so consistent ;-) >>> ? >>> >>> Please vote for or against a feature freeze on the master branch. I assume >>> only critical bug or vulnerability fixes get freeze immunity? >>> >>> Thank you >>> James >>> >
[GitHub] [drill] jnturton merged pull request #2449: DRILL-7994: Dependency version updates for severe vulnerabilities
jnturton merged pull request #2449: URL: https://github.com/apache/drill/pull/2449 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Freeze for Drill 1.20
PR #2449 was merged and there are now zero Dependabot alerts against master. +1 for freezing from me. On 2022/02/02 16:36, Charles Givre wrote: Assuming we pass dependabot, big +1 from me!! Great work everyone! --C On Feb 2, 2022, at 9:35 AM, James Turton wrote: Please vote again on the assumption that the very minor Postgresql 42.3.1 -> 42.3.2 PR will be merged, clearing the last Dependabot alert. It passed local testing so it looks like a safe bet. On 2022/01/30 01:51, Charles Givre wrote: Hey James, Alas... I'm afraid I'd have to give a -1 on this. There are some dependabot alerts at the moment, which we really should resolve (or at least look at) before cutting a release. One of which has is linked to a severe CVE. Also, I just submitted a VERY minor bug fix which I'd love to squeak into this release, but that's not urgent. Best, --C On Jan 29, 2022, at 7:36 AM, James Turton wrote: Hello Dev community Not a moment too soon, we've finally dispatched the last issues holding back 1.20! Here's a big thank you from the release manager to everyone who helped to push us forward to this point. I'm sure I'm not the only one receiving the "When it's coming??" questions. As an interesting bit of trivia, there have been about 9 months separating recent releases and it has now been about 8 months since 1.19. Who knew we were so consistent ;-) ? Please vote for or against a feature freeze on the master branch. I assume only critical bug or vulnerability fixes get freeze immunity? Thank you James
Re: [VOTE] Freeze for Drill 1.20
+1 Kind regards, Volodymyr Vysotskyi On 2022/02/02 15:59:55 James Turton wrote: > PR #2449 was merged and there are now zero Dependabot alerts against > master. > > +1 for freezing from me. > > On 2022/02/02 16:36, Charles Givre wrote: > > Assuming we pass dependabot, big +1 from me!! Great work everyone! > > --C > > > >> On Feb 2, 2022, at 9:35 AM, James Turton wrote: > >> > >> Please vote again on the assumption that the very minor Postgresql 42.3.1 > >> -> 42.3.2 PR will be merged, clearing the last Dependabot alert. It > >> passed local testing so it looks like a safe bet. > >> > >> > >> On 2022/01/30 01:51, Charles Givre wrote: > >>> Hey James, > >>> Alas... I'm afraid I'd have to give a -1 on this. There are some > >>> dependabot alerts at the moment, which we really should resolve (or at > >>> least look at) before cutting a release. One of which has is linked to a > >>> severe CVE. Also, I just submitted a VERY minor bug fix which I'd love to > >>> squeak into this release, but that's not urgent. > >>> Best, > >>> --C > >>> > >>> > On Jan 29, 2022, at 7:36 AM, James Turton wrote: > > Hello Dev community > > Not a moment too soon, we've finally dispatched the last issues holding > back 1.20! Here's a big thank you from the release manager to everyone > who helped to push us forward to this point. I'm sure I'm not the only > one receiving the "When it's coming??" questions. As an interesting bit > of trivia, there have been about 9 months separating recent releases and > it has now been about 8 months since 1.19. Who knew we were so > consistent ;-) ? > > Please vote for or against a feature freeze on the master branch. I > assume only critical bug or vulnerability fixes get freeze immunity? > > Thank you > James > > >> > > >
Re: [VOTE] Freeze for Drill 1.20
+1 Kind regards Vitalii On Wed, Feb 2, 2022 at 6:04 PM Vova Vysotskyi wrote: > +1 > > Kind regards, > Volodymyr Vysotskyi > > On 2022/02/02 15:59:55 James Turton wrote: > > PR #2449 was merged and there are now zero Dependabot alerts against > > master. > > > > +1 for freezing from me. > > > > On 2022/02/02 16:36, Charles Givre wrote: > > > Assuming we pass dependabot, big +1 from me!! Great work everyone! > > > --C > > > > > >> On Feb 2, 2022, at 9:35 AM, James Turton wrote: > > >> > > >> Please vote again on the assumption that the very minor Postgresql > 42.3.1 -> 42.3.2 PR will be merged, clearing the last Dependabot alert. It > passed local testing so it looks like a safe bet. > > >> > > >> > > >> On 2022/01/30 01:51, Charles Givre wrote: > > >>> Hey James, > > >>> Alas... I'm afraid I'd have to give a -1 on this. There are some > dependabot alerts at the moment, which we really should resolve (or at > least look at) before cutting a release. One of which has is linked to a > severe CVE. Also, I just submitted a VERY minor bug fix which I'd love to > squeak into this release, but that's not urgent. > > >>> Best, > > >>> --C > > >>> > > >>> > > On Jan 29, 2022, at 7:36 AM, James Turton wrote: > > > > Hello Dev community > > > > Not a moment too soon, we've finally dispatched the last issues > holding back 1.20! Here's a big thank you from the release manager to > everyone who helped to push us forward to this point. I'm sure I'm not the > only one receiving the "When it's coming??" questions. As an interesting > bit of trivia, there have been about 9 months separating recent releases > and it has now been about 8 months since 1.19. Who knew we were so > consistent ;-) ? > > > > Please vote for or against a feature freeze on the master branch. > I assume only critical bug or vulnerability fixes get freeze immunity? > > > > Thank you > > James > > > > >> > > > > > >
Re: [VOTE] Freeze for Drill 1.20
\+1 from me Regards Christian \ Original-Nachricht Am 2. Feb. 2022, 17:13, Vitalii Diravka schrieb: > > > > \+1 > > Kind regards > Vitalii > > > On Wed, Feb 2, 2022 at 6:04 PM Vova Vysotskyi wrote: > > > +1 > > > > Kind regards, > > Volodymyr Vysotskyi > > > > On 2022/02/02 15:59:55 James Turton wrote: > > > PR \#2449 was merged and there are now zero Dependabot alerts against > > > master. > > > > > > +1 for freezing from me. > > > > > > On 2022/02/02 16:36, Charles Givre wrote: > > > > Assuming we pass dependabot, big +1 from me!! Great work everyone! > > > > --C > > > > > > > >> On Feb 2, 2022, at 9:35 AM, James Turton wrote: > > > >> > > > >> Please vote again on the assumption that the very minor Postgresql > > 42.3.1 -> 42.3.2 PR will be merged, clearing the last Dependabot alert. It > > passed local testing so it looks like a safe bet. > > > >> > > > >> > > > >> On 2022/01/30 01:51, Charles Givre wrote: > > > >>> Hey James, > > > >>> Alas... I'm afraid I'd have to give a -1 on this. There are some > > dependabot alerts at the moment, which we really should resolve (or at > > least look at) before cutting a release. One of which has is linked to a > > severe CVE. Also, I just submitted a VERY minor bug fix which I'd love to > > squeak into this release, but that's not urgent. > > > >>> Best, > > > >>> --C > > > >>> > > > >>> > > > On Jan 29, 2022, at 7:36 AM, James Turton wrote: > > > > > > Hello Dev community > > > > > > Not a moment too soon, we've finally dispatched the last issues > > holding back 1.20! Here's a big thank you from the release manager to > > everyone who helped to push us forward to this point. I'm sure I'm not the > > only one receiving the "When it's coming??" questions. As an interesting > > bit of trivia, there have been about 9 months separating recent releases > > and it has now been about 8 months since 1.19. Who knew we were so > > consistent ;-) ? > > > > > > Please vote for or against a feature freeze on the master branch. > > I assume only critical bug or vulnerability fixes get freeze immunity? > > > > > > Thank you > > > James > > > > > > >> > > > > > > > > > > publickey - EmailAddress(s=z0ltrix@pm.me) - 0xF0E154C5.asc Description: application/pgp-keys signature.asc Description: OpenPGP digital signature
[GitHub] [drill] paul-rogers commented on pull request #2364: DRILL-8037: Add V2 JSON Format Plugin based on EVF
paul-rogers commented on pull request #2364: URL: https://github.com/apache/drill/pull/2364#issuecomment-1028638636 Oddly, `TestE2EUnnestAndLateral` works just fine in Eclipse on my machine with this branch. Is that the correct test which was failing? Also, I see in the panel here in GitHub that all tests passed. Can you explain the issue a bit more? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (DRILL-8123) Revise scan limit pushdown
Paul Rogers created DRILL-8123: -- Summary: Revise scan limit pushdown Key: DRILL-8123 URL: https://issues.apache.org/jira/browse/DRILL-8123 Project: Apache Drill Issue Type: New Feature Reporter: Paul Rogers Assignee: Paul Rogers Recent work added a push down of the limit into a scan. The work had a few holes, one of which was plugged by the recent update of EVF to manage the limit. Another hole is that the physical plan uses a value of 0 to indicate no limit, but 0 is a perfectly valid limit, it means "no data, only schema." The field name is "maxRecords", but should be "limit" to indicate the purpose. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [drill] paul-rogers opened a new pull request #2450: DRILL-8123: Revise scan limit pushdown
paul-rogers opened a new pull request #2450: URL: https://github.com/apache/drill/pull/2450 # [DRILL-8123](https://issues.apache.org/jira/browse/DRILL-8123): Revise scan limit pushdown ## Description Recent work added a push down of the limit into a scan. The work had a few holes, one of which was plugged by the recent update of EVF to manage the limit. Another hole is that the physical plan uses a value of 0 to indicate no limit, but 0 is a perfectly valid limit, it means "no data, only schema." The field name is "maxRecords", but should be "limit" to indicate the purpose. ## Documentation N/A ## Testing Reran unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (DRILL-8124) Fix implicit file issue with EVF 2
Paul Rogers created DRILL-8124: -- Summary: Fix implicit file issue with EVF 2 Key: DRILL-8124 URL: https://issues.apache.org/jira/browse/DRILL-8124 Project: Apache Drill Issue Type: New Feature Reporter: Paul Rogers Assignee: Paul Rogers Unit testing with EVF 2 found an issue in the handling of implicit columns. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [drill] jnturton commented on pull request #2450: DRILL-8123: Revise scan limit pushdown
jnturton commented on pull request #2450: URL: https://github.com/apache/drill/pull/2450#issuecomment-1028677289 Thank you for reworking these PRs @paul-rogers. It was only the timestamp fixes that I really felt should receive separate review, but these incremental PRs are great. Should I close the monolithic #2419, or switch it to draft, so that it's clear we should not merge that one? Anecdote: I had to look at a LIMIT 0 query against Parquet yesterday and saw that the Parquet reader reads a single batch of data anyway, even though I don't believe there's any need for it to. All "limit 0 shortcut" config opts that I could see were enabled. I know the present-day Parquet readers are their own animals entirely, entirely unlike EVF style readers, but I thought this anecdote might be of interest since the same LIMIT 0 case is being addressed here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
