Re: [PR] DRILL-8450: Add Data Type Inference to XML Format Plugin (drill)
cgivre commented on PR #2819: URL: https://github.com/apache/drill/pull/2819#issuecomment-1673416654 Converting to draft. There's a unit test failing in the HTTP plugin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] DRILL-8451: options and profile pages have bad order symbols style (drill)
cgivre commented on PR #2820: URL: https://github.com/apache/drill/pull/2820#issuecomment-1673415150 @rymarm Would you mind please rebasing on current master? There's now a merge conflict as a result of your other PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] DRILL-8449: fix typo in width property in FreeMarker templates (drill)
cgivre merged PR #2818: URL: https://github.com/apache/drill/pull/2818 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: checkstyle problems
So mvn checkstyle:checkstyle announces a count of two errors but doesn't print out their descriptions earlier on? On 2023/08/08 16:28, Mike Beckerle wrote: I'm getting a crash on checkstyle. I can't figure out what the remaining 2 checkstyle errors are, and checkstyle is failing to create its output report. Does anybody have a clue for me on how to proceed? [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1:checkstyle (default-cli) on project drill-format-xml: An error has occurred in Checkstyle report generation.: Failed during checkstyle execution: There are 2 errors reported by Checkstyle 10.7.0 with src/main/resources/checkstyle-config.xml ruleset. -> [Help 1] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1:checkstyle (default-cli) on project drill-format-xml: An error has occurred in Checkstyle report generation. at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148) Mike Beckerle Apache Daffodil PMC | daffodil.apache.org OGF DFDL Workgroup Co-Chair | www.ogf.org/ogf/doku.php/standards/dfdl/dfdl Owl Cyber Defense | www.owlcyberdefense.com
Re: UserBitShared.proto question
Check the following readme on how to regenerate java sources: https://github.com/apache/drill/blob/master/protocol/readme.txt Be careful, to regenerate java sources you need to have 'protoc' compiler installed on your machine. Except for java, Drill also has c++ sources used for native clients. Those sources should be also regenerated but it is a more complicated task than compiling java sources. The link to the doc on how to do this you can find in the above readme. On 2023/08/08 13:46:02 Mike Beckerle wrote: > So is UserBitShared.java generated from UserBitShared.proto ? > > It looks like it is, but mvn clean install -DskipTests=true doesn't seem to > cause it to be regenerated. > > What do I do to cause the regeneration? > > Right now I've edited both files to add a new ErrorType.SCHEMA, but I think > I should only have to edit in one spot. >
