Re: [PR] DRILL-8436: Upgrade Hadoop 3.2.4 → 3.3.6 (drill)
jnturton commented on code in PR #2821: URL: https://github.com/apache/drill/pull/2821#discussion_r1305095341 ## exec/jdbc-all/pom.xml: ## @@ -679,86 +688,85 @@ *:* -**/logback.xml Review Comment: Another list that's been sorted alphabetically in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] DRILL-8436: Upgrade Hadoop 3.2.4 → 3.3.6 (drill)
jnturton commented on code in PR #2821: URL: https://github.com/apache/drill/pull/2821#discussion_r1305093910 ## exec/jdbc-all/pom.xml: ## @@ -388,51 +396,52 @@ *:* - io.protostuff:* Review Comment: @cgivre All the diff noise here comes about because I decided to sort this list alphabetically in the hopes that contributors will keep it sorted from here on, making checking what's in it that much easier. I can revert the sorting if preferred though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] DRILL-8436: Upgrade Hadoop 3.2.4 → 3.3.6 (drill)
jnturton commented on code in PR #2821: URL: https://github.com/apache/drill/pull/2821#discussion_r1305092866 ## contrib/storage-phoenix/pom.xml: ## @@ -29,9 +29,9 @@ Drill : Contrib : Storage : Phoenix -5.1.2 +5.1.3 Review Comment: @cgivre I need to reword this comment slightly and prune some commented sections from java-exec/pom.xml below, but are you happy with this PR at this stage? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump sqlite-jdbc from 3.30.1 to 3.41.2.2 in /metastore/rdbms-metastore (drill)
cgivre merged PR #2812: URL: https://github.com/apache/drill/pull/2812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: drill tests not passing
Still no luck. Output from your mvn-test-drill command is attached. drill-java-exec: Artifact has not been packaged yet. On Mon, Aug 21, 2023 at 10:36 AM James Turton wrote: > Hi Mike > > I took a look at the build log that you shared with me recently and what > happened in that run was OOM (first report on line 9348). > >9355 2198813 ERROR [UserServer-1] > [org.apache.drill.exec.rpc.RpcExceptionHandler] - Exception in RPC > communication.9355 Connection: /127.0.0.1:31046 <--> /127.0.0.1:39558 > (user server). Closing connection. >9356 java.lang.OutOfMemoryError: GC overhead limit exceeded > > My command to run Drill tests set memory limits as follows. > > alias mvn-test-drill="mvn test \ > -Djunit.args=\"-Duser.timezone=UTC -Duser.language=en > -Duser.region=US\" \ > -DmemoryMb=2560 -DdirectMemoryMb=2560 \ > -DforkCount=2" > > Hope this helps... > James > > On 2023/07/25 00:00, Mike Beckerle wrote: > > Hi drill devs, > > I'm still stuck on this problem. Can anyone suggest a way past this? > > Mike Beckerle > Apache Daffodil PMC | daffodil.apache.org > OGF DFDL Workgroup Co-Chair | www.ogf.org/ogf/doku.php/standards/dfdl/dfdl > Owl Cyber Defense | www.owlcyberdefense.com > > > > On Mon, Jul 17, 2023 at 9:53 AM Mike Beckerle > wrote: > > > Looks like I attached the wrong file. Doing too many things at once. > > The correct file is attached here. > > > > On Fri, Jul 14, 2023 at 2:04 PM Mike Beckerle > > wrote: > > > Update: I did a clean and install -DskipTests=true. > > Then I tried the mvn test using the non-UTC timezone stuff, as suggested. > > But alas, it still fails, this time the failure unique and is only in > "Java Execution Engine" > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-dependency-plugin:3.4.0:unpack > (unpack-vector-types) on project drill-java-exec: Artifact has not been > packaged yet. When used on reactor artifact, unpack should be executed > after packaging: see MDEP-98. -> [Help 1] > > The command and complete trace output are below. > > I need assistance on how to proceed. > > Complete trace from the mvn test is attached. > > > On Thu, Jul 13, 2023 at 1:13 PM Mike Beckerle > > wrote: > > > To answer questions: > > 1. Paul: This is a 100% stock build. All I have done is clone the repo > (master branch). Make a new git branch (in case I make future changes). Try > to build (success) and test (failed so far). > > 2. James: The /opt/drill directory I created is owned by my userid and > has full read/write access for all the development activities. I just put > it there so it would have a shorter path to fix the first Hive-related > glitch I encountered with the Linux 255 limit on file pathname length. > > I will try the suggested maven command line for non-UTC and see if > things improve. > > The challenge for me as a newby is how do I know if I have everything > properly configured? > > Can I just turn off building and testing of the Hive-related stuff in > some supported/well-known way? > > If so, I would suggest I'd like to turn off not just Hive, but *as much > as possible*. I really just need the embedded drill to work. > > I would agree with @Charles Givrethat > a contrib > package addition is the ideal approach and that's what I'll be attempting. > > -mikeb > > On Thu, Jul 13, 2023 at 10:59 AM Charles Givre > wrote: > > > I'll add some heresy here... IMHO, for the purposes of developing a > DFDL extension, you probably don't need all the Drill tests to run. For > your project, my suggestion would be to add a module to the contrib package > and that way your changes are relatively self contained. > Best, > -- C > > > > > On Jul 13, 2023, at 10:27 AM, James Turton > wrote: > > Hi Mike > > Here's the command line I use to run tests on a machine that's not in > > the UTC time zone (plus some unrelated memory size arguments). > > mvn test -Djunit.args="-Duser.timezone=UTC -Duser.language=en > > -Duser.region=US" -DmemoryMb=2560 -DdirectMemoryMb=2560 > > I have one other question to add to Paul's comments - does the OS > > user that you're running Maven under have write access to all of the source > tree that you put at /opt/drill? > > On 2023/07/11 22:12, Paul Rogers wrote: > > Hi Mike, > > A quick glance at the log suggests a failure in the tests for the > > JSON > > reader, in the Mongo extended types. Drill's date/time support has > historically been fragile. Some tests only work if your machine is > > set to > > use the UTC time zone (or Java is told to pretend that the time is > > UTC.) > > The Mongo types test failure seems to be around a date/time test so > > maybe > > this is the issue? > > There are also failures indicating that the Drillbit (Drill server) > > died. > > Not sure how this can happen, as tests run Drill embedded (or used > > to.) > > Looking earlier in the logs, it seems that the Drillbit didn't start > > due to > > UDF (user-defined function) failures: > > Found duplicate
Re: [PR] DRILL-8453: Add XSD Support to XML Reader (Part 1) (drill)
mbeckerle commented on PR #2824: URL: https://github.com/apache/drill/pull/2824#issuecomment-1691830388 I'm ok with merging this. It's still a bit of a work-in-progress (hence the Part 1) Some TODOs in here are mine. I do intend to get to them, but no reason to hold up this change set for that. I highly recommend that you squash these 15 commits together into one coherent commit rather than commit all 15 as is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] DRILL-8420: Remove Guava shading and patching (drill)
jnturton commented on PR #2786: URL: https://github.com/apache/drill/pull/2786#issuecomment-1691627763 > @jnturton Is this PR still relevant? Yes, I'm going to resurrect it after all the other clean up and upgrade PRs are in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] DRILL-8454: Disable unsupported MapR profile and plugin (drill)
jnturton opened a new pull request, #2825: URL: https://github.com/apache/drill/pull/2825 # [DRILL-8454](https://issues.apache.org/jira/browse/DRILL-8454): Disable unsupported MapR profile and plugin ## Description The MapR build profile and format plugin, which fell out of support in the open source Drill codebase years ago, are disabled. Drill users needing support for these components should contact HPE. ## Documentation See the HPE Ezmeral docs. ## Testing Build and unit tests of remaining modules pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (DRILL-8454) Disable unsupported MapR profile and plugin
James Turton created DRILL-8454: --- Summary: Disable unsupported MapR profile and plugin Key: DRILL-8454 URL: https://issues.apache.org/jira/browse/DRILL-8454 Project: Apache Drill Issue Type: Improvement Components: Tools, Build & Test Affects Versions: 1.21.1 Reporter: James Turton Assignee: James Turton Fix For: 1.22.0 The MapR build profile and format plugin, which fell out of support in the open source Drill codebase years ago, are disabled. Drill users needing support for these components should contact HPE. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] DRILL-8453: Add XSD Support to XML Reader (Part 1) (drill)
cgivre commented on code in PR #2824:
URL: https://github.com/apache/drill/pull/2824#discussion_r1304230698
##
contrib/format-xml/src/test/resources/logback-test.xml:
##
@@ -0,0 +1,69 @@
+
+
+
+
+
+
+true
+1
+true
+${LILITH_HOSTNAME:-localhost}
+
Review Comment:
This is a file which should have not been included in the PR. ;-).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] DRILL-8420: Remove Guava shading and patching (drill)
cgivre commented on PR #2786: URL: https://github.com/apache/drill/pull/2786#issuecomment-1691559682 @jnturton Is this PR still relevant? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
