Re: [PR] DRILL-8467: Update Netty to 4.1.101 (drill)
jnturton commented on PR #2857: URL: https://github.com/apache/drill/pull/2857#issuecomment-1872747437 P.S. the failing test class is fine on my laptop under IBM JDK 8 so I do think we can fix this in the CI with some environment tweaks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: Next Version
Hi Luoc, Thanks for reminding me about the EVF V2 work. I got mostly done adding projection for complex types, then got busy on other projects. I've yet to tackle the hard cases: unions, repeated unions and repeated lists (which are, in fact, repeated repeated unions). The code to handle unprojected fields in these areas is getting awfully complicated. In doing that work, and then seeing a trick that Druid uses, I'm tempted to rework the projection bits of the code to use a cleaner approach. However, it might be better to commit the work done thus far so folks can use it before I wander off to take another approach. Then, I wondered if anyone actually still uses this stuff. Do you still need the code to handle non-projection of complex types? Of course, perhaps no one will ever need the hard cases: I've never been convinced that unions, repeated lists, or arrays of repeated lists are things that any sane data engineer will want to use -- or use more than once. Thanks, - Paul On Sat, Dec 30, 2023 at 10:26 PM James Turton wrote: > Hi Luoc and Drill devs! > > It's best to email Paul directly since he doesn't follow these lists > closely. In the meantime I've prepared a PR of backported fixes for > 1.21.2 to the 1.21 branch [1]. I think we can try to get the Netty > upgrade that Maksym is working on, and which looks close to done, > included? There's at least one CVE applicable to our current version of > Netty... > > Regards > James > > > 1. https://github.com/apache/drill/pull/2860 > > On 2023/12/11 04:41, luoc wrote: > > Hello all, > >1.22 will be a more stable version. This is a digression: Is Paul > still interested in participating in the EVF V2 refactoring in the > framework? I would like to offer time to assist him. > > > > luoc > > > >> 2023年12月9日 01:01，Charles Givre 写道： > >> > >> Hello all, > >> Happy Friday everyone! I wanted to raise the topic of getting a Drill > minor release out the door before the end of the year. My opinion is that > I'd really like to release Drill 1.22 once the integration with Apache > Daffodil is complete, but it sounds like that is still a few weeks away. > >> > >> What does everyone think about issuing a maintenance release before the > end of the year? There are a number of singificant fixes including some > security updates and a major bug in the ES plugin that basically makes it > unusable. > >> Best, > >> -- C > >
Re: Next Version
Hi Luoc and Drill devs! It's best to email Paul directly since he doesn't follow these lists closely. In the meantime I've prepared a PR of backported fixes for 1.21.2 to the 1.21 branch [1]. I think we can try to get the Netty upgrade that Maksym is working on, and which looks close to done, included? There's at least one CVE applicable to our current version of Netty... Regards James 1. https://github.com/apache/drill/pull/2860 On 2023/12/11 04:41, luoc wrote: Hello all, 1.22 will be a more stable version. This is a digression: Is Paul still interested in participating in the EVF V2 refactoring in the framework? I would like to offer time to assist him. luoc 2023年12月9日 01:01，Charles Givre 写道： Hello all, Happy Friday everyone! I wanted to raise the topic of getting a Drill minor release out the door before the end of the year. My opinion is that I'd really like to release Drill 1.22 once the integration with Apache Daffodil is complete, but it sounds like that is still a few weeks away. What does everyone think about issuing a maintenance release before the end of the year? There are a number of singificant fixes including some security updates and a major bug in the ES plugin that basically makes it unusable. Best, -- C
[PR] BACKPORT-TO-STABLE: Backported fixes for Drill 1.21.2 (drill)
jnturton opened a new pull request, #2860: URL: https://github.com/apache/drill/pull/2860 # [BACKPORT-TO-STABLE]: Backported fixes for Drill 1.21.2 ## Description Fixes and minor enhancements since Drill 1.21.1 backported from the master branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] DRILL-8443: Upgrade netty due to CVE (drill)
jnturton commented on PR #2813: URL: https://github.com/apache/drill/pull/2813#issuecomment-1872676811 @pjfanning @cgivre, @rymarm has made progress on this in #2857. Shall we close this one and try to get that one over the line? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update Netty to 4.1.101 (drill)
jnturton commented on PR #2857: URL: https://github.com/apache/drill/pull/2857#issuecomment-1872673208 Hi @rymarm! Here are two things it would be interesting to redo the Java 8 runs with. 1. Adding the EasyOutOfMemory annotation to TestValueVector.java. 2. Bumping the directMemoryMb value in pom.xml. We set up a swap file at the start of the CI run now so you could try to taking this up to 3Gb. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
