[GitHub] drill issue #1236: DRILL-6347: Inconsistent method name "field".

[BruceKuiLiu]

Github user BruceKuiLiu commented on the issue:

https://github.com/apache/drill/pull/1236
  
@vrozov Thanks.



---

[GitHub] drill issue #1235: DRILL-6336: Inconsistent method name.

[BruceKuiLiu]

Github user BruceKuiLiu commented on the issue:

https://github.com/apache/drill/pull/1235
  
Thanks.


---

[GitHub] drill pull request #1236: DRILL-6347: Inconsistent method name "field".

[BruceKuiLiu]

GitHub user BruceKuiLiu opened a pull request:

https://github.com/apache/drill/pull/1236

DRILL-6347: Inconsistent method name "field".

The method is names as "field", but the method is mainly doing appending. 
So that, rename the method as "append" should be better.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/BruceKuiLiu/drill field

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/1236.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1236


commit ecef20386237eb154555ec76e8cf4eabac022c38
Author: Kui LIU 
Date:   2018-04-21T20:03:56Z

Change the method name 'field' to 'append'.




---

[GitHub] drill pull request #1235: DRILL-6336: Inconsistent method name.

[BruceKuiLiu]

GitHub user BruceKuiLiu opened a pull request:

https://github.com/apache/drill/pull/1235

DRILL-6336: Inconsistent method name.

Change the method name "append" to "print" since its body code is an method 
invocation "writer.print( s )". The method named "print" should be more clear.
The method name "append" is labeled as "@Deprecated" in case of breaking 
backward compatibility.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/BruceKuiLiu/drill master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/1235.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1235


commit d501d338f23acd60164d85c36f5143426a426ea3
Author: Kui LIU 
Date:   2018-04-17T15:45:44Z

Rename method.




---