Access to jira
Hi All, Can I get rights to assign/modify JIRA issues to myself -- Kamesh.
Re: Access to jira
Thanks Jacques. It is working. On Sun, Nov 8, 2015 at 10:22 PM, Jacques Nadeau <jacq...@dremio.com> wrote: > Updated. Let me know if it doesn't work. > > -- > Jacques Nadeau > CTO and Co-Founder, Dremio > > On Sun, Nov 8, 2015 at 6:50 AM, Kamesh <kamesh.had...@gmail.com> wrote: > > > Hi All, > > Can I get rights to assign/modify JIRA issues to myself > > > > -- > > Kamesh. > > > -- Kamesh.
[jira] [Resolved] (DRILL-2352) MongoDB join queries can't select fields
[ https://issues.apache.org/jira/browse/DRILL-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bhallamudi Venkata Siva Kamesh resolved DRILL-2352. --- Resolution: Fixed Fix Version/s: (was: Future) > MongoDB join queries can't select fields > > > Key: DRILL-2352 > URL: https://issues.apache.org/jira/browse/DRILL-2352 > Project: Apache Drill > Issue Type: Bug > Components: Storage - MongoDB >Affects Versions: 0.7.0 > Environment: Ubuntu 14.04 64 bits, OpenJDK 1.7.0_75, Mongo 2.6.8 >Reporter: Mariano Ruiz > Attachments: drill-error-select-without-limit.log, > drill-select-with-limit.log > > > When I perform this *JOIN* query between two MongoDB documents, there is no > problem: > {code:sql} > select * from zips as z join states as s on z.state = s.code; > {code} > Result: > {code} > +++ > | * | *0 | > +++ > | { "city" : "AGAWAM" , "loc" : [ -72.622739 , 42.070206] , "pop" : 15338 , > "state" : "MA"} | { "code" : "CA" , "name" : "California"} | > | { "city" : "AGAWAM" , "loc" : [ -72.622739 , 42.070206] , "pop" : 15338 , > "state" : "MA"} | { "code" : "DC" , "name" : "Washington"} | > | { "city" : "AGAWAM" , "loc" : [ -72.622739 , 42.070206] , "pop" : 15338 , > "state" : "MA"} | { "code" : "NY" , "name" : "New York"} | > | { "city" : "CUSHMAN" , "loc" : [ -72.51565 , 42.377017] , "pop" : 36963 , > "state" : "MA"} | { "code" : "CA" , "name" : "California"} | > | { "city" : "CUSHMAN" , "loc" : [ -72.51565 , 42.377017] , "pop" : 36963 , > "state" : "MA"} | { "code" : "DC" , "name" : "Washington"} | > {code} > But when I try to select which field I want to see I get this: > {code} > 0: jdbc:drill:zk=local> select z.city, s.name from zips as z join states as s > on z.state = s.code; > Query failed: Query failed: Unexpected exception during fragment > initialization: null > Error: exception while executing query: Failure while executing query. > (state=,code=0) > {code} > I realized after a few tests, that the problem is you can't specify a column > from the table left operator in the JOIN-ON clause. > For example, this works: > {code} > jdbc:drill:zk=local> select z.city from states as s join zips as z on s.code > = z.state limit 5; > ++ > |city| > ++ > | LOS ANGELES | > | TRUCKEE| > | TRUCKEE| > | SOUTH LAKE TAHOE | > | TAHOE VISTA | > {code} > But this doesn't: > {code} > jdbc:drill:zk=local> select s.name from states as s join zips as z on s.code > = z.state limit 5; > ++ > |name| > ++ > ++ > {code} > The same occurs in the WHERE clause, for example this works: > {code:sql} > select z.city from states as s join zips as z on s.code = z.state where > z.city = 'LOS ANGELES'; > {code} > And this doesn't: > {code} > 0: jdbc:drill:zk=local> select z.city from states as s join zips as z on > s.code = z.state where s.code = 'CA' limit 5; > Query failed: Query failed: Unexpected exception during fragment > initialization: null > Error: exception while executing query: Failure while executing query. > (state=,code=0) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Apache Drill 1.2 Release Notes
Please check whether this can be added to RN Enhancements to Avro file formats - Supporting complexing data types like Union, Map etc.. - Optimizing the way Avro file are processed (block wise processing). On Thu, Oct 15, 2015 at 11:03 AM, Jacques Nadeau <jacq...@dremio.com> wrote: > You've changed the format of the release notes. Why don't we use the same > as before for the JIRA table? I'd use the JIRA release notes link as there > are a few that were merged since this initial list was likely generated. > > One of the key new features is support for JDBC data sources (MySQL, etc) > via a new JDBC Storage plugin. That isn't listed on the list of what's new. > > We also have improvements in the Drill JDBC driver including inclusion of > Javadocs and better application dependency compatibility. > > Additionally, these look like dupes: > >- Native file readers for Parquet >< > http://kristinehahn.github.io/drill/docs/querying-hive/#optimizing-reads-of-parquet-backed-tables > > >- Optimized reads >< > http://kristinehahn.github.io/drill/docs/querying-hive/#optimizing-reads-of-parquet-backed-tables > > > of >Parquet-backed, Hive tables > > And the first one is misleading. I would only include the second. > > > > -- > Jacques Nadeau > CTO and Co-Founder, Dremio > > On Wed, Oct 14, 2015 at 12:25 PM, Kristine Hahn <kh...@maprtech.com> > wrote: > > > Release notes and a What's New section for Apache Drill 1.2 are ready for > > review on my staging site. > > > >- > > > > > http://kristinehahn.github.io/drill/docs/apache-drill-1-2-0-release-notes/ > >- > > > > > http://kristinehahn.github.io/drill/docs/drill-introduction/#what-39-s-new-in-apache-drill-1-2 > > > > Jacques--I got a sanitized list from Hakim about a week ago and think a > few > > issues have been handled since then. Please tell me: > > > >- Any additions/deletions to the RN? JDBC storage plugin? > >- Any changes to What's New? > > > > Kristine Hahn > > Sr. Technical Writer > > 415-497-8107 @krishahn skype:krishahn > > > -- Kamesh.
Re: Improved JIRA process
+1 on this proposal. On Wed, Sep 23, 2015 at 7:28 AM, Edmon Begoli <ebeg...@gmail.com> wrote: > Got it. Makes sense. > > On Tue, Sep 22, 2015 at 9:42 PM, Jacques Nadeau <jacq...@dremio.com> > wrote: > > > On (3), my thought is that they plan on commencing in the next couple > > weeks, (not that they have to complete by then). The fix for tag tells > > others how long they it will take. If someone wants it faster, they > should > > chime in to help out. > > > > -- > > Jacques Nadeau > > CTO and Co-Founder, Dremio > > > > On Tue, Sep 22, 2015 at 6:15 PM, Edmon Begoli <ebeg...@gmail.com> wrote: > > > > > Sounds good to me. > > > > > > I would only comment that we should probably relax item 3 to tie the > > > commitment to the release schedule. > > > There might be issues that cannot be worked on within few weeks, but > are > > > good to keep planned for the future few releases ahead. > > > > > > On Tue, Sep 22, 2015 at 9:05 PM, Jacques Nadeau <jacq...@apache.org> > > > wrote: > > > > > > > Hey Everybody, > > > > > > > > As more and more people are starting to work on JIRAs, I'd like to > > > propose > > > > a new process around jira assignment, targeting, etc. This way people > > > will > > > > be able to more easily identify available issues for pick up and > > general > > > > development intentions. > > > > > > > > I propose the following: > > > > > > > >1. We should remove the default assignment of new issues. > > > >2. We need to remove all current assignments other than those that > > are > > > >currently active (or about to be active). > > > >3. Individual developers who plan to work on a feature should > assign > > > it > > > >to themselves. This should be a commitment to work on this feature > > > > within > > > >the next couple weeks. (They should also set the "fix for" to the > > > > release > > > >they would like to target completion.) > > > >4. Once a developer starts work on a feature, they should accept > the > > > >feature (showing that they are actively working on it). > > > >5. If another developer is interested in working on a feature that > > is > > > >assigned (but inactive), they should request taking over that > > feature > > > > from > > > >the current assignee. > > > > > > > > How does this sound? > > > > > > > > Jacques > > > > > > > > > > -- Kamesh.
[jira] [Created] (DRILL-3810) Filesystem plugin's support for file format's schema
Bhallamudi Venkata Siva Kamesh created DRILL-3810: - Summary: Filesystem plugin's support for file format's schema Key: DRILL-3810 URL: https://issues.apache.org/jira/browse/DRILL-3810 Project: Apache Drill Issue Type: Improvement Components: Storage - JSON, Storage - Other, Storage - Parquet, Storage - Text & CSV Reporter: Bhallamudi Venkata Siva Kamesh Assignee: Steven Phillips Filesystem Plugin supports multiple type of file formats like * json * avro * text (csv|psv|tsv) * parquet and can support any type of file formats. Among these file formats, some of the file formats are schema based like *avro* and *parquet* and some of them are schema less like *json*. For schema based file formats, Drill should have capability to validate the query against file schema, before start executing the query. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (DRILL-3777) Better to Upgrade mongodb java driver version.
Bhallamudi Venkata Siva Kamesh created DRILL-3777: - Summary: Better to Upgrade mongodb java driver version. Key: DRILL-3777 URL: https://issues.apache.org/jira/browse/DRILL-3777 Project: Apache Drill Issue Type: Improvement Components: Storage - MongoDB Reporter: Bhallamudi Venkata Siva Kamesh Assignee: B Anil Kumar Mongodb java driver version 3.0.3 fixed following critical issues, [JAVA-1881|https://jira.mongodb.org/browse/JAVA-1881] [JAVA-1882|https://jira.mongodb.org/browse/JAVA-1882] So, it is better to upgrade mongodb java driver version to 3.0.3, to avoid above issues. [Release Notes Mongo Java Driver 3.0.3|https://jira.mongodb.org/secure/ReleaseNote.jspa?projectId=10006=15539] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Patch Reviews (Mongo & Avro related issues)
Hi All, For the following issues I submitted patches. Can somebody review them. . DRILL-1666 <https://issues.apache.org/jira/browse/DRILL-1666> DRILL-2879 <https://issues.apache.org/jira/browse/DRILL-2879> DRILL-3720 <https://issues.apache.org/jira/browse/DRILL-3720> DRILL-3458 <https://issues.apache.org/jira/browse/DRILL-3458> DRILL-3699 <https://issues.apache.org/jira/browse/DRILL-3699> -- Kamesh.
[jira] [Created] (DRILL-3720) Avro Record Reader should process Avro files by per block basis
Bhallamudi Venkata Siva Kamesh created DRILL-3720: - Summary: Avro Record Reader should process Avro files by per block basis Key: DRILL-3720 URL: https://issues.apache.org/jira/browse/DRILL-3720 Project: Apache Drill Issue Type: Improvement Components: Storage - Other Affects Versions: 1.1.0, 1.0.0 Reporter: Bhallamudi Venkata Siva Kamesh Assignee: Jacques Nadeau Fix For: 1.2.0 Currently Avro Record Reader processes entire file in single drill bit. This is fine as long as files are of size HDFS block size. However, if the size of the file is *large*, it causes a lot of performance issues. To address this, Avro Record Reader should process Avro files by per block basis. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (DRILL-3699) Avro file format should validate the query with schema before processing.
Bhallamudi Venkata Siva Kamesh created DRILL-3699: - Summary: Avro file format should validate the query with schema before processing. Key: DRILL-3699 URL: https://issues.apache.org/jira/browse/DRILL-3699 Project: Apache Drill Issue Type: Improvement Components: Storage - Other Reporter: Bhallamudi Venkata Siva Kamesh Assignee: Jacques Nadeau For avro data, as schema will be available with data, Drill can evaluate the query with the schema before processing. This will avoid unnecessary processing and gives users a meaningful information, if the field, a user is using in the query does not exist in the data file. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Timing for 1.2 release, ideas around things to include
Can someone please look into the following patches. These are aimed for 1.2.0 release. DRILL-1666 (Testcases for Mongo plugin) DRILL-3458 (Enhancing Avro file format by supporting complex data types like Union, Map etc...) -- This is reviewed and I think, it is ready to commit. DRILL-2879 (Extended JSON support) On Wed, Aug 19, 2015 at 5:28 AM, Parth Chandra par...@apache.org wrote: A couple of reasons - a) We definitely need more QA time for the features that are ready. b) Some features, in particular, Parquet metadata caching (Steven) and Faster Hive reads (Jason) are close enough to completion that we really should include them. Again the team could use the extra time to QA these. On Tue, Aug 18, 2015 at 4:32 PM, Chris Westin chriswesti...@gmail.com wrote: Unfortunately, we've had to modify our plans, and are now thinking of aiming for a vote on September 10th. On Thu, Aug 13, 2015 at 1:29 PM, Chris Westin chriswesti...@gmail.com wrote: We were thinking of targetting for a vote on August 26th. On Thu, Aug 13, 2015 at 1:19 PM, Jacques Nadeau jacq...@dremio.com wrote: Following up since we haven't discussed the 1.2 release in a while. How are people feeling about trying to get a candidate out in the next week or two? thanks, Jacques -- Jacques Nadeau CTO and Co-Founder, Dremio -- Forwarded message -- From: Parth Chandra pchan...@maprtech.com Date: Thu, Jul 9, 2015 at 11:29 AM Subject: Re: Timing for 1.2 release, ideas around things to include To: dev@drill.apache.org I just moved DRILL-3201 to 1.2. It's one of the candidates for inclusion into 1.2 On Thu, Jul 9, 2015 at 7:04 AM, michael.engl...@nomura.com wrote: I'm not sure what the appetite is for pushing this into 1.2 vs the planned 1.3, but Drill UI Authentication would be really great for companies/users that run multi-tenant Hadoop clusters with Drill. At the moment any user can change storage plugins and cancel running queries, even if they did not submit them. This is a bit of a blocker for Drill on multi-tenant production clusters for now. JIRA link: https://issues.apache.org/jira/browse/DRILL-3201 -Original Message- From: Jacques Nadeau [mailto:jacq...@apache.org] Sent: 08 July 2015 17:19 To: dev@drill.apache.org Subject: Timing for 1.2 release, ideas around things to include Hey Guys, What do you think about planning the 1.2 feature cutoff around Aug 21st and target a release vote a week or so after that? What are different features people want to get into 1.2? Here are couple of things that I'd like to help facilitate contribution and/or inclusion: - Mongo improvements (including extended type fixes 2879 , test cases 1666, etc) - httpd log parser format plugin (3423) - rpc enhancements (local 2941 and off-thread 3242) - First merge of Magnus' JDBC connector (3180) - New allocator (1942) Other key goals? What do people think about the proposed timing? This e-mail (including any attachments) is private and confidential, may contain proprietary or privileged information and is intended for the named recipient(s) only. Unintended recipients are strictly prohibited from taking action on the basis of information in this e-mail and must contact the sender immediately, delete this e-mail (and all attachments) and destroy any hard copies. Nomura will not accept responsibility or liability for the accuracy or completeness of, or the presence of any virus or disabling code in, this e-mail. If verification is sought please request a hard copy. Any reference to the terms of executed transactions should be treated as preliminary only and subject to formal written confirmation by Nomura. Nomura reserves the right to retain, monitor and intercept e-mail communications through its networks (subject to and in accordance with applicable laws). No confidentiality or privilege is waived or lost by Nomura by any mistransmission of this e-mail. Any reference to Nomura is a reference to any entity in the Nomura Holdings, Inc. group. Please read our Electronic Communications Legal Notice which forms part of this e-mail: http://www.Nomura.com/email_disclaimer.htm -- Kamesh.
Pushing operators into Storage Plugin
Hi All, We would like to work on pushing operators (like sorting, aggregations) into Mongo Storage Plugin. Are there any optimization rules, which we can extend it to Mongo Storage Plugin? -- Kamesh.
Re: Timing for 1.2 release, ideas around things to include
Hi Jacques, Is it possible to include enhancements to Avro file format (DRILL-3458) in 1.2.0 also? On Wed, Jul 8, 2015 at 9:49 PM, Jacques Nadeau jacq...@apache.org wrote: Hey Guys, What do you think about planning the 1.2 feature cutoff around Aug 21st and target a release vote a week or so after that? What are different features people want to get into 1.2? Here are couple of things that I'd like to help facilitate contribution and/or inclusion: - Mongo improvements (including extended type fixes 2879 , test cases 1666, etc) - httpd log parser format plugin (3423) - rpc enhancements (local 2941 and off-thread 3242) - First merge of Magnus' JDBC connector (3180) - New allocator (1942) Other key goals? What do people think about the proposed timing? -- Kamesh.
[jira] [Created] (DRILL-3458) Avro file format's support for map and nullable union data types.
Bhallamudi Venkata Siva Kamesh created DRILL-3458: - Summary: Avro file format's support for map and nullable union data types. Key: DRILL-3458 URL: https://issues.apache.org/jira/browse/DRILL-3458 Project: Apache Drill Issue Type: Bug Components: Storage - Other Affects Versions: 1.0.0 Reporter: Bhallamudi Venkata Siva Kamesh Assignee: Jacques Nadeau Avro file format as of now does not support union and map datatypes. For union datatypes, like [Pig|https://cwiki.apache.org/confluence/display/PIG/AvroStorage] and [Hive|https://cwiki.apache.org/confluence/display/Hive/AvroSerDe], I think, we can support nullable union like [null, some-type]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 35720: DRILL-3177: Various Mongo plugin enhancements
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35720/#review88739 --- There are two minor comments. 1. The MongoClient (and ServerAddress) constructors no longer throw UnknownHostException. So, I think, we can remove handling or throwing this. 2. While creating shardClient in MongoGroupScan#init (line# 223), using all hosts rather than taking only first host. I addressed them in my later version of this patch (https://reviews.apache.org/r/34625/diff/2#1). - Kamesh B On June 22, 2015, 12:52 a.m., Jacques Nadeau wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35720/ --- (Updated June 22, 2015, 12:52 a.m.) Review request for drill, Kamesh B and Steven Phillips. Repository: drill-git Description --- - Upgrading Mongo Java Driver to 3.0.1 (by Kamesh) - Fix issues with initial Mongo 3 update patch - Update mongo connection management so we don't generate infinite MongoClients. - Move from static class to management inside Storage Plugin. - Increase limit on number of connections. - move mongo cursor initialization to batch reading, so a query won't block indefinitely on this code - Update mongo driver version to 3.0.2 Diffs - contrib/storage-mongo/pom.xml 8168861 contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoCnxnManager.java 35cc265 contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoGroupScan.java e33d2ae contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoRecordReader.java 182f5a4 contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoScanBatchCreator.java 3a8a496 contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoStoragePlugin.java 38bc91d contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoUtils.java b43a22f contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/schema/MongoSchemaFactory.java fccffb5 Diff: https://reviews.apache.org/r/35720/diff/ Testing --- in progress Thanks, Jacques Nadeau
[jira] [Created] (DRILL-3177) Upgrade Mongo java driver to 3.0.1
Bhallamudi Venkata Siva Kamesh created DRILL-3177: - Summary: Upgrade Mongo java driver to 3.0.1 Key: DRILL-3177 URL: https://issues.apache.org/jira/browse/DRILL-3177 Project: Apache Drill Issue Type: Improvement Components: Storage - MongoDB Reporter: Bhallamudi Venkata Siva Kamesh Assignee: B Anil Kumar Upgrade Mongo java driver to 3.0.1 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (DRILL-2879) Drill extended json's support $oid
Bhallamudi Venkata Siva Kamesh created DRILL-2879: - Summary: Drill extended json's support $oid Key: DRILL-2879 URL: https://issues.apache.org/jira/browse/DRILL-2879 Project: Apache Drill Issue Type: Improvement Components: Storage - JSON Reporter: Bhallamudi Venkata Siva Kamesh Assignee: Steven Phillips Enhancing JSON reader to parse $oid (from mongo). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (DRILL-2734) Predicate pushdown like operator into Mongo.
Bhallamudi Venkata Siva Kamesh created DRILL-2734: - Summary: Predicate pushdown like operator into Mongo. Key: DRILL-2734 URL: https://issues.apache.org/jira/browse/DRILL-2734 Project: Apache Drill Issue Type: New Feature Components: Storage - MongoDB Reporter: Bhallamudi Venkata Siva Kamesh Assignee: B Anil Kumar Predicate pushdown like operator into mongo db. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 30313: Fixing Mongo join issue when * is selected
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30313/ --- (Updated March 3, 2015, 3:54 p.m.) Review request for drill, Jacques Nadeau and Jinfeng Ni. Changes --- Fixing review comments Repository: drill-git Description --- Fixing Mongo join issue when * is selected. Diffs (updated) - contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoRecordReader.java da9670154e38b6248e826b03dd71ec396ddef5f4 Diff: https://reviews.apache.org/r/30313/diff/ Testing --- Tested the patch by selecting * in join operation. It is working fine. This patch also fixes some of issues caused by earlier commits. Thanks, Kamesh B
Re: Review Request 30313: Fixing Mongo join issue when * is selected
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30313/ --- (Updated March 4, 2015, 2:11 a.m.) Review request for drill, Jacques Nadeau and Jinfeng Ni. Changes --- Attaching patch generated using git format-patch Repository: drill-git Description --- Fixing Mongo join issue when * is selected. Diffs (updated) - contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoRecordReader.java da96701 Diff: https://reviews.apache.org/r/30313/diff/ Testing --- Tested the patch by selecting * in join operation. It is working fine. This patch also fixes some of issues caused by earlier commits. Thanks, Kamesh B
[jira] [Created] (DRILL-2350) Star query failed with exception on JSON data
Bhallamudi Venkata Siva Kamesh created DRILL-2350: - Summary: Star query failed with exception on JSON data Key: DRILL-2350 URL: https://issues.apache.org/jira/browse/DRILL-2350 Project: Apache Drill Issue Type: Bug Components: Storage - JSON, Storage - MongoDB Affects Versions: 0.7.0 Reporter: Bhallamudi Venkata Siva Kamesh Assignee: Steven Phillips Fix For: 0.8.0 Query failed while executing following query on JSON data with following exception {noformat}select * from hdfs.drill.`zips.json`;{noformat} {noformat} 2015-02-28 21:37:34,058 [2b0e183a-7597-0a1e-fd12-56d91173af70:frag:0:0] ERROR o.a.d.e.w.f.AbstractStatusReporter - Error 6b26e17b-f114-47a9-9cf7-1a77ba52a8e6: Failure while running fragment. java.lang.IllegalStateException: Needed to be in state INIT or IN_BIGINT but in mode IN_FLOAT8 at org.apache.drill.exec.vector.complex.impl.SingleListWriter.bigInt(SingleListWriter.java:387) ~[drill-java-exec-0.8.0-SNAPSHOT-rebuffed.jar:0.8.0-SNAPSHOT] at org.apache.drill.exec.vector.complex.fn.JsonReader.writeData(JsonReader.java:422) ~[drill-java-exec-0.8.0-SNAPSHOT-rebuffed.jar:0.8.0-SNAPSHOT] at org.apache.drill.exec.vector.complex.fn.JsonReader.writeData(JsonReader.java:256) ~[drill-java-exec-0.8.0-SNAPSHOT-rebuffed.jar:0.8.0-SNAPSHOT] at org.apache.drill.exec.vector.complex.fn.JsonReader.writeDataSwitch(JsonReader.java:208) ~[drill-java-exec-0.8.0-SNAPSHOT-rebuffed.jar:0.8.0-SNAPSHOT] at org.apache.drill.exec.vector.complex.fn.JsonReader.writeToVector(JsonReader.java:182) ~[drill-java-exec-0.8.0-SNAPSHOT-rebuffed.jar:0.8.0-SNAPSHOT] at org.apache.drill.exec.vector.complex.fn.JsonReader.write(JsonReader.java:156) ~[drill-java-exec-0.8.0-SNAPSHOT-rebuffed.jar:0.8.0-SNAPSHOT] at org.apache.drill.exec.store.easy.json.JSONRecordReader.next(JSONRecordReader.java:125) ~[drill-java-exec-0.8.0-SNAPSHOT-rebuffed.jar:0.8.0-SNAPSHOT] at org.apache.drill.exec.physical.impl.ScanBatch.next(ScanBatch.java:165) ~[drill-java-exec-0.8.0-SNAPSHOT-rebuffed.jar:0.8.0-SNAPSHOT] at org.apache.drill.exec.physical.impl.validate.IteratorValidatorBatchIterator.next(IteratorValidatorBatchIterator.java:118) ~[drill-java-exec-0.8.0-SNAPSHOT-rebuffed.jar:0.8.0-SNAPSHOT] at org.apache.drill.exec.physical.impl.BaseRootExec.next(BaseRootExec.java:67) ~[drill-java-exec-0.8.0-SNAPSHOT-rebuffed.jar:0.8.0-SNAPSHOT] at org.apache.drill.exec.physical.impl.ScreenCreator$ScreenRoot.innerNext(ScreenCreator.java:97) ~[drill-java-exec-0.8.0-SNAPSHOT-rebuffed.jar:0.8.0-SNAPSHOT] at org.apache.drill.exec.physical.impl.BaseRootExec.next(BaseRootExec.java:57) ~[drill-java-exec-0.8.0-SNAPSHOT-rebuffed.jar:0.8.0-SNAPSHOT] at org.apache.drill.exec.work.fragment.FragmentExecutor.run(FragmentExecutor.java:121) ~[drill-java-exec-0.8.0-SNAPSHOT-rebuffed.jar:0.8.0-SNAPSHOT] at org.apache.drill.exec.work.WorkManager$RunnableWrapper.run(WorkManager.java:303) [drill-java-exec-0.8.0-SNAPSHOT-rebuffed.jar:0.8.0-SNAPSHOT] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) [na:1.7.0_51] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) [na:1.7.0_51] at java.lang.Thread.run(Thread.java:744) [na:1.7.0_51] {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 30313: Fixing Mongo join issue when * is selected
On Feb. 27, 2015, 12:19 a.m., Hanifi Gunes wrote: contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoRecordReader.java, line 200 https://reviews.apache.org/r/30313/diff/1/?file=836234#file836234line200 This does not seem quite right to me. What if multiple writes fail? Also note that this will change the order of records being written into vectors. The reason for doing this is, if there is any issue while storing documents into value vectors, and if the vectors don't have any buffers, if fails to write it. But by that time, Mongo iterator advances its iterator. When the flow again reaches to next method, first we need to process the previously read document, otherwise, we will miss that document. But, I think, with DRILL-1960, we may not encounter this scenario. Will update the patch. - Kamesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30313/#review74406 --- On Jan. 27, 2015, 10:27 a.m., Kamesh B wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30313/ --- (Updated Jan. 27, 2015, 10:27 a.m.) Review request for drill, Jacques Nadeau and Jinfeng Ni. Repository: drill-git Description --- Fixing Mongo join issue when * is selected. Diffs - contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoRecordReader.java 4b7360057e9d95fb0176b035469bca02128a0b34 Diff: https://reviews.apache.org/r/30313/diff/ Testing --- Tested the patch by selecting * in join operation. It is working fine. This patch also fixes some of issues caused by earlier commits. Thanks, Kamesh B
Review Request 30313: Fixing Mongo join issue when * is selected
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30313/ --- Review request for drill, Jacques Nadeau and Jinfeng Ni. Repository: drill-git Description --- Fixing Mongo join issue when * is selected. Diffs - contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoRecordReader.java 4b7360057e9d95fb0176b035469bca02128a0b34 Diff: https://reviews.apache.org/r/30313/diff/ Testing --- Tested the patch by selecting * in join operation. It is working fine. This patch also fixes some of issues caused by earlier commits. Thanks, Kamesh B