[GitHub] drill issue #258: DRILL-4091: Support for additional gis operations in gis c...

2018-03-28 Thread brendanstennett
Github user brendanstennett commented on the issue:

https://github.com/apache/drill/pull/258
  
Hey guys, we have some cycles to have a look at this now. @ChrisSandison is 
going to take a look who has made a few contributions to this project before.  


---


[GitHub] drill issue #258: DRILL-4091: Support for additional gis operations in gis c...

2018-03-15 Thread brendanstennett
Github user brendanstennett commented on the issue:

https://github.com/apache/drill/pull/258
  
Hi @cgivre .  I have some spare cycles coming up in our next open sprint 
starting Apr 2 that either I or someone on my team can take a look at it to get 
it across if it isn't already.  Will keep you updated.  What is your timeline 
for the next release?


---


[GitHub] drill issue #258: DRILL-4091: Support for additional gis operations in gis c...

2018-03-06 Thread brendanstennett
Github user brendanstennett commented on the issue:

https://github.com/apache/drill/pull/258
  
+1 And would be happy to help get it across the finish line for you.


---


[GitHub] drill pull request #1036: DRILL-5962: Adding ST_AsJSON functionality

2017-11-15 Thread brendanstennett
Github user brendanstennett commented on a diff in the pull request:

https://github.com/apache/drill/pull/1036#discussion_r151267136
  
--- Diff: 
contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STAsJson.java 
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/*
+ * Wrapper for ESRI ST_AsJson to convert geometry into REST Json.
+ * Emulates functionality from spatial-framework-for-hadoop.
+ */
+package org.apache.drill.exec.expr.fn.impl.gis;
+
+import javax.inject.Inject;
+
+import org.apache.drill.exec.expr.DrillSimpleFunc;
+import org.apache.drill.exec.expr.annotations.FunctionTemplate;
+import org.apache.drill.exec.expr.annotations.Output;
+import org.apache.drill.exec.expr.annotations.Param;
+import org.apache.drill.exec.expr.holders.VarBinaryHolder;
+import org.apache.drill.exec.expr.holders.VarCharHolder;
+
+import io.netty.buffer.DrillBuf;
+
+@FunctionTemplate(name = "st_as_json", scope = 
FunctionTemplate.FunctionScope.SIMPLE,
+  nulls = FunctionTemplate.NullHandling.NULL_IF_NULL)
+public class STAsJson implements DrillSimpleFunc {
--- End diff --

@ChrisSandison I would suggest naming this `ST_AsGeoJSON` to stay in line 
with the conventions set forth in PostGIS.

http://www.postgis.net/docs/ST_AsGeoJSON.html


---