[GitHub] [drill] arina-ielchiieva commented on issue #1843: DRILL-7350: Move RowSet related classes from test folder

2019-08-16 Thread GitBox
arina-ielchiieva commented on issue #1843: DRILL-7350: Move RowSet related 
classes from test folder
URL: https://github.com/apache/drill/pull/1843#issuecomment-522068340
 
 
   @paul-rogers 
   
   > I also recall that Arina once suggested removing an anonymous inner class 
in favor of a declared class. 
   
   I doubt this is true :) Maybe thrown out of the context though...


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [drill] arina-ielchiieva commented on issue #1843: DRILL-7350: Move RowSet related classes from test folder

2019-08-16 Thread GitBox
arina-ielchiieva commented on issue #1843: DRILL-7350: Move RowSet related 
classes from test folder
URL: https://github.com/apache/drill/pull/1843#issuecomment-521974104
 
 
   Overall, LGTM. Let's wait for @paul-rogers approval.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services