[GitHub] [drill] arina-ielchiieva edited a comment on issue #1779: DRILL-7222: Visualize estimated and actual row counts for a query
arina-ielchiieva edited a comment on issue #1779: DRILL-7222: Visualize estimated and actual row counts for a query URL: https://github.com/apache/drill/pull/1779#issuecomment-489200426 Oh, now I see where it comes from :). Just not sure if this is worth adding new config param. Won't be devs lazy enough to update drill config and restart the drillbits? Is adding it as session / system option be more convenient for devs? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [drill] arina-ielchiieva edited a comment on issue #1779: DRILL-7222: Visualize estimated and actual row counts for a query
arina-ielchiieva edited a comment on issue #1779: DRILL-7222: Visualize estimated and actual row counts for a query URL: https://github.com/apache/drill/pull/1779#issuecomment-489200426 Oh, now I see where it comes from :). Just not sure if this is worth adding new config param. Won't be devs lazy enough to update drill config and restart the drillbits? Is adding it as session / system option be more convenient for devs? Anyway, I am fine with any of the choice. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [drill] arina-ielchiieva edited a comment on issue #1779: DRILL-7222: Visualize estimated and actual row counts for a query
arina-ielchiieva edited a comment on issue #1779: DRILL-7222: Visualize estimated and actual row counts for a query URL: https://github.com/apache/drill/pull/1779#issuecomment-489087756 @kkhatua why it's false by default? Also can we just show estimated row count without having separate option for this? If estimated row count is available, we show the info, if not, we don't. Or maybe make decision based on statistics availability, if it is available show, otherwise don't. Also maybe it will be more obvious to have separate column for estimated row count, rather than explaining what number in parenthesis means? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [drill] arina-ielchiieva edited a comment on issue #1779: DRILL-7222: Visualize estimated and actual row counts for a query
arina-ielchiieva edited a comment on issue #1779: DRILL-7222: Visualize estimated and actual row counts for a query URL: https://github.com/apache/drill/pull/1779#issuecomment-489087756 @kkhatua why it's false by default? Also can we just show estimated row count without having separate option for this? If estimated row count is available, we show the info, if not, we don't. Or maybe make decision based on statistics availability, if it is available show, otherwise don't. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
