[GitHub] [drill] cgivre commented on pull request #1888: DRILL-5956: Add Storage Plugin for Apache Druid

2020-06-23 Thread GitBox 


cgivre commented on pull request #1888:
URL: https://github.com/apache/drill/pull/1888#issuecomment-648561547


   @vvysotskyi 
   I'm trying to assist and rebuild the protobufs for this PR.   I have version 
3.11.4 installed and the CI is producing the following errors below.  What 
version should I be using?
   Thx
   
   ```
   The following changes are found in files after regenerating protobufs 
(output may be used as a patchto apply):
   11
   diff --git a/contrib/native/client/src/include/drill/protobuf/Types.pb.h 
b/contrib/native/client/src/include/drill/protobuf/Types.pb.h
   12
   index be9fe8a..a4f30cd 100644
   13
   --- a/contrib/native/client/src/include/drill/protobuf/Types.pb.h
   14
   +++ b/contrib/native/client/src/include/drill/protobuf/Types.pb.h
   15
   @@ -13,7 +13,7 @@
   16
#error incompatible with your Protocol Buffer headers. Please update
   17
#error your headers.
   18
#endif
   19
   -#if 3011004 < PROTOBUF_MIN_PROTOC_VERSION
   20
   +#if 3011001 < PROTOBUF_MIN_PROTOC_VERSION
   21
#error This file was generated by an older version of protoc which is
   22
#error incompatible with your Protocol Buffer headers. Please
   23
#error regenerate this file with a newer version of protoc.
   24
   diff --git a/contrib/native/client/src/protobuf/BitControl.pb.h 
b/contrib/native/client/src/protobuf/BitControl.pb.h
   25
   index 3235cf4..dce43cb 100644
   26
   --- a/contrib/native/client/src/protobuf/BitControl.pb.h
   27
   +++ b/contrib/native/client/src/protobuf/BitControl.pb.h
   28
   @@ -13,7 +13,7 @@
   29
#error incompatible with your Protocol Buffer headers. Please update
   30
#error your headers.
   31
#endif
   32
   -#if 3011004 < PROTOBUF_MIN_PROTOC_VERSION
   33
   +#if 3011001 < PROTOBUF_MIN_PROTOC_VERSION
   34
#error This file was generated by an older version of protoc which is
   35
#error incompatible with your Protocol Buffer headers. Please
   36
#error regenerate this file with a newer version of protoc.
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [drill] cgivre commented on pull request #1888: DRILL-5956: Add Storage Plugin for Apache Druid

2020-06-23 Thread GitBox 


cgivre commented on pull request #1888:
URL: https://github.com/apache/drill/pull/1888#issuecomment-648176064


   @akkapur 
   Looks like I broke my dev environment and accidentally updated protoc.  I'll 
fix this evening and take care of this.  



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [drill] cgivre commented on pull request #1888: DRILL-5956: Add Storage Plugin for Apache Druid

2020-06-23 Thread GitBox 


cgivre commented on pull request #1888:
URL: https://github.com/apache/drill/pull/1888#issuecomment-648103073


   @akkapur 
   Can you please fix the protobufs?  Once that's done and commits are 
squashed, I'll commit.  I'm happy to do this as well. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [drill] cgivre commented on pull request #1888: DRILL-5956: Add Storage Plugin for Apache Druid

2020-06-22 Thread GitBox 


cgivre commented on pull request #1888:
URL: https://github.com/apache/drill/pull/1888#issuecomment-647896283


   Hi @akkapur 
   Can you squash the protobuf commit with the the other commit please?
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [drill] cgivre commented on pull request #1888: DRILL-5956: Add Storage Plugin for Apache Druid

2020-06-22 Thread GitBox 


cgivre commented on pull request #1888:
URL: https://github.com/apache/drill/pull/1888#issuecomment-647489533


   @akkapur 
   LGTM +1
   Can you please rebase on current master and squash all commits?  If you want 
to update the `README` to reflect that this is now part of Drill, that would be 
good too to avoid confusion. 
   
   Thank you for this submission!!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [drill] cgivre commented on pull request #1888: DRILL-5956: Add Storage Plugin for Apache Druid

2020-06-07 Thread GitBox 


cgivre commented on pull request #1888:
URL: https://github.com/apache/drill/pull/1888#issuecomment-640335224


   @akkapur 
   This is looking really good.  Can you please fix merge conflicts, and squash 
commits?  I'd like to take one last look but I think we're ready to go.  Please 
also just do a final scrub, remove any TODOs (Or leave them but create JIRAs 
and reference the JIRA in the comment), and any commented out code or anything 
else like that?
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [drill] cgivre commented on pull request #1888: DRILL-5956: Add Storage Plugin for Apache Druid

2020-05-19 Thread GitBox 


cgivre commented on pull request #1888:
URL: https://github.com/apache/drill/pull/1888#issuecomment-631162082


   @akkapur 
   I just updated the protobufs and I think they're all up to date.  Can you 
rebase with the current master?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [drill] cgivre commented on pull request #1888: DRILL-5956: Add Storage Plugin for Apache Druid

2020-05-01 Thread GitBox 


cgivre commented on pull request #1888:
URL: https://github.com/apache/drill/pull/1888#issuecomment-622419667


   @akkapur 
   Hi there.  I'd agree that the protobufs are a pain.  I was having the same 
issue with a PR that I just submitted as well. 
(https://github.com/apache/drill/pull/2067).  If you're developing on a Mac, 
this tutorial helped me:  
http://google.github.io/proto-lens/installing-protoc.html
   
   But for now, I'd say don't worry about the protobufs.  Let's get the code 
reviewed and once we're ready to commit we can fix the protobufs. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org